int-full-pgsql-compile-all - Build # 609 - Failure:
Check console output at
https://ci.openbravo.com/job/int-full-pgsql-compile-all/609/ to view the
results.
Committers since last success:
Changes for Build #609
Augusto Mauch <[email protected]> null
Fixes issue 30571: Rows with mandatory image columns can be removed
When a row contains columns that use the ad_image reference, those images are
removed when the row is removed in the RemoveImagesEventHandler. This is an
event handler that is executed before the row is removed, so removing the image
results in a query like this:
update my_table set my_image_field = null
This is a problem is the image column is mandatory.
There were two ways to fix this:
- Give support to event handlers that are executed after the row is removed.
- Set a dummy image to the deleted row, to avoid breaking the not null
constraint.
The first option is very complex, so the first one has been chosen.
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RemoveImagesEventHandler.java
David Miguelez <[email protected]> null
Related to Issue 30526: Code Review Changes.
Modifes ELSEIF sentence to make sure the trigger will be fired
for both locator_ID's if both are changed.
src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml
Alvaro Ferraz <[email protected]> null
Fixes issue 30526: Unneeded storage detail updates on changes for
MovementLines
Some checks have been added to M_MOVEMENTLINE_TRG trigger to update
M_Storage_Detail only when it is necesary.
src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml
Víctor Martínez Romanos <[email protected]> null
Related to issue 30463: code review improvements
Usage of constant for the Goods Movement window id
Utility.getContext(this, vars, M_Warehouse_ID, windowId) called one time
Avoid possible NPE when windowId is null
src/org/openbravo/erpCommon/info/Locator.java
Atul Gaware <[email protected]> null
Fixes Issue 30463: Move a Storage Bin process of Goods Movement window
allows
to choose any locator without taking into account the organization
In case of Good Movements window with id 170, org id set in transaction is
sent as a filter for locator selector.
While applying default filters to Locator selector in Alias and Warehouse a
check is provided to check whether login profile warehouse's organization is
included under the organization selected in the transaction.
src/org/openbravo/erpCommon/info/Locator.java
src/org/openbravo/erpCommon/info/Locator_data.xsql
David Miguelez <[email protected]> null
Related to Issue 29723. Code Review changes.
Modifies Query to improve performance.
src-db/database/sourcedata/OBUISEL_SELECTOR.xml
Alvaro Ferraz <[email protected]> null
Related to issue 29723: Modify an assert in TestCosting
src-test/src/org/openbravo/test/costing/TestCosting.java
Alvaro Ferraz <[email protected]> null
Fixes issue 29723: Avoid cost adjustmens in Landed Cost + Standard Algorithm
Cost Adjustments will not be created in landed cost created with Standard
Algorithm.
Goods Receipt selector in Landed Cost window - Receipt tab, will only show
receipts processed with current costing rule.
Landed Cost and Landed Cost Cost documents will create cost adjustment only if
active costing rule does not use Standard Algorithm.
Landed Cost and Landed Cost Cost differences will be posted to a IPV account
(instead of an Asset account) if used costing rule does not use Standard
Algorithm.
src-db/database/sourcedata/AD_AUXILIARINPUT.xml
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/OBUISEL_SELECTOR.xml
src/org/openbravo/costing/LCMatchingCancelHandler.java
src/org/openbravo/costing/LCMatchingProcess.java
src/org/openbravo/costing/LandedCostProcess.java
src/org/openbravo/costing/ReactivateLandedCost.java
src/org/openbravo/erpCommon/ad_forms/DocLCCost.java
src/org/openbravo/erpCommon/ad_forms/DocLandedCost.java
Víctor Martínez Romanos <[email protected]> null
[prodcostexpl] code review improvements
Removed static in orgs
Set costDimensions as private
src/org/openbravo/common/datasource/CostingTransactionsHQLTransformer.java
Víctor Martínez Romanos <[email protected]> null
[prodcostexpl] Adapted IndexesTest OBBaseTest
The query inside IndexesTest was failing after including the new tabs related
to the [prodcostexpl] project, because a subquery was returning more than one
record where only one record was possible.
The reason was it was wrongly taken into account the new
M_Costing_Transactions_HQL HQL table.
Now the query only uses ad_table records defined as 'Table', which are the only
ones that can have indexes
src-test/src/org/openbravo/test/model/IndexesTest.java
Víctor Martínez Romanos <[email protected]> null
[prodcostexpl] Rename table to M_Costing_Transactions_HQL
src-db/database/sourcedata/AD_TABLE.xml
Víctor Martínez Romanos <[email protected]> null
[prodcostexpl] Module stuff integrated directly into Core
referencedata/standard/Costing_Transactions_not_sortable_and_not_filterable.xml
src-db/database/sourcedata/AD_MODULE_MERGE.xml
src/org/openbravo/common/datasource/CostingTransactionsHQLTransformer.java
.classpath.template
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_DATASET.xml
src-db/database/sourcedata/AD_DATASET_TABLE.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_REFERENCE.xml
src-db/database/sourcedata/AD_REF_TABLE.xml
src-db/database/sourcedata/AD_TAB.xml
src-db/database/sourcedata/AD_TABLE.xml
modules/org.openbravo.costing.explaincostadjustments/referencedata/standard/Costing_Transactions_not_sortable_and_not_filterable.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_COLUMN.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_DATASET.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_DATASET_TABLE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_ELEMENT.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_FIELD.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE_DBPREFIX.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_PACKAGE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_REFERENCE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_REF_TABLE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TAB.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TABLE.xml
modules/org.openbravo.costing.explaincostadjustments/src/org/openbravo/costing/explaincostadjustments/CostingTransactionsHQLTransformer.java
Víctor Martínez Romanos <[email protected]> null
[prodcostexpl] Renamed m_costing_id to M_Costing_ID
this situation was creating an error in the RuntimeModelTest.testIsParent4 test.
Added product window to obcosta_costing_transactions table
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_COLUMN.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TABLE.xml
Víctor Martínez Romanos <[email protected]> null
[prodcostexpl] Inventory Average Cost Transactions module added to OB3
.classpath.template
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
Unai Martirena [email protected]_ null
[prodcostexpl] Change module name, Update module version
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TAB.xml
Unai Martirena [email protected]_ null
[prodcostexpl] Show results only for Costing records of type 'AVA'
Also while getting previous costing record, if there is more than one with same
movement date and trx process date, get the one with latest ending date, and if
this is also equal, get the one with less movement qty, as costing background
process processes the transactions in this order.
modules/org.openbravo.costing.explaincostadjustments/src/org/openbravo/costing/explaincostadjustments/CostingTransactionsHQLTransformer.java
Unai Martirena [email protected]_ null
[prodcostexpl] Update module name and version
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE.xml
Unai Martirena [email protected]_ null
[prodcostexpl] Update Costing Transactions tab name
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TAB.xml
Unai Martirena [email protected]_ null
[prodcostexpl] Modify module dependency to PR15Q1.3
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
Unai Martirena [email protected]_ null
[prodcostexpl] Update module version to 1.0.1
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE.xml
Unai Martirena [email protected]_ null
[prodcostexpl] Refactor of the code done. Javadoc added
modules/org.openbravo.costing.explaincostadjustments/src/org/openbravo/costing/explaincostadjustments/CostingTransactionsHQLTransformer.java
Unai Martirena [email protected]_ null
[prodcostexpl] Replace Order By clause of transformer with order by clause
in tab
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TAB.xml
modules/org.openbravo.costing.explaincostadjustments/src/org/openbravo/costing/explaincostadjustments/CostingTransactionsHQLTransformer.java
Unai Martirena [email protected]_ null
[prodcostexpl] Display Net Unit Price and Transaction Cost for shipments
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TABLE.xml
Unai Martirena [email protected]_ null
[prodcostexpl] Avoid IOB Expection when setting summary function.
When setting summary function on a tab based on an HQL Query table, order by
clause is empty in HQLDataSourceService, so this case has to be handled in
CostingTransactionsHQLTransformer.java in order to not to fail.
modules/org.openbravo.costing.explaincostadjustments/src/org/openbravo/costing/explaincostadjustments/CostingTransactionsHQLTransformer.java
Unai Martirena [email protected]_ null
[prodcostexpl] Few changes in Application Dictionary
[1] Set flag Has Reference Data of the module to 'Y'. To take into account the
dataset of the module during the installation.
[2] Set flag Disable Parent Key Property of Costing Transactions tab to 'N', in
order to be able to Link a column with parent tab.
[3] Set flag Link to Parent Column of m_costing_id column to 'Y', in order to
filter by parent record.
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_COLUMN.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TAB.xml
Unai Martirena [email protected]_ null
[prodcostexpl] Not return any record when there is no transaction in
selected costing record
modules/org.openbravo.costing.explaincostadjustments/src/org/openbravo/costing/explaincostadjustments/CostingTransactionsHQLTransformer.java
Unai Martirena [email protected]_ null
[prodcostexpl] Set legal entity org while calling getCostDimensionRule
method
modules/org.openbravo.costing.explaincostadjustments/src/org/openbravo/costing/explaincostadjustments/CostingTransactionsHQLTransformer.java
Unai Martirena [email protected]_ null
[prodcostexpl] Set proper org while calling getCostDimensionRule method
modules/org.openbravo.costing.explaincostadjustments/src/org/openbravo/costing/explaincostadjustments/CostingTransactionsHQLTransformer.java
Unai Martirena [email protected]_ null
[prodcostexpl] Initial Load
modules/org.openbravo.costing.explaincostadjustments/referencedata/standard/Costing_Transactions_not_sortable_and_not_filterable.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_COLUMN.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_DATASET.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_DATASET_TABLE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_ELEMENT.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_FIELD.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE_DBPREFIX.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_PACKAGE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_REFERENCE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_REF_TABLE.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TAB.xml
modules/org.openbravo.costing.explaincostadjustments/src-db/database/sourcedata/AD_TABLE.xml
modules/org.openbravo.costing.explaincostadjustments/src/org/openbravo/costing/explaincostadjustments/CostingTransactionsHQLTransformer.java
Last 20 lines of the console output:
[...truncated 2204 lines...]
[javac] ^
[javac]
/srv/ci/workspace/int-full-pgsql-compile-all/srcAD/org/openbravo/erpWindows/Product/AverageCostTransactions.java:951:
cannot find symbol
[javac] symbol : variable AverageCostTransactionsData
[javac] location: class
org.openbravo.erpWindows.Product.AverageCostTransactions
[javac] if
(AverageCostTransactionsData.getCurrentDBTimestamp(this, data.id).equals(
[javac] ^
[javac] 16 errors
BUILD FAILED
/srv/ci/workspace/int-full-pgsql-compile-all/build.xml:489: The following error
occurred while executing this line:
/srv/ci/workspace/int-full-pgsql-compile-all/src/build.xml:280: Compile failed;
see the compiler error output for details.
Total time: 8 minutes 37 seconds
Build step 'Execute managed script' marked build as failure
Checking console output
/srv/ci/jobs/int-full-pgsql-compile-all/builds/609/log:
[java] 2764 [main] ERROR org.openbravo.data.Sqlc - SQL error in query:
SELECT to_char(M_Costing_Transactions_HQL.Created, ?) as created,
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
------------------------------------------------------------------------------
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds