int-accounting-pgsql - Build # 1114 - Fixed:
Check console output at https://ci.openbravo.com/job/int-accounting-pgsql/1114/
to view the results.
Committers since last success:
Changes for Build #1113
Guillermo Gil <guillermo....@openbravo.com> null
[ChangePassword] Merge ChangePassword development
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Applied code review.
Now client messages are translated.
Used === for javascript comparison
src-db/database/sourcedata/AD_MESSAGE.xml
src/org/openbravo/erpCommon/security/Login.html
src/org/openbravo/erpCommon/security/Login.java
src/org/openbravo/erpCommon/security/Login.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Renamed trigger to AD_USER_EXPIRATIONPASS_TRG
src-db/database/model/triggers/AD_USER_EXPIRATIONPASS_TRG.xml
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Applied code review.
Renamed trigger to be consistent, used expiration instead of expiry.
Used === to compare strings in Login.html.
Renamed getUpdatePasswordDate method to checkIfPasswordExpired in
DefaultAuthenticationManager class.
Added throws in signature and javadoc for checkIfPasswordExpired and
updatePassword methods.
Removed static parameter from checkIfPasswordExpired and updatePassword methods.
Removed extra brackets in expression in checkIfPasswordExpired method.
Exception AuthenticationExpirationPasswordException fixed. Removed extra
variables, error is now loaded in the subclass AuthenticationException.
Removed empty line in checkIfPasswordExpired.
Removed check to support 2.50.
LoginUtils file keep unmodified.
src/org/openbravo/authentication/AuthenticationException.java
src/org/openbravo/authentication/AuthenticationExpirationPasswordException.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/base/secureApp/LoginUtils.java
src/org/openbravo/erpCommon/security/Login.html
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Applied code review.Fixed security problem.
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/erpCommon/security/Login.html
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Added text interfaces from login.html
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Code review applied.
Updated javadocs of methods.
Added check to avoid security problem when updating password.
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/erpCommon/security/Login.html
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Updated year of license in some files. Updated referenced
data with new name of the column
src-db/database/sourcedata/referencedData/AD_USER.xml
src/org/openbravo/authentication/AuthenticationException.java
src/org/openbravo/authentication/AuthenticationExpirationPasswordException.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Code review applied.
Solved camel case in Days To Password Expiration column.
Labels in Login.html are now translatable.
Last Password Update column is now updated in case user didn't have a password
and is set for the first time.
Messages are now set correctly from the beginning and are not overwritten.
Refactor code, now check for expiration date is made in the method, exception
is thrown in the method also.
AuthenticationExpirationPasswordException now log a single line.
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src/org/openbravo/authentication/AuthenticationException.java
src/org/openbravo/authentication/AuthenticationExpirationPasswordException.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/erpCommon/security/Login.html
Alberto Santos <alberto.san...@openbravo.com> null
[Change Password] Merge with pi
Alberto Santos <alberto.san...@openbravo.com> null
Correct the column updated in AD_USER_EXPIRYPASS_TRG and the message name.
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
src-db/database/sourcedata/AD_MESSAGE.xml
Alberto Santos <alberto.san...@openbravo.com> null
[Change Password] Code review applied:
Rename property Lastupdatepassworddate to lastPasswordUpdate.
Be consistent in naming: change expiry to expiration.
Use 'userID' instead of username in getUpdatePasswordDate function.
Check sameOldPassword in the rigth place.
src/org/openbravo/authentication/AuthenticationExpirationPasswordException.java
src-db/database/model/tables/AD_USER.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/authentication/AuthenticationExpiryPasswordException.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Solved security problem, added check to change user
password
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Fixed code after code review.
Username is not cleaned in case of invalid user/password.
Added check in LoginHandler to avoid security problem when changing password.
Deleted unused params in getUpdatePasswordDate method.
Login param changed to username in getUpdatePasswordDate method.
Deleted UserLock delay because has been already done (getUpdatePasswordDate and
updatePassword methods).
Updated javadoc in getUpdatePasswordDate method.
Corrections in OBCriteria, using eq instead of like, using property of User
PROPERTY_USERNAME.
Refactor in Dates in getUpdatePasswordDate method.
Deleted comments.
Now gets the pasword value from password field instead of user field (Both have
the same content when updating the password).
Removed strange vars names like strUser and strPass.
setAdminMode and restorePreviousMode moved to updatePassword method.
Replaced vars.getLanguage() with language var where possible.
Updated javadoc in updatePassword method.
getUpdatePasswordDate method moved to DefaultAuthenticationManager and changed
visibility to private.
updatePassword method moved to LoginHandler and changed visibility to private.
AuthenticationExpiryPasswordException is now a subclass of authentication
exception.
Strings compared with === in js(Login.html).
Using single quotes '' for js strings.
src/org/openbravo/authentication/AuthenticationExpiryPasswordException.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/base/secureApp/LoginUtils.java
src/org/openbravo/erpCommon/security/Login.html
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Fixed trigger to work with oracle
Changed logic of trigger
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Fixed trigger to work with oracle
Deleted return new;
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with pi
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Fixed trigger to work with oracle
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Solved null value in users fields, added columns from last
merge
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/referencedData/AD_USER.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with pi
Guillermo Gil <guillermo....@openbravo.com> null
[ChangePassword] Fixed issue on WebServices
There is no session if you are not logged in Openbravo.
Use SeguridadData instead of OBCriteria.
src/org/openbravo/base/secureApp/LoginUtils.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with Pi
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Fixed problem with triggers. Last update password date
column mandatory to avoid NPE
src-db/database/model/tables/AD_USER.xml
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Modified message
src-db/database/sourcedata/AD_MESSAGE.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Fixed bug when valid days of password equal to zero.
src/org/openbravo/base/secureApp/LoginUtils.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Renamed AD elements,added messages,renamed some variables,
trigger updated
src-db/database/model/tables/AD_CLIENT.xml
src-db/database/model/tables/AD_USER.xml
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_MESSAGE.xml
src/org/openbravo/authentication/AuthenticationExpiryPasswordException.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/base/secureApp/LoginUtils.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with pi.
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Fixed some minor issues. Messages added. Refactor of some
files
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_MESSAGE.xml
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/base/secureApp/LoginUtils.java
src/org/openbravo/erpCommon/security/Login.html
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Merge with actual pi
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Updated fields, synchronize terminology to get elements
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Updated date of licenses.
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/base/secureApp/LoginUtils.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Updated date in trigger license.
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Added license to trigger.
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Fixed licenses of file.
src/org/openbravo/authentication/AuthenticationExpiryPasswordException.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Added messages in AD. Solved some problems with OBDAL
default restrictions
src-db/database/sourcedata/AD_MESSAGE.xml
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/base/secureApp/LoginUtils.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Deleted retail script.
Retail.sh
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Added trigger to update date once password is changed
Retail.sh
src-db/database/model/triggers/AD_USER_EXPIRYPASS_TRG.xml
src-db/database/model/tables/AD_USER.xml
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/base/secureApp/LoginUtils.java
src/org/openbravo/erpCommon/security/Login.html
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Added logic to client and server to update the password
once validity date is reached
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/base/secureApp/LoginUtils.java
src/org/openbravo/erpCommon/security/Login.html
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Changed query to validate password date
src/org/openbravo/authentication/AuthenticationExpiryPasswordException.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginUtils.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Solved some problems importing libraries.
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginUtils.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Added more logic to client and server
src/org/openbravo/authentication/AuthenticationExpiryPasswordException.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/base/secureApp/LoginUtils.java
Jonathan Bueno <jonathan.bu...@openbravo.com> null
[ChangePassword] Added columns/fields to ad_client and ad_user. Added some
logic to login in client and server
src-db/database/model/tables/AD_CLIENT.xml
src-db/database/model/tables/AD_USER.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_FIELD.xml
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
src/org/openbravo/base/secureApp/LoginUtils.java
Changes for Build #1114
Miguel de Juana <miguel.deju...@openbravo.com> null
Fixed issue 0032044: Ensure stable ids in docs send from WebPOS to the
server (Payment API)
- Set some entities ids related to order loading in Web POS to ensure stable ids
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
Víctor Martínez Romanos <victor.marti...@openbravo.com> null
Fixed bug 31419: Add parameter to control flushes in some APRM methods
Added a parameter doFlush to some APRM methods to control whether to flush
inside the method. By default it continues to have the same behavior as before
(to flush inside the method) so we should avoid any possible regression.
These flushes inside the method makes the process of several payments in a
batch really slow, which is a common scenario for the remittance module. With
this change (and with the necessary modifications in the remittance module),
the time to process a remittance line has been decreased from 900ms to 15ms.
The idea is to create this "self-protected" methods and adapt the flows with
performance problems. When the time goes by, we should clean the duplicated
methods.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
Asier Lostalé <asier.lost...@openbravo.com> null
fixed bug 32354: field edit access doesn't allow to save if tab contains
audit
For tabs that explicitly define their audit (updated/updated by) fields, roles
with access to edit only some fields couldn't save unless in those fields
audit
were also included.
Now audit fields are not checked for this validation as they are always
updated
on any allowed modification.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
Last 20 lines of the console output:
[...truncated 9403 lines...]
Total time: 3 seconds
executing script 'Tomcat stop'
[int-accounting-pgsql] $ /bin/bash
/tmp/build_step_template837323860461603272.sh ENABLE
DEBUG: Tomcat stop called with parameters: ENABLED=ENABLE
* Stopping Tomcat servlet engine for Openbravo tomcat
...done.
executing script 'Check log'
[int-accounting-pgsql] $ /bin/bash
/tmp/build_step_template5442830225436008857.sh ENABLE
DEBUG: Check log called with parameters: ENABLED=ENABLE
Check log: openbravo log (artifact: int-accounting-pgsql.log) is clean
Recording test results
Archiving artifacts
Checking \] ERROR|\] WARN
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Openbravo-builds mailing list
Openbravo-builds@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
