int-dbcons-pgsql - Build # 2040 - Failure:

Check console output at https://ci.openbravo.com/job/int-dbcons-pgsql/2040/ to 
view the results.


Committers since last success:

Changes for Build #2040

    Gorka Ion Damián <[email protected]> null
    [alfresco] add TabAttachments_data.xsql file.

Recover deleted file to avoid api-change that affects published modules
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_data.xsql

    Gorka Ion Damián <[email protected]> null
    Fixed issue 29771. Merge of attachment enhancenment project

This projects enables the ability to define different attachment methods.
http://wiki.openbravo.com/wiki/Projects:Alfresco_Integration
      
    Gorka Ion Damián <[email protected]> null
    [alfresco]Fixes managing parameter values

- Do not save parameter values with null or empty value.
- Reset to null c_file.text column when an old attachment is edited.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Use context clients instead of organization client.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Improvements in metadata tabs layout.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Do not compute and save description in c_file.text
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue when searching generic system configuration.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Asier Lostalé <[email protected]> null
    [alfresco] typo
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Add missing javadoc
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Asier Lostalé <[email protected]> null
    [alfresco] removed some code duplication
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Asier Lostalé <[email protected]> null
    [alfresco] fixed incorrect casting management
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Asier Lostalé <[email protected]> null
    [alfresco] fixed typo
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/MetadataOnTab.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Ensure that attachemt are reset when section is disabled.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Create new private method to avoid duplicated code.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentMetadataEventHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix type in javadoc
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix type in new public method downloadAll
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Include original exception on rethrow.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Allow and use as default attachment configs in system.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java
        src-db/database/sourcedata/AD_TABLE.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove hungarian notation.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix typo in javadoc
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Javadoc improvements.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/CoreAttachImplementation.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Improve javadoc of AttachImplementation abstract class.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementation.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Set c_file.text column as deprecated.
        src-db/database/sourcedata/AD_COLUMN.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Code improvements on MetadataOnTab callout.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/MetadataOnTab.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove unused variables.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Initialize default value of ATT_SHOWINDESCRIPTION flag
        
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.querylist/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.widgets/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix potential regression when creating a new record in form view.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Set mandatory boolean column ATT_SHOWINDESCRIPTION
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Add some context in error logs of AttachmentAH
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]hardcode message format for performance reasons.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]remove unneeded public method.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Performance fix.Load attachments when section is expanded.

* Modify FIC to send only the count of attachmetns.
** If several records are selected return 1 if there is any attachment not the
   actual count.
* Modify the section to set the number of attachments on the form load and not
  when the attachments are loaded.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FICExtension.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Split execute method in different methods
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Use ConcurrentHashMap for clientConfigs
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Use proper StringUtils class.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Use ConcurrentHashMap to avoid concurrence issues.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Move AttachmentsAH class to attachment package.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix package declaration of moved class.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Moved attachment related classes to own package.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentMetadataEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/MigrateAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AttachmentMetadataEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/event/AttachmentConfigEventHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix copyright year of modified files.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AttachmentMetadataEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove todo.boolean parameters tested.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove blank spaces on js file.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Send command instead of action for EDIT
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix height of attachment list on form.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Properly reset upload state on upload errors
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Show description text on existing attachments
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]fix merge issue with column default value.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_SYSTEM.xml
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_TAB.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Add callout to populate seqNo in tab metadata definition.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/MetadataOnTab.java
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_CALLOUT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix js leaks uploading attachments.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Properly initialize att metadata on ADCS
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Do not include organization in view request.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <[email protected]> null
    Merge alfresco branch with pi 1450b7bf6b32 revision.
      
    Gorka Ion Damián <[email protected]> null
    [alfresco]store in cache the metadata of each tab and method.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <[email protected]> null
    [Alfresco]Change getAttachmentConfig to return the AttMethod instead.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix event handler javadoc.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AttachmentMetadataEventHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Improvements in clientConfigs Map management
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Capitalize attachment tables definition.
        src-db/database/sourcedata/AD_TABLE.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco] ui fixes

- Use parents module when creating metadata on attachment method.
- Improvements in help.
- Move active field to the end of the tab.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml

    Gorka Ion Damián <[email protected]> null
    Add name to implicit filter of Attachment Method -> Metadata
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_TAB.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]use adcs to retrieve tab information.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove unneeded method from BaseProcessActionHandler.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Use proxies when possible. Do not do toString() on log.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Add class javadoc and move chech to method begining.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Properly format js file.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Send metadata values as a JSON when uploading a file.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Build description of attachment dynamically.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Build attachment json in FIC using AttachmentUtils method.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Change window title when editing metadata.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix default values of modules in Attach Metadata tab.
        src-db/database/sourcedata/AD_COLUMN.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue overwriting files in core implementation.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Use existing attachment config and method when overwriting a file.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix NPE removing attachment without related AttConfig.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue downloading all attachments.

NPE checking the method to use on the attachments. Attachments uploaded
without any Attachment Config have that value empty. Check that property for
null values instead of the AttachmentMethod that it is mandatory.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix NPE in downloadAll

The dataType is not send anymore in the submit of the upload file. Calculate
it in the AttachImplementationManager using the Tika library.

When downloading a file properly check if there is a dataType defined for the
attachament.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue retrieving context information.

Use buttonOwnerView instead of ownerView. The OBBaseParameterWindowView
getUnderLyingRecordContext method uses buttonOwnerView.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Set fixed parameters values in fixedParameters
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue with display and read only logics

Add a new constructor in DynamicExpressionParser for parameters that are not
based in a Process as is the case of Attachment Metadata. This new constructor
receivs as a parameter the list of related Parameters instead of loading them
from the Process.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Load description from text property on old attachments.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Set attachment method id to Description parameter.
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Several improvements due to code review.

- Change att_value_key column to be able to store List Search Keys instead of
  just the id.
- Property path values are also calculated when the popup is opened in case
  another metadata depends on it.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER_VALUE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Code style inprovements.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Performance fixes in CoreAttachImplementation
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Add again setProcess method to avoid unneeded api change
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Change name of variable.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Set OB Style to file item
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix consistency issue running synchronize terminology
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fixed issues with attachments uploaded with old system.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Add handler to avoid duplicated db columnnames in metadata.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AttachmentMetadataEventHandler.java
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Set default seq number on attachment metadata.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml

    Gorka Ion Damián <[email protected]> null
    [alfesco]Remove hidden field compilation warning.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue setting default values in attachment popup.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Show metadata parameters ordered by seqno.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Use single quotes in js files.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix metadata tab layouts.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco] Add translation tabs for attachment metadata
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TAB.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove translation tab for attachment methods
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD_TRL.xml
        src-db/database/model/triggers/C_ATTACHMENT_METHOD_TRG.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Set proper ui on popup based on mockups.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue on process definition windows.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]File item form is only needed in Upload mode.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco] Use FileItem instead of UploadItem in attachment window.

It is not possible to use UploadItem on a form that redraws. This is the case
when display logics have to be executed. FileItem is used instead.

When using a FileItem it is not possible to do submitForm as the file will not
be included in the request. In this case it is used the internal DynamicForm
used by the FileItem. To include all the parameters in the request they need
to be added as hidden inputs in the DynamicForm that it is finally submited.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    Merge with pi revision 707bfc29b8b5
      
    Gorka Ion Damián <[email protected]> null
    [alfresco]Add missing indexes for new child tabs.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD_TRL.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix integration issues
- Check for null parameters when converting the parameter map to String
  values.
- Fix check constraint por postgresql.
- Remove not needed text interfaces after html file removal.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseActionHandler.java
        src-db/database/sourcedata/AD_TEXTINTERFACES.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue with default values return null when FK Object is not 
found.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Merge with pi revision 2e0980743044
      
    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix several issues based on testing.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER_VALUE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_TAB.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix display logics for fixed parameters.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]update session att config values when changing the active conf.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        src/org/openbravo/event/AttachmentConfigEventHandler.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Do flush before restoring previous mode.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fixed issue while loading the add attachment from the grid.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Several code review fixes.Remove unused code.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD_TRL.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_WINDOW.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove unneeded code.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-form-styles.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove unneeded code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue compiling ViewComponent.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java

    Asier Martirena <[email protected]> null
    [Alfresco] Code review applied
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER_VALUE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REFERENCE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REF_TABLE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Move and deprecate some publics methods to 
CoreAttachImplementation.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/MigrateAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Format js code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js

    Gorka Ion Damián <[email protected]> null
    [alfresco] Clean code. Remove files and code from 2.50 version

Removed xmlEngine templates of unused 2.50 attachment popup
Removed all the related code from TabAttachments servlet
Changed the Logger to slf4j
Renamed download commands
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_Edition.html
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_Edition.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_F1.html
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_F1.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_FS.html
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_FS.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_data.xsql

    Asier Martirena <[email protected]> null
    [Alfresco]IsUserEditable column removed from Obuiapp_Parameter table
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <[email protected]> null
    [Alfresco]Popup metadata is loaded when editing an attachment
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <[email protected]> null
    [Alfresco] Fix issue with fixed parameters
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <[email protected]> null
    Property path and fixed parameters correctly treated
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <[email protected]> null
    [Alfresco]Changes in Alfresco method applied for core implementation too
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Asier Martirena <[email protected]> null
    [Alfresco] New error messages
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Format js code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Add attachment method to viewId
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-attachment-view.js.ftl
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Asier Martirena <[email protected]> null
    [Alfresco] Parameters with property path allowed for attachments
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java

    Asier Martirena <[email protected]> null
    [Alfresco]Metadata type conversion dane before calling AttachImplementation 
class
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Asier Martirena <[email protected]> null
    [Alfresco] Supported List parameters for attachments
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue uploading files in core
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Asier Martirena <[email protected]> null
    [Alfresco] Fixed issue saving metadata
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix issue getting context info
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Merge heads
      
    Asier Martirena <[email protected]> null
    [Alfresco] Use ParameterUtils class methods to save metadata.
This change is done because now the table ParameterValue is used to store 
metadata.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Asier Martirena <[email protected]> null
    [Alfresco] Used ParameterValue table instead of Parameter in metadata Map
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Asier Martirena <[email protected]> null
    [Alfresco] New table to store attachments metadata.

>From C_File_Metadata to OBUIAPP_Parameter_Value table.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER_VALUE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/OBUISEL_SELECTOR.xml
        src-db/database/model/tables/C_FILE_METADATA.xml

    Gorka Ion Damián <[email protected]> null
    [alfresco]Format js code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove commented code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Implement EDIT with new attachment popup.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Calculate default values of metadata fields on popup load.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Fix return of method to return retval.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java

    Asier Martirena <[email protected]> null
    [Alfresco] Removed property path from metadata in Attachment Method
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Asier Martirena <[email protected]> null
    [Alfresco] In c_file, only metadata with isInDescription is saved in Text 
column
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Remove symlink
        modules/org.openbravo.integration.alfresco

    Gorka Ion Damián <[email protected]> null
    [alfresco]Format js files.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js

    Gorka Ion Damián <[email protected]> null
    [alfresco] Implement attach popup using freemaker and obuiapp parameters

Create a new utils class to retrieve attachment method, config and metadata
parameters.
Several fixes on templates and classes to properly load the attachment popup.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        modules/org.openbravo.integration.alfresco
        
modules/org.openbravo.client.application/src-db/database/sourcedata/OBCLKER_TEMPLATE_DEPENDENCY.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-attachment-view.js.ftl
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ParameterWindowComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <[email protected]> null
    [alfresco]Add new argument to fetchView to add extra parameters.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-view-manager.js

    Gorka Ion Damián <[email protected]> null
    [alfresco]Default parameter description as Text of 255
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Gorka Ion Damián <[email protected]> null
    [Alfresco] Attachments based on OBUIAPP_Parameter metadata.

- Split of ob-parameter-widnow to create a OBBaseParameterWindow.
- Created ob-attachment-window-view.js extending OBBaseParameterWindow.
- Create a new ftl template to generate the attachment view based on tab and
  client to add the related metadata.

Note. This is work in progress and more changes are needed to complete the
development.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-attachment-view.js.ftl
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        
modules/org.openbravo.client.application/src-db/database/sourcedata/OBCLKER_TEMPLATE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ParameterWindowComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js

    Asier Martirena <[email protected]> null
    [Alfresco] New method to get a parameter value converted to its original 
type.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java

    Asier Martirena <[email protected]> null
    [Alfresco] Added new metadata to save description for core attachments.
Code cleaned
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Asier Martirena <[email protected]> null
    [Alfresco] IsActive field is shown for Metadata windows.

Now is easier to see if metadata values are or not enabled.
Code cleaned.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <[email protected]> null
    [Alfresco] Added filter clause to Metadata tab in Attachment Method window

Filters by metadata asigned to the Attachment Method, in order to hide metadata 
assigned to specific windows
        src-db/database/sourcedata/AD_TAB.xml

    Asier Martirena <[email protected]> null
    [Alfresco] Attachment Configuration functionality updated.

Now, each client may have more than one attachment configuration, but only one 
activated at once
        src/org/openbravo/event/AttachmentConfigEventHandler.java
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_FILE.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MESSAGE.xml

    Asier Martirena <[email protected]> null
    [Alfresco] getMetadataValues abstract method removed from 
AttachmentImplementation class
Code cleaned
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Asier Martirena <[email protected]> null
    [Alfresco] New windows and table to save attachment metadata
        src-db/database/model/tables/C_FILE_METADATA.xml
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REFERENCE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REF_TABLE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_DATASET_TABLE.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUISEL_SELECTOR.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA_TRL.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_MOD_TRG.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_TRG.xml
        src-db/database/sourcedata/C_ATTACHMENT_METADATA.xml

    Jonathan Bueno <[email protected]> null
    [Alfresco] correct format of java class
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Jonathan Bueno <[email protected]> null
    Updated downloadAll method
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Jonathan Bueno <[email protected]> null
    Updated method at TabAttachments
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Jonathan Bueno <[email protected]> null
    Save attachment config and upload api
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src-db/database/model/tables/C_FILE.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_FIELD.xml

    Naiara Martinez <[email protected]> null
    [Alfresco] Remove unnecessary variable
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Naiara Martinez <[email protected]> null
    [Alfresco] add a validation to show only modules in development (in 
attachment method)
        src-db/database/sourcedata/AD_COLUMN.xml

    Asier Martirena <[email protected]> null
    [Alfresco] Fixed bug of text modification in metadata while using accents
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <[email protected]> null
    [Alfresco]in JS when metadata value is null, insert "" into the array
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <[email protected]> null
    [Alfresco] Modify metadata hashmap to be <String, String> instead of 
<String, Object>.
Modify command to be EDIT instead of EDIT_DESC_OB3
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Daniel Ruiz <[email protected]> null
    [Alfresco]Fixes issue when adding new attachment:more than one file could be
uploaded. Now, it is not possible.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <[email protected]> null
    [Alfresco] Fix a bug in ReportManager and send the tabID instead of tableId
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Daniel Ruiz <[email protected]> null
    [Alfresco]Fixes file parameter when calling callback in order to show 
metadata
fields popup or edit metadata values.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <[email protected]> null
    [Alfresco] Remove UpdateAttachmentMetadataHandler, and add its logic to 
AttachmentsAH
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/event/UpdateAttachmentMetadataHandler.java

    Naiara Martinez <[email protected]> null
    [Alfresco]Get Metadata and remove description from upload/update methods
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
        src/org/openbravo/event/UpdateAttachmentMetadataHandler.java

    Daniel Ruiz <[email protected]> null
    [Alfresco]Added help to all new attachment windows, tabs and fields.
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/AD_WINDOW.xml

    Daniel Ruiz <[email protected]> null
    [Alfresco]Added Value field to JSON object in order to change metadata 
fields
name when adding and editing attachments.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/event/UpdateAttachmentMetadataHandler.java

    Naiara Martinez <[email protected]> null
    [Alfresco] Add Attachment Method TRL
        src-db/database/model/tables/C_ATTACHMENT_METHOD_TRL.xml
        src-db/database/model/triggers/C_ATTACHMENT_METHOD_TRG.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_TRG.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml

    Naiara Martinez <[email protected]> null
    [Alfresco] Add Attachment Metadata TRL
        src-db/database/model/tables/C_ATTACHMENT_METADATA_TRL.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_TRG.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml

    Naiara Martinez <[email protected]> null
    [Alfresco]Add search key column/field in metadata table. Add unique 
constraint and message
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/C_ATTACHMENT_METADATA.xml

    Naiara Martinez <[email protected]> null
    [Alfresco] Modify Core's default attachment method name
        src-db/database/sourcedata/C_ATTACHMENT_METHOD.xml

    Naiara Martinez <[email protected]> null
    [Alfresco] Add missing ad_messages
        src-db/database/sourcedata/AD_MESSAGE.xml

    Naiara Martinez <[email protected]> null
    [Alfresco]Catch exceptions and show errors in the window for Upload/Edit 
options
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <[email protected]> null
    [Alfresco] Changes in js in order to be able to show error when downloading 
files
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <[email protected]> null
    [Alfresco] Show error in the window if download/downloadAll fails.Missing 
changes in ob-view-form-attachment.js
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <[email protected]> null
    [Alfresco] create unique constraint messages into ad_message
        src-db/database/sourcedata/AD_MESSAGE.xml

    Daniel Ruiz <[email protected]> null
    [Alfresco]Fixes issue on previous changeset related to edit part of 
attachments
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Daniel Ruiz <[email protected]> null
    [Alfresco]Added new Handler that provides all metadata fields in order to 
show
them in the add and edit attachments popup.
        src/org/openbravo/event/UpdateAttachmentMetadataHandler.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <[email protected]> null
    [Alfresco]Delete downloadAll from the abstract class. Modify DownloadAll 
method from Manager Implementation class.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <[email protected]> null
    [Alfresco]Update download method to return a fileUtility.
Add new abstract method that returns if download method is creating a temporary 
file in Openbravo Server.
In Manager class, modify the donwload  method to remove the temporary file if 
it is needed.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <[email protected]> null
    New message to show error which an user will understand for database 
constraint error
        src-db/database/sourcedata/AD_MESSAGE.xml

    Naiara Martinez <[email protected]> null
    [Alfresco]Use system tmpdir folder, instead of using attachment/tmp
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <[email protected]> null
    [Alfresco] Remove temp file from attachment/tmp when uploading files, if 
still exists
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <[email protected]> null
    [Alfresco] Remove unnecessary code from delete method (Core implementation).
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Naiara Martinez <[email protected]> null
    [Alfresco] Add AdminMode in AttachImplementationManager.update() and remove 
it from Core implementation.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Naiara Martinez <[email protected]> null
    [Alfresco]Feedback from codeReview:
{}, log, in upload method use only File argument (remove FileItem), put private 
methods at the end of the class
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Naiara Martinez <[email protected]> null
    [Alfresco] Modify name of Edit Description link in attachments section.Used 
new name 'Edit'
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml

    Naiara Martinez <[email protected]> null
    Error Messages in ad_message
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml

    Naiara Martinez <[email protected]> null
    Create abstract class for attachment method. Core attachment implementation
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Daniel Ruiz <[email protected]> null
    Fixes issue related to naming rules for Attachment Configuration table.
        src-db/database/sourcedata/AD_TABLE.xml

    Daniel Ruiz <[email protected]> null
    Fixes issue related to missed identifier for table c_attachment_conf
        src-db/database/sourcedata/AD_COLUMN.xml

    Naiara Martinez <[email protected]> null
    Fix check constraints for active columns
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD.xml

    Daniel Ruiz <[email protected]> null
    Fixes issue on trigger c_attachment_metadata_mod_trg.
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_MOD_TRG.xml

    Daniel Ruiz <[email protected]> null
    Fixes new issues on previous commit:
- Added new data to c_attachment_metadata table.
- Fixed c_attachment_metadata_mod_trg trigger.
- Deleted ad_dataset_column created before.
        src-db/database/sourcedata/C_ATTACHMENT_METADATA.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_MOD_TRG.xml
        src-db/database/sourcedata/AD_DATASET_COLUMN.xml

    Daniel Ruiz <[email protected]> null
    Fixes different issues on previous commit.
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_MOD_TRG.xml
        src-db/database/sourcedata/C_ATTACHMENT_METHOD.xml
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD.xml
        src-db/database/model/tables/C_FILE.xml
        src-db/database/model/triggers/C_ATTACHMENT_METHOD_MOD_TRG.xml
        src-db/database/sourcedata/AD_DATASET_COLUMN.xml
        src-db/database/sourcedata/AD_DATASET_TABLE.xml

    Daniel Ruiz <[email protected]> null
    Changes on previous commit: Metadata window has been deleted and instead of
this one, Attachment Method window has been created with Metadata tab.
There are other minor changes too.
        src-db/database/model/tables/C_ATTACHMENT_METHOD.xml
        src-db/database/model/triggers/C_ATTACHMENT_METHOD_MOD_TRG.xml
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_FILE.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_DATASET_TABLE.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MENU.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_REF_LIST.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/AD_TREENODE.xml
        src-db/database/sourcedata/AD_WINDOW.xml

    Daniel Ruiz <[email protected]> null
    Core Attachments changes: new attachement configuration window used to 
define
the attachment method used to Download/Upload files. New column added to c_file
table (attachment method). New Attachment metadata window in order to define
fields that will be shown on Download/Upload pop-up depending on attachment
method used.
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_FILE.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MENU.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_REF_LIST.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/AD_TREENODE.xml
        src-db/database/sourcedata/AD_WINDOW.xml

    Asier Lostalé <[email protected]> null
    related to bug 29313: code cleanup

  removed unneeded code
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Lostalé <[email protected]> null
    fixed bug 29313: attachment download of different records at once fails

  It generated an invalid zip file.

  The problem was it tried to find the attachment directory based on the whole
  list of ids to download instead of splitting it.
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Augusto Mauch <[email protected]> null
    Related with issue 28842: Improves javadoc of checkReadableAccess method
        src/org/openbravo/dal/security/SecurityChecker.java

    Naroa Iriarte <[email protected]> null
    Fixed issue 28842: There are problems to handle attachments.

There were two problems:
First: When storing an attachment in the database (c_file table), the current
 organization of the user was used instead of the organization of the document 
where the
file is being attached to. The aim of this fix is to take the value of the 
organization
of the attached document instead of the current user organization.
Second: When an attachment was created with an organization and after that, the
 organization of the document was changed, it was not possible to download it, 
update it nor delete
it with a user who does not have access to the organization used to create the 
attachment.

To fix the first part, a new field that stores the document organization has 
been added to the canvas
 of the OBAttachmentsSectionItem class in the fillAttachments function. After 
that the
 field is sent as a param in the request, and can be used in the 
TabAttachments.java class
to be included to create the new record in c_file.

To fix the second part, the way the attachments are retrieved in the 
TabAttachments and in the
AttachmentsAH classes has been modified. Now the automated organization filter 
is disabled,
so the organization of the attachment is not taken into accout. It is needed 
that the user has at
least readable access to the document's organization for downloading, deleting 
or editing its attachments
a new method has been added to the SecurityChecker class for checking this.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-linked-items.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
        src/org/openbravo/dal/security/SecurityChecker.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Lostalé <[email protected]> null
    fixed bug 29329: can't download attachments for 2 rows with same name & no 
ext

  When trying to download at once attachemnts for different records that have 
the
  same name and it does not have extension, it fails.

  The problem is in case of duplicated names to be included within the zipped 
file,
  a number is appended to the file name before the extension. Extesion is 
present
  is assumed, failing if not.

  Fix: don't assume file name has extension.
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java




Last 20 lines of the console output:

[...truncated 1574 lines...]
+<!--F52B56FE91C64CB2B5AC43E52C1C763E-->  
<ALLOWED_CROSS_ORG_LINK><![CDATA[N]]></ALLOWED_CROSS_ORG_LINK>
 <!--F52B56FE91C64CB2B5AC43E52C1C763E--></AD_COLUMN>
 
 <!--F55387BA03C14531AA6A20E0AF799E1B--><AD_COLUMN>
reverting 
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
reverting src-db/database/sourcedata/AD_COLUMN.xml
ERROR: found differences



 * FAILURE:  DBconsistency ERP
LOG: 
https://ci.openbravo.com/job/int-dbcons-pgsql/2040/artifact/dbconsistency.log/*view*/
 

Build step 'Execute managed script' marked build as failure
Checking console output
/srv/ci/jobs/int-dbcons-pgsql/builds/2040/log:
ERROR: found differences
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds

Reply via email to