int-api - Build # 2024 - Failure:
Check console output at https://ci.openbravo.com/job/int-api/2024/ to view the
results.
Committers since last success:
Changes for Build #2024
Inigo Sanchez <[email protected]> null
Fixed issue 32728: Standard datasources should check entity access.
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Improve comments and notation Override.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Improve legibility, copyright and a typo
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_REF_LIST.xml
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java
src-test/src/org/openbravo/test/datasource/DataSourceWhereParameter.java
src-test/src/org/openbravo/test/security/ExplicitCrossOrganizationReference.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Merge with pi
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added a test case
src-test/src/org/openbravo/test/datasource/TestInitializeAccess.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Fixed tests related to security projects
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
src-test/src/org/openbravo/test/datasource/DataSourceWhereParameter.java
src-test/src/org/openbravo/test/security/ExplicitCrossOrganizationReference.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Revert default jdk version
.settings/org.eclipse.jdt.core.prefs
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Merge with pi.
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Improve performance and small clean code.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Removed unnecessary setAdminMode method
modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
src/org/openbravo/materialmgmt/ManageVariantsDS.java
src/org/openbravo/materialmgmt/ProductCharacteristicsDS.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Merge with pi.
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Some code review improvements
Some code review improvements are fixed:
- Typo errors.
- Name conventions.
- Declare "OBSERDS_AllowUnsecuredDatasourceRequest" constant in CachedPreference
instead of BaseDataSourceService.
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
src/org/openbravo/dal/security/EntityAccessChecker.java
src/org/openbravo/materialmgmt/ManageVariantsDS.java
src/org/openbravo/materialmgmt/ProductCharacteristicsDS.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] EntityAccessChecker performance improvements
- Store in memory process ids, not the whole objects
- Query for ids rather than whole object
- Retrieve from a single query all required objects, do not do a query for
each item
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Refactor and improve performance in
addEntitiesFromProcess.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Fixes role in TestComboDatasource.
Now are checked properly all entities access and for this
reason role that uses this test was wrong. It has been fixed
by using F&B International Group Admin role instead of
F&B España - Employee.
src-test/src/org/openbravo/test/datasource/TestComboDatasource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Fixes Account tree and Stock Reservation fetch
test.
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Merge with pi.
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Improve performance in initialize method
Performance in initialize method is improved. Besides some getter methods are
added.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Checking access to Process with new check method
In EntityAccessChecker a new check method is implemented. This new check method
it
is used to check if a current user/role has access to a process.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] The constant was wrongly removed in a merge.
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Improve name method and comment
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Take into account ref windows in initialize method
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Merge with pi.
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Take into account process related with selectors
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Updated test case for trees and property selector
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Take into account tab for check access.
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] updated test case for
SelectorFieldPropertyDataSource
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Merge with pi.
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added tests for some datasources.
It have been added some test cases:
- ComboTableDatasourceService
- CustomQuerySelectorDatasource
- QuickLaunchDataSource
- QuickCreateDataSource
- HQLDataSourceService
- ADTreeDatasourceService
- AccountTreeDatasourceService
- StockReservationPickAndEditDataSource
- QueryListDataSource
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added check fetch in StockReservationDataSource.
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added check fetch in
SelectorFieldPropertyDataSource.
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added check fetch in HQLDataSourceService.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Use checkReadableAccess method instead old one.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added test case for Notes and ManageVariants.
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added check fetch in ProductCharacteristicsDS.
src/org/openbravo/materialmgmt/ProductCharacteristicsDS.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added check fetch in ManageVariantsDS.
src/org/openbravo/materialmgmt/ManageVariantsDS.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] added test case for Product Characteristics
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] added test case for manage variants ds
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Improve name method
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] added test case for Windows > Tab > Field >
Property
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] no need to add name parameter to produce good test
names
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] ds in test cases are now an enum, making better
test names
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] added test case for alert data source
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] set proper organization in test cases
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added a test case related when a targetProperty is
null
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Use preference properly in checkEdit...()
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Improve comment and java doc
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Refactor method name
src/org/openbravo/base/model/ModelProvider.java
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added another case into parameterized test.
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess]Avoids null pointer exc related to null
targetProperty
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added a new preference
Added OBSERDS_AllowUnsecuredDatasourceRequest preference to force security
access by default. If this preference is set to 'Y' can be
use datasources without any security check.
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_REF_LIST.xml
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Merge with pi.
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Implement fetch check and edit check in tree ds
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Removed unnecesary methods and comments.
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Fixes comment and status expected.
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess]Derived entities from process are other type of
derived
It has been added new collection for entities derived from process. Besides it
has
been added a small redactor.
src/org/openbravo/base/model/ModelProvider.java
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Refactor and Improve performance
It has been improved performance in initialize method of entityAccessChecker.
Besides
it has been refactored some code to avoid unnecessary if conditions and to
catch a
forgotten case: a role without permissions.
src/org/openbravo/base/model/ModelProvider.java
src/org/openbravo/dal/security/EntityAccessChecker.java
Asier Lostalé <[email protected]> null
[TestSecurityEntityAccess] Renamed test class
src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
src-test/src/org/openbravo/test/AllWebserviceTests.java
src-test/src/org/openbravo/test/datasource/TestSecurityEntityAccess.java
Asier Lostalé <[email protected]> null
[DataSourceEntityAccess] Test is now parameterized:
- Now it checks same datasources for roles with and without access
- It does not use sys admin role but a new dummy empty one
src-test/src/org/openbravo/test/datasource/TestSecurityEntityAccess.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Refactor for use new check methods in combos.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added test cases.
src-test/src/org/openbravo/test/datasource/TestSecurityEntityAccess.java
src-test/src/org/openbravo/test/AllWebserviceTests.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Improve log when checking access
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Fixes test updating to a properly profile
src-test/src/org/openbravo/test/datasource/TestAllowUnpagedDatasourcePreference.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Merge with pi.
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Refactor fetch entity access check
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Take into account derived entities from process.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Adding javadoc
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Remove testing code in fetch, add and remove
methods
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Merge with pi.
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Refactor NoteDataSource.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceConstants.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added check in missing case: add().
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Remove testing code.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Fixed test by adding two necessary parameters
src-test/src/org/openbravo/test/datasource/ProductSelectorDataSourceTest.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess]Removed unnecessary entity parameter from new
methods
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Removed unnecessary conditions
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Refactor for use new check methods.
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Refactor entity access check at
BaseDataSourceService
Re-implement entity access check at BaseDataSourceService level. Now it have
been added 2 methods instead of previous checker method: fetch and edit
(add, remove and update).
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added entity access check for specific datasources
It is used entity access check at specific datasources.
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added entity access check for custom selectors
It is used entity access check at CustomQuerySelectorDatasource level to checks
if
entity is derived.
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java
Inigo Sanchez <[email protected]> null
[DataSourceEntityAccess] Added entity access check at BaseDataSourceService
Implement entity access check at BaseDataSourceService level. This mechanism
should be overwritable so specific cases (ie. AlertDS, Notes…) can implement
their own security mechanisms.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
src/org/openbravo/dal/security/EntityAccessChecker.java
Last 20 lines of the console output:
[...truncated 30963 lines...]
org.openbravo.service.datasource:
Abs.add
method
org.openbravo.service.datasource.DataSourceService.checkEditDatasourceAccess(java.util.Map<java.lang.String,
java.lang.String>): new interface method in
/srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java
method
org.openbravo.service.datasource.DataSourceService.checkFetchDatasourceAccess(java.util.Map<java.lang.String,
java.lang.String>): new interface method in
/srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java
+ failure=1
+ exit 1
Build step 'Execute shell' marked build as failure
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : cp
/srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java.japi.gz .
[int-api] $ /bin/bash -xe /tmp/hudson886807449036206300.sh
+ cp /srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java.japi.gz .
POST BUILD TASK : SUCCESS
END OF POST BUILD TASK : 0
Archiving artifacts
Checking console output
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
