[Openbravo-builds] up-2.50topi-oracle - Build # 130 - Still Failing!

[jenkins]

up-2.50topi-oracle - Build # 130 - Still Failing:

Check console output at https://ci.openbravo.com/job/up-2.50topi-oracle/130/ to 
view the results.


Committers since last success:

Changes for Build #129

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Related to issue 32510: Code review improvements
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java

    Atul Gaware <atul.gaw...@openbravo.com> null
    Fixes issue 32510: Improve performance of Payment Report

- Improve hql query.
- Avoid joins in query if they are not necessary.
- Retrieve only id instead of dal object in query.
- Use !isEmpty() instead of size()>0.
- Use setMaxResults(1) and uniqueResult() instead of list().get(0).
- Improve simple queries to return needed column instead of full dal object and 
avoid looping through results.
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    Fixed issue 32707: ORA-00918 error was got while packaging module

When a module was being packed in oracle, that error was shown.
This means that a column in ambiguously created.

The problem was in a query.
It was trying to execute a query where there were two tables with
a column with the same name. TABLE_NAME was being exectued insetad of
U.TABLE_NAME (with the alias of the table), and as that column exists in the two
tables, that error was raised.
        src-db/database/lib/dbsourcemanager.jar

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    Fixed issue 32689: The ResultMapCriteriaUtils class has been deleted

The unused ResultMapCriteriaUtils class has been deleted.
        src/org/openbravo/common/datasource/ResultMapCriteriaUtils.java

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Related to issue 32654: Create new ad_element for ad_org_id_process 
parameter
        
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Related to issue 32281: Wrong picking list quantity when no stock available

Send p_reservation_id as null when calling M_GET_STOCK_PARAM from 
M_RESERVE_STOCK_AUTO in order to check reserved quantity from any reservation.
        src-db/database/model/functions/M_RESERVE_STOCK_AUTO.xml

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed 32760: add to jUnit test cases log info about when they start/complete

  Now when test cases extending OBBaseTest are executed, a line is logged before
  they start and when they complete.
        src-test/src/org/openbravo/test/base/OBBaseTest.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    related to issue 32756: run missing synchronize terminology
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Related to issue 32281: Backout changeset a8bef035c93c and fc9de8940c8e
        src-db/database/model/functions/M_RESERVE_STOCK_AUTO.xml

    Mark <m.mol...@nectus.com> null
    Fixes issue 32579: Generated credit set as used when it should not

Generated credit was set as used although it is not possible to process the 
payment that uses it, when an exception is thrown the payment processing aborts 
and can't be created or updated the credits.
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Related to issue 32654: Code review improvements

Some changes have been done in Add Transaction process definition related to 
organization field in order to have the same behaviour as in Financial Account 
Transaction tab.

- Filter payments in Payment selector (drop down or magnifying glass) in Add 
new transaction process definition:
Add new parameter called ad_org_id_process to save process definition's current 
organization value, and filter by it in the hql where clause of the payment 
selector.
- Filter in Add Payment grids when opening from Payment selector in Add new 
transaction process definition.
Check for ad_org_id parameter before checking for inpadOrgId parameter in 
TransactionAddPaymentDefaultValues.
- Creating new payments in Add Payment when opening from Payment selector in 
Add new transaction process definition:
Check for ad_org_id parameter before checking for inpadOrgId parameter in 
AddPaymentActionHandler.
- Creating new financial account transactions in Add new transaction process 
definition:
Process definition's current organization value will be taken instead of 
selected payment organization.
- Avoid changing organization once you have selected a payment:
Update read only logic of accounting dimensions to disable them when we have 
already selected a payment.
        
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUISEL_SELECTOR.xml
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionActionHandler.java
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java
        
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js

    Mark <m.mol...@nectus.com> null
    Fixes issue 32654: Unhomogeneus behavior in Transaction organization 
dimension.

To avoid that the value for Organization in Transaction's dimension section be 
different depending on process used to add transaction, if the Add payment 
action is excecuted from it, always will be used as organization the ad_org_id 
field selected in the caller window (Add transaction window).
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    fixes issue 32756: Hide the 'Recalculate Permissions' button
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/OBUIAPP_PROCESS.xml

    Augusto Mauch <augusto.ma...@openbravo.com> null
    Related with issue 32702: Improves JavaDoc
        src/org/openbravo/server/ServerControllerHandler.java

    Augusto Mauch <augusto.ma...@openbravo.com> null
    Fixes issue 32702: Access to be backend can be restricted in the store 
servers

If the RestrictErpAccessInStoreServer preference is set to Y, only users with 
the System Administrator role will be granted access to the backend in the 
store servers.

Summary of the changes:
- ServerController & ServerControllerHandler: New classes to be able to know in 
core whether the current server is a central or a store server.
- CachedPreference: The value of the RestrictErpAccessInStoreServer is cached.
- UserInfoWidgetActionHandler: Controls that if the access is restricted only 
the System Administrator role should be available in the role combo
- index.jsp: Controls that if the access is restricted and the current user is 
not using the System Administrator role, the backend workspace is not shown.
- HttpSecureAppServlet: Controls that if the access is restricted the default 
role of a user that logs in is System Administrator.
- LoginHandler: Controls that login is denied for users that do not have the 
System Administrator role if access is restricted in the store servers. For 
users that do have the System Administrator role it makes sure only that role 
is used.
        src/org/openbravo/server/ServerController.java
        src/org/openbravo/server/ServerControllerHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoWidgetActionHandler.java
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_REF_LIST.xml
        src/index.jsp
        src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
        src/org/openbravo/base/secureApp/LoginHandler.java

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Related to issue 32504: Add some sleeps in TestCosting to avoid assert 
errors
        src-test/src/org/openbravo/test/costing/TestCosting.java

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Fixes issue 32504: Improve performance of Costing process

- Add new column cumcost in M_Costing table
- Make some queries in CostingUtils and CostAdjustmentUtils incremental using 
cumqty and cumcost from current m_costing record to avoid sum every record in 
m_transaction and m_transaction_cost tables.
- Avoid join m_transaction with m_locator if current costing rule has no 
warehouse dimension.
- Improve CostingServer checkCostAdjustments method to do query only if needed.
- Avoid count query in CostingBackground process.
- Add indexes in m_costing table: (m_product_id, datefrom, dateto) and 
(m_transaction_id).
- Change in AverageCostAdjustment: cost will be taken from trxPrice in case 
current stock is zero.
- Update cumqty column name to cumstock in M_Costing table to set it as NULL 
and delete it in F&B International Group and QA Testing clients sampledata.
- Assert new m_costing cumcost column in TestCosting.
        referencedata/sampledata/F_B_International_Group/M_COSTING.xml
        referencedata/sampledata/QA_Testing/M_COSTING.xml
        src-db/database/model/tables/M_COSTING.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-test/src/org/openbravo/test/costing/TestCosting.java
        src/org/openbravo/costing/AverageAlgorithm.java
        src/org/openbravo/costing/AverageCostAdjustment.java
        src/org/openbravo/costing/CostAdjustmentUtils.java
        src/org/openbravo/costing/CostingBackground.java
        src/org/openbravo/costing/CostingMigrationProcess.java
        src/org/openbravo/costing/CostingServer.java
        src/org/openbravo/costing/CostingUtils.java
        src/org/openbravo/costing/InventoryAmountUpdateProcess.java

    David Miguelez <david.migue...@openbravo.com> null
    Related to Issue 18273, related to Issue 18271. Fixes extra characters in 
html.
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.html

    David Miguelez <david.migue...@openbravo.com> null
    Related to Issue 18271. Related to Issue 18273. Export of
AD_TEXTINTERFACES.
        
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_TEXTINTERFACES.xml

    David Miguelez <david.migue...@openbravo.com> null
    Fixes Issue 18271. Adds payment method field to Report output.
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.html
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.xml
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportExcel.jrxml
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportPDF.jrxml

    David Miguelez <david.migue...@openbravo.com> null
    Fixes Issue 18273. Adds ability to filter Payment Report by
Sales Representative.

Adapts code to be able to filter the data based on Sales Rep.
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.html
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.java
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReport.xml
        
modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    Fixed issue 32285: It is possible to manually set passwords as expired

When a user is created, now it is possible to set the password as expired 
manually.
This is to force the user to change it the first time he logs in.
      
    Naroa Iriarte <naroa.iria...@openbravo.com> null
    [pi-expired-password] Merge with latest pi
      
    Naroa Iriarte <naroa.iria...@openbravo.com> null
    [pi-expired-password] An export corrected

There was a column missing, now the export is correct.
        src-db/database/sourcedata/AD_COLUMN.xml

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    [pi-expired-password] Merge with latest pi
      
    Naroa Iriarte <naroa.iria...@openbravo.com> null
    [pi-expired-password] Changed the name of the checkbox in the UI

is Expired Password was noa good name for the UI. It has been changed.
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    [pi-expired-password] Some uneeded parenthesees

Some uneeded parenthesees have been deleted from the 
DefaultAuthenticationManager class.
        src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    [pi-expired-password] Changed the ad_user_expirationpass_trg

To set the is expired password to false the ad_user_expirationpass_trg
has been modified, here is where the new password of the user is set, so,
it is a good place to modify the value of the is expired password if it was
previously set to true.
        src-db/database/model/tables/AD_USER.xml
        src-db/database/model/triggers/AD_USER_EXPIRATIONPASS_TRG.xml
        src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    [pi-expired-password] Added some constraints to the column

Added not null and check constraints to the is expired password column.
        src-db/database/model/tables/AD_USER.xml

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    [pi-expired-password] Created the logic for the new feature

Created the logic for the manual expired password.
        src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    [pi-expired-password] Creation of the new is expired password field

The new checkbox is expired password has been created.
        src-db/database/model/tables/AD_USER.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    Fixed issue 32705.check that attachmentCount is a number

Change the if clause to check that attachmentCount is a number instead of just
if (data.attachmentCount) {}.
In this case when count is 0 the if clause should return true but JavaScript
considers 0 as false.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js

    Unai Martirena <unai.martir...@openbravo.com> null
    Fixes issue 32687: Applied Product Services Code Review
        src-db/database/model/functions/C_GET_SERVICE_AMOUNT.xml
        src-db/database/model/functions/C_ORDER_POST1.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-test/src/org/openbravo/test/services/ServicesTest.java
        src/org/openbravo/common/actionhandler/ServiceOrderLineRelate.java
        
src/org/openbravo/erpCommon/info/ServiceProductPricePrecisionFilterExpression.java
        src/org/openbravo/event/ServiceOrderLineEventHandler.java
        src/org/openbravo/materialmgmt/ServicePriceUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    Related to issue 29771.Populate allowed_corrs_org_link column in new columns
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_COLUMN.xml

    Asier Lostalé <asier.lost...@openbravo.com> null
    related to issue 32615: updated Licensing file to match new jar name
        legal/Licensing.txt

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco] add TabAttachments_data.xsql file.

Recover deleted file to avoid api-change that affects published modules
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_data.xsql

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    Fixed issue 29771. Merge of attachment enhancenment project

This projects enables the ability to define different attachment methods.
http://wiki.openbravo.com/wiki/Projects:Alfresco_Integration
      
    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fixes managing parameter values

- Do not save parameter values with null or empty value.
- Reset to null c_file.text column when an old attachment is edited.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Use context clients instead of organization client.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Improvements in metadata tabs layout.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Do not compute and save description in c_file.text
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue when searching generic system configuration.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [alfresco] typo
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Add missing javadoc
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [alfresco] removed some code duplication
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [alfresco] fixed incorrect casting management
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [alfresco] fixed typo
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/MetadataOnTab.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Ensure that attachemt are reset when section is disabled.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Create new private method to avoid duplicated code.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentMetadataEventHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix type in javadoc
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix type in new public method downloadAll
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Include original exception on rethrow.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Allow and use as default attachment configs in system.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java
        src-db/database/sourcedata/AD_TABLE.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove hungarian notation.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix typo in javadoc
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Javadoc improvements.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/CoreAttachImplementation.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Improve javadoc of AttachImplementation abstract class.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementation.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Set c_file.text column as deprecated.
        src-db/database/sourcedata/AD_COLUMN.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Code improvements on MetadataOnTab callout.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/MetadataOnTab.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove unused variables.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Initialize default value of ATT_SHOWINDESCRIPTION flag
        
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.querylist/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.widgets/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix potential regression when creating a new record in form view.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Set mandatory boolean column ATT_SHOWINDESCRIPTION
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Add some context in error logs of AttachmentAH
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]hardcode message format for performance reasons.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]remove unneeded public method.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Performance fix.Load attachments when section is expanded.

* Modify FIC to send only the count of attachmetns.
** If several records are selected return 1 if there is any attachment not the
   actual count.
* Modify the section to set the number of attachments on the form load and not
  when the attachments are loaded.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FICExtension.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Split execute method in different methods
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Use ConcurrentHashMap for clientConfigs
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Use proper StringUtils class.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Use ConcurrentHashMap to avoid concurrence issues.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Move AttachmentsAH class to attachment package.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix package declaration of moved class.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Moved attachment related classes to own package.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentConfigEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentMetadataEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/MigrateAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AttachmentMetadataEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/event/AttachmentConfigEventHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix copyright year of modified files.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AttachmentMetadataEventHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove todo.boolean parameters tested.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove blank spaces on js file.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Send command instead of action for EDIT
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix height of attachment list on form.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Properly reset upload state on upload errors
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Show description text on existing attachments
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]fix merge issue with column default value.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_SYSTEM.xml
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_TAB.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Add callout to populate seqNo in tab metadata definition.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/MetadataOnTab.java
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_CALLOUT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix js leaks uploading attachments.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Properly initialize att metadata on ADCS
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Do not include organization in view request.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    Merge alfresco branch with pi 1450b7bf6b32 revision.
      
    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]store in cache the metadata of each tab and method.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [Alfresco]Change getAttachmentConfig to return the AttMethod instead.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix event handler javadoc.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AttachmentMetadataEventHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Improvements in clientConfigs Map management
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Capitalize attachment tables definition.
        src-db/database/sourcedata/AD_TABLE.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco] ui fixes

- Use parents module when creating metadata on attachment method.
- Improvements in help.
- Move active field to the end of the tab.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    Add name to implicit filter of Attachment Method -> Metadata
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_TAB.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]use adcs to retrieve tab information.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove unneeded method from BaseProcessActionHandler.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Use proxies when possible. Do not do toString() on log.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Add class javadoc and move chech to method begining.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Properly format js file.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Send metadata values as a JSON when uploading a file.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Build description of attachment dynamically.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Build attachment json in FIC using AttachmentUtils method.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Change window title when editing metadata.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix default values of modules in Attach Metadata tab.
        src-db/database/sourcedata/AD_COLUMN.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue overwriting files in core implementation.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Use existing attachment config and method when overwriting a file.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix NPE removing attachment without related AttConfig.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue downloading all attachments.

NPE checking the method to use on the attachments. Attachments uploaded
without any Attachment Config have that value empty. Check that property for
null values instead of the AttachmentMethod that it is mandatory.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix NPE in downloadAll

The dataType is not send anymore in the submit of the upload file. Calculate
it in the AttachImplementationManager using the Tika library.

When downloading a file properly check if there is a dataType defined for the
attachament.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue retrieving context information.

Use buttonOwnerView instead of ownerView. The OBBaseParameterWindowView
getUnderLyingRecordContext method uses buttonOwnerView.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Set fixed parameters values in fixedParameters
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue with display and read only logics

Add a new constructor in DynamicExpressionParser for parameters that are not
based in a Process as is the case of Attachment Metadata. This new constructor
receivs as a parameter the list of related Parameters instead of loading them
from the Process.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Load description from text property on old attachments.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Set attachment method id to Description parameter.
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Several improvements due to code review.

- Change att_value_key column to be able to store List Search Keys instead of
  just the id.
- Property path values are also calculated when the popup is opened in case
  another metadata depends on it.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER_VALUE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Code style inprovements.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Performance fixes in CoreAttachImplementation
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Add again setProcess method to avoid unneeded api change
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Change name of variable.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Set OB Style to file item
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix consistency issue running synchronize terminology
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fixed issues with attachments uploaded with old system.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Add handler to avoid duplicated db columnnames in metadata.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/AttachmentMetadataEventHandler.java
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Set default seq number on attachment metadata.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfesco]Remove hidden field compilation warning.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue setting default values in attachment popup.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Show metadata parameters ordered by seqno.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Use single quotes in js files.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix metadata tab layouts.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco] Add translation tabs for attachment metadata
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TAB.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove translation tab for attachment methods
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD_TRL.xml
        src-db/database/model/triggers/C_ATTACHMENT_METHOD_TRG.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Set proper ui on popup based on mockups.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue on process definition windows.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]File item form is only needed in Upload mode.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco] Use FileItem instead of UploadItem in attachment window.

It is not possible to use UploadItem on a form that redraws. This is the case
when display logics have to be executed. FileItem is used instead.

When using a FileItem it is not possible to do submitForm as the file will not
be included in the request. In this case it is used the internal DynamicForm
used by the FileItem. To include all the parameters in the request they need
to be added as hidden inputs in the DynamicForm that it is finally submited.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    Merge with pi revision 707bfc29b8b5
      
    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Add missing indexes for new child tabs.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD_TRL.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix integration issues
- Check for null parameters when converting the parameter map to String
  values.
- Fix check constraint por postgresql.
- Remove not needed text interfaces after html file removal.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseActionHandler.java
        src-db/database/sourcedata/AD_TEXTINTERFACES.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue with default values return null when FK Object is not 
found.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Merge with pi revision 2e0980743044
      
    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix several issues based on testing.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER_VALUE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_TAB.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix display logics for fixed parameters.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]update session att config values when changing the active conf.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        src/org/openbravo/event/AttachmentConfigEventHandler.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Do flush before restoring previous mode.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fixed issue while loading the add attachment from the grid.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Several code review fixes.Remove unused code.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD_TRL.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_WINDOW.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove unneeded code.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-form-styles.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove unneeded code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue compiling ViewComponent.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Code review applied
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER_VALUE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REFERENCE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REF_TABLE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Move and deprecate some publics methods to 
CoreAttachImplementation.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/MigrateAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Format js code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco] Clean code. Remove files and code from 2.50 version

Removed xmlEngine templates of unused 2.50 attachment popup
Removed all the related code from TabAttachments servlet
Changed the Logger to slf4j
Renamed download commands
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_Edition.html
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_Edition.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_F1.html
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_F1.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_FS.html
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_FS.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments_data.xsql

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco]IsUserEditable column removed from Obuiapp_Parameter table
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco]Popup metadata is loaded when editing an attachment
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Fix issue with fixed parameters
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <asier.martir...@openbravo.com> null
    Property path and fixed parameters correctly treated
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco]Changes in Alfresco method applied for core implementation too
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] New error messages
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Format js code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Add attachment method to viewId
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-attachment-view.js.ftl
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Parameters with property path allowed for attachments
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco]Metadata type conversion dane before calling AttachImplementation 
class
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Supported List parameters for attachments
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue uploading files in core
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Fixed issue saving metadata
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix issue getting context info
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Merge heads
      
    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Use ParameterUtils class methods to save metadata.
This change is done because now the table ParameterValue is used to store 
metadata.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Used ParameterValue table instead of Parameter in metadata Map
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] New table to store attachments metadata.

>From C_File_Metadata to OBUIAPP_Parameter_Value table.
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER_VALUE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/OBUISEL_SELECTOR.xml
        src-db/database/model/tables/C_FILE_METADATA.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Format js code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove commented code.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Implement EDIT with new attachment popup.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Calculate default values of metadata fields on popup load.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsAttachmentActionHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Fix return of method to return retval.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Removed property path from metadata in Attachment Method
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] In c_file, only metadata with isInDescription is saved in Text 
column
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Remove symlink
        modules/org.openbravo.integration.alfresco

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Format js files.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco] Implement attach popup using freemaker and obuiapp parameters

Create a new utils class to retrieve attachment method, config and metadata
parameters.
Several fixes on templates and classes to properly load the attachment popup.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentUtils.java
        modules/org.openbravo.integration.alfresco
        
modules/org.openbravo.client.application/src-db/database/sourcedata/OBCLKER_TEMPLATE_DEPENDENCY.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-attachment-view.js.ftl
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ParameterWindowComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Add new argument to fetchView to add extra parameters.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-view-manager.js

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [alfresco]Default parameter description as Text of 255
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Gorka Ion Damián <gorkaion.dam...@openbravo.com> null
    [Alfresco] Attachments based on OBUIAPP_Parameter metadata.

- Split of ob-parameter-widnow to create a OBBaseParameterWindow.
- Created ob-attachment-window-view.js extending OBBaseParameterWindow.
- Create a new ftl template to generate the attachment view based on tab and
  client to add the related metadata.

Note. This is work in progress and more changes are needed to complete the
development.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-attachment-view.js.ftl
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-attachment-window-view.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
        
modules/org.openbravo.client.application/src-db/database/sourcedata/OBCLKER_TEMPLATE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ViewComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewParameterHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ParameterWindowComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] New method to get a parameter value converted to its original 
type.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Added new metadata to save description for core attachments.
Code cleaned
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] IsActive field is shown for Metadata windows.

Now is easier to see if metadata values are or not enabled.
Code cleaned.
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Added filter clause to Metadata tab in Attachment Method window

Filters by metadata asigned to the Attachment Method, in order to hide metadata 
assigned to specific windows
        src-db/database/sourcedata/AD_TAB.xml

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Attachment Configuration functionality updated.

Now, each client may have more than one attachment configuration, but only one 
activated at once
        src/org/openbravo/event/AttachmentConfigEventHandler.java
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_FILE.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MESSAGE.xml

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] getMetadataValues abstract method removed from 
AttachmentImplementation class
Code cleaned
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] New windows and table to save attachment metadata
        src-db/database/model/tables/C_FILE_METADATA.xml
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REFERENCE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REF_TABLE.xml
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_DATASET_TABLE.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUISEL_SELECTOR.xml
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA_TRL.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_MOD_TRG.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_TRG.xml
        src-db/database/sourcedata/C_ATTACHMENT_METADATA.xml

    Jonathan Bueno <jonathan.bu...@openbravo.com> null
    [Alfresco] correct format of java class
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Jonathan Bueno <jonathan.bu...@openbravo.com> null
    Updated downloadAll method
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java

    Jonathan Bueno <jonathan.bu...@openbravo.com> null
    Updated method at TabAttachments
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Jonathan Bueno <jonathan.bu...@openbravo.com> null
    Save attachment config and upload api
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src-db/database/model/tables/C_FILE.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_FIELD.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Remove unnecessary variable
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] add a validation to show only modules in development (in 
attachment method)
        src-db/database/sourcedata/AD_COLUMN.xml

    Asier Martirena <asier.martir...@openbravo.com> null
    [Alfresco] Fixed bug of text modification in metadata while using accents
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco]in JS when metadata value is null, insert "" into the array
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Modify metadata hashmap to be <String, String> instead of 
<String, Object>.
Modify command to be EDIT instead of EDIT_DESC_OB3
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Daniel Ruiz <daniel.r...@openbravo.com> null
    [Alfresco]Fixes issue when adding new attachment:more than one file could be
uploaded. Now, it is not possible.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Fix a bug in ReportManager and send the tabID instead of tableId
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Daniel Ruiz <daniel.r...@openbravo.com> null
    [Alfresco]Fixes file parameter when calling callback in order to show 
metadata
fields popup or edit metadata values.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Remove UpdateAttachmentMetadataHandler, and add its logic to 
AttachmentsAH
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        src/org/openbravo/event/UpdateAttachmentMetadataHandler.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco]Get Metadata and remove description from upload/update methods
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
        src/org/openbravo/event/UpdateAttachmentMetadataHandler.java

    Daniel Ruiz <daniel.r...@openbravo.com> null
    [Alfresco]Added help to all new attachment windows, tabs and fields.
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/AD_WINDOW.xml

    Daniel Ruiz <daniel.r...@openbravo.com> null
    [Alfresco]Added Value field to JSON object in order to change metadata 
fields
name when adding and editing attachments.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/event/UpdateAttachmentMetadataHandler.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Add Attachment Method TRL
        src-db/database/model/tables/C_ATTACHMENT_METHOD_TRL.xml
        src-db/database/model/triggers/C_ATTACHMENT_METHOD_TRG.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_TRG.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Add Attachment Metadata TRL
        src-db/database/model/tables/C_ATTACHMENT_METADATA_TRL.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_TRG.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco]Add search key column/field in metadata table. Add unique 
constraint and message
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/C_ATTACHMENT_METADATA.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Modify Core's default attachment method name
        src-db/database/sourcedata/C_ATTACHMENT_METHOD.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Add missing ad_messages
        src-db/database/sourcedata/AD_MESSAGE.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco]Catch exceptions and show errors in the window for Upload/Edit 
options
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Changes in js in order to be able to show error when downloading 
files
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Show error in the window if download/downloadAll fails.Missing 
changes in ob-view-form-attachment.js
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] create unique constraint messages into ad_message
        src-db/database/sourcedata/AD_MESSAGE.xml

    Daniel Ruiz <daniel.r...@openbravo.com> null
    [Alfresco]Fixes issue on previous changeset related to edit part of 
attachments
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Daniel Ruiz <daniel.r...@openbravo.com> null
    [Alfresco]Added new Handler that provides all metadata fields in order to 
show
them in the add and edit attachments popup.
        src/org/openbravo/event/UpdateAttachmentMetadataHandler.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco]Delete downloadAll from the abstract class. Modify DownloadAll 
method from Manager Implementation class.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco]Update download method to return a fileUtility.
Add new abstract method that returns if download method is creating a temporary 
file in Openbravo Server.
In Manager class, modify the donwload  method to remove the temporary file if 
it is needed.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Martirena <asier.martir...@openbravo.com> null
    New message to show error which an user will understand for database 
constraint error
        src-db/database/sourcedata/AD_MESSAGE.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco]Use system tmpdir folder, instead of using attachment/tmp
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Remove temp file from attachment/tmp when uploading files, if 
still exists
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Remove unnecessary code from delete method (Core implementation).
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Add AdminMode in AttachImplementationManager.update() and remove 
it from Core implementation.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco]Feedback from codeReview:
{}, log, in upload method use only File argument (remove FileItem), put private 
methods at the end of the class
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Naiara Martinez <naiara.marti...@openbravo.com> null
    [Alfresco] Modify name of Edit Description link in attachments section.Used 
new name 'Edit'
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    Error Messages in ad_message
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    Create abstract class for attachment method. Core attachment implementation
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/CoreAttachImplementation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java

    Daniel Ruiz <daniel.r...@openbravo.com> null
    Fixes issue related to naming rules for Attachment Configuration table.
        src-db/database/sourcedata/AD_TABLE.xml

    Daniel Ruiz <daniel.r...@openbravo.com> null
    Fixes issue related to missed identifier for table c_attachment_conf
        src-db/database/sourcedata/AD_COLUMN.xml

    Naiara Martinez <naiara.marti...@openbravo.com> null
    Fix check constraints for active columns
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD.xml

    Daniel Ruiz <daniel.r...@openbravo.com> null
    Fixes issue on trigger c_attachment_metadata_mod_trg.
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_MOD_TRG.xml

    Daniel Ruiz <daniel.r...@openbravo.com> null
    Fixes new issues on previous commit:
- Added new data to c_attachment_metadata table.
- Fixed c_attachment_metadata_mod_trg trigger.
- Deleted ad_dataset_column created before.
        src-db/database/sourcedata/C_ATTACHMENT_METADATA.xml
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_MOD_TRG.xml
        src-db/database/sourcedata/AD_DATASET_COLUMN.xml

    Daniel Ruiz <daniel.r...@openbravo.com> null
    Fixes different issues on previous commit.
        src-db/database/model/triggers/C_ATTACHMENT_METADATA_MOD_TRG.xml
        src-db/database/sourcedata/C_ATTACHMENT_METHOD.xml
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_ATTACHMENT_METHOD.xml
        src-db/database/model/tables/C_FILE.xml
        src-db/database/model/triggers/C_ATTACHMENT_METHOD_MOD_TRG.xml
        src-db/database/sourcedata/AD_DATASET_COLUMN.xml
        src-db/database/sourcedata/AD_DATASET_TABLE.xml

    Daniel Ruiz <daniel.r...@openbravo.com> null
    Changes on previous commit: Metadata window has been deleted and instead of
this one, Attachment Method window has been created with Metadata tab.
There are other minor changes too.
        src-db/database/model/tables/C_ATTACHMENT_METHOD.xml
        src-db/database/model/triggers/C_ATTACHMENT_METHOD_MOD_TRG.xml
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_FILE.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_DATASET_TABLE.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MENU.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_REF_LIST.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/AD_TREENODE.xml
        src-db/database/sourcedata/AD_WINDOW.xml

    Daniel Ruiz <daniel.r...@openbravo.com> null
    Core Attachments changes: new attachement configuration window used to 
define
the attachment method used to Download/Upload files. New column added to c_file
table (attachment method). New Attachment metadata window in order to define
fields that will be shown on Download/Upload pop-up depending on attachment
method used.
        src-db/database/model/tables/C_ATTACHMENT_CONF.xml
        src-db/database/model/tables/C_ATTACHMENT_METADATA.xml
        src-db/database/model/tables/C_FILE.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MENU.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_REF_LIST.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/AD_TREENODE.xml
        src-db/database/sourcedata/AD_WINDOW.xml

    Asier Lostalé <asier.lost...@openbravo.com> null
    related to bug 29313: code cleanup

  removed unneeded code
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed bug 29313: attachment download of different records at once fails

  It generated an invalid zip file.

  The problem was it tried to find the attachment directory based on the whole
  list of ids to download instead of splitting it.
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Augusto Mauch <augusto.ma...@openbravo.com> null
    Related with issue 28842: Improves javadoc of checkReadableAccess method
        src/org/openbravo/dal/security/SecurityChecker.java

    Naroa Iriarte <naroa.iria...@openbravo.com> null
    Fixed issue 28842: There are problems to handle attachments.

There were two problems:
First: When storing an attachment in the database (c_file table), the current
 organization of the user was used instead of the organization of the document 
where the
file is being attached to. The aim of this fix is to take the value of the 
organization
of the attached document instead of the current user organization.
Second: When an attachment was created with an organization and after that, the
 organization of the document was changed, it was not possible to download it, 
update it nor delete
it with a user who does not have access to the organization used to create the 
attachment.

To fix the first part, a new field that stores the document organization has 
been added to the canvas
 of the OBAttachmentsSectionItem class in the fillAttachments function. After 
that the
 field is sent as a param in the request, and can be used in the 
TabAttachments.java class
to be included to create the new record in c_file.

To fix the second part, the way the attachments are retrieved in the 
TabAttachments and in the
AttachmentsAH classes has been modified. Now the automated organization filter 
is disabled,
so the organization of the attachment is not taken into accout. It is needed 
that the user has at
least readable access to the document's organization for downloading, deleting 
or editing its attachments
a new method has been added to the SecurityChecker class for checking this.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/AttachmentsAH.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-linked-items.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
        src/org/openbravo/dal/security/SecurityChecker.java
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed bug 29329: can't download attachments for 2 rows with same name & no 
ext

  When trying to download at once attachemnts for different records that have 
the
  same name and it does not have extension, it fails.

  The problem is in case of duplicated names to be included within the zipped 
file,
  a number is appended to the file name before the extension. Extesion is 
present
  is assumed, failing if not.

  Fix: don't assume file name has extension.
        src/org/openbravo/erpCommon/businessUtility/TabAttachments.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed issue 30291: reduced DAL memory footprint

  It has been accomplished by making internal and caching select strings in this
  manner it is possible to make much more intesive reuse of them.
        lib/runtime/hibernate3-patched.jar
        lib/runtime/hibernate3.jar

Changes for Build #130

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    Fixed issue 32728: Standard datasources should check entity access.
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Improve comments and notation Override.
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Improve legibility, copyright and a typo
        
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_REF_LIST.xml
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java
        src-test/src/org/openbravo/test/datasource/DataSourceWhereParameter.java
        
src-test/src/org/openbravo/test/security/ExplicitCrossOrganizationReference.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Merge with pi
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added a test case
        src-test/src/org/openbravo/test/datasource/TestInitializeAccess.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Fixed tests related to security projects
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
        src-test/src/org/openbravo/test/datasource/DataSourceWhereParameter.java
        
src-test/src/org/openbravo/test/security/ExplicitCrossOrganizationReference.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Revert default jdk version
        .settings/org.eclipse.jdt.core.prefs

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Merge with pi.
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Improve performance and small clean code.
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Removed unnecessary setAdminMode method
        
modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java
        
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
        src/org/openbravo/materialmgmt/ManageVariantsDS.java
        src/org/openbravo/materialmgmt/ProductCharacteristicsDS.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Merge with pi.
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Some code review improvements

Some code review improvements are fixed:
- Typo errors.
- Name conventions.
- Declare "OBSERDS_AllowUnsecuredDatasourceRequest" constant in CachedPreference
instead of BaseDataSourceService.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java
        
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
        src/org/openbravo/dal/security/EntityAccessChecker.java
        src/org/openbravo/materialmgmt/ManageVariantsDS.java
        src/org/openbravo/materialmgmt/ProductCharacteristicsDS.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] EntityAccessChecker performance improvements

  - Store in memory process ids, not the whole objects
  - Query for ids rather than whole object
  - Retrieve from a single query all required objects, do not do a query for
    each item
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Refactor and improve performance in 
addEntitiesFromProcess.
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Fixes role in TestComboDatasource.

Now are checked properly all entities access and for this
reason role that uses this test was wrong. It has been fixed
by using F&B International Group Admin role instead of
F&B España - Employee.
        src-test/src/org/openbravo/test/datasource/TestComboDatasource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Fixes Account tree and Stock Reservation fetch 
test.
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Merge with pi.
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Improve performance in initialize method

Performance in initialize method is improved. Besides some getter methods are 
added.
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Checking access to Process with new check method

In EntityAccessChecker a new check method is implemented. This new check method 
it
is used to check if a current user/role has access to a process.
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] The constant was wrongly removed in a merge.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Improve name method and comment
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Take into account ref windows in initialize method
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Merge with pi.
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Take into account process related with selectors
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Updated test case for trees and property selector
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Take into account tab for check access.
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] updated test case for 
SelectorFieldPropertyDataSource
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Merge with pi.
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added tests for some datasources.

It have been added some test cases:
- ComboTableDatasourceService
- CustomQuerySelectorDatasource
- QuickLaunchDataSource
- QuickCreateDataSource
- HQLDataSourceService
- ADTreeDatasourceService
- AccountTreeDatasourceService
- StockReservationPickAndEditDataSource
- QueryListDataSource
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added check fetch in StockReservationDataSource.
        
src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added check fetch in 
SelectorFieldPropertyDataSource.
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorFieldPropertyDataSource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added check fetch in HQLDataSourceService.
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Use checkReadableAccess method instead old one.
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added test case for Notes and ManageVariants.
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added check fetch in ProductCharacteristicsDS.
        src/org/openbravo/materialmgmt/ProductCharacteristicsDS.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added check fetch in ManageVariantsDS.
        src/org/openbravo/materialmgmt/ManageVariantsDS.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] added test case for Product Characteristics
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] added test case for manage variants ds
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Improve name method
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] added test case for Windows > Tab > Field > 
Property
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] no need to add name parameter to produce good test 
names
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] ds in test cases are now an enum, making better 
test names
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] added test case for alert data source
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] set proper organization in test cases
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added a test case related when a targetProperty is 
null
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Use preference properly in checkEdit...()
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Improve comment and java doc
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Refactor method name
        src/org/openbravo/base/model/ModelProvider.java
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added another case into parameterized test.
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess]Avoids null pointer exc related to null 
targetProperty
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added a new preference

Added OBSERDS_AllowUnsecuredDatasourceRequest preference to force security 
access by default. If this preference is set to 'Y' can be
use datasources without any security check.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java
        
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_REF_LIST.xml
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Merge with pi.
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Implement fetch check and edit check in tree ds
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Removed unnecesary methods and comments.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Fixes comment and status expected.
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess]Derived entities from process are other type of 
derived

It has been added new collection for entities derived from process. Besides it 
has
been added a small redactor.
        src/org/openbravo/base/model/ModelProvider.java
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Refactor and Improve performance

It has been improved performance in initialize method of entityAccessChecker. 
Besides
it has been refactored some code to avoid unnecessary if conditions and to 
catch a
forgotten case: a role without permissions.
        src/org/openbravo/base/model/ModelProvider.java
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [TestSecurityEntityAccess] Renamed test class
        src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
        src-test/src/org/openbravo/test/AllWebserviceTests.java
        src-test/src/org/openbravo/test/datasource/TestSecurityEntityAccess.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [DataSourceEntityAccess] Test is now parameterized:
  - Now it checks same datasources for roles with and without access
  - It does not use sys admin role but a new dummy empty one
        src-test/src/org/openbravo/test/datasource/TestSecurityEntityAccess.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Refactor for use new check methods in combos.
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added test cases.
        src-test/src/org/openbravo/test/datasource/TestSecurityEntityAccess.java
        src-test/src/org/openbravo/test/AllWebserviceTests.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Improve log when checking access
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Fixes test updating to a properly profile
        
src-test/src/org/openbravo/test/datasource/TestAllowUnpagedDatasourcePreference.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Merge with pi.
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Refactor fetch entity access check
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Take into account derived entities from process.
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Adding javadoc
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Remove testing code in fetch, add and remove 
methods
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Merge with pi.
      
    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Refactor NoteDataSource.
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceConstants.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added check in missing case: add().
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Remove testing code.
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Fixed test by adding two necessary parameters
        
src-test/src/org/openbravo/test/datasource/ProductSelectorDataSourceTest.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess]Removed unnecessary entity parameter from new 
methods
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
        
modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Removed unnecessary conditions
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Refactor for use new check methods.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
        
modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Refactor entity access check at 
BaseDataSourceService

Re-implement entity access check at BaseDataSourceService level. Now it have
been added 2 methods instead  of previous checker method: fetch and edit
(add, remove and update).
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added entity access check for specific datasources

It is used entity access check at specific datasources.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ADAlertDatasourceService.java
        
modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/NoteDataSource.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added entity access check for custom selectors

It is used entity access check at CustomQuerySelectorDatasource level to checks 
if
entity is derived.
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    [DataSourceEntityAccess] Added entity access check at BaseDataSourceService

Implement entity access check at BaseDataSourceService level. This mechanism
should be overwritable so specific cases (ie.  AlertDS, Notes…) can implement
their own security mechanisms.
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceService.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
        src/org/openbravo/dal/security/EntityAccessChecker.java




Last 20 lines of the console output:

[...truncated 4628 lines...]
Connected to:
Oracle Database 11g Release 11.2.0.1.0 - 64bit Production

SQL> SQL> 
 OBJECT_ID OBJECT_NAME                      OBJECT_TYPE
---------- -------------------------------- -------------------
  19109376 MA_PRODUCTION_COST               PROCEDURE
  19109377 MA_PRODUCTION_COST_GENERATE      PROCEDURE
  19109380 MA_WORKEFFORT_VALIDATE           PROCEDURE
  19109409 M_GENERATE_AVERAGE_COSTS         PROCEDURE
  19109410 M_GENERATE_STANDARD_COSTS        PROCEDURE

SQL> Disconnected from Oracle Database 11g Release 11.2.0.1.0 - 64bit Production
+ failure=1
+ exit 1
Build step 'Execute shell' marked build as failure
Checking console output
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any

------------------------------------------------------------------------------
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
_______________________________________________
Openbravo-builds mailing list
Openbravo-builds@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-builds