int-gui-pgsql - Build # 1591 - Fixed:

Check console output at https://ci.openbravo.com/job/int-gui-pgsql/1591/ to 
view the results.


Committers since last success:

Changes for Build #1590

    Alvaro Ferraz <[email protected]> null
    Fixes issue 32914: Fix properly issue 31457

Change getOrderedPaymentScheduleDetails method in AddPaymentActionHandler class 
to order by absolute value of FIN_PaymentScheduleDetail.PROPERTY_AMOUNT 
property.
Change also the manage negative amounts check to recalculate remainingAmount if 
it is lower than outstandingAmount in case remainingAmount is negative.
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java

Changes for Build #1591

    Carlos Aristu <[email protected]> null
    fixes issue 33015: Performance Improvements in Product Selector
      
    Carlos Aristu <[email protected]> null
    [pi-selector-performance] Improved comment
        
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java

    Carlos Aristu <[email protected]> null
    [pi-selector-performance] Code review improvements
        
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java

    Carlos Aristu <[email protected]> null
    [pi-selector-performance] Code improvements in ob-selector-item
        
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js

    Carlos Aristu <[email protected]> null
    [pi-selector-performance] Mechanism to detect if filter by id is supported
A new flag has been included in the request when opening the a selector in 
order to detect if filter by ID can be applied for default filtering. This is 
because SelectorDefaultFilterActionHandler is used by selectors in classic mode 
(OBSelectorWidget) also. This way, the changes done to filter by ID are 
transparent for this kind of selectors.
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorConstants.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java
        
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js

    Carlos Aristu <[email protected]> null
    [pi-selector-performance] Refactor M_PRODUCT_PRICE_WAREHOUSE_V view
The M_PRODUCT_PRICE_WAREHOUSE_V has been refactored, instead of joining it with 
M_PRODUCT_WAREHOUSE_QTYS_V the quantities (available, on hand, reserved and 
ordered) are calculated with subqueries for each row. This solution performs 
better in environments with big amount of records specially in M_STORAGE_DETAIL 
and M_STORAGE_PENDING tables.
        src-db/database/model/views/M_PRODUCT_PRICE_WAREHOUSE_V.xml

    Carlos Aristu <[email protected]> null
    [pi-selector-performance] Use inner join when possible
Due to performance reasons, entities joined for sorting the query should use an 
inner join instead of a left join when possible. This is because a left join 
sometimes prevent using indexes for sorting. This does not happen for inner 
joins.
Together with this views whose primary key is the result of a concatenation of 
several columns, should not use that primary key for predictable sorting, 
because it is not an indexable key. In this type of cases, the id of the 
referenced entity used as value field is used for predictable sorting.
        
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
        
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java

    Carlos Aristu <[email protected]> null
    [pi-selector-perform^Cce] Unneeded query performed when targetRecordId is 
null
 The targetRecordId parameter is used on the DefaultJsonDataService to compute 
a new startrow based on this paremeter value. If this parameter arrives with a 
null or empty value, the query to compute the new startrow must not be 
launched. Until now, this query was fired when targetRecordId parameter was 
received on the backend without considering its value. For example, this 
behavior could be reproduced after following these steps:
 1- Edit an existing sales order line in form view.
 2- Open the product selector pop-up.
 3- Remove the default filters.
        
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java

    Carlos Aristu <[email protected]> null
    [pi-selector-performance] Selected properties in selector drop-down requests
The requests performed by the drop-down of the selector now include just the 
needed properties:
1- The fields to be displayed on the pick list are requested using the 
SELECTED_PROPERTIES parameter.
2- The display field, value field and out fields are requested using the 
EXTRA_PROPERTIES parameter. This is because this parameter is always used on 
the requests as it is part of the selector template definition within the view.
        
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
        
modules/org.openbravo.service.datasource/web/org.openbravo.service.datasource/js/ob-datasource-utilities.js
        
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js

    Carlos Aristu <[email protected]> null
    [pi-selector-performance] Added filtering by ID for default selector filters
Now the SelectorDefaultFilterActionHandler builds the default filtering 
criteria in order to filter FK columns by ID. Together with this an issue is 
solved on the openSelectorWindow function of OBSelectorItem, because the scroll 
was being kept after reopening the selector pop-up, which caused a wrong 
request after the first pop-up opening.
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorConstants.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java
        
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js

    Atul Gaware <[email protected]> null
    Fixes issue 32709: Create link to Good Shipment in Create Invoice from 
Orders

Fully shipped lines linked with invoice lines not only in case of POS Order but 
in any case
        src-db/database/model/functions/C_INVOICE_CREATE.xml

    Asier Lostalé <[email protected]> null
    related to issue 32932: backed out unrelated changeset
        src-core/.settings/org.eclipse.jdt.core.prefs

    Asier Lostalé <[email protected]> null
    related to issue 32932: suppress warns in sqlc generated code
        src-core/.settings/org.eclipse.jdt.core.prefs
        src-core/src/org/openbravo/data/Sqlc.java

    Asier Lostalé <[email protected]> null
    related to issue 32932: supress warns in WAD generated code
        src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.javaxml
        src-wad/src/org/openbravo/wad/ActionButton_Responser.javaxml

    Asier Lostalé <[email protected]> null
    related to issue 32932: suppress warn for false positives
        src/org/openbravo/erpCommon/ad_actionButton/ProjectCopyFrom.java
        src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java

    Stefan Hühner <[email protected]> null
    related to issue 32932: fix up javadoc warnings
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentWindowComponent.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
        src/org/openbravo/base/secureApp/LoginHandler.java
        src/org/openbravo/base/secureApp/VariablesSecureApp.java
        src/org/openbravo/costing/StandardCostAdjustment.java
        src/org/openbravo/erpCommon/ad_forms/Fact.java
        src/org/openbravo/erpCommon/ad_process/AcctServerProcess.java
        src/org/openbravo/erpCommon/businessUtility/AccountTree.java
        src/org/openbravo/erpCommon/modules/ImportModule.java
        src/org/openbravo/erpCommon/modules/UninstallModule.java
        src/org/openbravo/erpCommon/utility/AntExecutor.java
        src/org/openbravo/erpCommon/utility/BasicUtility.java
        src/org/openbravo/erpCommon/utility/ComboTableData.java
        src/org/openbravo/erpCommon/utility/ModelSQLGeneration.java
        src/org/openbravo/erpCommon/utility/TableSQLData.java
        src/org/openbravo/erpCommon/utility/Utility.java
        src/org/openbravo/erpCommon/utility/WindowTree.java
        src/org/openbravo/erpCommon/utility/WindowTreeUtility.java
        src/org/openbravo/materialmgmt/ServicePriceUtils.java

    Stefan Hühner <[email protected]> null
    related to issue 32932: removed some other warnings
        
modules/org.openbravo.client.kernel/src-test/org/openbravo/client/kernel/freemarker/test/FreemarkerTemplateProcessorTest.java
        src-core/src/org/openbravo/utils/FileUtility.java
        src-test/src/org/openbravo/test/xml/XMLBaseTest.java
        src/org/openbravo/erpCommon/obps/ActivationKey.java
        src/org/openbravo/services/webservice/Module.java
        src/org/openbravo/services/webservice/Module1.java
        src/org/openbravo/services/webservice/Module2.java
        src/org/openbravo/services/webservice/ModuleDependency.java
        src/org/openbravo/services/webservice/ModuleInstallDetail.java
        src/org/openbravo/services/webservice/SimpleModule.java
        src/org/openbravo/services/webservice/SimpleModule1.java
        src/org/openbravo/services/webservice/SimpleModule2.java




Last 20 lines of the console output:

[...truncated 10573 lines...]
executing script 'Tomcat stop'
[int-gui-pgsql] $ /bin/bash /tmp/build_step_template7620669143684216336.sh 
ENABLE
DEBUG: Tomcat stop called with parameters: ENABLED=ENABLE
 * Stopping Tomcat servlet engine for Openbravo tomcat
   ...done.
 * Stopping web server apache2
 ... waiting .   ...done.

executing script 'Check log'
[int-gui-pgsql] $ /bin/bash /tmp/build_step_template7106276068181105011.sh 
ENABLE
DEBUG: Check log called with parameters: ENABLED=ENABLE
Check log: openbravo log (artifact: int-gui-pgsql.log) is clean

Recording test results
Archiving artifacts
Checking \] ERROR|\] WARN
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds

Reply via email to