int-dummy-pgsql - Build # 1629 - Fixed:

Check console output at https://ci.openbravo.com/job/int-dummy-pgsql/1629/ to 
view the results.


Committers since last success:

Changes for Build #1626

    Carlos Aristu <[email protected]> null
    fixes issue 34514: CachedPreference should implement Serializable
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java

    Carlos Aristu <[email protected]> null
    fixes issue 34499: CachedPreference feature does not support clustering

The CachedPreference was being used as a singleton which was keeping a set of 
preferences defined at System Level in a cache. Those values can be refreshed 
with the PreferenceEventHandler every time it detects a change. This mechanism 
was not valid for clustered environments because changes were being detected 
just on the node (JVM) where the event handler was executed.

To fix this problem we have modified the scope of the class from application to 
session. Thus, the cache will be initialized on every new session created on 
each node of the cluster.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java

Changes for Build #1627

    Asier LostalĂ© <[email protected]> null
    fixed issue 34518: [clustering] different nodes detected as clones

  When working in a clustered environment, sys admin logins in different
  nodes where detected as cloned instances.

  MAC identifier is used as part of clone identifier, in case of clustering
  different nodes can have different MAC ids, so they were always detected
  as clones.

  Added a new "cluster" property, when it is set MAC address is not computed
  beacause it was not relevant in this situation.
        src/org/openbravo/erpCommon/utility/SystemInfo.java

    Carlos Aristu <[email protected]> null
    related to issue 34514: Prevent Null Pointer Exception
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java

    Carlos Aristu <[email protected]> null
    related to issue 34514: declare cachedPreference map as transient

By marking cachedPreference as transient we are preventing it to be transferred 
through the network as it will be lost intentionally when serialization 
converts the object state to serial bytes
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java

Changes for Build #1628

    Asier LostalĂ© <[email protected]> null
    fixed issue 34534: StatementFinalizer causes some overhead on each statement

  StatementFinalizer caused overhead both in terms of memory (by keeping a list
  of statements in the current transaction) and time (by trying to close again
  those statements).

  This finalizer is no longer used, as the potential benefit is small compared
  with its price.
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Naroa Iriarte <[email protected]> null
    Fixed issue 34469: The manage variants record selection was not working 
fine.

When a record was selected and after that another action was done, the record 
which must remain selected, was not.
The problem was in the "ManageVariantsDS". There was a property which was not 
being set. In the client there is a place where it is searching the selected 
records by a "findByKey" method. This method was searching the property 
"primaryKeys" and it needs to have the id set. In this case, as it was not set, 
it was not returning anything and it was not being able to find the selected 
record. That was causing the problem of the unselected record.
The fix consists on implementing the "getDataSourceProperties" method and there 
set the needed properties of the datasource.
        src/org/openbravo/materialmgmt/ManageVariantsDS.java

    David Miguelez <[email protected]> null
    Fixes Issue 34509. Removes warning by changing parameter name.
        src/org/openbravo/dal/security/OrganizationStructureProvider.java

    Naroa Iriarte <[email protected]> null
    Fixed issue 34405: The Manage Variants filter was not working fine.

If the filter was used, after that a record was selected and after that the 
filter was cleaned up, the "no items to show" message was shown instead of 
showing all the records.
The problem was that the "ManageVariantsDS" manual datasource was not capable 
of managing the criteria: "criteria:{"fieldName":"id","operator":"notNull"}" 
which is the criteria that must return every record.
The problem was in this code line: "value = criteria.getString("value")"  
because the creiteria has not value, it only has fieldName and operator. It was 
throwing an exception which was not being correctly handled in the catch. This 
problem has been solved also, by properly handling the exception by showing log.
The first problem has been solved by processing the concrete criteria properly. 
If this criteria is found, it means that every record must be shown, so it 
continues with doing nothing.
There was a another problem that has been solved and it is that the searchKey 
and the nameFilters were acting as a "Contains" filter instead of like as an 
"iContains".
This has been fixed by changing the "contains" method of StringUtils by the 
"containsIgnoreCase".
        src/org/openbravo/materialmgmt/ManageVariantsDS.java

Changes for Build #1629

    Nono Carballo <[email protected]> null
    Fixes issue 34410: GL item in Open Items section is set read only

If Simple G/L Journal is multi general ledger, the G/L Item in Open Item section
is set read only and it's value is set to G/L Item in the line, this value is
updated when G/L Item value in the line changes.

The display logic of G/L Item in Open Item section takes into account if Multi
General Ledger is set in header. A new callout was made to kep updated it's 
value
when Account values in line changes.
        src-db/database/sourcedata/AD_COLUMN.xml
        src/org/openbravo/erpCommon/ad_callouts/SL_Journal_MultiAcctSchema.java

    Carlos Aristu <[email protected]> null
    related to issue 34499: updated comment
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java

    Carlos Aristu <[email protected]> null
    related to issue 34499: removed PreferenceEventHandler class

PreferenceEventHandler class was being used to detect changes on the preference 
values cached by the CachedPreference class. As CachedPreference now declared 
the @SessionScoped is no longer a singleton therefore the cached values will 
persist along the life cycle of a session.

As preferences are refreshed with every new session this handler is no longer 
required. Besides, the injection of the @SessionScoped bean in this handler was 
causing WELD-001303 error.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/PreferenceEventHandler.java




Last 20 lines of the console output:

[...truncated 3390 lines...]
Total time: 3 seconds

executing script 'Tomcat stop'
[int-dummy-pgsql] $ /bin/bash /tmp/build_step_template84454586755828358.sh 
ENABLE
DEBUG: Tomcat stop called with parameters: ENABLED=ENABLE
 * Stopping Tomcat servlet engine for Openbravo tomcat
   ...done.

executing script 'Check openbravo log'
[int-dummy-pgsql] $ /bin/bash /tmp/build_step_template8265699521090965076.sh 
ENABLE
DEBUG: Check openbravo log called with parameters: ENABLED=ENABLE
Check log: openbravo log (artifact: int-dummy-pgsql.log) is clean

Recording test results
Archiving artifacts
Checking \] ERROR|\] WARN
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds

Reply via email to