int-basic-oracle - Build # 1685 - Fixed:
Check console output at https://ci.openbravo.com/job/int-basic-oracle/1685/ to
view the results.
Committers since last success:
Changes for Build #1684
David Miguelez <[email protected]> null
[UOM Management] Fixes non desired API Changes.
Instead of removing column and field edit the existing ones.
Remove check in table.
src-db/database/model/tables/C_ORDERLINE.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_FIELD.xml
Carlos Aristu <[email protected]> null
related to issue 33997: updated dbsourcemanager library
src-db/database/lib/dbsourcemanager.jar
David Miguelez <[email protected]> null
[UOM Management] Merge with pi.
David Miguelez <[email protected]> null
[UOM Management] Merge with pi.
David Miguelez <[email protected]> null
[UOM Management] export text interfaces.
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
Mark <[email protected]> null
[UOM Management] Fixed issue in Return Material Receip - Pick and Edit
Fixed the M_RM_RECEIPT_PICK_EDIT view to use the correct AUMQTY and RETURNED
AUM.
src-db/database/model/views/M_RM_RECEIPT_PICK_EDIT.xml
Nono Carballo <[email protected]> null
[UOM Management] Call to flush is not necessary and provoke an hibernate
exception
src/org/openbravo/event/MInOutLineEventHandler.java
Nono Carballo <[email protected]> null
[UOM Management] Avoid null pointer exception when preference is defined
with
empty value
src/org/openbravo/materialmgmt/UOMUtil.java
David Miguelez <[email protected]> null
[UOM Management] Fixes problem that did not allow to work
with financial Invoices.
If a Sales/Purchase Invoice Line is checked as a Financial Invoice,
it uses base Qty and UOM fields instead of AUM and AUMQty.
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_FIELD.xml
David Miguelez <[email protected]> null
[UOM Management] Prevents npe when not using AUM in create Purchase Order
from previous Order.
src/org/openbravo/common/actionhandler/OrderCreatePOLines.java
David Miguelez <[email protected]> null
[UOM Management] Fixes jscheck in javascript file.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/procurement/ob-procurement.js
David Miguelez <[email protected]> null
[UOM Management] Fixes AUMQuantity in parcial documents for
Create from Shipments/Invoices documents.
The already shipped/invoiced quantity was not being taken into account.
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
Nono Carballo <[email protected]> null
[UOM Management] Code Improvements
* Query for duplicate primary AUM for sales, purchase and logistics only if
processed
object has set primary in corresponding fields
* Use of field names defined in entity class in queries
src/org/openbravo/event/ProductAumEventHandler.java
David Miguelez <[email protected]> null
[UOM Management] Fix issue when voiding a Shipment.
Not it calculates the amount with the proper sign.
src-db/database/model/functions/M_INOUT_POST.xml
David Miguelez <[email protected]> null
[UOM Management] Fixes Issue: AUMQty not properly calculated.
Was storing previous value, now it recalculates it every time.
src-db/database/model/functions/M_INOUT_CREATE.xml
David Miguelez <[email protected]> null
[UOM Management] Merge with pi 30-nov-2015
Nono Carballo <[email protected]> null
[UOM Management] Fixes criteria for retrieving duplicate AUM
src/org/openbravo/event/ProductAumEventHandler.java
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Code Review ob-return-material.js
- OB.PropertyStore.get('UomManagement') === 'Y' is call just one time and
outside the loop
- Checked if record.returned is null in var declaration
- Checked it's a number before creating the BigDecimal
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/return-material/ob-return-material.js
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Code Review RMInOutPickEditLines.java
- Preference is retrieved outside the for loop
- Used Adminmode
- Updated copyright
src/org/openbravo/common/actionhandler/RMInOutPickEditLines.java
Nono Carballo <[email protected]> null
[UOM Management] Code Improvements
* Use OBMessageUtils
* Use isEmpty() to check if lists contains elements
src/org/openbravo/event/ProductAumEventHandler.java
Nono Carballo <[email protected]> null
[UOM Management] Code review RMShipmentPickEditLines.java
* Preference is retrieved outside the for loop
* If preference is set, logic is run under admin mode
src/org/openbravo/common/actionhandler/RMShipmentPickEditLines.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review CreateFrom_Shipment_data.xsql
* Fixed SQL sentence in hasSecondaryUOM method
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
Nono Carballo <[email protected]> null
[UOM Management] Code Review SRMOPickEditLines.java
* Retrieving preference ouside the for loop
src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review
* Updated copyright year
* Changing COALESCE(TABLE.FIELD,'0') = '0' to TABLE.FIELD IS NUL
* Indentation fixed
src/org/openbravo/erpCommon/ad_reports/InoutEdition_data.xsql
src/org/openbravo/erpCommon/ad_reports/OrderEdition_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscount_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportInvoices_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportPurchaseOrder.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderInvoiced_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvided_data.xsql
Nono Carballo <[email protected]> null
[UOM Management] Code Review ProductAumEventHandler.java
Added queries to check for duplicates instead of doing it in a for loop.
src/org/openbravo/event/ProductAumEventHandler.java
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Revert Code review MaterialReceiptPending_data.xsql
This change was reverted because when AUMQTY is not null, the SUM is the
M_MATCHPO.QTY converted to the default AUM.
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
David Miguelez <[email protected]> null
[UOM Management] Fixes problem in Oracle in function.
It is necessary to catch exception when no data found.
src-db/database/model/functions/M_GET_DEFAULT_AUM_FOR_DOCUMENT.xml
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Code review MaterialReceiptPending_data.xsql
Changed the way to recover the AUMQTY value
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
Nono Carballo <[email protected]> null
[UOM Management] Fixed issue "Returned UOM change in new lines"
The returned UOM is always the base UOM or the default UOM for the current flow
src/org/openbravo/common/datasource/ReturnToFromCustomerVendorHQLTransformer.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review SL_InOutLine_Product.java
Retrieving ShipmentInOut in admin mode
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review CreateFrom_Shipment_data.xsql
Query hasSecondaryUOM has refactored to use select ... where exists clause, in
order to improve performance
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
Nono Carballo <[email protected]> null
[UOM Management] Code Review OperativeQuantity_To_BaseQuantity.java
Executing callout logic in admin mode
src/org/openbravo/erpCommon/ad_callouts/OperativeQuantity_To_BaseQuantity.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review CreateFrom.java
* Added default value 'none' to aumvisible in sql sentences
* The for loop is only run if the preference is enabled
* The if sentence enclosing logic for computing aumqty and aum was refactored
* Exception messages are logged
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
Nono Carballo <[email protected]> null
[UOM Management] Code Review CopyFromPOOrder.java
* The method isUomManagementEnabled is called before the for loop
* The if sentence enclosing logic for computing aumqty, aum and qtyordered was
refactored
src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review CopyFromOrder.java
The method isUomManagementEnabled() is called before the for loop
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.java
David Miguelez <[email protected]> null
[UOM Management] Merge with pi 28-nov-2015
David Miguelez <[email protected]> null
[UOM Management] Fixes in DB Functions to make them work in Oracle.
src-db/database/model/functions/M_EXPLODEBOMNOTSTOCK.xml
src-db/database/model/functions/M_INOUTEXPLODEBOMNOTSTOCK.xml
src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
David Miguelez <[email protected]> null
[UOM Management] Remove unnecessary commit due to SonarLint.
.project
src-core/.project
src-trl/.project
src-wad/.project
David Miguelez <[email protected]> null
[UOM Management] Code Review OBContext.setAdminMode()
There should be always a try-finally with a OBContext.retorePreviousMode()
src/org/openbravo/erpCommon/ad_callouts/AUM_ConversionRate.java
David Miguelez <[email protected]> null
[UOM Management] Code Review OBContext.setAdminMode()
There should be always a try-finally with a OBContext.retorePreviousMode()
src/org/openbravo/materialmgmt/UOMUtil.java
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Fixed Create Lines From Goods Shipment not modified
This pop up has been updated to support the new fileds Aum y AumQty
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment.html
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment.xml
Nono Carballo <[email protected]> null
[UOM Management] Code Review CopyFromInvoice.java
* isUomManagementEnable method is called before for loop
* Improved if sentence to compute aumqty and qtyinvoiced
src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
Mark <[email protected]> null
[UOM Management] Code review M_INOUTLINE_TRG
Added the validation for "CannotUseAUMandSecondUOM", as done in
C_ORDLINE_CHK_RESTRICTIONS_TRG,
M_REQUISITIONLINE_TRG and C_INVLINE_CHK_RESTRICTIONS_TRG
src-db/database/model/triggers/M_INOUTLINE_TRG.xml
Mark <[email protected]> null
[UOM Management] Code review M_REQUISITION_CREATEPO
It includes:
-Removed unused v_UomManagement_Pref variable.
-Changed some variable types.
-Removed unnecessary first query to ad_preference table
src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
Mark <[email protected]> null
[UOM Management] Code review M_INOUT_CREATE. Fixed indentation and var types
src-db/database/model/functions/M_INOUT_CREATE.xml
Mark <[email protected]> null
[UOM Management] Code review M_EXPLODEBOMNOTSTOCK
Several changes in M_EXPLODEBOMNOTSTOCK.xml. Includes:
-Updated copyright year
-Change some vars type to Use %TYPE instead of varchar
-Removed unnecessary first query to ad_preference table
-Moved the calculation of the preference from inside the loop. It's going to be
always the same value (per instance)
src-db/database/model/functions/M_EXPLODEBOMNOTSTOCK.xml
Mark <[email protected]> null
[UOM Management] Code review M_INOUTEXPLODEBOMNOTSTOCK
Several changes in M_EXPLODEBOMNOTSTOCK.xml. Includes:
-Change some vars type to Use %TYPE instead of varchar
-Removed unnecessary first query to ad_preference table
-Moved the calculation of the preference from inside the loop. It's going to be
always the same value (per instance)
src-db/database/model/functions/M_INOUTEXPLODEBOMNOTSTOCK.xml
Nono Carballo <[email protected]> null
Merge changes in AD_Field and CreateFrom.java
Nono Carballo <[email protected]> null
[UOM Management] Fixes issue Return From Customer - Pick/Edit Lines - Error
- ReturnedUOM empty
Added returnedUOM to select clause in HQL Query
Updated the labels of columns.
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_TABLE.xml
Mark <[email protected]> null
[UOM Management] Related to Issues on Purchase Order - Copy Lines process
When the row is selected the first time that quantity aum is changed the
ONCHANGE
event is not fired (because the AUM combo is filled with the default AUM) and
due that quantity ordered was calculated with the incorrect AUM, in this case
the
BUM. Was changed the CreateLinesOnChangeQuantityAum method to use the correct
AUM.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/procurement/ob-procurement.js
Mark <[email protected]> null
[UOM Management] Fixed Issues on Purchase Order - Copy Lines process
Removed the onchange binding to the Odered Quantity column as it is not needed.
Adapted the ob-procurement to calculate the correct Ordered Quantity when AUM or
AUM Qty changes in the UI.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/procurement/ob-procurement.js
src-db/database/sourcedata/AD_FIELD.xml
Nono Carballo <[email protected]> null
[UOM Management] Ordered Quantity is set read only in Create Order Lines
window
if preference is active
src-db/database/sourcedata/AD_COLUMN.xml
Nono Carballo <[email protected]> null
[UOM Management] Restoring from admin mode if product or uom are null
src/org/openbravo/materialmgmt/UOMUtil.java
Nono Carballo <[email protected]> null
[UOM Management] Updated M_CREATEPOLINES_PE_V view to return default AUM of
the
product instead of base UOM
src-db/database/model/views/M_CREATEPOLINES_PE_V.xml
Nono Carballo <[email protected]> null
[UOM Management] Avoiding exception when movement quantity has not been set
in
line.
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Fixed AUM and AumQty fields are not editable in Purchase
Order
- Create Lines.
src-db/database/sourcedata/AD_FIELD.xml
Mark <[email protected]> null
[UOM Management] Code Review: Related to the ob-procurement.js file
Fixed some parameters names when the GetConvertedQtyActionHandler action handler
is called.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/procurement/ob-procurement.js
Nono Carballo <[email protected]> null
[UOM Management] Fixed how movement quantity is computed in goods receipt
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
Rafael Queralta Pozo <[email protected]> null
[UOM Management] UomManagement preference in lines of Return from Customer,
Return to Vendor, Return to Vendor Shipment and Return Material Receipt
windows for display logics is evaluated on server side.
src-db/database/sourcedata/AD_FIELD.xml
David Miguelez <[email protected]> null
[UOM Management] Fixes Issue in Return Material.
The Returned AUM was not set for a previously selected record.
src/org/openbravo/common/datasource/ReturnToFromCustomerVendorHQLTransformer.java
David Miguelez <[email protected]> null
[UOM Management] Synchronize Terminology.
.project
src-core/.project
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
src-trl/.project
src-wad/.project
David Miguelez <[email protected]> null
[UOM Management] Rearrange Fields in Return Material Flow.
src-db/database/sourcedata/AD_FIELD.xml
David Miguelez <[email protected]> null
[UOM Management] Fixes problems in views in Postgres.
src-db/database/model/views/M_RM_RECEIPT_PICK_EDIT.xml
src-db/database/model/views/M_RM_SHIPMENT_PICK_EDIT.xml
David Miguelez <[email protected]> null
[UOM Management] Reverts change while fixing issue in CreateFrom
to fix pop ups. In this case is better to do the conversion in this
direction.
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
David Miguelez <[email protected]> null
[UOM Management] Fixes problems in Return Material Flow.
AumQuantity should be stored as a negative value in the Database
and converted into a positive one while it is shown in the Field.
src-db/database/model/views/M_RM_RECEIPT_PICK_EDIT.xml
src-db/database/model/views/M_RM_SHIPMENT_PICK_EDIT.xml
src-db/database/sourcedata/AD_FIELD.xml
src/org/openbravo/common/actionhandler/RMInOutPickEditLines.java
src/org/openbravo/common/actionhandler/RMShipmentPickEditLines.java
src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
src/org/openbravo/common/datasource/ReturnToFromCustomerVendorHQLTransformer.java
David Miguelez <[email protected]> null
[UOM Management] Fixes Issues in Purchase Order Report.
src/org/openbravo/erpCommon/ad_reports/ReportPurchaseOrder.jrxml
David Miguelez <[email protected]> null
[UOM Management] Fixes issues in Oracle in C_INVOICE_CREATE
src-db/database/model/functions/C_INVOICE_CREATE.xml
David Miguelez <[email protected]> null
[Uom Management] Rearragend some fields.
src-db/database/sourcedata/AD_FIELD.xml
Nono Carballo <[email protected]> null
Merge back to uommanagement2
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Added again changeset "Rearrange C_AUM and AUMQTY field in
grid view in Sales and Purchase Order, Sales
and Purchase Invoice, Goods Receipt and Shipment windows"
src-db/database/sourcedata/AD_FIELD.xml
Nono Carballo <[email protected]> null
[UOM Management] Code Review C_INVOICE_CREATE
* Changed variable types
* Fixed identation
* Enclosed call to AD_GET_PREFERENCE_VALUE in a BEGIN-EXCEPTION block
* Fixed position of v_aum_qty, v_default_aum in INSERT sentences
* Used constants
src-db/database/model/functions/C_INVOICE_CREATE.xml
David Miguelez <[email protected]> null
[UOM Management] Fixes problems in Create From PopUps.
* Fixes AUM was not shown by changing get_default_aum method
* Fixes wrong conversion, now if there is no aumqty, the base qty
remains the same and the aumqty is converted properly
* Formatting issues.
src-db/database/model/functions/M_GET_DEFAULT_AUM_FOR_DOCUMENT.xml
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
David Miguelez <[email protected]> null
[UOM Management] Fix problems with possible null values in UOMUtil.
Plus some formatting fixes.
src/org/openbravo/materialmgmt/UOMUtil.java
Mark <[email protected]> null
[UOM Management] Code Review: Removed unused CreateLinesFromPOConvertAUM
handler
CreateLinesFromPOConvertAUM Action handler was only used in the
ob-procurement.js
file. As it was adapted to use GetConvertedQtyActionHandler instead of it, it is
not necessary anymore.
src/org/openbravo/common/actionhandler/CreateLinesFromPOConvertAUM.java
Mark <[email protected]> null
[UOM Management] Code Review: Related to the ob-procurement.js file
As org.openbravo.common.actionhandler.GetConvertedQtyActionHandler exists and is
used to execute a similar logic than CreateLinesFromPOConvertAUM, it is used to
make homogeneous and centralized the automatic calculation of quantities from
AUM/BUM to BUM/AUM.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/procurement/ob-procurement.js
Nono Carballo <[email protected]> null
[UOM Management] Fixed selection of secondary Uom
A new method selectUOM was created in UOMUtil and invoked from CreateFrom.java
to get the secondary uom of the line product.
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/materialmgmt/UOMUtil.java
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Issue Pending Goods Receipt - Process - Error while
processing, not AUM found
In Java, in MaterialReceiptPending.java, in line 459 String defaultAum =
vars.getStringParameter(""inpcAUMId"" + strOrderlineId);
nothing is retrieved because inpAUMId was read only in form. Now is editable.
Also others bug was found and fixed in CopyFromOrder.html and
CreateFrom_ShipmentPO.html
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.html
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.html
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.html
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
Mark <[email protected]> null
[UOM Management] Code Review: Changes to the M_COPY_PRODUCT_TEMPLATE
It includes:
- Used %TYPE instead of varchar in some variables declarations
- If the default AUM is dfferent than BUM the aumQty is recalculated using the
defined conversion rate between the units of measure. In other case the
aumQty will be the QTY.
src-db/database/model/functions/M_COPY_PRODUCT_TEMPLATE.xml
Mark <[email protected]> null
[UOM Management] Code Review: Changes to the C_ORDER_POST1
It includes:
- Used alias table for C_AUM column.
- Fixed some incorrect indentations.
src-db/database/model/functions/C_ORDER_POST1.xml
Mark <[email protected]> null
[UOM Management] Code Review: Refactoring to the ob-procurement.js file
It includes:
- Checking quantities are number before creating the BigDecimal.
- Removed grid.getRecordIndex(item.record)).aum === undefined condition as it
is not needed.
- Removed casting to Number when setting value to cells because it is
redundant
- To make more consistent with other implementations similar to it, the
reverse
parameter takes values: true/false instead of 'Y'/'N'. Because of it
CreateLinesFromPOConvertAUM action handler was adapted to get this parameter
as Boolean instead of a String.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/procurement/ob-procurement.js
src/org/openbravo/common/actionhandler/CreateLinesFromPOConvertAUM.java
Nono Carballo <[email protected]> null
[UOM Management] Fixed UOMUtil.java
selectAUM and selectDefaultAUM return a FieldProvider array with empty values
when product or document type are null or empty.
src/org/openbravo/materialmgmt/UOMUtil.java
David Miguelez <[email protected]> null
[UOM Management] Export database after merge.
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
David Miguelez <[email protected]> null
[UOM Management] Merge with pi - 22.11.16
David Miguelez <[email protected]> null
[UOM Management] Fixes Queries in HQL Transformer due to problems in
hibernate while translating the expression into SQL code for Oracle.
src/org/openbravo/common/datasource/ReturnToFromCustomerVendorHQLTransformer.java
Nono Carballo <[email protected]> null
[UOM Management] Updated OperativeQuantity_To_BaseQuantity.java
src/org/openbravo/erpCommon/ad_callouts/OperativeQuantity_To_BaseQuantity.java
Mark <[email protected]> null
[UOM Management] Code Review: Changes to M_GET_DEFAULT_AUM_FOR_DOCUMENT
function
It includes:
-Added a comment describing the usage of this function
-Removed the use of a cursor. Rewrited a equivalent code in a simple SQL query.
-Use the IsSOTrx flag to diferentiate purchases and sales documents
If not record is found with sales=P or purchase=P, is reurned the BUM of the
product as the default AUM.
src-db/database/model/functions/M_GET_DEFAULT_AUM_FOR_DOCUMENT.xml
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Replace CentralBroker by UOMUtil class into reports
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerJR.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscountJR.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportInvoicesEditJR.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportPurchaseOrder.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderInvoicedJasper.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderJR.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportShipmentEdition.jrxml
Rafael Queralta Pozo <[email protected]> null
[UOM Management] Fix issue No correct AUM in Delivered Sales Order Report
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvidedJR.jrxml
Nono Carballo <[email protected]> null
[UOM Management] Code Review OperativeQuantity_To_BaseQuantity.java
src/org/openbravo/erpCommon/ad_callouts/OperativeQuantity_To_BaseQuantity.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review GtinFormat.java
src/org/openbravo/erpCommon/ad_callouts/GtinFormat.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review AUM_ConversionRate.java
src/org/openbravo/erpCommon/ad_callouts/AUM_ConversionRate.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review GetConvertedQtyActionHandler.java
src/org/openbravo/common/actionhandler/GetConvertedQtyActionHandler.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review CreateLinesFromPOConvertAUM.java
src/org/openbravo/common/actionhandler/CreateLinesFromPOConvertAUM.java
Mark <[email protected]> null
[UOM Management] Code Review: Changes to M_GET_CONVERTED_QTY function
It includes:
-Added a comment describing the usage of this function
-Removed unnecessary check IS NOT NULL of C_uom.stdprecision because it is a
mandatory column.
src-db/database/model/functions/M_GET_CONVERTED_QTY.xml
Mark <[email protected]> null
[UOM Management] Code Review: Changes to M_GET_CONVERTED_AUMQTY function
It includes:
-Added a comment describing the usage of this function
-As conversion rate between BUM and AUM can be 0, or even a negative value,
Was necessary to add a check contraint to force it to be > 0
-Removed unnecessary check IS NOT NULL of C_uom.stdprecision because it is a
mandatory column.
src-db/database/model/functions/M_GET_CONVERTED_AUMQTY.xml
src-db/database/model/tables/C_CONVERSION_RATE.xml
Nono Carballo <[email protected]> null
[UOM Management] Added unique constraint to M_PRODUCT_AUM table
src-db/database/model/tables/M_PRODUCT_AUM.xml
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
Nono Carballo <[email protected]> null
[UOM Management] Updated CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
Mark <[email protected]> null
[UOM Management] Added parenthesis to C_UOM Validation to make more legible
Set parenthesis so the query is easier to read
src-db/database/sourcedata/AD_VAL_RULE.xml
Mark <[email protected]> null
[UOM Management] Updated help & description to elements, columns and fields
Reviewed existing description and help of several AD_COLUMN, AD_ELEMENT and
AD_FIELD.
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
Nono Carballo <[email protected]> null
[UOM Management] Code Review CopyFromOrder_data.xsql,
CreateFrom_Shipment_data.xsql
and MaterialReceiptPending_data.xsql
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.java
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder_data.xsql
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
src/org/openbravo/materialmgmt/UOMUtil.java
Nono Carballo <[email protected]> null
[UOM Management] Updated UOMUtil and ProductAumEventHandler
Added new methods to UOMUtils to get a FieldProvider array containing the
default
and availables Aum for a product in a given flow.
Improved validation in ProductAumEventHandler.
src/org/openbravo/event/ProductAumEventHandler.java
src/org/openbravo/materialmgmt/UOMUtil.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review SL_RequisitionLine_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_RequisitionLine_Product.java
src/org/openbravo/materialmgmt/UOMUtil.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review SL_Order_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review SL_Invoice_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
Nono Carballo <[email protected]> null
[UOM Management] Code Review CentralBroker.java
src/org/openbravo/materialmgmt/UOMUtil.java
modules/org.openbravo.reports.ordersawaitingdelivery/src/org/openbravo/reports/ordersawaitingdelivery/erpCommon/ad_reports/ReportOrderNotShipped.java
src-test/src/org/openbravo/test/centralbroker/CentralBrokerTest.java
src/org/openbravo/common/actionhandler/CreateLinesFromPOConvertAUM.java
src/org/openbravo/common/actionhandler/GetConvertedQtyActionHandler.java
src/org/openbravo/common/actionhandler/RMInOutPickEditLines.java
src/org/openbravo/common/actionhandler/RMShipmentPickEditLines.java
src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
src/org/openbravo/common/datasource/ReturnToFromCustomerVendorHQLTransformer.java
src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.java
src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_callouts/OperativeQuantity_To_BaseQuantity.java
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_RequisitionLine_Product.java
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java
src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
src/org/openbravo/materialmgmt/CentralBroker.java
Rafael Queralta Pozo <[email protected]> null
Rearrange C_AUM and AUMQTY field in grid view in Sales and Purchase Order,
Sales
and Purchase Invoice, Goods Receipt and Shipment windows
src-db/database/sourcedata/AD_FIELD.xml
Rafael Queralta Pozo <[email protected]> null
[UOM Management] UomManagement preference in lines of Manage Requisiton
window
for display logics is evaluated on server side. Rearrange C_AUM and AUMQTY field
in grid view.
src-db/database/sourcedata/AD_FIELD.xml
Nono Carballo <[email protected]> null
[UOM Management] Fixes issue Mutant table operations in M_PRODUCT_AUM_TRG
A new EntityPersistenceEventObserver was created to check duplicity of Aum for
the product, as well as it's availability (Primary/Secondary) for the differents
flows.
src/org/openbravo/event/ProductAumEventHandler.java
Mark <[email protected]> null
[UOM Management] Fixes issue Copy Lines does not allow to select BUM
Added the BUM of the product to the list of the generated list of AUMs
when the process is executed.
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder_data.xsql
Rafael Queralta Pozo <[email protected]> null
[UOM Management] UomManagement preference in lines of Goods Receipt and
Goods Shipment windows for display logics is evaluated on server side. Rearrange
C_AUM and AUMQTY field in grid view.
src-db/database/sourcedata/AD_FIELD.xml
David Miguelez <[email protected]> null
[UOM Management] Remove warnings.
src-test/src/org/openbravo/test/AllAntTaskTests.java
src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.java
src/org/openbravo/erpCommon/ad_callouts/AUM_ConversionRate.java
src/org/openbravo/erpCommon/ad_callouts/GtinFormat.java
src/org/openbravo/erpCommon/ad_callouts/OperativeQuantity_To_BaseQuantity.java
David Miguelez <[email protected]> null
[UOM Management] Modified trigger due to table mutation problem.
Removed logic will be placed in an EventObserver instead.
src-db/database/model/triggers/M_PRODUCT_AUM_TRG.xml
Nono Carballo <[email protected]> null
[UOM Management] UomManagement preference is retieved in Central Broker as a
System preference
src/org/openbravo/materialmgmt/CentralBroker.java
Nono Carballo <[email protected]> null
[UOM Management] UomManagement preference in lines of Sales and Purchase
invoice
windows for display logics is evaluated on server side.
src-db/database/sourcedata/AD_FIELD.xml
Mark <[email protected]> null
[UOM Management] Adapted Report Order Not Shipped to use new UOM Management
functionality.
modules/org.openbravo.reports.ordersawaitingdelivery/src/org/openbravo/reports/ordersawaitingdelivery/erpCommon/ad_reports/ReportOrderNotShipped.html
modules/org.openbravo.reports.ordersawaitingdelivery/src/org/openbravo/reports/ordersawaitingdelivery/erpCommon/ad_reports/ReportOrderNotShipped.java
modules/org.openbravo.reports.ordersawaitingdelivery/src/org/openbravo/reports/ordersawaitingdelivery/erpCommon/ad_reports/ReportOrderNotShipped.jrxml
modules/org.openbravo.reports.ordersawaitingdelivery/src/org/openbravo/reports/ordersawaitingdelivery/erpCommon/ad_reports/ReportOrderNotShipped.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src/org/openbravo/reports/ordersawaitingdelivery/erpCommon/ad_reports/ReportOrderNotShipped_data.xsql
src-db/database/model/functions/C_INVOICE_CREATE.xml
Mark <[email protected]> null
[UOM Management] Adapted Requisition To Order workflow to use new UOM
Management
functionality.
src-db/database/model/tables/C_ORDERLINE.xml
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.html
src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.java
src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder.xml
src/org/openbravo/erpCommon/ad_forms/RequisitionToOrder_data.xsql
Nono Carballo <[email protected]> null
[UOM Management] UomManagement preference in lines of Sales and Purchase
windows
for display logics is evaluated on server side.
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
David Miguelez <[email protected]> null
[UOM Management] Fixes problems in SQL expression in Validation Rule
while using Oracle.
src-db/database/sourcedata/AD_VAL_RULE.xml
David Miguelez <[email protected]> null
[UOM Management] Fixed several Issues in Reports in Oracle.
In Oracle is not possible to group records by Alias.
Changed '' for NULL due to Oracle Issues.
src/org/openbravo/erpCommon/ad_reports/InoutEdition_data.xsql
src/org/openbravo/erpCommon/ad_reports/InvoiceCustomerEdition_data.xsql
src/org/openbravo/erpCommon/ad_reports/OrderEdition_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscount_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportInvoices_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderInvoiced_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvided_data.xsql
David Miguelez <[email protected]> null
[UOM Management] Test cases in JUnit to test new UOM Management
functionality.
src-test/src/org/openbravo/test/centralbroker/CentralBrokerTest.java
src-test/src/org/openbravo/test/AllAntTaskTests.java
src-test/src/org/openbravo/test/AllQuickAntTaskTests.java
src-test/src/org/openbravo/test/AllTests.java
David Miguelez <[email protected]> null
[UOM Management] Adapted reports from Sales and Purchase flows
to include new UOM Management functionality
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
src/org/openbravo/erpCommon/ad_reports/InoutEdition_data.xsql
src/org/openbravo/erpCommon/ad_reports/InvoiceCustomerEdition_data.xsql
src/org/openbravo/erpCommon/ad_reports/OrderEdition_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerJR.java
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerJR.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscountJR.java
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscountJR.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscount_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportInvoicesEditJR.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportInvoicesJR.java
src/org/openbravo/erpCommon/ad_reports/ReportInvoices_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportPurchaseOrder.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderInvoicedJasper.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderInvoiced_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderJR.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvidedJR.jrxml
src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvided_data.xsql
src/org/openbravo/erpCommon/ad_reports/ReportShipmentEdition.jrxml
David Miguelez <[email protected]> null
[UOM Management] Return Material Flow
Addapted the Return Material Flow to support new UOM
Management functionality.
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/return-material/ob-return-material.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
src-db/database/model/views/M_RM_RECEIPT_PICK_EDIT.xml
src-db/database/model/views/M_RM_SHIPMENT_PICK_EDIT.xml
src/org/openbravo/common/actionhandler/RMInOutPickEditLines.java
src/org/openbravo/common/actionhandler/RMShipmentPickEditLines.java
src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
src/org/openbravo/common/datasource/ReturnToFromCustomerVendorHQLTransformer.java
David Miguelez <[email protected]> null
[UOM Management] Sales and Purchase flows.
Addapted both Sales and Purchase flows to support new UOM
Management functionality.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/procurement/ob-procurement.js
src-db/database/model/functions/C_INVOICE_CREATE.xml
src-db/database/model/functions/C_INVOICE_POST.xml
src-db/database/model/functions/C_ORDER_POST1.xml
src-db/database/model/functions/M_COPY_PRODUCT_TEMPLATE.xml
src-db/database/model/functions/M_EXPLODEBOMNOTSTOCK.xml
src-db/database/model/functions/M_INOUTEXPLODEBOMNOTSTOCK.xml
src-db/database/model/functions/M_INOUT_CREATE.xml
src-db/database/model/functions/M_INOUT_CREATEINVOICE.xml
src-db/database/model/functions/M_INOUT_POST.xml
src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
src-db/database/model/triggers/C_INVLINE_CHK_RESTRICTIONS_TRG.xml
src-db/database/model/triggers/C_ORDLINE_CHK_RESTRICTIONS_TRG.xml
src-db/database/model/triggers/M_INOUTLINE_TRG.xml
src-db/database/model/triggers/M_IOLINE_CHK_RESTRICTIONS_TRG.xml
src-db/database/model/triggers/M_REQUISITIONLINE_TRG.xml
src-db/database/model/views/M_CREATEPOLINES_PE_V.xml
src-db/database/sourcedata/AD_CALLOUT.xml
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
src-db/database/sourcedata/OBUISEL_SELECTOR.xml
src/org/openbravo/common/actionhandler/OrderCreatePOLines.java
src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice_data.xsql
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.html
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.java
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.xml
src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder_data.xsql
src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.java
src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder_data.xsql
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice.html
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice.xml
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.html
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.xml
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_RequisitionLine_Product.java
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.html
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.xml
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPendingLines_data.xsql
src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
David Miguelez <[email protected]> null
[UOM Management] Creates Java and DB functions to operate using
UOM Management. Creates callouts for AUM tab in Product Window.
src-db/database/model/functions/M_GET_CONVERTED_AUMQTY.xml
src-db/database/model/functions/M_GET_CONVERTED_QTY.xml
src-db/database/model/functions/M_GET_DEFAULT_AUM_FOR_DOCUMENT.xml
src/org/openbravo/common/actionhandler/CreateLinesFromPOConvertAUM.java
src/org/openbravo/common/actionhandler/GetConvertedQtyActionHandler.java
src/org/openbravo/erpCommon/ad_callouts/AUM_ConversionRate.java
src/org/openbravo/erpCommon/ad_callouts/GtinFormat.java
src/org/openbravo/erpCommon/ad_callouts/OperativeQuantity_To_BaseQuantity.java
src/org/openbravo/materialmgmt/CentralBroker.java
David Miguelez <[email protected]> null
[UOM Management] Creates new Table and modify existing ones to include
additional fields for UOM Management
src-db/database/model/tables/M_PRODUCT_AUM.xml
src-db/database/model/triggers/M_PRODUCT_AUM_TRG.xml
src-db/database/model/tables/C_INVOICELINE.xml
src-db/database/model/tables/C_ORDERLINE.xml
src-db/database/model/tables/M_INOUTLINE.xml
src-db/database/model/tables/M_REQUISITIONLINE.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_MESSAGE.xml
src-db/database/sourcedata/AD_REFERENCE.xml
src-db/database/sourcedata/AD_REF_LIST.xml
src-db/database/sourcedata/AD_REF_TABLE.xml
src-db/database/sourcedata/AD_TAB.xml
src-db/database/sourcedata/AD_TABLE.xml
src-db/database/sourcedata/AD_VAL_RULE.xml
Inigo Sanchez <[email protected]> null
Fixes issue 33170: ant setup forgets to copy src-test/.classpath.template
Ant setup application forgets to copy src-test/.classpath.template to
src-test/.classpath.
Now It has been solved the problem by copy the template.
src/org/openbravo/configuration/ConfigurationApp.java
Atul Gaware <[email protected] null
Related to issue 34205: Code review improvements
- Fix parenthesis in C_INVOICE_CANDIDATE_V view.
- Fix CreateFrom_InvoiceData.selectFromShipmentSOTrxCombo query, by retrieving
shipments not related to orders or shipments related to orders with invoicerule
<> 'N'.
- Remove unnecessary ic.term <> 'N' checks, as C_INVOICE_CANDIDATE_V view will
not retrieve orders with invoicerule = 'N' anymore.
src-db/database/model/views/C_INVOICE_CANDIDATE_V.xml
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
src/org/openbravo/erpCommon/ad_forms/GenerateInvoicesmanual_data.xsql
Changes for Build #1685
Martin Taal <[email protected]> null
Fixes issue 34331: Support pre-defined allowed domains for cross-domain
requests in a multi-server environment
Make method public so that it can be used by others to check if a url is in an
allowed domain
src/org/openbravo/base/secureApp/AllowedCrossDomainsHandler.java
Martin Taal <[email protected]> null
Fixes issue 34486: Support web/mobile service requests which do not create
a http session but still supports login
Create a dbsession record also for stateless webservice requests
src/org/openbravo/authentication/AuthenticationManager.java
Last 20 lines of the console output:
[...truncated 19477 lines...]
Total time: 2 seconds
executing script 'Tomcat stop'
[int-basic-oracle] $ /bin/bash /tmp/build_step_template5492438376120355977.sh
ENABLE
DEBUG: Tomcat stop called with parameters: ENABLED=ENABLE
* Stopping Tomcat servlet engine for Openbravo tomcat
...done.
executing script 'Check openbravo log'
[int-basic-oracle] $ /bin/bash /tmp/build_step_template1568278338504424384.sh
ENABLE
DEBUG: Check openbravo log called with parameters: ENABLED=ENABLE
Check log: openbravo log (artifact: int-basic-oracle.log) is clean
Recording test results
Archiving artifacts
Checking \] ERROR|\] WARN
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
