int-upgrade-pgsql - Build # 1821 - Fixed:

Check console output at https://ci.openbravo.com/job/int-upgrade-pgsql/1821/ to 
view the results.


Committers since last success:

Changes for Build #1819

    Asier Lostalé <[email protected]> null
    fixed issue 34975: change scope of ADCS to ApplicationScoped
      
    Asier Lostalé <[email protected]> null
    [adcs] compare field ids rather than field instances

  Being now ApplicationScoped intsances are always different, resulting in
  incorrect view generation.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java

    Asier Lostalé <[email protected]> null
    [adcs] add tab to map only when initialization is completed
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] pi merge
      
    Asier Lostalé <[email protected]> null
    [adcs] typo
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialization.java
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java

    Asier Lostalé <[email protected]> null
    [adcs] prevent unneeded getVars() invocations
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] typo
        src-test/src/org/openbravo/test/AllAntTaskTests.java

    Asier Lostalé <[email protected]> null
    [adcs] ADCS is no longer SessionScoped so it doesn't need to be Serializable
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] removed obvious and outdated java doc on private methods
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] don't use Hashtable
        src/org/openbravo/erpCommon/utility/QueryFieldStructure.java

    Asier Lostalé <[email protected]> null
    [adcs] keep default constructor for backwards compat
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] comment
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java

    Asier Lostalé <[email protected]> null
    [adcs] stop thread after 5 failures
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java

    Asier Lostalé <[email protected]> null
    [adcs] change sorting in test: same window but different tab sorting per 
thread
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java

    Asier Lostalé <[email protected]> null
    [adcs] Map.putIfAbsent is not available till JDK8
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] cleanup
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java

    Asier Lostalé <[email protected]> null
    [adcs] javadoc
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java

    Asier Lostalé <[email protected]> null
    [adcs] moved eager initialization to testing code
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] eager initialization for attachment methods
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] initialize request with fake vars so combos can be initialized
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java

    Asier Lostalé <[email protected]> null
    [adcs] test: initialize several threads with some delay
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java

    Asier Lostalé <[email protected]> null
    [adcs] optimize logging for eager initialization
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] sync window initialization
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] added test case for concurrent ADCS initialization
        
modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSInitialiazation.java
        src-test/src/org/openbravo/test/AllAntTaskTests.java

    Asier Lostalé <[email protected]> null
    [adcs] useCache made public to be able to test it
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] eagear initialization done by tab

  which better emulaltes actual initialization
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] initialize reference's lists before iterating them
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] pi merge
      
    Asier Lostalé <[email protected]> null
    [adcs] constants should be static and upper cased
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] updated (c)
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
        
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/reference/SelectorUIReference.java
        src/org/openbravo/erpCommon/utility/ComboTableData.java
        src/org/openbravo/erpCommon/utility/QueryFieldStructure.java
        src/org/openbravo/reference/ui/UITable.java
        src/org/openbravo/reference/ui/UITableDir.java

    Asier Lostalé <[email protected]> null
    [adcs] use constants
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/reference/SelectorUIReference.java
        src/org/openbravo/erpCommon/utility/ComboTableData.java
        src/org/openbravo/reference/ui/UITable.java
        src/org/openbravo/reference/ui/UITableDir.java

    Asier Lostalé <[email protected]> null
    [adcs] javadoc in public method
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] removed unneeded empty default constructor
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] javadoc in public methods
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] create the map directly as a copy of original
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] update index
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] early return if not using cache
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] javadoc
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] removed some duplicity
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] prevent concurrent modification of initializedWindows
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] pi merge
      
    Asier Lostalé <[email protected]> null
    [adcs] eager combo initialization
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] unneded new String
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] replaced StringBuffer with StringBuilder
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] replaced for statements with foreach constructs
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] Moved synchronized structures to non-syncs where possible
        src/org/openbravo/erpCommon/utility/ComboTableData.java
        src/org/openbravo/erpCommon/utility/QueryFieldStructure.java

    Asier Lostalé <[email protected]> null
    [adcs] removed commented code
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] don't set actual values when parsing the query
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] missing client list place holder
        src/org/openbravo/reference/ui/UITableDir.java

    Asier Lostalé <[email protected]> null
    [adcs] using field info in ComboTableData to get client/org lists
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] combos can be cached by field
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
        
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] don't cache client/org lists in combos
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
        
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ComboTableDatasourceService.java
        
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/reference/SelectorUIReference.java
        src/org/openbravo/erpCommon/utility/ComboTableData.java
        src/org/openbravo/reference/ui/UITable.java
        src/org/openbravo/reference/ui/UITableDir.java

    Asier Lostalé <[email protected]> null
    [adcs] added log if query fails in ComboTableData
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] don't cache vars in ComboTableData as it's session dependent
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
        src/org/openbravo/erpCommon/utility/ComboTableData.java

    Asier Lostalé <[email protected]> null
    [adcs] pi merge
      
    Asier Lostalé <[email protected]> null
    [adsc] missing cache
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] allow concurrent modifications in all caches
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] added comments to getTab locks
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] added debug info
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] removed debugging code
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] added convenience methods to reset and eager window initialization
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] prevent NPE when locking obj
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] sync at object level for initializeDALObject
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] split getTab synchronization

  Before it was a synchronized method, so that all paralell invokations got
  queued and executed one by one.

  Now:
   - If tab is already cached, there is no locking
   - It is possible to process several different tabs in paralell, the locking
     occurs at different tab level.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] prevent loading modules in development
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] prevent double initialization
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

    Asier Lostalé <[email protected]> null
    [adcs] set ADCS as ApplicationScoped
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java

Changes for Build #1820

    Carlos Aristu <[email protected]> null
    related to issue 34816: fixed javadoc parameter name
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    fixes issue 34816: Support a second database for reporting
      
    Carlos Aristu <[email protected]> null
    [multi-pool] Database sessions must be related to a pool with a not null 
name
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    [multi-pool] removed obsolete comment
        src/org/openbravo/dal/service/OBCriteria.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Removed unused variable
        src/org/openbravo/dal/core/DalThreadHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Ensure that session handler and OBContext are always cleaned up
        src/org/openbravo/dal/core/DalThreadHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Merge with pi
      
    Carlos Aristu <[email protected]> null
    [multi-pool] Extracted clean up logic into two new private methods
        src/org/openbravo/dal/core/DalThreadHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Improved javadoc description
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Ensure that all sessions are cleaned up by the SessionHandler
        src/org/openbravo/dal/core/DalThreadHandler.java
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Use constant for currency ID
        src-test/src/org/openbravo/test/security/CrossOrganizationReference.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated missing constant usage
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_01.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_02.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_03.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_04.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_05.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_06.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_07.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_08.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_09.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_10.java
        src-test/src/org/openbravo/advpaymentmngt/test/PaymentTest_11.java
        src-test/src/org/openbravo/test/costing/TestCosting.java
        src-test/src/org/openbravo/test/security/EntityAccessTest.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated copyright year
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/ConnectionInitializerInterceptor.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated copyright year
        src-test/src/org/openbravo/test/security/CrossOrganizationReference.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Use constants for Strings
        src-test/src/org/openbravo/test/base/OBBaseTest.java
        src-test/src/org/openbravo/test/dal/DalPerformanceCriteriaTest.java
        src-test/src/org/openbravo/test/dal/DalQueryTest.java
        src-test/src/org/openbravo/test/dal/DalTest.java
        src-test/src/org/openbravo/test/dal/ValidationTest.java
        src-test/src/org/openbravo/test/security/CrossOrganizationReference.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Added new test cases
        src-test/src/org/openbravo/test/base/OBBaseTest.java
        src-test/src/org/openbravo/test/dal/DalTest.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Camel cased method name
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Register available pools instead of unavailable ones

Register available pools instead of unavailable ones, otherwise 
isSessionHandlerPresent was returning true when using it with a non-initialized 
pool name
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated copyright year
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Fix typo
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Set the interceptors for every available datasource
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated copyright year
        src/org/openbravo/dal/core/DalThreadHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] SessionHandler must take into account the availability of the 
pools

As the SessionHandler is not removed anymore after doing commit or rollback, it 
remains present along all the lifecycle of the thread (it is removed at the 
end). But the session of a particular pool is indeed closed after doing commit 
or rollback, therefore the isSessionHandlerPresent() needed to be updated to 
take into account for which pools in particular is the session handler 
available.

>From now the SessionHandler maintains a set with the names of the pools where 
>a commit or a rollback has been done. This set is consulted to decide if the 
>session handler is present for a particular pool as 'sessionHandler.get() != 
>null' is not enough to decide it, because of the reason explained above.

Without this changeset, two consecutive calls to 
OBDal.getInstance().commitAndClose() would fail because the second commit would 
be performed without an active session and the checkInvariant method of the 
SessionHandler would throw an exception.
        src/org/openbravo/dal/core/DalThreadHandler.java
        src/org/openbravo/dal/core/SessionHandler.java
        src/org/openbravo/dal/service/OBDal.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Declare otherPoolInstances as ConcurrentHashMap

Declare otherPoolInstances as ConcurrentHashMap in order to prevent compilation 
errors because of the usage of the putIfAbsent method: this method is not 
present in the Map interface in Java 7.
        src/org/openbravo/dal/service/OBDal.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Use read only pool by default in utility methods used by 
reports
        src/org/openbravo/erpCommon/utility/Utility.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Use read only pool by default with ReportManager
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
        
src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Use read only pool by default to retrieve report info
        src/org/openbravo/erpCommon/utility/reporting/Report.java
        
src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated copyright year
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Prevent connection leak after printing with PrintController

- Not all the session were being clean-up by the DalThreadHandler, if the 
OBDal.getInstance().commitAndClose() method was invoked along the lifecycle of 
a thread. This was happening in the printing flow that makes use of the 
PrintController class.
- Besides, now the session is not initialized in the 
SessionHandler.getInstance() method, now this is performed just in the 
getSession() method which is invoked by all the public methods of the 
SessionHandler when required.
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated copyright year
        src/org/openbravo/dal/service/OBDal.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Use putIfAbsent to avoid possible thread unsafeties

The putIfAbsent method of ConcurrentHashMap associates a key with the given 
value if the key is not already present in the map. This method is performed 
atomically, this way we ensure that two threads executing the 
getInstance(String pool) method at the same time always return the same 
instance for the same pool name.
        src/org/openbravo/dal/service/OBDal.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated javadoc info
        src/org/openbravo/dal/service/OBDal.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Avoid duplicated call to retrive the hibernate session 
statistics
        src/org/openbravo/dal/service/OBDal.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Flush the session of the pool assigned to the OBDal instance
        src/org/openbravo/dal/service/OBDal.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Use OBDal read-only instance when needed in the reporting 
engine
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/report/ReportingUtils.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Removed useless static variable
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Merge with pi
      
    Carlos Aristu <[email protected]> null
    [multi-pool] Do not use getSession() in checkInvariant()

Retrieve the session directly from the map. If we were using getSession(pool), 
the null check would be useless because that method never return null as it 
creates the session if it does not exists
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated copyright year and added missing javadoc
        src-core/src/org/openbravo/database/ExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Added missing javadoc information
        src/org/openbravo/dal/service/OBQuery.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Added missing javadoc information
        src/org/openbravo/dal/service/OBDal.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Updated copyright year
        src/org/openbravo/dal/core/DalThreadHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Added missing javadoc information
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Added missing javadocs
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Fix wrong pool selection in createQuery method
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Moved datasource existence check to getDataSourceByName method
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Delete session handler if it was not deleted before

At this point session handler will not be present normally, we delete it just 
in case it is still present
        src/org/openbravo/dal/core/DalThreadHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Do not include default pool in otherPoolInstances map
        src/org/openbravo/dal/service/OBDal.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Delete session handler if it was not deleted before
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Created new methods to organize maps handling

- New methods added to handle session, connection and transaction maps.
- Change position of some methods to have them better organized.
        src/org/openbravo/dal/core/SessionHandler.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Use default pool if requested pool is not configured
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Close all available DataSource instances
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Default DataSource is cached
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Return default property if pool name is not provided
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Added missing trim() for int property parsing
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Added missing javadoc for getConnection(String) method
        src-core/src/org/openbravo/database/ExternalConnectionPool.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Added constant for the attribute that marks connections as not 
new
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/ConnectionInitializerInterceptor.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Added isReadOnlyPool private method
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/ConnectionInitializerInterceptor.java

    Carlos Aristu <[email protected]> null
    [multi-pool] Merge with pi
      
    Asier Lostalé <[email protected]> null
    [multi-pool] close transaction in case commit fails
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    [multi-pool] fixed incorrect condition
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    [multi-pool] some code clean up
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    [multi-pool] rename variables that have collections
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    [multi-pool] better handling of thread clean up
        src/org/openbravo/dal/core/DalThreadHandler.java
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    [multi-pool] simplified API for readonly Connection Providers
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/report/ReportingUtils.java
        src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
        
src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
        src/org/openbravo/service/db/DalConnectionProvider.java

    Asier Lostalé <[email protected]> null
    [multi-pool] add import + reorder them
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/report/ReportingUtils.java

    Asier Lostalé <[email protected]> null
    [multi-pool] pi merge
      
    Asier Lostalé <[email protected]> null
    [multi-pool] jasper reports with query in jrxml use readonly pool
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/report/ReportingUtils.java
        src/org/openbravo/base/secureApp/HttpSecureAppServlet.java

    Asier Lostalé <[email protected]> null
    [multi-pool] set pool when creting dal query
        src/org/openbravo/dal/service/OBDal.java

    Asier Lostalé <[email protected]> null
    [multi-pool] prevent audit infra initialization for readonly pool
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/ConnectionInitializerInterceptor.java

    Asier Lostalé <[email protected]> null
    [multi-pool] DAL queries and criterias can use readonly pool
        src/org/openbravo/dal/service/OBCriteria.java
        src/org/openbravo/dal/service/OBDal.java
        src/org/openbravo/dal/service/OBQuery.java

    Asier Lostalé <[email protected]> null
    [multi-pool] fixed regexp to get pool properties
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Asier Lostalé <[email protected]> null
    [multi-pool] moved pool name to constant
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java
        src-core/src/org/openbravo/database/ExternalConnectionPool.java
        src/org/openbravo/dal/service/OBDal.java

    Asier Lostalé <[email protected]> null
    [multi-pool] don't set audit trail info for readonly
        src-core/src/org/openbravo/database/SessionInfo.java

    Asier Lostalé <[email protected]> null
    [multi-pool] readonly pool will get connections in read only mode
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Asier Lostalé <[email protected]> null
    [multi-pool] read only pool read from Openbravo.properties
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    Asier Lostalé <[email protected]> null
    [multi-pool] reduced new methods visibility where possible
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    [multi-pool] moved default pool name to constant
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java
        src-core/src/org/openbravo/database/ExternalConnectionPool.java
        src/org/openbravo/dal/core/SessionHandler.java
        src/org/openbravo/dal/service/OBDal.java
        src/org/openbravo/service/db/DalConnectionProvider.java

    Asier Lostalé <[email protected]> null
    [multi-pool] do not leak other pools' connections
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    [multi-pool] set default pool for DalConnectionProvider
        src/org/openbravo/service/db/DalConnectionProvider.java

    Asier Lostalé <[email protected]> null
    [multi-pool] DalConnectionProvider uses Dal's pools
        src/org/openbravo/dal/core/SessionHandler.java
        src/org/openbravo/service/db/DalConnectionProvider.java

    Asier Lostalé <[email protected]> null
    [multi-pool] allow multiple dal instances
        src/org/openbravo/dal/core/DalThreadHandler.java
        src/org/openbravo/dal/core/SessionHandler.java
        src/org/openbravo/dal/service/OBDal.java

    Asier Lostalé <[email protected]> null
    [multi-pool] PrintController uses RO pool
        
src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java

    Asier Lostalé <[email protected]> null
    [multi-pool] don't leak connections obtained for different pools
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    [multi-pool] DalConnectionProvider can retrieve conn from a named pool
        src/org/openbravo/service/db/DalConnectionProvider.java

    Asier Lostalé <[email protected]> null
    [multi-pool] base for connection pool can return a connection from a 
different one
        src-core/src/org/openbravo/database/ExternalConnectionPool.java

    Asier Lostalé <[email protected]> null
    [multi-pool] basic multipool infrastructure
        
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/JdbcExternalConnectionPool.java

    RM packaging bot <[email protected]> null
    Merge back from main
      
    RM packaging bot <[email protected]> null
    Merge temporary head for 3.0PR16Q4.1
      
    RM packaging bot <[email protected]> null
    Added signature for changeset fa51600e25b2
        .hgsigs

    RM packaging bot <[email protected]> null
    Added tag 3.0PR16Q4.1 for changeset b93f495b2cde
        .hgtags

    RM packaging bot <[email protected]> null
    Update AD_MODULE version to 3.0PR16Q4.1
        
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml
        
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
        src-db/database/sourcedata/AD_MODULE.xml

    Asier Lostalé <[email protected]> null
    Fixed bug 34940: 3.0 selectors cannot be used in classic mode

  When a 3.0 selector was included within classic mode, the JS failed to load.

  The problem was cancelAndReplace.js was included within classic mode JS but it
  depends on resources not available in this mode.

  Because cancel and replace is not designed to work in classic mode, its JS is
  now not included in this mode.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java

    Naroa Iriarte <[email protected]> null
    Fixed issue 34892: The GL item section of add payment was not working fine

The grid of the G/L item section of the Add payment process was not workinf 
fine. The problem was that it was shown as sortable and as filterable and it 
must not be filterable nor sortable. This has been caused by the changeset[1]. 
This proyect set every column as sortable and as filterable and so was the 
problem.
To fix this the values of "canSort" and "canFilter" have been changed in the 
needed cases, which are the ones that satisfy the condition of having the 
canDelete property or the canAdd property set to yes and are in Pick and 
Execute window.
The code which handles the logic has been moved from the 
OBViewFieldHandler.getGridFieldProperties() to 
UIDefinition.getGridFieldProperties().

[1]http://code.openbravo.com/erp/devel/pi/rev/afa165be3e5900d1114d33e5106114d0e089876a
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
        
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java

    Rafael Queralta Pozo <[email protected]> null
    Fixed issue 34852: Not possible to select a GS in RFC not created from an 
order

 Restructured HQL inserter query for discount to select a GS in RFC has not been
 created from an order
        src/org/openbravo/common/datasource/ReturnFromCustomerHQLInserter.java

    Inigo Sanchez <[email protected]> null
    Fixed issue 34829: Product selector of the Requisition subtab appears empty

The problem was introduced in a refactor of checkFetchDatasourceAccess() method 
of
BaseDataSourceService class. This refactor change the way in wich entities of
selectors were calculated. It is important to note that the refactor is not bad 
in
itself. The problem was appeared because it was forgotten to do an additional 
thing.

Before this refactor in some cases entities were not calculated properly. For 
example
in the subtab of Requisition window there are a complex selector of product. 
(Reference:
Product Complete - Parent Reference: Search). In this example, 
checkFetchDatasourceAccess
method was checked Product entity instead of ProductStockView. The refactor 
fixed this
problem.

Otherwise, the refactor missed to take into account entities of complex defined 
selectors
as derivedReadableEntities. To solve the problem now, when initialize() method 
of
EntityAccessChecker class calculates permissions, it will take into account 
this entities.
        src/org/openbravo/dal/security/EntityAccessChecker.java

    Carlos Aristu <[email protected]> null
    fixes issue 34882: Incorrect styling in Chrome 56
        
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js

Changes for Build #1821

    Inigo Sanchez <[email protected]> null
    Fixed issue 34977: A deactivated organization can not be activated again.

When an organization was disabled you could not activate it again as the row 
was not ediable. This
problem was introduced in a fix related with the code of addWritableAttribute() 
method of
DefaultJsonDataService class. Before this fix, It was managing the reported 
case properly (Activate
again a deactivated organization) because this method was handling the 
particular case of Organizations.

Now is taking into account this particular case (deactivate organizations) in 
order to manages this
particular case properly. Now it is possible to activate again a deactivate 
organization.
        
modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
        src/org/openbravo/dal/core/OBContext.java
        src/org/openbravo/dal/security/SecurityChecker.java

    Carlos Aristu <[email protected]> null
    related to issue 34816: added missing pool name when using checkInvariant

Providing the pool name when invoking checkInvariant in commitAndStart method. 
Besides, the private checkInvariant() method has been removed as now is unused.
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    related to bug 35057: check also if trx is null
        src/org/openbravo/dal/core/SessionHandler.java

    Asier Lostalé <[email protected]> null
    fixed bug 35057: potential NPE on trx rollback
        src/org/openbravo/dal/core/SessionHandler.java

    Mark <[email protected]> null
    Related to issue 35015: Posting the cost adjustment with trx's organization

When posting Cost Adjustment document, transaction's organization is considered
(instead of cost adjustment line's organization) to avoid lines will be post to
"generic" organization.
        src/org/openbravo/erpCommon/ad_forms/DocLineCostAdjustment_data.xsql

    Armaignac <[email protected]> null
    Fixes issue 35015: Adjustment Lines are created for "Legal" organization

In order to maintain organization's structure consistency, it is necessary that
Adjustment Lines are created for "Legal" organization same as Adjustment Header
is actually created.
        src/org/openbravo/costing/CostAdjustmentUtils.java




Last 20 lines of the console output:

[...truncated 3384 lines...]
Total time: 2 seconds

executing script 'Tomcat stop'
[int-upgrade-pgsql] $ /bin/bash /tmp/build_step_template1818271893695953170.sh 
ENABLE
DEBUG: Tomcat stop called with parameters: ENABLED=ENABLE
 * Stopping Tomcat servlet engine for Openbravo tomcat
   ...done.

executing script 'Check openbravo log'
[int-upgrade-pgsql] $ /bin/bash /tmp/build_step_template8642117933340063697.sh 
ENABLE
DEBUG: Check openbravo log called with parameters: ENABLED=ENABLE
Check log: openbravo log (artifact: int-upgrade-pgsql.log) is clean

Recording test results
Archiving artifacts
Checking \] ERROR|\] WARN
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds

Reply via email to