up-2.50topi-oracle - Build # 175 - Still Failing:

Check console output at https://ci.openbravo.com/job/up-2.50topi-oracle/175/ to 
view the results.


Committers since last success:

Changes for Build #174

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    Fixed issue 35214:Dropdowns are not opening properly when included in a 
process

The problem is assuming that the selector is placed on a standard view (window).
When a selector is placed on a process definition, the selector raises an error
and no data is showed. It must consider the case where the selector is being
displayed from a process definition view.

This problem has been resolved by take into account when a selector is being
displayed from a process definition. Now, the problem has been fixed.
        
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-filter-select-item.js

    Inigo Sanchez <inigo.sanc...@openbravo.com> null
    Fixed issue 35204: define partial indexes for not null values

The following indexes have been transformed into partial indexes:
-ad_process_run_adprgroup_id
-ad_column_process
-obuiapp_paramval_file_idx
-ad_tab_tabletree_fk
-obuiapp_parameter_tab_idx
-obuiapp_parameter_attmet_idx
-ad_modelobject_reference_idx
-ad_modelobject_form_idx
-ad_modelobject_callout_idx
-ad_modelobject_process_idx
-em_obkmo_param_widget
-obuiapp_parameter_process
-obcql_widget_query_ds
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_PARAMETER_VALUE.xml
        
modules/org.openbravo.client.myob/src-db/database/model/modifiedTables/OBUIAPP_PARAMETER.xml
        
modules/org.openbravo.client.querylist/src-db/database/model/tables/OBCQL_WIDGET_QUERY.xml
        src-db/database/model/tables/AD_COLUMN.xml
        src-db/database/model/tables/AD_MODEL_OBJECT.xml
        src-db/database/model/tables/AD_PROCESS_RUN.xml
        src-db/database/model/tables/AD_TAB.xml

    Armaignac <collazoan...@gmail.com> null
    Fix for issue 35266: General Ledger filter removed when paginating in GL 
Report

The General Ledger filter was removed when paginating in General Ledger Report
in HTML view

Now the General Ledger filter it's save in the session by the FIND action and 
get in the DEFAULT action
for showing in the report page
        src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java

    Victor Martinez Romanos <victor.marti...@openbravo.com> null
    Fixed bug 35263: Organization filter in Best Seller widget

The Best Seller widget didn't have organization filter thus showing records 
belonging to organizations where the role doesn't have access to.

The fix introduces a new parameter to get the readable orgs, and the HQL query 
has been adapated to use it.
        
modules/org.openbravo.client.widgets/src-db/database/sourcedata/OBCQL_WIDGET_QUERY.xml
        
modules/org.openbravo.client.widgets/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed issue 20515: OBCriteria creates contention at JVM

  When using OBCriteria for same entity by several concurrent threads, there was
  contention at JVM due to locks in Class.forName(entityName).

  This Class.forName(entityName) always results in ClassNotFoundException 
because
  entityName is not an actual class name. Hibernate criteria can accept either 
an
  entity name or a class name. It has been changed to set class name instead of
  entity so that it finds the class in the classloader cache earlier removing 
contention.

  Note when criteria is used for scrolling, Hibernate's flow is different and it
  expects it to be an entity name, though in this case there's no contention 
because
  class is resolved by internal caches. This is also covered in the fix as 
exceptional
  case.
        src/org/openbravo/dal/service/OBCriteria.java
        src/org/openbravo/dal/service/OBDal.java

    sanjota <sanjota.nel...@promantia.com> null
    Related to issue 34993: reverting changes of the issue.

Reverting the changes of the issue due to failure in oracle.
        src-db/database/model/triggers/C_INVOICELINE_TRG2.xml

    Mark <markm...@gmail.com> null
    Related to issue 34993: Update the invoice prepaiment amount with correct 
value
if after create from a paid order line, it updates the line net amount to 0
or it changes from 0 to a another value.

If you create the invoice line from a paid order line, and then the line net 
amount
changes it value to 0 (by updating qty = 0 or price = 0, for instance), then
previously prepayment was remaining instead of be discarded. So, you may have an
invoice with Total Gross Amount of 0 and a prepayment different than 0.

When you are updating a line with a NEW line net amount = 0 or deleting the 
line,
it is needed to remove the prepayment of this line from the invoice.

If the OLD line net amount was zero (the prepayment was removed or not taken 
into
account when creating or updating the line) and it changes
to a non-zero new line net amount value, is necessary take into account the 
prepaid
order line amount to increase the invoice prepayment amount with its value.

In any other case it is not necessary update the prepayment amount of the 
invoice.
        src-db/database/model/triggers/C_INVOICELINE_TRG2.xml

    Mark <markm...@gmail.com> null
    Related to issue 34993: Code review improvements

Removed unnecessary variables and query.
If the invoice line will be deleted always the invoice must update it prepayment
amount. If the invoice line is related to a paid order line, then invoice
prepayment will be updated discounting the prepaid value of the order line, in
other hands the prepayment amount of the invoice will still with its value 
because
there are not any pay related to the order line.
        src-db/database/model/triggers/C_INVOICELINE_TRG2.xml

    sanjota <sanjota.nel...@promantia.com> null
    Fixes issue 34993: Update Prepaymentamt properly on changing the 
Invoicelines.

Update the prepayment amount value in invoice as per updation of invoice lines 
referriing to orderlines.
Ex : If Order linked to invoice line is prepaid, the invoice prepayment is 
updated,
if the same invoiceline referring to orderline is deleted then the prepayment 
amount is updated properly.
        src-db/database/model/triggers/C_INVOICELINE_TRG2.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed bug 35203: performance problem in DocInvoice with cashvat 
functionality

Solution based on patch supplied by MAL.

Added three new columns to C_INVOICETAX_CASHVAT_V view: c_invoice_id, c_tax_id 
and isprepayment. Note that this won't create a performance issue, since the 
correspondent tables are already included in the view.
Redesign HQL query in CashVATUtil.calculatePrepaidPercentageForCashVATTax() 
method to use those new columns avoiding slow joins to external tables.

After the change the query for this method just uses the C_InvoiceTax_CashVAT_V 
view without joining with other tables thus improving the performance.
        src-db/database/model/views/C_INVOICETAX_CASHVAT_V.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src/org/openbravo/erpCommon/utility/CashVATUtil.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed bug 35260: unneeded flushes in window settings action handler

  * No need to flush before querying with sqlc.
  * This is a readonly process, so we can safelly clear session at the end so
    that flush done when finalizing the thread don't require to check any object
    for dirtiness
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    related to bug 35258: updated dbsourcemanager library
        src-db/database/lib/dbsourcemanager.jar

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Fixes issue 35241: Random failure in TestCosting when executing it in Oracle
        src-test/src/org/openbravo/test/costing/TestCosting.java

    Mark <markm...@gmail.com> null
    Related to issue 35068: Code review improvements

Used a HQL query instead of a direct SQL query.
        src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java

    Atul Gaware <atul.gaw...@openbravo.com> null
    Fixes Issue 35068: Valued Stock Report is showing warehouses that do not
belong to the organization included in the filter

Selected warehouse or list of applicable warehouse for selected
organization sent as parameter to queries fetching valued stock
data.
        src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
        src/org/openbravo/erpCommon/ad_reports/ReportValuationStock_data.xsql

Changes for Build #175

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed bug 35287: Slow behavior in Financial Account | Accounting tab

Added new index to improve query performance.
In the customer environment the total cost has been reduced from 6581196 to 
1310605, and the query time from 18 seconds to 1.2 seconds.

The index is declared as partial index because, although the null ratio is 
going to be low (around 10% in real instances), it is very unlikely to search 
by "is null" in this column. So we can have a (small) benefit in declaring as 
partial index (faster inserts/deletes/updates when the column is null).
        src-db/database/model/tables/FACT_ACCT.xml

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed issue 31674: don't show stack trace in log on failed login

  Removed log with error level for invalid logins. It was already logged
  with debug level which is enough.
        src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    related to bug 31674: apply proper java formatting
        src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed bug 35346: can't save grid record with multi field pick list selector

  Records in tabs with a column having a selector with multiple fields in pick
  list couldn't be saved in grid after opening form view.

  The problem was casued becasue this kind of selectors require to calculate the
  size for the picking list, but when saving it is already closed so it failed
  assuming it has a grid.

  Fixed by checking if grid is present which indirectly checks if it is visible.
        
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35205: reverted some partial indexes

Some indexes have been reverted to normal indexes because they belong to high 
volume tables and the benefit to transform them to partial index is very 
reduced (if any) because most of the values will usually be not null.
Besides, transforming them to partial index would create a big delay in the 
update database process.
        src-db/database/model/tables/A_AMORTIZATIONLINE.xml
        src-db/database/model/tables/C_INVOICELINE.xml
        src-db/database/model/tables/C_INVOICETAX_CASHVAT.xml
        src-db/database/model/tables/C_ORDERLINE.xml
        src-db/database/model/tables/C_TAX_ZONE.xml
        src-db/database/model/tables/FIN_FINACC_TRANSACTION.xml
        src-db/database/model/tables/M_INOUTLINE.xml
        src-db/database/model/tables/M_LANDEDCOST.xml

    Martin Taal <martin.t...@openbravo.com> null
    Related to issue 35326: Support basic authentication
back out of changeset as it causes several retail offline tests to fail
        src/org/openbravo/base/secureApp/HttpSecureAppServlet.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35205: new normal index 
C_CONVERSION_RATE_DOCUMENT.C_INVOICE_ID
Added this new normal indexes because it has been detected to avoid seq. scan 
in several flows.
More info at 
https://docs.google.com/spreadsheets/d/1m5GZaaoEkYvyGdyxddtxxb3SeAhvtavfdq53iumOT7s
        src-db/database/model/tables/C_CONVERSION_RATE_DOCUMENT.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed issue 35205: Partial indexes functional stuff

The only performance drawback in transforming a normal index to a partial index 
is in the queries with a where clause filtering by a indexed column when this 
column is null.
In this case, and only when the ratio of null values is very low, the query 
will probably execute a seq. scan over the table instead of using the index, 
thus killing the performance.

To detect this scenario, we have "greped" the PI code for "is*null" string 
(case insensitve), and filtered the places where the candidate indexes appear. 
Then, we have individually analize each of the queries to detect whether we 
could safely transform the index to partial index based on the previous 
explanation.

The result can be found in 
https://docs.google.com/spreadsheets/d/1m5GZaaoEkYvyGdyxddtxxb3SeAhvtavfdq53iumOT7s
 Functional Analysis tab.
Values with Candidate = Y are the ones to be transformed to partial indexes, 
Candidate = N means to keep the normal index, and TBCN is to create a normal 
index because it would help in performance.
When there is no query that uses this index inside an "IS NULL" condition, we 
have automatically set it to partial index as there shouldn't be any risk
For the rest of the candidates there are individual explanations which can be 
found as a note (in the Candidate column and/or in the places where this index 
might be used).

For future references, this is the command used to grep the PI code:
grep -n --color=always  -riI  "is[[:space:]]*null" --exclude \*.js 
--exclude-dir src-wad --exclude-dir build  /home/openbravo/HG/erp/devel/pi | 
grep -vi case | more
        
modules/org.openbravo.userinterface.selector/src-db/database/model/tables/OBUISEL_SELECTOR_TRL.xml
        src-db/database/model/tables/AD_USER.xml
        src-db/database/model/tables/A_AMORTIZATIONLINE.xml
        src-db/database/model/tables/A_ASSET.xml
        src-db/database/model/tables/C_ACCTSCHEMA_PROCESS.xml
        src-db/database/model/tables/C_BPARTNER.xml
        src-db/database/model/tables/C_CITY.xml
        src-db/database/model/tables/C_CONVERSION_RATE_DOCUMENT.xml
        src-db/database/model/tables/C_INVOICE.xml
        src-db/database/model/tables/C_INVOICELINE.xml
        src-db/database/model/tables/C_INVOICETAX_CASHVAT.xml
        src-db/database/model/tables/C_ORDER.xml
        src-db/database/model/tables/C_ORDERLINE.xml
        src-db/database/model/tables/C_POC_DOCTYPE_TEMPLATE.xml
        src-db/database/model/tables/C_POC_EMAILDEFINITION.xml
        src-db/database/model/tables/C_TAXREGISTER.xml
        src-db/database/model/tables/C_TAXREGISTERLINE.xml
        src-db/database/model/tables/C_TAXREGISTER_TYPE_LINES.xml
        src-db/database/model/tables/C_TAX_ZONE.xml
        src-db/database/model/tables/FIN_FINACC_TRANSACTION.xml
        src-db/database/model/tables/FIN_ORIG_PAYMENT_SCHEDULE.xml
        src-db/database/model/tables/FIN_ORIG_PAYM_SCHEDDETAIL.xml
        src-db/database/model/tables/FIN_PAYMENT_SCHEDULE.xml
        src-db/database/model/tables/FIN_PAYMENT_SCHEDULEDETAIL.xml
        src-db/database/model/tables/GL_JOURNAL.xml
        src-db/database/model/tables/MA_MAINTENANCE.xml
        src-db/database/model/tables/MA_MEASURE_GROUP.xml
        src-db/database/model/tables/MA_PROCESS.xml
        src-db/database/model/tables/MA_WEINCIDENCE.xml
        src-db/database/model/tables/MRP_RUN_PRODUCTIONLINE.xml
        src-db/database/model/tables/M_COSTADJUSTMENTLINE.xml
        src-db/database/model/tables/M_COSTING.xml
        src-db/database/model/tables/M_INOUT.xml
        src-db/database/model/tables/M_INOUTLINE.xml
        src-db/database/model/tables/M_LANDEDCOST.xml
        src-db/database/model/tables/M_LC_COST.xml
        src-db/database/model/tables/M_LC_MATCHED.xml
        src-db/database/model/tables/M_LC_RECEIPT.xml
        src-db/database/model/tables/M_LC_RECEIPTLINE_AMT.xml
        src-db/database/model/tables/M_LOCATOR.xml
        src-db/database/model/tables/M_MATCHPO.xml
        src-db/database/model/tables/M_PRODUCT.xml
        src-db/database/model/tables/M_RAPPEL_BPARTNER.xml
        src-db/database/model/tables/M_RAPPEL_INVOICE.xml
        src-db/database/model/tables/M_RAPPEL_PRODUCT.xml
        src-db/database/model/tables/M_RAPPEL_PRODUCTCATEGORY.xml
        src-db/database/model/tables/M_RAPPEL_SCALE.xml
        src-db/database/model/tables/M_RESERVATION.xml
        src-db/database/model/tables/M_RESERVATION_STOCK.xml
        src-db/database/model/tables/M_STOCK_AUX.xml
        src-db/database/model/tables/M_STOCK_VALUATION.xml
        src-db/database/model/tables/M_TRANSACTION.xml
        src-db/database/model/tables/M_TRANSACTION_COST.xml
        src-db/database/model/tables/M_WAREHOUSE_SHIPPER.xml
        src-db/database/model/tables/S_TIMEEXPENSELINE.xml

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Fixes issue 35337: Fix CostingUtils.existsProcessedTransactions method

Add an alias for Locator class in CostingUtils.existsProcessedTransactions 
method.
        src/org/openbravo/costing/CostingUtils.java

    Alvaro Ferraz <alvaro.fer...@openbravo.com> null
    Fixes issue 35330: CostingAlgorithm not properly initialized

Set costingAlgorithm variable as a global variable inside CostingServer class.
Call CostingAlgorithm.init() method only inside getCostingAlgorithm() method.
Call getCostingAlgorithm() method only inside CostingServer.init() method.
Thus, new CostingAlgorithm instances will only be created and initialized when 
creating a new CostingServer instance.
        src/org/openbravo/costing/CostingServer.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed issue 35089 and fixed issue 35130:

Fixed build validation when MultipleBP selector is not installed
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$1.class
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$MergedModule.class
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
        
src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed issue 35089 and fixed issue 35130:
Updated execution limits
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
        
src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35089 and related to issue 35130:
Updated execution limits
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
        
src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35089 and related to issue 35130:
Fixed db consistency after merge
        src-db/database/sourcedata/AD_TEXTINTERFACES.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35089 and related to issue 35130:
Added net.sf.jasperreports.export.xls.detect.cell.type property to properly 
export numbers in Excel
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleXLS.jrxml
        src/org/openbravo/erpCommon/ad_reports/CashflowForecastExcel.jrxml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35089 and related to issue 35130:

Build Validation shows a warning when Multi Business Partner Selector module is 
detected as orphan
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$1.class
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$MergedModule.class
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
        
src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35089 and related to issue 35130:

Added missed subclasses .class files
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$1.class
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$MergedModule.class

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35089 and related to issue 35130:

Declare merge for modules:
* Aging Balance Report
* Cashflow Forecast Report

Added buildvalidation to check:
1. Both merged modules are not inside modules folder
2. There are no modules in the instance that depend on any of the merged modules
        
src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
        
src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java
        modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_MERGE.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35089: code review improvements
Fixed amounts format in XLS views
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailXLS.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleXLS.jrxml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35130: code review improvements

Fixed db consistency.
Reused core's messages instead of creating new ones.
Deleted 2 jrxml files that are not needed.
Properly set menu entry for new report.
Fixed issue that hid the first record in HTML/PDF view (not XLS).
Usage of AMOUNTFORMAT and patternExpression based on it.
Removed useless SQL queries in JRXML files.
Make Strings in reports translatable.
Several jasper UI improvements: padding, link behavior, borders...
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_TEXTINTERFACES.xml
        src-db/database/sourcedata/AD_TREENODE.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_REPORT.xml
        
src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java
        src/org/openbravo/common/actionhandler/CashflowForecast_data.xsql
        src/org/openbravo/erpCommon/ad_reports/CashflowForecast.jrxml
        src/org/openbravo/erpCommon/ad_reports/CashflowForecastExcel.jrxml
        src/org/openbravo/erpCommon/ad_reports/CashflowForecastLines.jrxml
        src/org/openbravo/erpCommon/ad_reports/CashflowForecastLinesByDate.jrxml
        src/org/openbravo/erpCommon/ad_reports/CashflowForecastSummary.jrxml
        src/org/openbravo/erpCommon/ad_reports/FinaccDetailByDate.jrxml
        src/org/openbravo/erpCommon/ad_reports/FinaccDetailMain.jrxml

    Rafael Queralta Pozo <rquera...@nauta.cu> null
    Fixed issue 35130: Merged Cashflow Forecast Report into Core
        src-db/database/model/functions/C_CONVERT_DOC_CURRENCY.xml
        
src/org/openbravo/common/actionhandler/CashflowForecastReportActionHandler.java
        src/org/openbravo/common/actionhandler/CashflowForecast_data.xsql
        src/org/openbravo/erpCommon/ad_reports/CashflowForecast.jrxml
        src/org/openbravo/erpCommon/ad_reports/CashflowForecastExcel.jrxml
        src/org/openbravo/erpCommon/ad_reports/CashflowForecastLines.jrxml
        src/org/openbravo/erpCommon/ad_reports/CashflowForecastLinesByDate.jrxml
        src/org/openbravo/erpCommon/ad_reports/CashflowForecastSummary.jrxml
        src/org/openbravo/erpCommon/ad_reports/FinaccDetailByDate.jrxml
        src/org/openbravo/erpCommon/ad_reports/FinaccDetailMain.jrxml
        src-db/database/sourcedata/AD_MENU.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_TEXTINTERFACES.xml
        src-db/database/sourcedata/AD_TREENODE.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_PROCESS.xml
        src-db/database/sourcedata/OBUIAPP_REPORT.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 35089: code review improvements

Simplified exception management.
Fixed execution of PDF and XLS in details view.
Transform index to partial index for not null values.
Fixed DB consistency.
Renamed Day One/Two/... by Group One/Two/...
Use AMOUNTFORMAT instead of NUMBERFORMAT.
Removed useless parameters.
Retrieved @basedesign@ from ReportingUtils.
        src-db/database/model/tables/FIN_DOUBTFUL_DEBT.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_TEXTINTERFACES.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_REPORT.xml
        
src/org/openbravo/common/actionhandler/AgingBalanceReportActionHandler.java
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailHTML.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailPDF.jrxml
        
src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailPDFDoubtfulDebt.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailXLS.jrxml
        
src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailXLSDoubtfulDebt.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleHTML.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingSchedulePDF.jrxml
        
src/org/openbravo/erpCommon/ad_reports/AgingSchedulePDFDoubtfulDebt.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleXLS.jrxml

    Nono Carballo <nono...@gmail.com> null
    Fixed issue 35089: Merged Aging Balance Report into Core

The following actions has been made

- Dependencies to 2.5 were removed.
- Reports in PDF and XLS format were taken from the module and left unchanged.
- Reports in HTML format were modified to allow navigation between reports
  and export to PDF and XLS format.
- Functions AGING_GETDOCNO, AGING_INVOICECURRENCY_RATE, AGING_ISDOUBTFULTDEBT 
and
  AGING_PAYMENTCURRENCY_RATE were renamed to FIN_AGING_GETDOCNO,
  FIN_AGING_INVOICECURRENCY_RATE, FIN_AGING_ISDOUBTFULTDEBT and
  FIN_AGING_PAYMENTCURRENCY_RATE, and updated the file AgingDao_data.xsql,
  where were calles.
- An index on column FIN_PAYMENT_SCHEDULE_ID was added to table 
FIN_DOUBTFUL_DEBT
- Two new Process Definitions were added, one for Payables Aging Schedule Report
  and other for Receivables Aging Schedule Report; defined parameters, default
  values and validation rules for each one.
- Two new menu entries were created to invoke the Process Definition.
- A new action handler was created (AgingBalanceReportActionHandler), extending
  BaseReportActionHandler, holding the logic to process both reports.
        src-db/database/model/functions/FIN_AGING_GETDOCNO.xml
        src-db/database/model/functions/FIN_AGING_INVOICECURRENCY_RATE.xml
        src-db/database/model/functions/FIN_AGING_ISDOUBTFULTDEBT.xml
        src-db/database/model/functions/FIN_AGING_PAYMENTCURRENCY_RATE.xml
        src-db/database/sourcedata/OBUIAPP_REPORT.xml
        
src/org/openbravo/common/actionhandler/AgingBalanceReportActionHandler.java
        src/org/openbravo/erpCommon/ad_reports/AgingDao.java
        src/org/openbravo/erpCommon/ad_reports/AgingDao_data.xsql
        src/org/openbravo/erpCommon/ad_reports/AgingData.java
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailHTML.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailPDF.jrxml
        
src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailPDFDoubtfulDebt.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailXLS.jrxml
        
src/org/openbravo/erpCommon/ad_reports/AgingScheduleDetailXLSDoubtfulDebt.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleHTML.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingSchedulePDF.jrxml
        
src/org/openbravo/erpCommon/ad_reports/AgingSchedulePDFDoubtfulDebt.jrxml
        src/org/openbravo/erpCommon/ad_reports/AgingScheduleXLS.jrxml
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
        src-db/database/model/tables/FIN_DOUBTFUL_DEBT.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_MENU.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_REF_LIST.xml
        src-db/database/sourcedata/AD_TEXTINTERFACES.xml
        src-db/database/sourcedata/AD_TREENODE.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_PROCESS.xml
        src-db/database/sourcedata/OBUISEL_SELECTOR.xml
        src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml

    Mark <markm...@gmail.com> null
    Fixes issue 34993: Update the invoice prepayment amount with correct value
if after create from a paid order line, it updates the line net amount to 0
or it changes from 0 to a another value.

If you create the invoice line from a paid order line, and then the line net 
amount
changes it value to 0 (by updating qty = 0 or price = 0, for instance), then
previously prepayment was remaining instead of be discarded. So, you may have an
invoice with Total Gross Amount of 0 and a prepayment different than 0.

When you are updating a line with a NEW line net amount = 0 or deleting the 
line,
it is needed to remove the prepayment of this line from the invoice.

If the OLD line net amount was zero (the prepayment was removed or not taken 
into
account when creating or updating the line) and it changes
to a non-zero new line net amount value, is necessary take into account the 
prepaid
order line amount to increase the invoice prepayment amount with its value.

In any other case it is not necessary update the prepayment amount of the 
invoice.
        src-db/database/model/triggers/C_INVOICELINE_TRG2.xml

    Asier Lostalé <asier.lost...@openbravo.com> null
    related with bug 20515: OBCriteria creates contention at JVM

  Same fix for missing createCriteria with alias.
        src/org/openbravo/dal/service/OBDal.java

    Armaignac <collazoan...@gmail.com> null
    Fix for issue 35129: Calculate Standard Costs check records from other 
clients

The Calculate Standar Costs Process was checking records from other clients for
a missing client check in the process

The client check was add in the process in order to get the current client 
records
        src-db/database/model/functions/MA_STANDARD_COST.xml

    Martin Taal <martin.t...@openbravo.com> null
    Fixes issue 35326: Support basic authentication
Return 401 status code when authentication fails
        src/org/openbravo/base/secureApp/HttpSecureAppServlet.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    fixes issue 35313: documents were not being attached after send them by 
e-mail

The CoreAttachImplementation class is deleting the original report file after 
completing the upload process. When attaching a document using the e-mail 
pop-up this is done before attaching the document into the e-mail. This 
explains why the document was not being received on the e-mail.

To avoid this problem, now a copy of the original document is sent to the 
AttachImplementationManager, this way the original file will never be deleted 
by an upload process handler.

Together with this, now when attaching a document after printing (not by 
e-mail) we have to delete the original file because in other case it will be 
kept on disk.
        src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
        
src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java

    Atul Gaware <atul.gaw...@openbravo.com> null
    Fixes Issue 34987:Not possible to post a payment in that has used as
payment method one which uses the “Leave as credit” execution process.

In Leave As Credit execution process added fin payment schedule detail
and fin payment detail for credit amount in case of payment in/out
with negative amount.
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/executionprocess/LeaveAsCredit.java

    Armaignac <collazoan...@gmail.com> null
    Fixes issue 35252: General Ledger filter changes with pagination in JE 
Report

Selected General Ledger filter value changes when pagination is executed in the
Journal Entries report

The General Ledger filter is not kept in the session to make use in the 
pagination.
For the solution, was saved the General Ledger Filter in the session every time
the search is executed (FIND action). By default, if there is any GL in the
session, the GL field will use the defaulted for the selected org. When 
paginating
always is used the account schema id stored in the session.
        src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed bug 35284, fixed bug 35297, fixed bug 35296

  dbsourcemanager.jar including fixes for these 3 issues.
        src-db/database/lib/dbsourcemanager.jar

    Stefan Hühner <stefan.hueh...@openbravo.com> null
    fixed issue 35303: Skip junit test if any module shipping grid configuration

The SortingFilteringGridConfiguration rely on the grid config setting being not 
modified for:
  private static final String BUSINESS_PARTNER_TAB_ID = "220";
  private static final String BUSINESS_PARTNER_CATEGORY_FIELD_ID = "3955";

If any grid config module is installed which modify those the tests can no 
longer work.
        
src-test/src/org/openbravo/test/views/SortingFilteringGridConfiguration.java




Last 20 lines of the console output:

[...truncated 4543 lines...]
+++ b/modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_FIELD.xml 
Sat Feb 25 14:40:58 2017 +0000
--- 
a/modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_FIELD.xml
    Fri Feb 24 14:36:27 2017 +0100
+++ 
b/modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_FIELD.xml
    Sat Feb 25 14:40:58 2017 +0000
--- 
a/modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_FIELD.xml
  Fri Feb 24 14:36:27 2017 +0100
+++ 
b/modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_FIELD.xml
  Sat Feb 25 14:40:58 2017 +0000
--- 
a/modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_FIELD.xml
      Fri Feb 24 14:36:27 2017 +0100
+++ 
b/modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_FIELD.xml
      Sat Feb 25 14:40:58 2017 +0000
--- 
a/modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_FIELD.xml
 Fri Feb 24 14:36:27 2017 +0100
+++ 
b/modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_FIELD.xml
 Sat Feb 25 14:40:58 2017 +0000
--- a/src-db/database/model/tables/AD_PROCESS_RUN.xml   Fri Feb 24 14:36:27 
2017 +0100
+++ b/src-db/database/model/tables/AD_PROCESS_RUN.xml   Sat Feb 25 14:40:58 
2017 +0000
-        <whereClause><![CDATA[AD_PROCESS_RUN_GROUP_ID IS NOT 
NULL]]></whereClause>
--- a/src-db/database/sourcedata/AD_FIELD.xml   Fri Feb 24 14:36:27 2017 +0100
+++ b/src-db/database/sourcedata/AD_FIELD.xml   Sat Feb 25 14:40:58 2017 +0000
+ exit 1
Build step 'Execute shell' marked build as failure
Checking console output
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
Openbravo-builds@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-builds

Reply via email to