int-gui-pgsql - Build # 2129 - Failure:
Check console output at https://ci.openbravo.com/job/int-gui-pgsql/2129/ to
view the results.
Committers since last success:
Changes for Build #2129
Mark <[email protected]> null
Fixes issue 35664: Improved performance of Add Multiple Payments P&E grid
Improved performance when load payments P&E grid from Add multiple payments
process.
Added a new index on status column of fin_payment table to improve the load of
P&E grid.
src-db/database/model/tables/FIN_PAYMENT.xml
Carlos Aristu <[email protected]> null
related to issue 35386: updated revision control number
src/org/openbravo/erpCommon/security/Login.html
web/js/utils.js
Carlos Aristu <[email protected]> null
fixes issue 35386: Login page needs some clean up
Carlos Aristu <[email protected]> null
[login-perf] redirectWhenPopup function is still needed
The redirectWhenPopup function is still needed when opening a pop-up from an
old 2.50 manual window having the session expired. In this case, this function
allows to close the pop-up and redirect to the login page properly.
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Prevent errors being inside an iframe
When rendering the login page with the new changes (without the frames) inside
an iframe, the 'Blocked a frame with origin' security message was being thrown.
Now this error is preventing by catching it and managing it properly for the
case of being inside an iframe.
web/js/utils.js
Carlos Aristu <[email protected]> null
[login-cleanup] Minor cleanup in html page
src/org/openbravo/erpCommon/security/Login.html
Carlos Aristu <[email protected]> null
[login-cleanup] MenuData class is not referenced anymore
src/org/openbravo/erpCommon/utility/Menu_data.xsql
Carlos Aristu <[email protected]> null
[login-cleanup] Prevent form resubmission after login
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Removed text interfaces no longer needed
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
Carlos Aristu <[email protected]> null
[login-cleanup] Removed html and xml files no longer needed
src/org/openbravo/erpCommon/security/Login_F0.html
src/org/openbravo/erpCommon/security/Login_F0.xml
src/org/openbravo/erpCommon/security/Login_F1.html
src/org/openbravo/erpCommon/security/Login_F1.xml
src/org/openbravo/erpCommon/security/Login_Logo.html
src/org/openbravo/erpCommon/security/Login_Logo.xml
src/org/openbravo/erpCommon/security/Login_Options_F1.html
src/org/openbravo/erpCommon/security/Login_Options_F1.xml
src/org/openbravo/erpCommon/security/Login_Welcome.html
src/org/openbravo/erpCommon/security/Login_Welcome.xml
Carlos Aristu <[email protected]> null
[login-cleanup] Added class javadoc and improved method name
src/org/openbravo/erpCommon/security/Menu.java
Carlos Aristu <[email protected]> null
[login-cleanup] Vertical Menu cleanup, removing 2.50 user part
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
src/org/openbravo/erpCommon/utility/VerticalMenu.html
src/org/openbravo/erpCommon/utility/VerticalMenu.java
src/org/openbravo/erpCommon/utility/VerticalMenuLoading.html
web/js/utils.js
web/skins/Default/Openbravo_ERP_250.css
src/org/openbravo/erpCommon/ad_forms/Role.html
src/org/openbravo/erpCommon/ad_forms/Role.java
src/org/openbravo/erpCommon/ad_forms/Role.xml
web/skins/Default/Menu/ToolBar/iconLogout.disabled.png
web/skins/Default/Menu/ToolBar/iconLogout.png
Carlos Aristu <[email protected]> null
[login-cleanup] Vertical Menu cleanup, removing 2.50 Alert classes and
mapping
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
src/org/openbravo/erpCommon/ad_forms/AlertManagement.html
src/org/openbravo/erpCommon/ad_forms/AlertManagement.java
src/org/openbravo/erpCommon/ad_forms/AlertManagement.xml
Carlos Aristu <[email protected]> null
[login-cleanup] Vertical Menu cleanup, removing 2.50 Alert part
src/org/openbravo/erpCommon/utility/VerticalMenu.html
web/js/utils.js
web/skins/Default/Openbravo_ERP_250.css
web/skins/Default/Menu/ToolBar/iconAlert.disabled.png
web/skins/Default/Menu/ToolBar/iconAlert.png
web/skins/Default/Menu/ToolBar/iconAlertActive.disabled.png
web/skins/Default/Menu/ToolBar/iconAlertActive.png
Carlos Aristu <[email protected]> null
[login-cleanup] Vertical Menu cleanup, removed images/styles not longer
needed
web/skins/Default/Openbravo_ERP_250.css
web/skins/Default/Menu/ToolBar/iconContract.disabled.png
web/skins/Default/Menu/ToolBar/iconUser.disabled.png
Carlos Aristu <[email protected]> null
[login-cleanup] Vertical Menu cleanup
src/org/openbravo/erpCommon/utility/Menu_data.xsql
src/org/openbravo/erpCommon/utility/VerticalMenu.html
src/org/openbravo/erpCommon/utility/VerticalMenu.java
web/js/utils.js
web/skins/Default/Openbravo_ERP_250.css
src/org/openbravo/erpCommon/utility/VerticalMenu_data.xsql
web/skins/Default/Menu/ToolBar/iconContract.png
web/skins/Default/Menu/ToolBar/iconExpand.png
Carlos Aristu <[email protected]> null
[login-cleanup] Obtain user name from OBContext instead of doing a query
src/org/openbravo/erpCommon/utility/Menu_data.xsql
src/org/openbravo/erpCommon/utility/VerticalMenu.java
Carlos Aristu <[email protected]> null
[login-cleanup] Removed unused methods
src/org/openbravo/erpCommon/utility/Utility.java
src/org/openbravo/erpCommon/utility/Utility_data.xsql
Carlos Aristu <[email protected]> null
[login-cleanup] Added comment
Added a comment to explain that once this handler is executed, a redirection to
the base URL is done. After this redirection, the AuthenticationManager takes
care of the final actions before logging out definitively
modules/org.openbravo.client.application/src/org/openbravo/client/application/LogOutActionHandler.java
Carlos Aristu <[email protected]> null
[login-cleanup] Removed Home servlet
The Home servlet was used for initial page in 2.50 right side, it shouldn't be
accessible anymore, so it can be deleted together with all related styles,
messages and images which are only being used by this servlet.
src-db/database/sourcedata/AD_MESSAGE.xml
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
web/skins/Default/Openbravo_ERP_250.css
src/org/openbravo/erpCommon/utility/Home.html
src/org/openbravo/erpCommon/utility/Home.java
src/org/openbravo/erpCommon/utility/Home.xml
web/skins/Default/Login/communityBrandingBackground.png
web/skins/Default/Login/communityBrandingBottom.png
web/skins/Default/Login/communityBrandingTop.png
Carlos Aristu <[email protected]> null
[login-cleanup] Removed xml:lang attribute
The xml:lang attribute can be removed, as it is applied within documents that
use an XHTML doctype.
src/org/openbravo/erpCommon/security/Login.html
Carlos Aristu <[email protected]> null
[login-cleanup] Moved inline code that can be cached
src/org/openbravo/erpCommon/security/Login.html
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Merge with pi
Carlos Aristu <[email protected]> null
[login-cleanup] Allow automatic record navigation after login
src/org/openbravo/base/secureApp/LoginHandler.java
Carlos Aristu <[email protected]> null
[login-cleanup] Do not need to set forceLogin during login process
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelServlet.java
Carlos Aristu <[email protected]> null
[login-cleanup] Apply correct format
src-trl/src/org/openbravo/translate/RTLSkin.java
Carlos Aristu <[email protected]> null
[login-cleanup] Add RTL support in loginStyles css file
src-trl/src/org/openbravo/translate/RTLSkin.java
Carlos Aristu <[email protected]> null
[login-cleanup] Merge with pi
Carlos Aristu <[email protected]> null
[login-cleanup] Use JSON.parse instead of eval
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Added missing style for clean cache screen
modules/org.openbravo.userinterface.skin.250to300Comp/web/org.openbravo.userinterface.skin.250to300Comp/skins/250to300Comp/loginStyles.css
Carlos Aristu <[email protected]> null
[login-cleanup] Better organization of functions
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Removed obsolete language tag
src/org/openbravo/erpCommon/security/Login.html
Carlos Aristu <[email protected]> null
[login-cleanup] Moved required code from ajax.js to login.js
src/org/openbravo/erpCommon/security/Login.html
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Moved required code from appStatus.js to login.js
src/org/openbravo/erpCommon/security/Login.html
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Moved required code from shortcuts.js to login.js
src/org/openbravo/erpCommon/security/Login.html
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Added required style
modules/org.openbravo.userinterface.skin.250to300Comp/web/org.openbravo.userinterface.skin.250to300Comp/skins/250to300Comp/loginStyles.css
Carlos Aristu <[email protected]> null
[login-cleanup] Do not need to calculate target
As the login page is not shown inside a frame anymore, parent.frameMenu will
always return null. Therefore the target will be always '_self'
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Clean js functions no longer needed
When the session has expired, now with the redirectWhenInsideMDI function is
enough to show the Login page.
src/org/openbravo/erpCommon/security/Login.html
web/js/login.js
Carlos Aristu <[email protected]> null
[login-cleanup] Moved Javascript code used in login page into a new js file
web/js/login.js
src/org/openbravo/erpCommon/security/Login.html
web/js/shortcuts.js
Carlos Aristu <[email protected]> null
[login-cleanup] Moved login styles into a single css file
modules/org.openbravo.userinterface.skin.250to300Comp/web/org.openbravo.userinterface.skin.250to300Comp/skins/250to300Comp/loginStyles.css
src/org/openbravo/erpCommon/security/Login.html
Carlos Aristu <[email protected]> null
[login-cleanup] Complete javadoc information
src/org/openbravo/erpCommon/businessUtility/Preferences.java
Carlos Aristu <[email protected]> null
[login-cleanup] Removed method and variables which are no longer needed
src/org/openbravo/erpCommon/utility/Utility.java
Carlos Aristu <[email protected]> null
[login-cleanup] Merge with pi
Carlos Aristu <[email protected]> null
[login-cleanup] Avoid redirection to /security/Menu.html on login
After login the LoginHandler does not redirect to /security/Menu.html anymore.
Before this change, the StartPage preference was calculated after that
redirection. Now the preference is calculated in the LoginHandler itself.
Together with this, the Preferences API has been increased with the ability to
provide the default filters (active, readable clients and readable orgs) to
look for the desired preference. This was needed because the retrieval of the
StartPage preference in the LoginHandler was being done with the system user
context.
src/org/openbravo/base/secureApp/LoginHandler.java
src/org/openbravo/erpCommon/businessUtility/Preferences.java
Carlos Aristu <[email protected]> null
[login-cleanup] Keep redirect when command is FORCE_NAMED_USER
Do the redirect if the command is FORCE_NAMED_USER. This means that we are
doing a login with a user that already has an existing session active having a
license that prevents multiple sessions for the same user.
In this case, we perform a redirect directly as at this point the login
response has already been handled in the client.
src/org/openbravo/base/secureApp/LoginHandler.java
Carlos Aristu <[email protected]> null
[login-cleanup] Removed redirection as login result
Since now always a JSON object is returned with the login result
src/org/openbravo/base/secureApp/LoginHandler.java
Carlos Aristu <[email protected]> null
[login-cleanup] Prevent login failure when entering an empty user name
Now after entering an empty user name, the LoginHandler returns an error
message which is captured property in the client.
src/org/openbravo/base/secureApp/LoginHandler.java
Carlos Aristu <[email protected]> null
[login-cleanup] Removed redirect to /security/Menu.html after login
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
Carlos Aristu <[email protected]> null
Removed redirect to Log.html after logout
To validate this changeset, it has been checked that the login page continues
being shown properly in the followin scenarios:
1) After a logout
2) When the session is expired, and a manual window (old 2.50 style) is opened.
3) When the session is expired, and a button is clicked on a process pop-up
(for example, the Order Post process).
4) When the session is expired, and the alert ping is fired.
src-core/src/org/openbravo/base/ConfigParameters.java
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
src-db/database/sourcedata/AD_MODEL_OBJECT_PARA.xml
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
src/org/openbravo/authentication/AuthenticationManager.java
src/org/openbravo/base/secureApp/ErrorConnection.java
src/org/openbravo/erpCommon/security/Login.html
src/org/openbravo/erpCommon/utility/Log.html
src/org/openbravo/erpCommon/utility/Log.java
src/org/openbravo/erpCommon/utility/Log.xml
Carlos Aristu <[email protected]> null
[login-cleanup] Updated copyright year
src/org/openbravo/erpCommon/security/Menu.java
Carlos Aristu <[email protected]> null
[login-cleanup] Prevent showing 2.50 menu
When the Startpage preference was defined with an empty value, the 2.50 menu
was being shown after login. This has been solved by doing the proper redirect
in that case.
src/org/openbravo/erpCommon/security/Menu.java
Carlos Aristu <[email protected]> null
[login-cleanup] Removed extra request, about:blank shows an empty page
src/org/openbravo/erpCommon/security/Login_FS_RTL.html
Carlos Aristu <[email protected]> null
[login-cleanup] Clean frames from Login page
src/org/openbravo/erpCommon/security/Login.java
Carlos Aristu <[email protected]> null
[login-cleanup] Check command is only for 2.50, removing code that handles
it
src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
Carlos Aristu <[email protected]> null
[login-cleanup] Removed unused constant
src/org/openbravo/erpCommon/utility/Utility.java
Carlos Aristu <[email protected]> null
[login-cleanup] Removed redirect to old mobile login version
src/org/openbravo/erpCommon/security/Login.java
Carlos Aristu <[email protected]> null
[login-cleanup] Updated method name
src/org/openbravo/erpCommon/security/Login.java
Carlos Aristu <[email protected]> null
[login-cleanup] Remove code to show 2.50 login page
src/org/openbravo/erpCommon/security/Login.java
Inigo Sanchez <[email protected]> null
Fixed issue 35622: EntityAccessChecker Perfomance Improvements project
This project aims to group a set of tasks and improvements that will applied to
the
EntityAccessChecker with the objective of improving the performance of this
process.
Asier Lostalé <[email protected]> null
[improvements-eac] removed some clutter
src/org/openbravo/dal/security/EntityAccessChecker.java
Asier Lostalé <[email protected]> null
[improvements-eac] javadoc
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] codereview: improve legibility creating constants.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] codereview: added javadoc
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] codereview: it's redundant to check for contains
Being processes a Set it's redundant to check for contains before adding
elements.
Besides a comment is removed.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] codereview: return a Set instead of a List.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] codereview: use a generic variable in all queries.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] targetTablesIds should be filtered properly
The info cached in targetTablesIds should be filtered by table of the column
instead of the table of the selector. Before these last fixes, the info in
targetTablesIds is not filtered properly by mistake. Now it has been fixed.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] fixed a typo
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] Merge with pi.
Inigo Sanchez <[email protected]> null
[improvements-eac] Create a generic method.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] Avoid unnecessary creation of objects using hql.
src/org/openbravo/dal/security/EntityAccessChecker.java
Inigo Sanchez <[email protected]> null
[improvements-eac] Calculate static permissions in a static block.
The static queries (Not dependent on the current role) can be executed one time
per
instance of EntityAccessChecker class. In order to achieve this, the queries
have
been moved to a static block of code.
Before this changeset, the queries in the database filtered the information
based on
certain parameters. Now this filter should be applied in the java part instead
of in
the database.
src/org/openbravo/dal/security/EntityAccessChecker.java
Last 20 lines of the console output:
[...truncated 1281 lines...]
[junit] Apr 06, 2017 7:13:20 PM
org.openqa.selenium.remote.ProtocolHandshake createSession
[junit] INFO: Attempting bi-dialect session, assuming Postel's Law holds
true on the remote end
[junit] Apr 06, 2017 7:13:27 PM
org.openqa.selenium.remote.ProtocolHandshake createSession
[junit] INFO: Detected dialect: OSS
[junit] Apr 06, 2017 7:13:27 PM org.openqa.selenium.remote.Augmenter
extractRemoteWebDriver
[junit] WARNING: Augmenter should be applied to the instances of
@Augmentable classes or previously augmented instances only
[junit]
BUILD FAILED
/srv/ci/workspace/int-gui-pgsql/SANDBOX/automation/pi/build.xml:326: The
following error occurred while executing this line:
/srv/ci/workspace/int-gui-pgsql/SANDBOX/automation/pi/build.xml:77: Test
com.openbravo.test.integration.erp.testsuites.guiunit.LoginSuccessFailSuite
failed
Total time: 5 minutes 15 seconds
Build step 'Execute managed script' marked build as failure
Recording test results
Archiving artifacts
Checking \] ERROR|\] WARN
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds