int-dummy-pgsql - Build # 1848 - Failure:
Check console output at https://ci.openbravo.com/job/int-dummy-pgsql/1848/ to
view the results.
Committers since last success:
Changes for Build #1848
Mark <[email protected]> null
Related to issue 34676: Code review improvements
Reordered conditions in where clause.
src-db/database/sourcedata/OBUISEL_SELECTOR.xml
Atul Gaware <[email protected]> null
Fixes Issue 34676:It is possible to see prices for list prices for
organizations that you don't have access to.
Problem is Organization property of Product Price in the Product Price By
Warehouse view is not checked whether it appears in Natural Tree of the
Current Logged in Organization.
src-db/database/sourcedata/OBUISEL_SELECTOR.xml
Alvaro Ferraz <[email protected]> null
Related to issue 35590: Code review improvements
Update modulescript limits.
Apply code format in modulescript.
Move ADOrgTreeTest test to same package as Ad_isorgincludedTest test.
src-test/src/org/openbravo/test/db/model/functions/ADOrgTreeTest.java
src-test/src/org/openbravo/test/AllAntTaskTests.java
src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateADOrgTree.class
src-util/modulescript/src/org/openbravo/modulescript/PopulateADOrgTree.java
src-test/src/org/openbravo/test/IsOrgIncluded/ADOrgTreeTest.java
Víctor Martínez Romanos <[email protected]> null
Related to issue 35590: Applied code review feedback
Deactivated performance tests as they might create false positives in CI
servers.
Removed info message in module script as the tests show the time to finish the
script is good enough (around 10 minutes for 700 orgs)
src-test/src/org/openbravo/test/IsOrgIncluded/ADOrgTreeTest.java
src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateADOrgTree.class
src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateADOrgTreeData.class
src-util/modulescript/src/org/openbravo/modulescript/PopulateADOrgTree.java
Víctor Martínez Romanos <[email protected]> null
Related to issue 35590: Added sampledata. Manage install.source in
modulescript
Ensure the module script is executed on install.source to control the scenario
where a sampledata module is installed.
The module script won't add duplicate lines to AD_Org_Tree in case of sampledata
referencedata/sampledata/F_B_International_Group/AD_ORG_TREE.xml
referencedata/sampledata/QA_Testing/AD_ORG_TREE.xml
src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateADOrgTree.class
src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateADOrgTreeData.class
src-util/modulescript/src/org/openbravo/modulescript/PopulateADOrgTree.java
src-util/modulescript/src/org/openbravo/modulescript/PopulateADOrgTree_data.xsql
Víctor Martínez Romanos <[email protected]> null
Related to issue 35590: Removed AD_ORG_TREE sampledata
and execute module script on install.source
This changeset should be reverted when creating sampledata for 3.0PR17Q3
src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateADOrgTree.class
src-util/modulescript/src/org/openbravo/modulescript/PopulateADOrgTree.java
referencedata/sampledata/F_B_International_Group/AD_ORG_TREE.xml
referencedata/sampledata/QA_Testing/AD_ORG_TREE.xml
Víctor Martínez Romanos <[email protected]> null
Related to issue 35590: Added new testChildOrgValidation
Removed useless flush()
src-test/src/org/openbravo/test/IsOrgIncluded/ADOrgTreeTest.java
Víctor Martínez Romanos <[email protected]> null
Related to issue 35590: Added tests to AllAntTaskTests
src-test/src/org/openbravo/test/AllAntTaskTests.java
Víctor Martínez Romanos <[email protected]> null
Fixed issue 35590: AD_IsOrgIncluded performance improvements
Created AD_Org_Tree table to store the plain parent organization tree.
The unique constraint defined in this table is the key to get the performance
improvement.
This table is populated when the organization is set as ready. In that moment
we ensure its parent organization tree won’t change anymore in the future.
The AD_IsOrgIncluded function has been totally rewritten to read the
AD_Org_Tree table, so there is no need to recursively iterate over the
AD_TreeNode table anymore.
Important: after this changeset the AD_IsOrgIncluded function will only work
for organizations set as ready!
A new AD_IsOrgIncluded_TreeNode is created as a copy of the previous
AD_IsOrgIncluded code to be used only by the processes working with non ready
organizations.
The Set as Ready process (AD_ORG_READY) has been updated to use this legacy
function when required.
A new module script PopulateADOrgTree.java has been developed to populate the
new table for existing instances.
Sampledata has been updated too.
A set of automatic tests have been created to ensure the function returns the
same values after the refactor, and that we get a real performance improvement.
The improvement heavily depends on the organization tree structure (the more
levels the better it will perform), parameters (the farther the passed orgs are
the better it will perform) and query/table over the function is called from
(the bigger table the better it will perform). In local testings we get
improvements from 2,70x to 200x
referencedata/sampledata/F_B_International_Group/AD_ORG_TREE.xml
referencedata/sampledata/QA_Testing/AD_ORG_TREE.xml
src-db/database/model/functions/AD_ISORGINCLUDED_TREENODE.xml
src-db/database/model/tables/AD_ORG_TREE.xml
src-test/src/org/openbravo/test/IsOrgIncluded/ADOrgTreeTest.java
src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateADOrgTree.class
src-util/modulescript/build/classes/org/openbravo/modulescript/PopulateADOrgTreeData.class
src-util/modulescript/src/org/openbravo/modulescript/PopulateADOrgTree.java
src-util/modulescript/src/org/openbravo/modulescript/PopulateADOrgTree_data.xsql
src-db/database/model/functions/AD_ISORGINCLUDED.xml
src-db/database/model/functions/AD_ORG_CHK_CALENDAR.xml
src-db/database/model/functions/AD_ORG_READY.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_DATASET_TABLE.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_TABLE.xml
src-test/src/org/openbravo/test/db/model/functions/Ad_isorgincludedTest.java
Last 20 lines of the console output:
[...truncated 1995 lines...]
[junit] Driver info: driver.version: unknown
[junit] at <anonymous
class>.anonymous(http://127.0.0.1/int-dummy-pgsql/ line 69 > Function:1)
[junit] at <anonymous
class>.handleEvaluateEvent(http://127.0.0.1/int-dummy-pgsql/:69)
[junit] 2017-04-10 19:42:50,438 [main] INFO
com.openbravo.test.integration.erp.testscripts.OpenbravoERPTest - Save the
screenshot.
[junit] 2017-04-10 19:42:50,450 [main] ERROR
com.openbravo.test.integration.erp.testscripts.OpenbravoERPTest - ** The test
has finished with 'Failed' status. Closing Selenium Instance **
[junit] 2017-04-10 19:42:50,757 [main] INFO
com.openbravo.test.integration.erp.testscripts.OpenbravoERPTest - ** End of
test execution @Test: userShouldLogInAndLogOut **
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
83.947 sec
BUILD FAILED
/srv/ci/workspace/int-dummy-pgsql/SANDBOX/automation/pi/build.xml:350: The
following error occurred while executing this line:
/srv/ci/workspace/int-dummy-pgsql/SANDBOX/automation/pi/build.xml:77: Test
com.openbravo.test.integration.erp.modules.ci.Upgrade_FSSuite failed
Total time: 1 minute 42 seconds
Build step 'Execute managed script' marked build as failure
Recording test results
Archiving artifacts
Checking \] ERROR|\] WARN
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
