int-api - Build # 2984 - Fixed:
Check console output at https://ci.openbravo.com/job/int-api/2984/ to view the
results.
Committers since last success:
Changes for Build #2983
Carlos Aristu <[email protected]> null
fixes issue 35164: AuthenticationManager.username thread unsafe
Two threads accessing to the same servlet could change the value of the user
name variable, which could lead to store wrong information into the AD_Session
table. This problem has been fixed by using a ThreadLocal variable to ensure
that each thread has each own value for the user name.
Besides some methods have been refactored in order to centralize and improve
code readability. We are now setting the user name just in one place in the
AuthenticationManager.
Finally the DefaultAuthenticationManager has been updated accordingly in
order to set the user name using the inherited ThreadLocal variable.
src/org/openbravo/authentication/AuthenticationManager.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
Changes for Build #2984
Stefan Hühner <[email protected]> null
Fixed 36818. Merge back project doing a lot more src-wad unused code
removal.
This merges back the pi-wad-cleanup2 branch doing follow up cleanup for 17q2
change which removed support to compile old style 2.50 windows.
Asier Lostalé <[email protected]> null
[wad-cleanup] removed useless and malformatted comment
src-wad/src/org/openbravo/wad/Wad.java
Asier Lostalé <[email protected]> null
[wad-cleanup] removed no-op branch
src-wad/src/org/openbravo/wad/Wad.java
Asier Lostalé <[email protected]> null
[wad-cleanup] use foreach to loop on array
src-wad/src/org/openbravo/wad/Wad.java
Asier Lostalé <[email protected]> null
[wad-cleanup] error message in English
src-wad/src/org/openbravo/wad/Wad.java
Asier Lostalé <[email protected]> null
[wad-cleanup] reformat java
src-wad/src/org/openbravo/wad/Wad.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove another unused template entry
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.xml
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove more unused template entries + setParameter calls.
src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.xml
src-wad/src/org/openbravo/wad/ActionButton_Responser.xml
src-wad/src/org/openbravo/wad/ComboReloadsProcess.xml
src-wad/src/org/openbravo/wad/ComboReloadsProcessHelper.xml
src-wad/src/org/openbravo/wad/Template_ActionButton.xml
src-wad/src/org/openbravo/wad/WadActionButton.java
src-wad/src/org/openbravo/wad/controls/WADDateXML.xml
src-wad/src/org/openbravo/wad/controls/WADNumber.java
Stefan Hühner <[email protected]> null
[wad-cleanup] cleanup unused entries in webConf & webParams control files
src-wad/src/org/openbravo/wad/Wad.java
src-wad/src/org/openbravo/wad/webConf.xml
src-wad/src/org/openbravo/wad/webParams.xml
Stefan Hühner <[email protected]> null
[wad-cleanup] cleanup unused elements from javasource.xml
Patched xmlEngine found a number of:
a.) Unused entries in javasource.xml control file
b.) a few setParameters calls for elements in javasource.xml which don't exist
Clean those up.
src-wad/src/org/openbravo/wad/Wad.java
src-wad/src/org/openbravo/wad/javasource.xml
Stefan Hühner <[email protected]> null
[wad-cleanup] Simplify checking if windows has no tabs with level=0
Only usage left of allTabs[] in processTab is to check if there are none
at all. Simplify code accordingly:
- getPrimaryTabs -> remove getSubTabs usage
- as caller only checks length<>0 the initial select is enough
as if it has 0 rows -> getSubTabs was never called anyway.
And if it has >0 rows that is sufficient already for the caller.
- remove getSubTabs functions + its related SqlMethod
- getPrimaryTabs -> inline into only caller processTab
- SqlMethod selectTabParent, simplify just keeping result count as relevant
output
src-wad/src/org/openbravo/wad/Tabs_data.xsql
src-wad/src/org/openbravo/wad/Wad.java
src/org/openbravo/erpCommon/businessUtility/AuditTrailPopup_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove some unused SqlMethod
src-wad/src/org/openbravo/wad/Tabs_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove now unused columnIdentifier from WADControl &
subclasses
That method is unused after previous cleanup: remove it. Also remove all code
which was only used by that method. That allows also to reduce visibility of
WadUtility class from public to package local.
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorData.xsql
src-wad/src/org/openbravo/wad/Fields_data.xsql
src-wad/src/org/openbravo/wad/WadUtility.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADID.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADTable.java
src-wad/src/org/openbravo/wad/controls/WADTableDir.java
src-wad/src/org/openbravo/wad/TableRelation_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove not needed calls to WADControl.columnIdentifier.
After last commit the outParams of those calls as no longer used. Remove
them. Also allows removal of two 2 unused method in WadUtility:
- getWadComboReloadContext
- getWadcomboReloadContextTranslate
src-wad/src/org/openbravo/wad/Wad.java
src-wad/src/org/openbravo/wad/WadUtility.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused parts of ComboReloads code generation.
The following element of the ComboReloadsProcess.xml file as never used in the
ComboReloadsProcess.javaxml file:
- fieldTableName1 aka tablename
- fieldTableName2 aka tablenametrl
- fieldMethod1 aka htmltext
- fieldMethod2 aka htmltexttrl
- fieldSelectFields1 aka xmltext
- fieldSelectFields2 aka xmltexttrl
Remove them from the ComboReloadsProcess.xml structure definition.
Also remove setting them in the FieldProvider[][] in Wad.processComboReloads.
src-wad/src/org/openbravo/wad/ComboReloadsProcess.xml
src-wad/src/org/openbravo/wad/Wad.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused isLink from subclass missed in earlier commit
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorPrimitive.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused WadUtility.columnIdentifier + whole EFD xsql
file.
src-wad/src/org/openbravo/wad/WadUtility.java
src-wad/src/org/openbravo/wad/EditionFields_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused getDefaultValue from WADControl + all subclasses
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADInteger.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADYesNo.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused getDisplayLogic from WADControl + all subclasses
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADInteger.java
src-wad/src/org/openbravo/wad/controls/WADLink.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADString.java
src-wad/src/org/openbravo/wad/controls/WADText.java
src-wad/src/org/openbravo/wad/controls/WADTime.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused getReadOnlyLogicColumn from WADControl +
subclasses
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove 3 more unused methods from WADControl and all
subclasses:
- isLink
- isText
- getLinkColumn Id
- this allows removal of now unused WADTable_data.xsql file also
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorData.xsql
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADSearch_data.xsql
src-wad/src/org/openbravo/wad/controls/WADTable.java
src-wad/src/org/openbravo/wad/controls/WADTableDir.java
src-wad/src/org/openbravo/wad/controls/WADYesNo.java
src-wad/src/org/openbravo/wad/controls/WADTable_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused processSelCol from WADControl 6 all subclasses
also remove now unused utility method isSearchValueColumn
src-wad/src/org/openbravo/wad/WadUtility.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADDateTime.java
src-wad/src/org/openbravo/wad/controls/WADInteger.java
src-wad/src/org/openbravo/wad/controls/WADMemo.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADString.java
src-wad/src/org/openbravo/wad/controls/WADTime.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused getSQLCasting from WADControl and all subclasses
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADDateTime.java
src-wad/src/org/openbravo/wad/controls/WADInteger.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADTime.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove 2 unused functions from WADControl and all subclasses.
Removes:
- addAdditionDefaulSQLFields
- addAdditionDefaulJavaFields
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused has2UIFields from WADControl and all subclasses.
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADTable.java
src-wad/src/org/openbravo/wad/controls/WADTableDir.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused toJava from WADControl and all subclasses.
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADDateTime.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADImageBLOB.java
src-wad/src/org/openbravo/wad/controls/WADLink.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADMemo.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADString.java
src-wad/src/org/openbravo/wad/controls/WADTime.java
src-wad/src/org/openbravo/wad/controls/WADYesNo.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove processTable from WADControl + all sub-classes.
processTable function in Wad was the only code calling those functions.
As that is removed in previous code all this code here is not obsolete.
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADID.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADMemo.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADTable.java
src-wad/src/org/openbravo/wad/controls/WADTableDir.java
src-wad/src/org/openbravo/wad/controls/WADText.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove processTable as its output is never used.
In prior wad cleanup all uses of the several Vector<Object> which
are out-parameter of the processTable function have been already removed.
Remove the call + the function itself. That allows some further cleanup of
more now unused utility functions.
Now unsed Fields_data.xsql select method was first in its file so is converted
into a dummy function (as SqlC only uses first function to get field names)
src-wad/src/org/openbravo/wad/Fields_data.xsql
src-wad/src/org/openbravo/wad/Wad.java
Stefan Hühner <[email protected]> null
[wad-cleanup] More unused code removal in processTab
Several variables were calculated but no longer used remove them.
That allows to also remove 2 xsql methods in Fields_data.xsql.
Those are copied into runtime accessible AuditTrailPopup_data.xsql
'linked' via sourcecode comment to keep in sync.
As the wad copy is now gone remove that comment.
src-wad/src/org/openbravo/wad/Fields_data.xsql
src-wad/src/org/openbravo/wad/Wad.java
src/org/openbravo/erpCommon/businessUtility/AuditTrailPopup_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] tab1 + tab2 arrays were never read -> remove them.
src-wad/src/org/openbravo/wad/Wad.java
Last 20 lines of the console output:
[...truncated 487 lines...]
Total: 100% good
Error Summary:
Errors:
+ exit 0
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : cp
/srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java.japi.gz .
[int-api] $ /bin/bash -xe /tmp/hudson533949461034526428.sh
+ cp /srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java.japi.gz .
POST BUILD TASK : SUCCESS
END OF POST BUILD TASK : 0
Archiving artifacts
Checking console output
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
