up-2.50topi-oracle - Build # 204 - Fixed:
Check console output at https://ci.openbravo.com/job/up-2.50topi-oracle/204/ to
view the results.
Committers since last success:
Changes for Build #203
Stefan Hühner <[email protected]> null
Fixed 36818. Merge back project doing a lot more src-wad unused code
removal.
This merges back the pi-wad-cleanup2 branch doing follow up cleanup for 17q2
change which removed support to compile old style 2.50 windows.
Asier Lostalé <[email protected]> null
[wad-cleanup] removed useless and malformatted comment
src-wad/src/org/openbravo/wad/Wad.java
Asier Lostalé <[email protected]> null
[wad-cleanup] removed no-op branch
src-wad/src/org/openbravo/wad/Wad.java
Asier Lostalé <[email protected]> null
[wad-cleanup] use foreach to loop on array
src-wad/src/org/openbravo/wad/Wad.java
Asier Lostalé <[email protected]> null
[wad-cleanup] error message in English
src-wad/src/org/openbravo/wad/Wad.java
Asier Lostalé <[email protected]> null
[wad-cleanup] reformat java
src-wad/src/org/openbravo/wad/Wad.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove another unused template entry
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.xml
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove more unused template entries + setParameter calls.
src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.xml
src-wad/src/org/openbravo/wad/ActionButton_Responser.xml
src-wad/src/org/openbravo/wad/ComboReloadsProcess.xml
src-wad/src/org/openbravo/wad/ComboReloadsProcessHelper.xml
src-wad/src/org/openbravo/wad/Template_ActionButton.xml
src-wad/src/org/openbravo/wad/WadActionButton.java
src-wad/src/org/openbravo/wad/controls/WADDateXML.xml
src-wad/src/org/openbravo/wad/controls/WADNumber.java
Stefan Hühner <[email protected]> null
[wad-cleanup] cleanup unused entries in webConf & webParams control files
src-wad/src/org/openbravo/wad/Wad.java
src-wad/src/org/openbravo/wad/webConf.xml
src-wad/src/org/openbravo/wad/webParams.xml
Stefan Hühner <[email protected]> null
[wad-cleanup] cleanup unused elements from javasource.xml
Patched xmlEngine found a number of:
a.) Unused entries in javasource.xml control file
b.) a few setParameters calls for elements in javasource.xml which don't exist
Clean those up.
src-wad/src/org/openbravo/wad/Wad.java
src-wad/src/org/openbravo/wad/javasource.xml
Stefan Hühner <[email protected]> null
[wad-cleanup] Simplify checking if windows has no tabs with level=0
Only usage left of allTabs[] in processTab is to check if there are none
at all. Simplify code accordingly:
- getPrimaryTabs -> remove getSubTabs usage
- as caller only checks length<>0 the initial select is enough
as if it has 0 rows -> getSubTabs was never called anyway.
And if it has >0 rows that is sufficient already for the caller.
- remove getSubTabs functions + its related SqlMethod
- getPrimaryTabs -> inline into only caller processTab
- SqlMethod selectTabParent, simplify just keeping result count as relevant
output
src-wad/src/org/openbravo/wad/Tabs_data.xsql
src-wad/src/org/openbravo/wad/Wad.java
src/org/openbravo/erpCommon/businessUtility/AuditTrailPopup_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove some unused SqlMethod
src-wad/src/org/openbravo/wad/Tabs_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove now unused columnIdentifier from WADControl &
subclasses
That method is unused after previous cleanup: remove it. Also remove all code
which was only used by that method. That allows also to reduce visibility of
WadUtility class from public to package local.
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorData.xsql
src-wad/src/org/openbravo/wad/Fields_data.xsql
src-wad/src/org/openbravo/wad/WadUtility.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADID.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADTable.java
src-wad/src/org/openbravo/wad/controls/WADTableDir.java
src-wad/src/org/openbravo/wad/TableRelation_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove not needed calls to WADControl.columnIdentifier.
After last commit the outParams of those calls as no longer used. Remove
them. Also allows removal of two 2 unused method in WadUtility:
- getWadComboReloadContext
- getWadcomboReloadContextTranslate
src-wad/src/org/openbravo/wad/Wad.java
src-wad/src/org/openbravo/wad/WadUtility.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused parts of ComboReloads code generation.
The following element of the ComboReloadsProcess.xml file as never used in the
ComboReloadsProcess.javaxml file:
- fieldTableName1 aka tablename
- fieldTableName2 aka tablenametrl
- fieldMethod1 aka htmltext
- fieldMethod2 aka htmltexttrl
- fieldSelectFields1 aka xmltext
- fieldSelectFields2 aka xmltexttrl
Remove them from the ComboReloadsProcess.xml structure definition.
Also remove setting them in the FieldProvider[][] in Wad.processComboReloads.
src-wad/src/org/openbravo/wad/ComboReloadsProcess.xml
src-wad/src/org/openbravo/wad/Wad.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused isLink from subclass missed in earlier commit
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorPrimitive.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused WadUtility.columnIdentifier + whole EFD xsql
file.
src-wad/src/org/openbravo/wad/WadUtility.java
src-wad/src/org/openbravo/wad/EditionFields_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused getDefaultValue from WADControl + all subclasses
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADInteger.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADYesNo.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused getDisplayLogic from WADControl + all subclasses
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADInteger.java
src-wad/src/org/openbravo/wad/controls/WADLink.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADString.java
src-wad/src/org/openbravo/wad/controls/WADText.java
src-wad/src/org/openbravo/wad/controls/WADTime.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused getReadOnlyLogicColumn from WADControl +
subclasses
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove 3 more unused methods from WADControl and all
subclasses:
- isLink
- isText
- getLinkColumn Id
- this allows removal of now unused WADTable_data.xsql file also
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelectorData.xsql
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADSearch_data.xsql
src-wad/src/org/openbravo/wad/controls/WADTable.java
src-wad/src/org/openbravo/wad/controls/WADTableDir.java
src-wad/src/org/openbravo/wad/controls/WADYesNo.java
src-wad/src/org/openbravo/wad/controls/WADTable_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove unused processSelCol from WADControl 6 all subclasses
also remove now unused utility method isSearchValueColumn
src-wad/src/org/openbravo/wad/WadUtility.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADDateTime.java
src-wad/src/org/openbravo/wad/controls/WADInteger.java
src-wad/src/org/openbravo/wad/controls/WADMemo.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADString.java
src-wad/src/org/openbravo/wad/controls/WADTime.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused getSQLCasting from WADControl and all subclasses
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADDateTime.java
src-wad/src/org/openbravo/wad/controls/WADInteger.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADTime.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove 2 unused functions from WADControl and all subclasses.
Removes:
- addAdditionDefaulSQLFields
- addAdditionDefaulJavaFields
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused has2UIFields from WADControl and all subclasses.
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADTable.java
src-wad/src/org/openbravo/wad/controls/WADTableDir.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove unused toJava from WADControl and all subclasses.
modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADDate.java
src-wad/src/org/openbravo/wad/controls/WADDateTime.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADImageBLOB.java
src-wad/src/org/openbravo/wad/controls/WADLink.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADMemo.java
src-wad/src/org/openbravo/wad/controls/WADNumber.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADString.java
src-wad/src/org/openbravo/wad/controls/WADTime.java
src-wad/src/org/openbravo/wad/controls/WADYesNo.java
Stefan Hühner <[email protected]> null
[wad-cleanup] remove processTable from WADControl + all sub-classes.
processTable function in Wad was the only code calling those functions.
As that is removed in previous code all this code here is not obsolete.
src-wad/src/org/openbravo/wad/controls/WADButton.java
src-wad/src/org/openbravo/wad/controls/WADControl.java
src-wad/src/org/openbravo/wad/controls/WADID.java
src-wad/src/org/openbravo/wad/controls/WADImage.java
src-wad/src/org/openbravo/wad/controls/WADList.java
src-wad/src/org/openbravo/wad/controls/WADMemo.java
src-wad/src/org/openbravo/wad/controls/WADSearch.java
src-wad/src/org/openbravo/wad/controls/WADTable.java
src-wad/src/org/openbravo/wad/controls/WADTableDir.java
src-wad/src/org/openbravo/wad/controls/WADText.java
Stefan Hühner <[email protected]> null
[wad-cleanup] Remove processTable as its output is never used.
In prior wad cleanup all uses of the several Vector<Object> which
are out-parameter of the processTable function have been already removed.
Remove the call + the function itself. That allows some further cleanup of
more now unused utility functions.
Now unsed Fields_data.xsql select method was first in its file so is converted
into a dummy function (as SqlC only uses first function to get field names)
src-wad/src/org/openbravo/wad/Fields_data.xsql
src-wad/src/org/openbravo/wad/Wad.java
Stefan Hühner <[email protected]> null
[wad-cleanup] More unused code removal in processTab
Several variables were calculated but no longer used remove them.
That allows to also remove 2 xsql methods in Fields_data.xsql.
Those are copied into runtime accessible AuditTrailPopup_data.xsql
'linked' via sourcecode comment to keep in sync.
As the wad copy is now gone remove that comment.
src-wad/src/org/openbravo/wad/Fields_data.xsql
src-wad/src/org/openbravo/wad/Wad.java
src/org/openbravo/erpCommon/businessUtility/AuditTrailPopup_data.xsql
Stefan Hühner <[email protected]> null
[wad-cleanup] tab1 + tab2 arrays were never read -> remove them.
src-wad/src/org/openbravo/wad/Wad.java
Carlos Aristu <[email protected]> null
fixes issue 35164: AuthenticationManager.username thread unsafe
Two threads accessing to the same servlet could change the value of the user
name variable, which could lead to store wrong information into the AD_Session
table. This problem has been fixed by using a ThreadLocal variable to ensure
that each thread has each own value for the user name.
Besides some methods have been refactored in order to centralize and improve
code readability. We are now setting the user name just in one place in the
AuthenticationManager.
Finally the DefaultAuthenticationManager has been updated accordingly in
order to set the user name using the inherited ThreadLocal variable.
src/org/openbravo/authentication/AuthenticationManager.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
Atul Gaware <[email protected]> null
Fixes issue 36753: Error in Payment Plan after execute a payment
** Use FIN_Utility updatePaymentAmounts method instead of private
updatePaymentAmounts
method in FIN_ExecutePayment to avoid wrong updation of fin_payment_schedule
** Use FIN_Utility updateBusinessPartnerCredit
** Remove break statement
** Removed unused private updatePaymentAmounts method from FIN_ExecutePayment
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java
Inigo Sanchez <[email protected]> null
Fixed issue 36611: Selection is lost when an error is raised removing a
record
When were removing a row and an error was raised (e.g. Deleting a already
processed "Good Shipment" is stopped
by a trigger) the selection of the record was lost. This generates an
inconsistent grid state that creates all
the reported problems.
The problem is fixed by take into account the described situation removing the
deselectAllRecords method because
it has no sense to remove the selection if it is not possible to know if the
removed process ends succesfully.
Now the selection is maintained if the record can't be removed properly.
Now the selection is maintained if the record can't be removed.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Asier Lostalé <[email protected]> null
fixed bug 36788: having some special UTF characters in DS response breaks UI
When a DS response (or any other one that's later evaluated as JavaScript)
includes certain characters, UI breaks.
This is causes because these characters are not valied in JavaScript so when
they are evaluated using eval function, it crashes.
It has been fixed by escaping those characters in client side when the request
arrives just before starting to process it.
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
Carlos Aristu <[email protected]> null
related to issue 35164: initial code improvements
- Reorder the modifiers of the getAuthenticationManager method to comply with
the Java Language Specification
- Created new private constant for "#AD_SESSION_ID"
- Use faster indexOf(char) method
src/org/openbravo/authentication/AuthenticationManager.java
Carlos Aristu <[email protected]> null
fixes bug 35654: module validation fails for killable BG processes using CDI
The DatabaseValidator class uses Class.forName(className) to retrieve the
class of the background processes and then determine if they implement the
KillableProcess interface.
When using that method, the class is also initialized. This initialization
failed in some cases with a java.lang.NoClassDefFoundError if the class was
making use of weld (CDI).
As we don't need to initialize the background process class to determine if it
implements the KillableProcess interface, we replace the usage of
Class.forName(className) with Class.forName(className, false, classLoader).
With the second argument the class initialization is prevented.
src/org/openbravo/service/system/DatabaseValidator.java
Carlos Aristu <[email protected]> null
fixes bug 35944: unresponsive UI after error in
EntityPersistenceEventObserver
When an EntityPersistenceEventObserver failed with an uncaught error (ie.
NPE), the UI became unresponsive after saving. This was happening due to a JS
error when trying to set the error message in the view. Under this
circumstances data can be undefined, and the error was thrown when trying to
access data.data.
That point of code was reached because the error message was not being
handled properly when the message text returned by the server is an empty
string. To fix the problem now we handle it and a generic error message is
shown in this case.
Besides, a security check has been added to ensure that data is not null when
trying to access to data.data.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Carlos Aristu <[email protected]> null
fixes bug 36762: The comparator to sort window personalizations wasn't
complete
Since Java 7 Collections.sort uses TimSort. Using a non-transitive comparator
for sorting in Java >= 7 can throw the following exception:
"java.lang.IllegalArgumentException: Comparison method violates its general
contract!" depending on the comparisons performed by the comparator.
The PersonalizationComparator violated the Comparable contract when checking
the priority by client between two window personalizations to calculate their
position. Now this problem has been solved.
modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java
David Miguelez <[email protected]> null
Fixes Issue 36796. Check that the Inventory Status of the Bin has the
Available flag checked for Goods Shipments and Return To Vendor Shipments
(outgoing warehouse transactions in the M_INOUT_POST)
src-db/database/model/functions/M_INOUT_POST.xml
Carlos Aristu <[email protected]> null
related to issue 36762: minor code clean-up
- Use org.slf4j.Logger to log
- Added an error log message
- Remove unneeded comments
- Use diamond operator
- Updated copyright year
modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java
David Miguelez <[email protected]> null
Fixes Isue 36789. Uses lenght function to know if a String is empty
instead of performing a comparison, which does not work the same
way in Oracle as it does in Postgresql.
src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
src-db/database/model/functions/M_INOUT_POST.xml
src-db/database/model/functions/M_PRODUCTION_RUN.xml
Alvaro Ferraz <[email protected]> null
Related to issue 36705: Code review improvements
Apply same fix in purchase flow.
modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
Mark <[email protected]> null
Fixes issue 36705: More than one pending payment plan detail for same
invoice
payment plan
When the payment schedule details were generated it was comparing the invoiced
amount of related order with the sum of lineNetAmt + taxAmt of it lines, as tax
calculation can be done at document level, and this sum is done at line level it
is possible that exists differences between this sum and totals already rounded
in the invoice.
Also was considered an order completely invoiced if it dosn't has lines with
ordered
quatities different than invoiced. When exists orders with lines with
lineNetAmt = 0
it was taking it as completed invoiced and then the whole amount of the psd was
included
in the invoice and it generates a difference between the total of document and
the sum of the
lines that was created as a new payment schedule detail.
To avoid this situation, only are considered order lines with lineNetAmt
different than zero
to use the whole amount of the psd or to re-calculate the correct amounts from
Payment
Schedule and Payment Schedule Details related to the order and invoices.
modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
Alvaro Ferraz <[email protected]> null
Related to issue 36776: Code review improvements
Retrieve currency standard precision instead of price precision in
selectFromPO, selectFromPOUpdate, selectFromPOUpdateSOTrx and selectPriceList
methods.
Do not round price actual with price precision when calculating line net amount.
Remove unused priceprecision variable.
Use data variable to retrieve currency standard precision when creating invoice
from order and dataAux variable when creating invoice from receipt/shipment.
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
Mark <[email protected]> null
Fixes issue 36776: Amounts in invoice lines and taxes rounded to price
precision
instead of standard precision in Create Lines From process.
In CreateFrom class, the price precision was used for rounding amounts instead
of
standard precision and it was causing differences with totals when invoices were
created from orders or shipments.
Now all prices are rounded with the price precision of it currency and amounts
with standard precision.
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
Atul Gaware <[email protected]> null
Fixes issue 36757: Negative Stock Correction for remaining stock valuation
not done in closing inventory lines (when validating a costing rule)
Add order by clause to sort movement qty desc, material transaction id
src/org/openbravo/costing/CostingRuleProcess.java
Atul Gaware <[email protected]> null
Fixes issue 36760: Error when running a Landing Cost
To avoid org.hibernate.LazyInitializationException Landed Cost Cost Object
is re-initialized
src/org/openbravo/costing/LandedCostProcess.java
Carlos Aristu <[email protected]> null
fixes bug 36763: Audit info not updated when replacing an already attached
file
The audit information (updated, updated by fields) of the attachments was not
being updated after replacing an already attached file. In this case the
OBInterceptor was not being invoked because the information of the attachment
(BaseOBObject) was indeed not changing.
To fix this problem we explicitly change the 'updated' date of the attachment
and the OBInterceptor will take care of update the rest of the audit
information (updated by).
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
Inigo Sanchez <[email protected]> null
Related with the issue 36598: now selectors are working as expected in P&E
Selecting multiple records and opening the process with a selector in the 'P&E'
it is
failing.
The problem has been fixed by take into account this case. Now when the
selector is open
shows records in the tree of all orgs current role has access instead of
records in the
org tree of the last selected record.
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
Mark <[email protected]> null
Fixes issue 36690: Insufficient stock in Create Standards Process of Work
Effort
When Create Standards Process of Work Effort - Production Run tab was executed
if stock is in different priority warehouses, an error message Insufficient
stock
is shown even if there is stock of the product.
Problem was that in M_GET_STOCK_PARAM function v_qtyaux is decreased on each
loop
and v_finalqty is taking into account stock in warehouses of the same priority
than
currently analyzed, when v_qtyaux is updated always is subtracted the sum of
m_stock_proposed lines with priority less or equal than current and it is wrong.
Solution is always compare the requested quantity (v_quantity) with sum of
quantities
from m_stock_proposed lines with priority less or equal than current iteration.
src-db/database/model/functions/M_GET_STOCK_PARAM.xml
Changes for Build #204
RM packaging bot <[email protected]> null
Merge back from main
RM packaging bot <[email protected]> null
Merge temporary head for 3.0PR17Q2.3
RM packaging bot <[email protected]> null
Added signature for changeset 9e6056c0e38e
.hgsigs
RM packaging bot <[email protected]> null
Added tag 3.0PR17Q2.3 for changeset 7fafd2a9f24b
.hgtags
RM packaging bot <[email protected]> null
Update AD_MODULE version to 3.0PR17Q2.3
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
src-db/database/sourcedata/AD_MODULE.xml
Carlos Aristu <[email protected]> null
related to bug 36766: last update not updated when removing description
The last updated information is now updated when the description of an
existing attachment is cleared. This was not happening before, because the
record in the OBUIAPP_Parameter_Value table was removed when the value to be
assigned is null
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
Carlos Aristu <[email protected]> null
related to bug 36766: Update attachment last update when metadata also
changes
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java
Alvaro Ferraz <[email protected]> null
Related to issue 36794: Code review improvements
Retrieve currency standard precision instead of price precision in
selectFromPO, selectFromPOUpdate, selectFromPOUpdateSOTrx and selectPriceList
methods.
Do not round price actual with price precision when calculating line net amount.
Remove unused priceprecision variable.
Use data variable to retrieve currency standard precision when creating invoice
from order and dataAux variable when creating invoice from receipt/shipment.
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
Mark <[email protected]> null
Fixes issue 36794: Amounts in invoice lines and taxes rounded to price
precision
instead of standard precision in Create Lines From process.
In CreateFrom class, the price precision was used for rounding amounts instead
of
standard precision and it was causing differences with totals when invoices were
created from orders or shipments.
Now all prices are rounded with the price precision of it currency and amounts
with standard precision.
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
Carlos Aristu <[email protected]> null
fixes bug 36766: Audit info not updated when replacing an already attached
file
The audit information (updated, updated by fields) of the attachments was not
being updated after replacing an already attached file. In this case the
OBInterceptor was not being invoked because the information of the attachment
(BaseOBObject) was indeed not changing.
To fix this problem we explicitly change the 'updated' date of the attachment
and the OBInterceptor will take care of update the rest of the audit
information (updated by).
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
Carlos Aristu <[email protected]> null
fixes bug 36739: Can't use fields based on some properties in selector
picklist
With the fix for issue #36268 the selector fields based on derived properties
that are shown in the picklist are sent as 'extra properties' in order to
calculate them properly.
The problem is that the fix was not complete when the derived properties were
not primitive. In that case the DataToJsonConverter class was not calculating
properly the referenced property.
Now that kind of properties are calculated properly.
modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
Alvaro Ferraz <[email protected]> null
Related to issue 36668: Update copyright
src/org/openbravo/erpCommon/ad_callouts/SL_Movement_Product.java
Mark <[email protected]> null
Fixes issue 36668: Wrong quantity in inventory lines
* Send quantities as BigDecimal instead of String.
* Remove unnecessary displaylogic() execute.
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Locator.java
src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Movement_Product.java
Augusto Mauch <[email protected]> null
Fixes issue 36725: Check role write access to organization of parent record
If the current role does not have writable access to the record selected in a
tab, the user should not be allowed to create records in its subtabs.
Now this is taken into account in order to enable/disable the toolbar buttons
that create new records, and also in the logic that creates a link to create
new records in a tab if the gr
id is currently empty.
Now it will not be possible to enter records in a subtab if:
- The subtab has an editable organization field
- The user's role does not have writable access to the organization of the
record selected in the parent tab.
Now the list of the current role of the user writable organizations is
available in OB.User.writableOrganizations.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ApplicationDynamicComponent.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-dynamic-js.ftl
Carlos Aristu <[email protected]> null
related to issue 36854: code review improvements
- Do not use getters for the private inner class: use attributes directly
- Do not need to initialize treeId to null
src/org/openbravo/erpCommon/utility/WindowTree.java
Carlos Aristu <[email protected]> null
fixes bug 36854: Can't see classic tree view without access to
AD_TAB/AD_TREE
- The AD_Tab and AD_Tree information is now retrieved using the admin mode
- The code has been refactored to avoid duplication: now that information is
retrieved once instead of doing it three times
src/org/openbravo/erpCommon/utility/WindowTree.java
Carlos Aristu <[email protected]> null
related to issue 36854: initial code clean-up
- Use diamond operator
- Can use StringBuilder instead of StringBuffer
- Log error into the log instead of into the standard output
- Fix typo
src/org/openbravo/erpCommon/utility/WindowTree.java
Carlos Aristu <[email protected]> null
fixes bug 35357: Timeout error message displayed in the UI is not user
readable
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MESSAGE.xml
Alvaro Ferraz <[email protected]> null
Related to issue 36856: Code review improvements
src-db/database/model/functions/C_INVOICE_POST.xml
Atul Gaware <[email protected]> null
Fixes issue 36856: No data found error when completing a invoice
No data found error when completing a invoice in
organization without legal accounting in oracle instance
Avoid no data exception in oracle using a null value check for value
returned by AD_ORG_GETCALENDAROWNER
src-db/database/model/functions/C_INVOICE_POST.xml
Carlos Aristu <[email protected]> null
related to issue 36834: added TODO comment
modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
Asier Lostalé <[email protected]> null
fixed 36857: invalid js generated if \u2028 or \u2029 chars are in recent
docs
Implemented temporary fix until freemarker gets updated. Dynamic js resources
now escape those special characters.
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/SessionDynamicResourceComponent.java
Inigo Sanchez <[email protected]> null
Fixes issue 36137: Config scripts are not applied on install.source
The problem was that config scripts could not be applied on install source task
at the same way
that update.database task. The problem was in ImportSampledata because this
task was not be able
to load the database model applying the config script files. Now this problem
has been fixed
because ImportSampledata task read the database model from xml taking into
account any model
changes defined in the configScript files.
Besides, it have been implemented new model changes unsupported till now:
RemoveTriggerChange,
RemoveIndexChange, ColumnRequiredChange and RemoveCheckChange.
This fix introduced also some important changes:
-DBSMOBUtil.loadDataStructures method is not executed
DBSMOBUtil.applyConfigScripts anymore.
-AlterDatabaseDataAll.readDatabaseModel method is take into account model
changes defined in
configScript files while reading the model from XML files.
-CreateXML2SQL task is take into account model changes defined in configScript
files.
-ImportSampledata task is take into account model changes defined in
configScript files.
-Now CheckAPIDistribution task is take into account model changes defined in
configScript files.
src-db/database/lib/dbsourcemanager.jar
Asier Lostalé <[email protected]> null
fixed bug 36855: license refresh is requested to butler too often
Prevented refreshal for:
- First login after Tomcat restart
- In case butler detected license didn't change
src/org/openbravo/erpCommon/obps/ActivationKey.java
Alvaro Ferraz <[email protected]> null
Related to issue 36789: Code review improvements
Initialize variables with null instead of an empty string and then check if
variable is not null.
Thus, we avoid problems in Oracle if we check if length('') = 0.
See: https://issues.openbravo.com/view.php?id=36789#c98858
src-db/database/model/functions/MA_STANDARD_COST.xml
src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
src-db/database/model/functions/M_GET_OFFERS_NAME.xml
src-db/database/model/functions/M_INOUT_POST.xml
src-db/database/model/functions/M_PRODUCTION_RUN.xml
src-db/database/sourcedata/AD_AUXILIARINPUT.xml
src-db/database/sourcedata/AD_COLUMN.xml
Mark <[email protected]> null
Fixes issue 36707: Price List Schema is not working in a "hierarchical" way
Price List Schema with several lines was not working in a "hierarchical" way,
because every time it was processing a new M_DiscountSchemaLine it was deleting
the previously calculated product prices, and it always save the last
calculation
taking the last line of the price list version as basis.
To fix that, only are removed previously calculated product prices that will be
regenerated at start of the process for the Price List Version being processed.
And these product prices only are removed and inserted once, the first time the
discount will be applied. For next discounts, product prices will be updated
using
previously calculated prices.
This way, apply several lines of the Price List Schema will be executed
sequencially:
first is applied the discounts for the first line and all prices calculated will
be the basis for the next one to apply, this process until all lines be applied.
src-db/database/model/functions/M_PRICELIST_CREATE.xml
Carlos Aristu <[email protected]> null
related to issue 36834: Use correct test name in test suites
src-test/src/org/openbravo/test/AllAntTaskTests.java
src-test/src/org/openbravo/test/AllTests.java
src-test/src/org/openbravo/test/AntTaskTests.java
Carlos Aristu <[email protected]> null
fixes issue 36834: js defaults containing Dates fail in JRE8
In Java 8 JavaScript engine was changed from Rhino to Nashorn. JavaScript
Dates evaluated in server, returned a java.util.Date in Rhino, but with Nashorn
they are evaluated to jdk.nashorn.internal.objects.NativeDate.
This change caused a ClassCastException in JRE8 when invoking the methods of
OBBindings which receive a java.util.Date as an argument. To fix the problem
those methods have been overloaded by receiving an Object as argument.
Therefore these methods will be invoked when working with JRE8, and we use
reflection to retrieve the time information avoiding using classes which are
not supported in JRE7.
modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
Carlos Aristu <[email protected]> null
related to issue 36834: Removed unneeded test
src-test/src/org/openbravo/test/expression/OBBindingsTest.java
Carlos Aristu <[email protected]> null
related to issue 36834: Added test case for OBBindings
src-test/src/org/openbravo/test/expression/OBBindingsTest.java
src-test/src/org/openbravo/test/AllAntTaskTests.java
src-test/src/org/openbravo/test/AllTests.java
src-test/src/org/openbravo/test/AntTaskTests.java
Alvaro Ferraz <[email protected]> null
Related to issue 36814: Use partial index
src-db/database/model/tables/FACT_ACCT.xml
Alvaro Ferraz <[email protected]> null
Backed out changeset b7b5576137de
src-db/database/model/tables/FACT_ACCT.xml
Alvaro Ferraz <[email protected]> null
Related to issue 36789: Use partial index
src-db/database/model/tables/FACT_ACCT.xml
Atul Gaware <[email protected]> null
Fixes issue 36814: Customer Statement process takes long
Add index for c_bpartner_id column in fact_acct table
src-db/database/model/tables/FACT_ACCT.xml
Carlos Aristu <[email protected]> null
related to bug 36763: last update not updated when removing description
The last updated information is now updated when the description of an
existing attachment is cleared. This was not happening before, because the
record in the OBUIAPP_Parameter_Value table was removed when the value to be
assigned is null
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
Alvaro Ferraz <[email protected]> null
Related to issue 36736: Use normal db in direct Journal Entries Report
Use normal db in Journal Entries Report only when it is launched just after
posting a document.
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournalDetail.java
Alvaro Ferraz <[email protected]> null
Related to issue 36736: Apply again changes in Journal Entries Report
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournalDetail.java
Carlos Aristu <[email protected]> null
related to issue 35164: use correct param name in javadoc
src/org/openbravo/authentication/AuthenticationManager.java
Carlos Aristu <[email protected]> null
related to issue 35164: code review improvements
- Initialize the ThreadLocal variable (loginName) on every call to
authenticate. Thus, we ensure that its value is cleaned up when Tomcat reuses a
thread.
- Use new UserLoginInfo to keep the login credentials instead of using a map.
src/org/openbravo/authentication/AuthenticationManager.java
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
Miguel de Juana <[email protected]> null
Related to issue 0035058: it is possible to return twice the same receipt
- Backout changeset 5c0c3e9c06ff
- We won't need a new column in ImportEntry because we will look for ids inside
the json
src-db/database/model/tables/C_IMPORT_ENTRY.xml
src-db/database/model/tables/C_IMPORT_ENTRY_ARCHIVE.xml
src-db/database/sourcedata/AD_COLUMN.xml
src/org/openbravo/service/importprocess/ImportEntryManager.java
Asier Lostalé <[email protected]> null
fixed bug 36824: false DB modified positive detected after compile.complete
compile.compile marks all entries in ad_textinterfaces as not used to later,
mark the actually used ones (while parsing) as used.
As this is part of source data, audit fields shoudln't be updated by this
process, other way, those records will be detected as modified after last
update preventing next one to occur.
src-trl/src/org/openbravo/translate/Translate_data.xsql
David Miguelez <[email protected]> null
Related to issue 36813. Changed visibility of method to private
since it should be called from getNumberOfTotalVirutalBins and
getNumberOfActiveVirtualBins public methods instead.
src/org/openbravo/erpCommon/utility/InventoryStatusUtils.java
Carlos Aristu <[email protected]> null
related to bug 36763: Update attachment last update when metadata also
changes
modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java
David Miguelez <[email protected]> null
Fixes Issue 36813. Changed API
* Added new boolean parameter to funciton
* Created two new functions to call the original one without the boolean
parameter
* Changed save by a flush to avoid problems when the Hibernate session
is cleared
src/org/openbravo/erpCommon/utility/InventoryStatusUtils.java
David Miguelez <[email protected]> null
Fixes Issue 36812. Shows Conversion Tab under Unit of Measure Window
when UOM Management Preference is enabled.
modules/org.openbravo.v3/src-db/database/configScript.xml
src-db/database/sourcedata/AD_TAB.xml
Last 20 lines of the console output:
[...truncated 4423 lines...]
Connected to:
Oracle Database 11g Release 11.2.0.1.0 - 64bit Production
SQL>
Call completed.
SQL> Disconnected from Oracle Database 11g Release 11.2.0.1.0 - 64bit Production
+ run_ora_command 'column object_name format a32
SELECT object_id, object_name, object_type FROM user_objects WHERE
status<>'\''VALID'\'' AND object_type IN('\''VIEW'\'', '\''PACKAGE'\'',
'\''PACKAGE BODY'\'', '\''FUNCTION'\'', '\''PROCEDURE'\'', '\''TRIGGER'\'',
'\''JAVA CLASS'\'') ORDER BY object_type, object_name;'
+ ssh [email protected]
Pseudo-terminal will not be allocated because stdin is not a terminal.
+ grep -q OBJECT_ID /tmp/int-dbcons-oracle_objects
+ true
+ exit 0
Checking console output
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
