up-2.50topi-oracle - Build # 211 - Fixed:
Check console output at https://ci.openbravo.com/job/up-2.50topi-oracle/211/ to
view the results.
Committers since last success:
Changes for Build #210
Carlos Aristu <[email protected]> null
fixes bug 37109: Blank "Default Edit Mode" tab on direct child record
opening
Having a tab configured to be opened in edit mode by default, it was being
shown in blank after direct opening a record present in one of its child tabs.
The problem was that in such scenario the standard viewForm was not being
loaded (prepared).
To fix the problem when opening the child record, the parent tab is marked to
force the opening of the parent record in form view once its data has arrived.
Note that this is just done when the parent tab is configured to be opened in
edit mode by default.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Asier Lostalé <[email protected]> null
fixed bug 37112: incorrect HQL to retrieve preferences
Removed extra unbalanced parentheses when organization parameter is null.
src/org/openbravo/erpCommon/businessUtility/Preferences.java
Augusto Mauch <[email protected]> null
Related with issue 37103: Unneeded change is backed out
The change done in .classpath was not meant to be pushed.
src-db/database/lib/dbsourcemanager.jar
Augusto Mauch <[email protected]> null
Fixes issue 37103: import.sample.data fails if a file cannot be imported
If a file cannot be imported the import.sample.data process will stop
immediately and will show log describing the problem.
To be able to catch the exceptions thrown in another thread, now the logic to
import files is wrapped in a Callable instead of a Runnable.
src-db/database/lib/dbsourcemanager.jar
Inigo Sanchez <[email protected]> null
Fixed issue 36838: multiple requests to load product image are performed
The problem was that multiple requests were performed when it shouldn't. When a
product had an image, multiple
requests were being performed when the product was beeing displayed in form
view and a refresh was being done.
Another problem discovered in the research of the issue was that a request was
being performed when return from
FormView to the GridView. This request should not be performed because images
are not showed in the grid view.
Both problems have been fixed by take into account when a request should be
performed to retrieve an image. When
the image is loaded previously, the setValue of the ob-formitem-image avoids to
performed an unnecessary request
to the server.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-image.js
Carlos Aristu <[email protected]> null
fixes issue 37093: Do not open default edit view if the record is not loaded
When the data arrives to an standard grid it tries to open the edit mode of
the view in case it has to. But if the data is being loaded just in that
moment, the edit mode should not be opened because it will cause javascript
errors as there is no data available to be shown.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
Alejandro <[email protected]> null
Fixes issue 32236: Process Monitor Duration field shows wrong data
Process Monitor Duration field was showing wrong data if the process lasts more
than 24 hours. When calculating the amount of hours that a process lasted, the
formula was designed in such a way that when the hours were bigger than 24, it
got
resseted to 0, so, for example, if the amount of hours were 30, it was showing
6 instead.
src/org/openbravo/scheduling/ProcessMonitor.java
Carlos Aristu <[email protected]> null
fixes bug 37055: RO pool not closed when used in thread out of
DalThreadHandler
Regular threads used in HTTP requests are encanpsulated inside
DalThreadHandler which eventually takes care of closing the opened database
sessions before the thread ends. But threads not encapsulated inside
DalThreadHandler are not taking into account the scenario of having multiple
sessions (pools) opened. They are just closing the default pool. Thus, this
issue affects:
a) ImportEntryProcessRunnable, which delegates into its subclasses the
ability of handling the transaction commit/rollback. But just in case the
subclasses does not handle it, the ImportEntryProcessRunnable should take care
of closing all the opened sessions before ending (if any). This way its
behavior will be the same as those threads running inside DalThreadHandler.
b) DalBaseProcess, this class was neither taking into account the possibility
of opening multiple pools during its execution. Now, all the opened database
sessions are closed if the process has been marked to close the default
database connection before ending.
src/org/openbravo/dal/core/SessionHandler.java
src/org/openbravo/service/db/DalBaseProcess.java
src/org/openbravo/service/importprocess/ImportEntryProcessor.java
Carlos Aristu <[email protected]> null
related to issue 37055: initial code clean up
- Use diamond operator
- In ImportEntryProcessRunnable class declaration, reorder the modifiers to
comply with the Java Language Specification
- Use && instead of &
src/org/openbravo/service/importprocess/ImportEntryProcessor.java
Changes for Build #211
Inigo Sanchez <[email protected]> null
Related with issue 36838: multiple requests to load product image are
performed
The problem was that multiple ShowImage requests were performed when it
shouldn't.
Now, the problem is fixed by take into account when the image has been loaded
previously. In this case,
the setValue of the ob-formitem-image avoids to performed an unnecessary
request to the server.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-image.js
Atul Gaware <[email protected]> null
Fixes Issue 37090: Error when processing payment generating credit and
business partner
has no currency defined
Before APRM_CreditCurrency check in AddPaymentOnProcessActionHandler,
check whether currency of business partner is null and raise
InitBPCurrencyLnk error message
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentOnProcessActionHandler.java
Asier Lostalé <[email protected]> null
related to bug 37153: removed unneded if nesting
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-tab.js
Carlos Aristu <[email protected]> null
fixes bug 37153: Do not show tab sets when they have all of its tabs hidden
When double-clicking on a tab, its child tab set was always being shown. In
case all the tabs in the child tab set were hidden (because of their respective
display logics), then the child tab set was being displayed empty.
To prevent this error, now in that case, the child tab set is displayed when
any of its tabs should be visible. Otherwise, the child tab set will not be
displayed.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-tab.js
Asier Lostalé <[email protected]> null
related to bug 36605: unneeded datasource requests in alert management
window
Removed unneeded parameter in getSectionHeader.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-management-view.js
Inigo Sanchez <[email protected]> null
Related with the issue 36605: Refresh is not working as expected
Refresh is not working as expected in Alert Management window. The problem was
that a
partial solution of the issue was pushed by mistake. Now the problem of the
refresh is
fixed. When a refresh is launched, 4 request are performed (one for each
status).
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-management-view.js
Asier Lostalé <[email protected]> null
related to bug 37135: updated Licensing.txt
legal/Licensing.txt
Asier Lostalé <[email protected]> null
fixed bug 37135: OOM parsing corrupted JSON
Backported jettison changesets to 1.3 version to solve this issue [1] and [2].
Code for patched library can be found at [3].
---
[1]
https://github.com/alostale/jettison/commit/b5df5afdff6987839f912780ad0fc9c0b0847f7f
[2]
https://github.com/alostale/jettison/commit/83e804177eb19ec258481a23ffe30c3fa2f43ba4
[3] https://github.com/alostale/jettison
lib/runtime/jettison-1.3-patched.jar
lib/runtime/jettison-1.3.jar
David Miguelez <[email protected]> null
Fixes Issue 37119. Sets correct Organization in new Invoice line
* If the organization of the original invoice line belongs to the child
tree of the organization of the document header of the new line,
use the organization of the original invoice line
* If not, use the organization of the document header of the new line
src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
Inigo Sanchez <[email protected]> null
Fixed issue 36605: unneeded datasource requests opening alert management
window
The problem was when Alert Management window was opened, 10 requests to
datasource were performed.
In order to improve this situation, several actions have been done. Firts, the
4 calls of the datasource
definition are removed. Now, the datasource is defined statically. Thisthat
Alert Management window is
not working good. Also, two of the duplicate request are removed.
Besides, when the Alert Management window is closed and the four grids are
removed, now the datasources
are destroyed too in order to avoid having several instances for the same
datasources every time that
Alerts windowd is reopened. Now, every grid removes their own datasource.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-management-view.js
David Miguelez <[email protected]> null
Related to Issue 37033. Code Review changes
* Take into account correct quantity when calculating the expected unit cost
* Use correct quantity to calculate Transaction Cost Difference
src/org/openbravo/costing/PriceDifferenceProcess.java
Nono Carballo <[email protected]> null
Fixes issue 37033: "Price Difference Correction" adjustment calculated when
it
should not
Cost adjustment is created just if expected unitary cost excedes transaction
unitary cost.
src/org/openbravo/costing/PriceDifferenceProcess.java
David Miguelez <[email protected]> null
Fixes Issue 37010. In the loop that goes through each
Non Deductuable Tax, the Orderlines are retrieved.
However, this lines must be filtered to retrieve only the ones
that use the Tax that is being looped. If not, all the lines
will be used for all the taxes and then duplicated data will appear
src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
src/org/openbravo/erpCommon/ad_forms/DocLineInvoice_data.xsql
Last 20 lines of the console output:
[...truncated 4406 lines...]
Connected to:
Oracle Database 11g Release 11.2.0.1.0 - 64bit Production
SQL>
Call completed.
SQL> Disconnected from Oracle Database 11g Release 11.2.0.1.0 - 64bit Production
+ run_ora_command 'column object_name format a32
SELECT object_id, object_name, object_type FROM user_objects WHERE
status<>'\''VALID'\'' AND object_type IN('\''VIEW'\'', '\''PACKAGE'\'',
'\''PACKAGE BODY'\'', '\''FUNCTION'\'', '\''PROCEDURE'\'', '\''TRIGGER'\'',
'\''JAVA CLASS'\'') ORDER BY object_type, object_name;'
+ ssh [email protected]
Pseudo-terminal will not be allocated because stdin is not a terminal.
+ grep -q OBJECT_ID /tmp/int-dbcons-oracle_objects
+ true
+ exit 0
Checking console output
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
