[Openbravo-builds] int-api - Build # 3183 - Fixed!

[jenkins]

int-api - Build # 3183 - Fixed:

Check console output at https://ci.openbravo.com/job/int-api/3183/ to view the 
results.


Committers since last success:

Changes for Build #3182

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Code review improvements

Removed onLoad function on process and use the standard Default Expression at 
field level.
Deleted unnecessary messages
Fixed javadoc in CopyFromOrdersProcessImplementationInterface
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/OBUIAPP_PROCESS.xml
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessFilterExpression.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessImplementationInterface.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: renamed some fields

The button has been renamed to Copy from Orders
The organization field in P&E has been renamed to Legal Entity Organization
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Use Proxy to improve performance
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessFilterExpression.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateOrderLineInformation.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateQuantitiesAndUOMs.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateTax.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: code review improvements

CopyFromOrdersProcess.java:
  Added order by lineNo when retrieving order lines, so we create lines in the 
same order as the original Order.
  Renamed private method to describe better its purpose.

CopyFromOrdersProcessFilterExpression.java:
  Added missed copyright information.
  Moved logic to a separate private method.
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessFilterExpression.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Fixed NPE in some JUnit tests
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_07.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_08.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Avoid overriding setUp()
        
src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Fixed javadoc
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessImplementationInterface.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Hooks are also run for the core's process

This allows a simplification in the code, as it doesn't differenciate between 
internal and external hooks.
Even more, external processes can be injected at any point in the process.

The interface has been extended to provide an execution order for the hooks.

JUnit tests have been adapted:
1. To support CDI with parametrized tests
2. To include all the information required by the test in the 
CopyLinesFromOrdersTestData object itself
        
src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_13.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_14.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_15.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_16.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_17.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_18.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_19.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_20.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPerformance.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_01.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_02.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_03.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_04.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_05.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_06.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_07.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_08.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_21.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_22.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CopyLinesFromOrdersTestData.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessImplementationInterface.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateOrderLineInformation.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdatePricesAndAmounts.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateProductAndAttributes.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateQuantitiesAndUOMs.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateTax.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Renamed package classes
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateOrderLineInformation.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdatePricesAndAmounts.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateProductAndAttributes.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateQuantitiesAndUOMs.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateTax.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateOrderLineInformation.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdatePricesAndAmounts.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateProductAndAttributes.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateQuantitiesAndUOMs.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateTax.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Use standard way to detect UOM Management,
This change fixes issues in Oracle
        
src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Added Copy From Orders tests to AllAntTaskTests
        src-test/src/org/openbravo/test/AllAntTaskTests.java

    Mark <markm...@gmail.com> null
    Related to issue 36466: jUnit Automated Tests for Copy From Orders process
        
src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/BPartnerDataConstants.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestConstants.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_13.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_14.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_15.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_16.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_17.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_18.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_19.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPO_20.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataPerformance.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_01.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_02.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_03.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_04.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_05.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_06.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_07.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_08.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_21.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CLFOTestDataSO_AUM_22.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/CopyLinesFromOrdersTestData.java
        src-test/src/org/openbravo/test/copyLinesFromOrders/data/JSONUtils.java
        src-test/src/org/openbravo/test/copyLinesFromOrders/data/OrderData.java
        
src-test/src/org/openbravo/test/copyLinesFromOrders/data/OrderLineData.java

    Mark <markm...@gmail.com> null
    Related to issue 36466: Fixed operative quantity calculation

Recalculated the operative quantity instead based on the ordered quantity.
The ordered quantity can't be changed because it value:
-Was already calculated based on the operative quantity and the defined 
conversion
 rate if AUM preference was enabled.
-Was defined in the order line and the operative quantity is not defined if the
 AUM preference was not defined.
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateQuantitiesAndUOMs.java

    Mark <markm...@gmail.com> null
    Related to issue 36466: Validate an attribute instance using Attribute 
defined
in the Attribute Use List of the attribute set instead of iterate on
the attribute instances list.
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateProductAndAttributes.java

    Mark <markm...@gmail.com> null
    Related to issue 36466: Avoid NPE when copyFromOrdersProcessHooks isn't 
defined

When the CopyFromOrdersProcess class is instantiated directly, for instance in 
an
automated test, it is possible that copyFromOrdersProcessHooks wasn't 
initialized
and a NPE is thrown due that.
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java

    Mark <markm...@gmail.com> null
    Related to issue 36466: Synchronize Terminology done
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml

    Mark <markm...@gmail.com> null
    Related to issue 36466: JS Beautified.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js

    Mark <markm...@gmail.com> null
    Related to Issue 36466: Removed database references to Copy From Order 
process

Removed other database references for old Copy From Order process in Sample 
datas
        modules/org.openbravo.v3.datasets/referencedata/standard/V3_Roles.xml
        referencedata/sampledata/F_B_International_Group/AD_PROCESS_ACCESS.xml
        referencedata/sampledata/QA_Testing/AD_PROCESS_ACCESS.xml

    David Miguelez <david.migue...@openbravo.com> null
    Related to Issue 36466. Code Review Changes:

* Synchronized Terminology and exported database
* Added new non editable Legal Entity Parameter in Process Definition
  to be able to show Orders for Organizations that belong to that legal entity
* Copy from Orders Process splitted in Handler, Process and classes that 
implement
  the calculations logic
* Copy From Orders Action Handler handles the request and the response and calls
  Copy From Orders Process to perform the logic
* Copy From Orders Process loops through the Orders and through the Order Lines
  and calls the classes that implement the logic for the calculations.
  It also explodes the non-Stocked BOM Products
* Copy From Orders Implementation Interface is the interface that must be
  implemented by the classes that implements the logic for the calculations
* Several classes created to perform the calculations related to amounts, taxes,
  prices, etc
* Added a Hook at the end of Copy From Orders Process
* Fixed wrong prices calculation
* Fixed wrong amounts calculation
* Fixed exception handling
* Added times taken for processing the orders in the log
* Added missing fields when copying OrderLines
        src/org/openbravo/common/actionhandler/CopyFromOrdersActionHandler.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcess.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessFilterExpression.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessImplementationInterface.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateOrderLineInformation.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdatePricesAndAmounts.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateProductAndAttributes.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateQuantitiesAndUOMs.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/CopyFromOrdersProcessUpdateTax.java
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_PROCESS.xml
        src/org/openbravo/common/actionhandler/CopyFromOrders.java

    Mark <markm...@gmail.com> null
    Related to issue 36466: Clean up of old Copy From Order process.

After refactoring the manual Copy From process to the new Copy From Orders 
Process
Definition, all the old process references in the database are deleted. Also 
other
unused files has been removed.
        src-db/database/sourcedata/AD_MODEL_OBJECT.xml
        src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
        src-db/database/sourcedata/AD_PROCESS.xml
        src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.html
        src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.java
        src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.xml
        src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder_data.xsql

    Mark <markm...@gmail.com> null
    Fixes issue 36466: "Copy from order" refactor to Process Definition

Currently the process "Copy From Order" is defined as a manual process and does
not make use of the benefits of Process Definition. The current process logic
was migrated to a new Process Definition, using the Pick and Edit (PE) pattern
in those windows that currently use it.

Was created a new Pick and Execute window. Defined a new tab with the same 
fields
that the old process.

Was created a new Process Definition using previously windows as parameter and
updated all the buttons that were using the "Create From Order" process to use
the new process definition "Create From Orders".

Was created a new action handler to process the selection of the orders. It
iterates through all the selected orders and add their lines to the order that
executes the process.
        src/org/openbravo/common/actionhandler/CopyFromOrders.java
        
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-onchange-functions.js
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_WINDOW.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_PROCESS.xml
        src-db/database/sourcedata/OBUIAPP_REF_WINDOW.xml

Changes for Build #3183

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Updated V3 Roles dataset

Added access to Copy From Orders P&E window
        modules/org.openbravo.v3.datasets/referencedata/standard/V3_Roles.xml
        
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_DATASET.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: modified sampledata

Added access to new process definition
        referencedata/sampledata/F_B_International_Group/AD_WINDOW_ACCESS.xml
        
referencedata/sampledata/F_B_International_Group/OBUIAPP_PROCESS_ACCESS.xml
        referencedata/sampledata/QA_Testing/AD_WINDOW_ACCESS.xml
        referencedata/sampledata/QA_Testing/OBUIAPP_PROCESS_ACCESS.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Related to issue 36466: Updated V3 Roles dataset

Added new process definition to Sales and Finance Roles
        modules/org.openbravo.v3.datasets/referencedata/standard/V3_Roles.xml
        
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_DATASET.xml




Last 20 lines of the console output:

[...truncated 497 lines...]
Total: 100% good

Error Summary:

Errors:
+ exit 0
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script  : cp 
/srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java.japi.gz .
[int-api] $ /bin/bash -xe /tmp/hudson3820079827601405885.sh
+ cp /srv/ci/workspace/int-full-pgsql/SANDBOX/api-checks/output/java.japi.gz .
POST BUILD TASK : SUCCESS
END OF POST BUILD TASK : 0
Archiving artifacts
Checking console output
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
Openbravo-builds@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-builds