up-2.50topi-oracle - Build # 225 - Fixed:
Check console output at https://ci.openbravo.com/job/up-2.50topi-oracle/225/ to
view the results.
Committers since last success:
Changes for Build #220
RM packaging bot <[email protected]> null
Merge back from main
RM packaging bot <[email protected]> null
Merge temporary head for 3.0PR17Q4
RM packaging bot <[email protected]> null
Added signature for changeset 43d95f7cb670
.hgsigs
RM packaging bot <[email protected]> null
Added tag 3.0PR17Q4 for changeset a8b6912d30a3
.hgtags
RM packaging bot <[email protected]> null
Update AD_MODULE version to 3.0PR17Q4
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
src-db/database/sourcedata/AD_MODULE.xml
RM packaging bot <[email protected]> null
Commit to increment the obx version
lib/README
RM packaging bot <[email protected]> null
Commit to increment the obx version
lib/README
RM packaging bot <[email protected]> null
Commit to increment the obx version
lib/README
Antonio Moreno <[email protected]> null
Fixed issue 37420. Added index to improve performance of
C_IMPORT_ENTRY_ARCHIVE deletion.
src-db/database/model/tables/C_IMPORT_ENTRY_ARCHIVE.xml
Atul Gaware <[email protected]> null
Fixes Issue 37456:Change the role in the ERP has performance
problems
** Flush is called before calling fillSessionArguments
** new ConnectionProvider without flush is passed to the
fillSessionArguments method which avoids flush for
every select statement which uses this connection Provider
as flush is not need for select statements.
modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoWidgetActionHandler.java
Carlos Aristu <[email protected]> null
fixes bug 37429: Duplicated DS calls having the tree view shown in a sub-tab
Fix for issue #35545 was intended to force a datasource call when the
fetchData does not perform it. This function has a mechanism that avoids DS
calls when the grid criteria i not being changed.
But when the criteria indeed changes two DS request was being fired: the one
that we are forcing and the other one fired by the fetchData function. To avoid
this problem we are forcing the DS call just when the grid criteria has not
changed.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Carlos Aristu <[email protected]> null
fixes bug 37311: OB created partially in old processes shown in 3.0 windows
With the changes introduced on issue 0035553, the OB object is generated in
two stages: it is initialized when the JS static resources are loaded and
secondly additional session data is included with the SessionDynamic request.
In old processes inside 3.0 windows, a request to load the JS static
resources is done but the SessionDynamic request is not. As a result, the OB
object was generated partially. This caused JS errors when referencing to the
missing data.
To fix this issue, now when we are in an old process loaded inside a 3.0
window, instead of generating the OB object from scratch, it is cloned from the
main OB object of the application which is generated right after logging in.
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
Inigo Sanchez <[email protected]> null
Fixed issue 37293: Deactivated orgs are displayed in the user profile widget
The problem was caused by the "Improve scalability of the login process"
project. When improving the performance
of the query that return the complete organizations list for the current user,
the OBQuery instance used to generate it was
replaced with a Query instance. The first includes by default the filter by is
active.
To fix the problem this filter must be added manually in the query. Now the
problem has been resolved by take into
account this filter. Besides the same problem is detected in other query
related with deactivated warehouses so it is fixed too.
modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/RoleInfo.java
Inigo Sanchez <[email protected]> null
Fixed issue 37281: Deactivated roles are displayed in the user profile
widget
The problem was caused by the "Improve scalability of the login process"
project. When improving the
performance of the query that return the complete role list for the current
user, the OBQuery instance
used to generate it was replaced with a Query instance. The first includes by
default the filter by is
active.
To fix the problem this filter must be added manually in the query. Now the
problem has been resolved
by take into account this filter.
modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoComponent.java
Carlos Aristu <[email protected]> null
related to issue 37261: adapt test cases to the new component's definition
modules/org.openbravo.client.kernel/src-test/org/openbravo/client/kernel/freemarker/test/GenerateComponentTest.java
modules/org.openbravo.client.kernel/src-test/org/openbravo/client/kernel/freemarker/test/LabelTest.java
Carlos Aristu <[email protected]> null
fixes issue 37261: Some labels are not translated after switching the
language
After the changes introduced on issue #35852 the labels were being cached
together with the rest of the static javascript code. Thus, being in an
environment not in "in development" status, the labels were being cached in the
language of the first login avoiding the translation when switching to another
language afterwards.
To fix the problem now the component responsible of collecting the labels has
been defined as a session dynamic component. This way the labels will be
retrieved on every login. And to avoid querying to the database on each login
request, the labels are now being cached in the server per language.
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/I18NComponent.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelComponentProvider.java
David Miguelez <[email protected]> null
Related to Issue 37191. Removes Organization filter.
* Filtering by the Natural Tree of the Organization of the Storage Detail
was not correct, since the Organization given to this function by the
Transaction might not be included in it.
* Since there is a Parameter to filter by Locator, it is not needed
to filter also by Organization (is implicit)
* This Paramter is optional in order to not break the API, but it is
highly recommemded that it is always filled.
src-db/database/model/functions/M_CHECK_STOCK.xml
David Miguelez <[email protected]> null
Related to Issue 37191.
* Fixes check stock method in InventoryCountProcess
* When completing a Goods Movement, do not check stock for Bin To
- It has been checked that only negative stock can be moved to that bin
if the Inventory Status allows over issue
- If it has already negative stock previously, do not check it here
src-db/database/model/functions/M_MOVEMENT_POST.xml
src/org/openbravo/materialmgmt/InventoryCountProcess.java
David Miguelez <[email protected]> null
Fixes Issue 37191. Fixes problem when checking negative
Stock in the system.
* Function m_check_stock filters records by the natural tree of the selected
Organization instead of the Organization itself. This is done due to the
fact that the Organization of the Storage Detail might not be the
same as the Organization of the Bin
* Function m_check_stock has an additional optional parameter, locator_id
This is done to filter the records just by the selected bin
* All PL's of Core that calls the m_check_stock has been adapted to support
the extra parameter
src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
src-db/database/model/functions/M_CHECK_STOCK.xml
src-db/database/model/functions/M_INOUT_POST.xml
src-db/database/model/functions/M_INTERNAL_CONSUMPTION_POST1.xml
src-db/database/model/functions/M_INVENTORY_POST.xml
src-db/database/model/functions/M_MOVEMENT_POST.xml
src-db/database/model/functions/M_PRODUCTION_RUN.xml
Guillermo Alvarez de Eulate <[email protected]> null
Fixed issue 37063 Backport of 36966: Retrieve AttSetIntance JSON info using
PL
-Added PL function to retrieve json details about certain m_attsetinstance_id
src-db/database/model/functions/M_GETJSONDESCRIPTION.xml
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelApplicationInitializer.java
src-db/database/sourcedata/AD_MESSAGE.xml
David Miguelez <[email protected]> null
Fixes Issue 37120. Sets correct Organization in new Invoice line
* If the organization of the original invoice line belongs to the child
tree of the organization of the document header of the new line,
use the organization of the original invoice line
* If not, use the organization of the document header of the new line
src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
Augusto Mauch <[email protected]> null
Fixes issue 37107: import.sample.data fails if a file cannot be imported
If a file cannot be imported the import.sample.data process will stop
immediately and will show log describing the problem.
To be able to catch the exceptions thrown in another thread, now the logic to
import files is wrapped in a Callable instead of a Runnable.
src-db/database/lib/dbsourcemanager.jar
Asier Lostalé <[email protected]> null
fixed bug 36990: 2.50->PR17Q4 upgrade fails
If failed becuse of the order source data rows are inserted/deleted/updated.
Before 35653 was fixed, rows were sorted by their ID and insertions deltions
and updates were performed in that order. Afterwars, rows were sorted in the
same way, but insertions and deletions were performed before updates.
This casues that, in some weird cases, constraints to be broken while updating
making the process to fail.
Now it has been fixed by restoring previous order, so that updates are not
postponed anymore.
src-db/database/lib/dbsourcemanager.jar
RM packaging bot <[email protected]> null
Merge back from main
RM packaging bot <[email protected]> null
Merge temporary head for 3.0PR17Q3.2
RM packaging bot <[email protected]> null
Added signature for changeset bbeae3078728
.hgsigs
RM packaging bot <[email protected]> null
Added tag 3.0PR17Q3.2 for changeset f500d43a59bb
.hgtags
RM packaging bot <[email protected]> null
Update AD_MODULE version to 3.0PR17Q3.2
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
src-db/database/sourcedata/AD_MODULE.xml
Antonio Moreno <[email protected]> null
Fixed issue 37421. Added index to improve performance of
C_IMPORT_ENTRY_ARCHIVE deletion.
src-db/database/model/tables/C_IMPORT_ENTRY_ARCHIVE.xml
Atul Gaware <[email protected]> null
Fixes Issue 37457:Change the role in the ERP has performance
problems
** Flush is called before calling fillSessionArguments
** new ConnectionProvider without flush is passed to the
fillSessionArguments method which avoids flush for
every select statement which uses this connection Provider
as flush is not need for select statements.
modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoWidgetActionHandler.java
Carlos Aristu <[email protected]> null
fixes bug 37400: Duplicated DS calls having the tree view shown in a sub-tab
Fix for issue #35545 was intended to force a datasource call when the
fetchData does not perform it. This function has a mechanism that avoids DS
calls when the grid criteria i not being changed.
But when the criteria indeed changes two DS request was being fired: the one
that we are forcing and the other one fired by the fetchData function. To avoid
this problem we are forcing the DS call just when the grid criteria has not
changed.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
Carlos Aristu <[email protected]> null
fixes issue 37312: OB created partially in old processes shown in 3.0
windows
With the changes introduced on issue 0035553, the OB object is generated in
two stages: it is initialized when the JS static resources are loaded and
secondly additional session data is included with the SessionDynamic request.
In old processes inside 3.0 windows, a request to load the JS static
resources is done but the SessionDynamic request is not. As a result, the OB
object was generated partially. This caused JS errors when referencing to the
missing data.
To fix this issue, now when we are in an old process loaded inside a 3.0
window, instead of generating the OB object from scratch, it is cloned from the
main OB object of the application which is generated right after logging in.
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
Inigo Sanchez <[email protected]> null
Fixed issue 37294: Deactivated orgs are displayed in the user profile widget
The problem was caused by the "Improve scalability of the login process"
project. When improving the performance
of the query that return the complete organizations list for the current user,
the OBQuery instance used to generate it was
replaced with a Query instance. The first includes by default the filter by is
active.
To fix the problem this filter must be added manually in the query. Now the
problem has been resolved by take into
account this filter. Besides the same problem is detected in other query
related with deactivated warehouses so it is fixed too.
modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/RoleInfo.java
Inigo Sanchez <[email protected]> null
Fixed issue 37282: Deactivated roles are displayed in the user profile
widget
The problem was caused by the "Improve scalability of the login process"
project. When improving the
performance of the query that return the complete role list for the current
user, the OBQuery instance
used to generate it was replaced with a Query instance. The first includes by
default the filter by
is active.
To fix the problem this filter must be added manually in the query. Now the
problem has been resolved
by take into account this filter.
modules/org.openbravo.client.application/src/org/openbravo/client/application/navigationbarcomponents/UserInfoComponent.java
Carlos Aristu <[email protected]> null
related to issue 37262: adapt test cases to the new component's definition
modules/org.openbravo.client.kernel/src-test/org/openbravo/client/kernel/freemarker/test/GenerateComponentTest.java
modules/org.openbravo.client.kernel/src-test/org/openbravo/client/kernel/freemarker/test/LabelTest.java
Carlos Aristu <[email protected]> null
fixes issue 37262: Some labels are not translated after switching the
language
After the changes introduced on issue #35852 the labels were being cached
together with the rest of the static javascript code. Thus, being in an
environment not in "in development" status, the labels were being cached in the
language of the first login avoiding the translation when switching to another
language afterwards.
To fix the problem now the component responsible of collecting the labels has
been defined as a session dynamic component. This way the labels will be
retrieved on every login. And to avoid querying to the database on each login
request, the labels are now being cached in the server per language.
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/I18NComponent.java
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelComponentProvider.java
Armaignac <[email protected]> null
Fixes issue 37523:Product selector filters by Non-Stocked products in Goods
Movement window
The Stocked field of product select is filtering to true if the window is sales
transaction. The field Default expression was modified to take into account the
Goods Movement window and sets to true the field value
src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
Changes for Build #221
David Miguelez <[email protected]> null
Related to Issue 37482. Removed unnecessary comment and added a deleted
variable to include it in the returned error message
src-db/database/model/functions/C_ORDER_POST1.xml
src-db/database/model/functions/M_GET_STOCK_PARAM.xml
David Miguelez <[email protected]> null
Related to Issue 37482. Removed unused variable and code in PL.
The check for stock consistency is done by the call to the
m_check_stock function
src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
David Miguelez <[email protected]> null
Related to Issue 37482. Revert variables that has been removed and use them
in the error message. Also updated copyrights
src-db/database/model/triggers/C_INVLINE_CHK_RESTRICTIONS_TRG.xml
src-db/database/model/triggers/C_ORDLINE_CHK_RESTRICTIONS_TRG.xml
src-db/database/model/triggers/MA_GLOBALUSE_TRG.xml
src-db/database/model/triggers/M_INTERNAL_CONSUMPTIONLINE_TRG.xml
src-db/database/model/triggers/M_INVENTORYLINE2_TRG.xml
src-db/database/model/triggers/M_IOLINE_CHK_RESTRICTIONS_TRG.xml
src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml
src-db/database/model/triggers/M_PRODUCTIONLINE_TRG.xml
src-db/database/model/triggers/M_REQUISITIONLINE_TRG.xml
src-db/database/model/triggers/M_RESERVATION_TRG.xml
src-db/database/model/triggers/M_STORAGE_DETAIL_TRG.xml
src-db/database/model/triggers/M_TRANSACTION_TRG2.xml
src-db/database/model/triggers/S_TIMEEXPENSELINE_TRG.xml
David Miguelez <[email protected]> null
Fixes Issue 37482. Remove unused variables in PL's
modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_ORD.xml
modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_TAX_PAYMENT.xml
src-db/database/model/functions/A_ASSET_CREATE.xml
src-db/database/model/functions/A_ASSET_POST.xml
src-db/database/model/functions/C_CHANGEPROJECTSTATUS.xml
src-db/database/model/functions/C_DEBT_PAYMENT_BALANCING_REP.xml
src-db/database/model/functions/C_DP_MANAGEMENT_POST.xml
src-db/database/model/functions/C_INVOICELINE_TAX.xml
src-db/database/model/functions/C_INVOICE_CANCEL.xml
src-db/database/model/functions/C_INVOICE_CREATE.xml
src-db/database/model/functions/C_INVOICE_POST.xml
src-db/database/model/functions/C_ORDER_POST1.xml
src-db/database/model/functions/C_SETTLEMENT_POST.xml
src-db/database/model/functions/C_TAXPAYMENT_POST.xml
src-db/database/model/functions/C_VALIDCOMBINATION_CLONE.xml
src-db/database/model/functions/FACT_ACCT_RESET.xml
src-db/database/model/functions/GL_JOURNAL_POST.xml
src-db/database/model/functions/MA_PRODUCTION_COST.xml
src-db/database/model/functions/MA_STANDARD_COST_SEQUENCE.xml
src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
src-db/database/model/functions/MA_WORKREQUIREMENT_CLOSE.xml
src-db/database/model/functions/MA_WORKREQUIREMENT_PROCESS.xml
src-db/database/model/functions/MA_WRPHASE_CLOSE.xml
src-db/database/model/functions/M_DISCOUNTSCHEMA_RESEQ.xml
src-db/database/model/functions/M_FREIGHT_CALCULATE.xml
src-db/database/model/functions/M_GENERATE_AVERAGE_COSTS.xml
src-db/database/model/functions/M_GENERATE_STANDARD_COSTS.xml
src-db/database/model/functions/M_GET_STOCK_PARAM.xml
src-db/database/model/functions/M_INOUTEXPLODEBOMNOTSTOCK.xml
src-db/database/model/functions/M_INOUT_CREATE.xml
src-db/database/model/functions/M_INOUT_CREATEINVOICE.xml
src-db/database/model/functions/M_INOUT_UPDATEQUANTITYES.xml
src-db/database/model/functions/M_PROMOTION_ADJUSTMENT.xml
src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
src-db/database/model/functions/M_UNIQUELOCATOR_RULE_PARAM.xml
src-db/database/model/triggers/A_ASSET_TRG.xml
src-db/database/model/triggers/C_ATTACHMENT_METHOD_MOD_TRG.xml
src-db/database/model/triggers/C_BPARTNER_TRG.xml
src-db/database/model/triggers/C_INVLINE_CHK_RESTRICTIONS_TRG.xml
src-db/database/model/triggers/C_INVOICELINE_TRG.xml
src-db/database/model/triggers/C_INVOICELINE_TRG2.xml
src-db/database/model/triggers/C_ORDERLINE2_TRG.xml
src-db/database/model/triggers/C_ORDERLINE_TRG2.xml
src-db/database/model/triggers/C_ORDLINE_CHK_RESTRICTIONS_TRG.xml
src-db/database/model/triggers/C_PROJECTLINE_TRG.xml
src-db/database/model/triggers/C_PROJECT_TRG3.xml
src-db/database/model/triggers/MA_GLOBALUSE_TRG.xml
src-db/database/model/triggers/M_COSTADJUSTMENTLINE_CHK_TRG.xml
src-db/database/model/triggers/M_INTERNAL_CONSUMPTIONLINE_TRG.xml
src-db/database/model/triggers/M_INVENTORYLINE2_TRG.xml
src-db/database/model/triggers/M_IOLINE_CHK_RESTRICTIONS_TRG.xml
src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml
src-db/database/model/triggers/M_OFFER_TYPE_MOD_TRG.xml
src-db/database/model/triggers/M_PRODUCTIONLINE_TRG.xml
src-db/database/model/triggers/M_REQUISITIONLINE_TRG.xml
src-db/database/model/triggers/M_RESERVATION_TRG.xml
src-db/database/model/triggers/M_STORAGE_DETAIL_TRG.xml
src-db/database/model/triggers/M_TRANSACTION_TRG2.xml
src-db/database/model/triggers/S_TIMEEXPENSELINE_TRG.xml
David Miguelez <[email protected]> null
Related to Issue 37239. Code Review changes:
* Display logic of fields changed to filter only documents that are set as
isReversal = Y
* Created Auxiliary inputs for display logics
* Changed Validation Rule. ARC and APC document types should not be used
to generate invoices from other processes regardless of the return flag
of the document
src-db/database/sourcedata/AD_AUXILIARINPUT.xml
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_VAL_RULE.xml
Atul Gaware <[email protected]> null
Fixes Issue 37239:Negative quantity is invoiced if Credit Memo is used for
invoicing Return From Customer and Return Material Receipt
** Return document type cannot be configured with Credit Memo as document
type for invoice.
** Create Line From button not shown in Sales/Purchase Invoice when Credit
Memo document type is used.
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_VAL_RULE.xml
RM packaging bot <[email protected]> null
CI: merge back from main
src-db/database/sourcedata/AD_MODULE.xml
RM packaging bot <[email protected]> null
CI: update AD_MODULE to version 33164
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
src-db/database/sourcedata/AD_MODULE.xml
Changes for Build #222
Carlos Aristu <[email protected]> null
fixes issue 37622: instantiate MBeanRegistry log properly
src/org/openbravo/jmx/MBeanRegistry.java
David Miguelez <[email protected]> null
Related to Issue 37346. Changed the returned parameter from
convertQuotationIntoSalesOrder
* The method convertQuotationIntoSalesOrder returns an Order when created
* When is not possible to create the Sales Order due to some restriction,
it throws an OBException that is captured to print the error message
src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java
David Miguelez <[email protected]> null
Related to Issue 37346. Refactor in ConvertQuotationIntoOrder Process.
Renamed variables to make the code more understandable
src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java
David Miguelez <[email protected]> null
Related to Issue 37346. Refactor to improve ConvertQuotationIntoOrder
Process:
* Extracted logic into a different public method, so it can be called from
outside the process
* Removed unused variables
src/org/openbravo/erpCommon/ad_process/ConvertQuotationIntoOrder.java
Armaignac <[email protected]> null
Fixes issue 37580: "division by zero" error when book sales order with BOM
products
When closing a sales order with a BOM product a division by zeror error was
raise
while the process tries to calculate the v_PriceActual variable.
A validation was added to only calculate the value when the qtyordered is
different from cero, if not the v_PriceActual value is cero.
src-db/database/model/triggers/C_ORDERLINE_TRG.xml
Asier Lostalé <[email protected]> null
fixed bug 37601: log in causes contention in other requests
OBContext.setOBContext static method was synchronized, it was invoked from DAL
request filter at the begining of every requests causing contention. This
method
is also invoked during the log in process to intialize OBContext, if
initalization
takes time, it can cause severe contention issues.
Now the synchronization occurs at session level so that 2 paralell requests
for
the same session are synchronized but any other request from other sessions is
not.
src/org/openbravo/dal/core/OBContext.java
David Miguelez <[email protected]> null
Related to Issue 37239. Updated documentation of Reversed Invoices
in Sales Invoice and Purchase Invoice window
src-db/database/sourcedata/AD_TAB.xml
David Miguelez <[email protected]> null
Related to Issue 37482. Removed unused variables in PL
src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
David Miguelez <[email protected]> null
Relate to Issue 34497: Several minor improvements to the code:
* Updated license year
* Changed StringBuffers with StringBuilders
* Set the names of the constants to uppercase
* Removed unnecessary comparison in if clause
* Use .isEmpty() instead of .size() > 0
src/org/openbravo/common/datasource/CostingTransactionsHQLTransformer.java
David Miguelez <[email protected]> null
Fixes issue 34497: CostingTransactionsHQLTransformer class is not thread
safe
The orgs and costDimensions fields is now local variable for the
transformHqlQuery
method to avoid concurrent modification access when being executed by different
threads in parallel
A refactor was made including the previous fields as method args when it needed
src/org/openbravo/common/datasource/CostingTransactionsHQLTransformer.java
David Miguelez <[email protected]> null
Related to Issue 34628. Updated license year
src/org/openbravo/materialmgmt/ManageVariantsDS.java
David Miguelez <[email protected]> null
Fixes issue 34628: Manage variants can return unexpected values
When filtering concurrently in Manage Variants P&E, it was possible to obtain
incorrect values. This is caused because ManageVariantsDS is not thread safe it
is used as singleton but it has state variables that can be messed up by
different threads.
The global state variables has been removed and now their values are contained
in a new private class. A new instance of this class is created for every
execution
of the process, so the values are not mixed again.
The getData and readCriteria methods have been modified to make use of this new
class.
src/org/openbravo/materialmgmt/ManageVariantsDS.java
Changes for Build #223
Javier Armendáriz <[email protected]> null
Fixed bug 37398: Use default value when TreeDatasourceFetchLimit is not
defined
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-tree.js
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
Inigo Sanchez <[email protected]> null
Fixed issue 37624: Filter on quick launch menu is not accent sensitive
After the changes introduced in the "Improve scalability of the login process"
project on issue #35553, the quick launch menu no longer used the specific
datasource. The datasource has a fieldMatchesFilter method that allow searchs
not distinguish between accent or non-accent words. Since the changes were
introduced, the data is filter in the client instead of in the datasource and
for this reason the fieldMatchesFilter method is not executed.
To fix the problem two main actions have been done:
- Small clean code moving the functionality of fieldMatchesFilter method to
ob-utilities in order to avoid duplicated code.
- The getQuickMenuItems method must be save the identifiers without accents
using the method previosuly created in ob-utilities. It has been done the same
with the value returned in the getPickListFilterCriteria method.
Removing the accents in the items of the filter in ob-quick-launch.js the
problem has been resolved. The accents are now ignored in Quick launch Menu'
suggestion combobox.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
Carlos Aristu <[email protected]> null
related to issue 37643: avoid definining getInstance() method as
synchronized
The instance variable is now initialized on first class load instead.
src/org/openbravo/base/expression/OBScriptEngine.java
David Miguelez <[email protected]> null
Related to Issue 37279. Added sleeps to automated test cases to avoid
problems while launching them in Oracle.
src-test/src/org/openbravo/test/costing/TestCosting.java
David Miguelez <[email protected]> null
Related to Issue 37640. Updated license year
src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
Atul Gaware <[email protected]> null
Fixes Issue 37640: Trying to separate discounts using different
organizations that are not in the same branch DOES NOT separate
these discounts
** Apply offers (discount and promotion) to the lines whose order
organization is in organization tree of the offer organization.
src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
David Miguelez <[email protected]> null
Related to Issue 32729. Code Review changes
Improvmentes in automated tests:
* Set more meaningful names
* Avoid Dal refresh when possible
* Set final to parameters in methods when possible
src-test/src/org/openbravo/test/costing/TestCosting.java
Nono Carballo <[email protected]> null
Added test for issue 32729
src-test/src/org/openbravo/test/costing/TestCosting.java
David Miguelez <[email protected]> null
Related to Issue 37279. Fixes automated test after fixing issue:
* Changed amounts of automated test LC3LC4
* Changed logic asserting the distributed amount of a Landed Cost between
it's related Recipt lines
* For each transacion it calculates it's cost as the original Transaction
Cost plus the Cost of the previous Unit Cost adjustments
* Reload and refresh the Landed Cost object when needed
* Add isNeedPosting variable to costAdjustmentAssertLine and use it to check
if a transaction has been posted or not
src-test/src/org/openbravo/test/costing/TestCosting.java
David Miguelez <[email protected]> null
Fixes Issue 37279. Corrects Transactions affected by Average cost
adjustments
When a Cost Adjustment is created, some transactions are affected by this change
For Average Cost adjustment, the transactions that modifies the average cost,
but has used the actual average cost in it's calculation must be taken into
account.
src/org/openbravo/costing/AverageCostAdjustment.java
Augusto Mauch <[email protected]> null
Fixes issue 37643: OBScriptEngine can be used to evaluate javascript scripts
There were four classes that were creating a new instance of ScriptEngine each
time they needed to evaluate a javascript script. This was not the better way
to do it, since creating a ScriptEngine instance can be expensive, and that
class is thread safety if properly used (i.e. by setting the bindings to each
evaluation instead of to the script engine itself).
A new singleton class has been added, OBScriptEngine, that is now used by all
the classes that need to evaluate javascript scripts.
src/org/openbravo/base/expression/OBScriptEngine.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java
src/org/openbravo/base/expression/Evaluator.java
Armaignac <[email protected]> null
Fixes issue 37626:Numbers in Valued Stock Report are exported as strings
The number columns of Valued Stock Report was exporting to text in xls format.
The net.sf.jasperreports.export.xls.detect.cell.type property was added to the
report
with a true value. Also the pattern "#,##0.00;-#,##0.00" was included to the
fields.
src/org/openbravo/erpCommon/ad_reports/ReportValuationStockExcel.jrxml
Augusto Mauch <[email protected]> null
Fixes issue 37641: Allows to configure Hibernate's hql query plan cache size
Now the max size of Hibernate's HQL query plan cache can be configured in
Openbravo.properties by defining the
hibernate.query.plan_cache_max_strong_references and
hibernate.query.plan_cache_max_soft_references properties.
src/org/openbravo/base/session/SessionFactoryController.java
Atul Gaware <[email protected]> null
Fixes Issue 0037516:Performance issue in Orders Awaiting Delivery Report
** Use a subquery to fetch qtyinstock, aum by respective queries
only once, add uomsymbol in inner select, aumsymbol in outer select
** Use isdelivered flag to avoid c_orderline exists clause which checks
undelivered orders line by line qtyordered against qtydelivered
modules/org.openbravo.reports.ordersawaitingdelivery/src/org/openbravo/reports/ordersawaitingdelivery/erpCommon/ad_reports/ReportOrderNotShipped_data.xsql
Changes for Build #224
Antonio Moreno <[email protected]> null
Related to issue 37667. Cookie won't be reset in password reset flow, as it
was just reset in the previous request.
src/org/openbravo/base/secureApp/LoginHandler.java
Antonio Moreno <[email protected]> null
Fixed issue 37667. Cookie identifier will now be regenerated just after
logging in the application.
Now every login the session will be invalidated and regenerated immediately,
thus forcing a cookie identifier reset.
src/org/openbravo/base/secureApp/LoginHandler.java
David Miguelez <[email protected]> null
Fixes Issue 37732. Adds an exetension Point at the beginning of the
C_Order_Post
src-db/database/model/functions/C_ORDER_POST1.xml
src-db/database/sourcedata/AD_EXTENSION_POINTS.xml
David Miguelez <[email protected]> null
Fixes Issue 34496. This class was original developed as a singleton.
However, as it evolved, this design was changed and now it behaves
as an object.
Now the information of the object should be created and destroyed
when a new instance of this object is created.
This is done in CostAdjustmentProcess using injection.
That is why the definition of ApplicationScoped does not make
sense any more, it must be Dependant.
src/org/openbravo/costing/CostingAlgorithmAdjustmentImp.java
David Miguelez <[email protected]> null
Related to Issue 34840. Change done to reload the qty in stock for a product
instead of 0 after the line has been saved
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
Nono Carballo <[email protected]> null
Fixes issue 34841: RTV shipment (Pick/Edit Lines) not properly working if
Returned UOM is changed from Unit to Pallet.
When changing Ship Qty and then returned Uom, just pending field is updated,
showing the pending quantity expressed in returned Uom.
Same behaviour in Return Material Receipt window.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/return-material/ob-return-material.js
David Miguelez <[email protected]> null
Related to issue 34840: Code Review changes
* Added final modifier to product object again
* Removed unused methods
* When setting the AUM, set also the Quantity expresed in AUM
and for that, convert the original quantity to the AUM equivalent.
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
Nono Carballo <[email protected]> null
Fixes issue 34840: Movement Qty column info not updated once a product with
stock
is selected in Goods Shipment if Alt UOM Preference is enable.
Operative Quantity field isautomatically populated if the selected product
do not have a default Alternative UOM configured and the product has
quantity on hand.
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
Nono Carballo <[email protected]> null
Fixes issue 37676: "Project Phase" field does not show any value
(although Project is selected) in Expense Sheet window
In callouts, for fields representing Ids, an empty string is returned instead
of null.
src/org/openbravo/erpCommon/ad_callouts/SE_Expense_BP_Project.java
src/org/openbravo/erpCommon/ad_callouts/SE_InOut_Organization.java
src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java
src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
src/org/openbravo/erpCommon/ad_callouts/SE_Order_Organization.java
src/org/openbravo/erpCommon/ad_callouts/SE_Project_BPartner.java
src/org/openbravo/erpCommon/ad_callouts/SE_Trxtype_Transaction.java
src/org/openbravo/erpCommon/ad_callouts/SL_GlobalUse_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_InOut_BPartner.java
src/org/openbravo/erpCommon/ad_callouts/SL_Internal_Consumption_Conversion.java
src/org/openbravo/erpCommon/ad_callouts/SL_Internal_Consumption_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_InvAmtUpd_ProductRefDate.java
src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_DocType.java
src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Journal_MultiAcctSchema.java
src/org/openbravo/erpCommon/ad_callouts/SL_Movement_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Order_DocType.java
src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Production_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_RefreshSequenceAndLength.java
src/org/openbravo/erpCommon/ad_callouts/SL_RequisitionLine_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_SequenceProduct_Product.java
Nono Carballo <[email protected]> null
Fixes issue 37642: Enable tree view in MRP Manufacturing Plan window
A tree of type LinkToParent was created using the column parentId (Report Set)
in table mrp_run_productionline.
The tree was set in manufacturing Plan/Lines tab.
src-db/database/sourcedata/AD_TAB.xml
src-db/database/sourcedata/AD_TABLE.xml
src-db/database/sourcedata/AD_TABLE_TREE.xml
Nono Carballo <[email protected]> null
Fixes Issue 37703. Refactors TestCosting class
* Assert Classes were placed in a new package
* Constants were moved to a new class
* TestCostingUtils now contains all the API to create tests
* New test classes were created containig the tests
* TestCosting class was converted into a suite running all test classes
src-test/src/org/openbravo/test/costing/TestCostingBase.java
src-test/src/org/openbravo/test/costing/TestCostingLandedCost.java
src-test/src/org/openbravo/test/costing/TestCostingNoSourceAdjustments.java
src-test/src/org/openbravo/test/costing/TestCostingSourceAdjustments.java
src-test/src/org/openbravo/test/costing/TestIssue37033.java
src-test/src/org/openbravo/test/costing/TestIssue37279.java
src-test/src/org/openbravo/test/costing/assertclass/CostAdjustmentAssert.java
src-test/src/org/openbravo/test/costing/assertclass/DocumentPostAssert.java
src-test/src/org/openbravo/test/costing/assertclass/LandedCostCostMatchedAssert.java
src-test/src/org/openbravo/test/costing/assertclass/LandedCostReceiptLineAmountAssert.java
src-test/src/org/openbravo/test/costing/assertclass/MatchedInvoicesAssert.java
src-test/src/org/openbravo/test/costing/assertclass/OrderToReceiptResult.java
src-test/src/org/openbravo/test/costing/assertclass/PhysicalInventoryAssert.java
src-test/src/org/openbravo/test/costing/assertclass/ProductCostingAssert.java
src-test/src/org/openbravo/test/costing/assertclass/ProductTransactionAssert.java
src-test/src/org/openbravo/test/costing/utils/TestCostingConstants.java
src-test/src/org/openbravo/test/costing/utils/TestCostingUtils.java
src-test/src/org/openbravo/test/costing/TestCosting.java
src-test/src/org/openbravo/test/costing/TestCostingUtils.java
David Miguelez <[email protected]> null
Related to Issue 37565. Removed unnecessary html and xml files.
Removed unused AD_TextInterfaces.
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
src/org/openbravo/erpCommon/ad_reports/ReportCashFlowPopUp.html
src/org/openbravo/erpCommon/ad_reports/ReportCashFlowPopUp.xml
src/org/openbravo/erpCommon/ad_reports/ReportCashFlowReload.html
src/org/openbravo/erpCommon/ad_reports/ReportCashFlowReload.xml
Armaignac <[email protected]> null
Fixes issue 37565: Remove outdated Cash Flow report
Removed the AD entry, QA Sample Data Process Access, Java, XML, XSQL and HTML
files for Report Cash Flow
referencedata/sampledata/QA_Testing/AD_PROCESS_ACCESS.xml
src-db/database/sourcedata/AD_MENU.xml
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
src-db/database/sourcedata/AD_PROCESS.xml
src-db/database/sourcedata/AD_TREENODE.xml
src/org/openbravo/erpCommon/ad_reports/ReportCashFlow.html
src/org/openbravo/erpCommon/ad_reports/ReportCashFlow.java
src/org/openbravo/erpCommon/ad_reports/ReportCashFlow.xml
src/org/openbravo/erpCommon/ad_reports/ReportCashFlow_data.xsql
Carlos Aristu <[email protected]> null
related to issue 34119: update copyright year
src-db/database/model/functions/AD_SYNCHRONIZE.xml
Javier Armendáriz <[email protected]> null
Fixed bug 34119: Sync terminology doesn't translate some PO window fields.
In Synchronize Terminology the PO field's name is taken from its element
instead of the element's translation (when available) when the element's
PO_NAME field is empty.
Now the element's translation takes precedence over the element values. It is
ordered as follows:
ad_element_trl.PO_NAME > ad_element.po_name > ad_element_trl.name >
ad_element.name
src-db/database/model/functions/AD_SYNCHRONIZE.xml
Carlos Aristu <[email protected]> null
related to issue 37501: remove unused text interface
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
Carlos Aristu <[email protected]> null
related to bug 37624: use title field as the display value for the menu
entries
As now the _identifier contains the title text but without accents, it can
not be used as the display field because in that case it would not be possible
to show menu entries with accents. For this reason we now use the title field
as the display field.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
Carlos Aristu <[email protected]> null
related to issue 37501: add missing final modifier for the constants
src/org/openbravo/erpCommon/utility/OBVersion.java
Javier Armendáriz <[email protected]> null
Fixes bug 37501: Remove hg revision reference in About screen.
Removed all references to current hg revision in About screen, so this won't
appear on the About popup.
src/org/openbravo/erpCommon/ad_forms/About.html
src/org/openbravo/erpCommon/ad_forms/About.java
src/org/openbravo/erpCommon/ad_forms/About.xml
David Miguelez <[email protected]> null
Fixes issue: 37628: Fixes wrong calculation of Taxes for Taxes based
on Tax amount.
When the taxes are based only on tax amount, then the taxbase amount
should not be added to it's calculation.
This change has been done for both Orders and Invoices Taxes triggers.
src-db/database/model/triggers/C_INVOICELINETAX_TRG.xml
src-db/database/model/triggers/C_ORDERLINETAX_TRG.xml
Atul Gaware <[email protected]> null
Fixes Issue 37515:Performance issue in Orders Awaiting Invoice Report
** Split the query using CTE for pending orders to be invoiced.
** Group by Taxes sub query on Order ID and Tax ID to void duplicates.
** Modify C_OrderLine_Order index by adding function based column
OBEQUALS(QTYORDERED,QTYINVOICED)
** Rearrange parameters in xsql accordingly and pass them while calling
select method in java class.
** Filters Orders to remove the ones in Draft and Closed Status.
src-db/database/model/tables/C_ORDERLINE.xml
src/org/openbravo/erpCommon/ad_reports/ReportOrderNotInvoiceJR.java
src/org/openbravo/erpCommon/ad_reports/ReportOrderNotInvoice_data.xsql
Javier Armendáriz <[email protected]> null
Fixed bug 37170: Remove unneeded toolbar buttons in SQL Query window.
This removes some navigation buttons in SQL Query Window that currently has no
functionality.
src/org/openbravo/erpCommon/utility/ToolBar.java
David Miguelez <[email protected]> null
Fixes Issue 30643:Overly huge request size in
AddPaymentDisplayLogicActionHandle
Before sending the context, the grids with the information about orders and
invoices,
gl items and credit used are removed from it.
This data is not used for calculating the display or read only logic of the
rest of the parameters
and sending the grid can have an impact in the performance of this process.
modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
Changes for Build #225
Javier Armendáriz <[email protected]> null
Fixed bug 35268: No message displayed on request timeout responses.
The RPC response handler does not show any message when the request fails. Now
it shows an error in the messageBar if its a server timeout.
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
Carlos Aristu <[email protected]> null
related to issue 37700: code review improvements in test case
- Use admin mode to create/remove data with the CostAdjustmentTestDataHelper
- Use getProxy() to set the document type
src-test/src/org/openbravo/test/datasource/LinkToParentTreeDataSourceTest.java
Javier Armendáriz <[email protected]> null
Fixed bug 37627: Web services does not handle CORS properly.
Web service servlet does not handle CORS so cross-domain request would fail.
Adding the CORS handler in the base servlet for web services.
src/org/openbravo/service/web/BaseWebServiceServlet.java
David Miguelez <[email protected]> null
Fixes Issue 37796. Selector for Product in Work Effort and Production Run
Windows
does not filter Products by non stocked. It is possible to select a product
regardless of having stock of it. If there is stock, it is possible to select
the specific stock.
src-db/database/sourcedata/OBUISEL_SELECTOR.xml
Asier Lostalé <[email protected]> null
related to issue 37667: Cookie should be regenerated when logging
-removed uncommented param in javadoc
-updated copyright
src/org/openbravo/base/secureApp/LoginHandler.java
Javier Armendáriz <[email protected]> null
Related to bug 37700.
Added a test case where a node has a single non-active children. The parent
node should have the _hasChildren field set as true.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/LinkToParentTreeDatasourceService.java
src-test/src/org/openbravo/test/datasource/LinkToParentTreeDataSourceTest.java
Inigo Sanchez <[email protected]> null
Fixed issue 37689: Update copyright in legal/Licensing.txt
legal/Licensing.txt
Augusto Mauch <[email protected]> null
Fixes issue 37681: Dont create ad_context_info if audit trail not active
Records are only read/written from the ad_context_info if audit trail is
enabled (if any ad_table is fully audited). If audit trail is disabled when
Tomcat is started, there is no need to create the ad_context_info table each
time that a new connection is created. From now on it will no be possible
to enable the audit trail while Tomcat is active, enabling it will require to
rebuild Openbravo and to restart Tomcat. Now:
- The Update Audit Trail Infrastructure has been removed
- When a new table is set to be audited in the AD,
SessionInfo.setAuditTrailActive(true) will not be invoked, so that the
isAuditTrailActive flag can
only be set to true when Tomcat starts.
modules/org.openbravo.apachejdbcconnectionpool/src/org/openbravo/apachejdbcconnectionpool/ConnectionInitializerInterceptor.java
src-core/src/org/openbravo/database/SessionInfo.java
src-db/database/sourcedata/AD_MENU.xml
src-db/database/sourcedata/AD_MESSAGE.xml
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src-db/database/sourcedata/AD_PROCESS.xml
src-db/database/sourcedata/AD_TREENODE.xml
src/org/openbravo/erpCommon/ad_callouts/SL_TableAudit.java
src/org/openbravo/erpCommon/ad_process/UpdateAuditTrail.java
Augusto Mauch <[email protected]> null
Fixes issue 37677: Dont check if ad_context_info table exists before
creating it
Now, if the pool is used, the query to check if the ad_context_info table
already exists will not be done. This check can be skipped because
if the pool is used, the initDB method will only be called when a new physical
connection is created, and in that case the temporary table is
garanteed not to exist.
This pool instance check is needed to keep supporting using pools other than
org.openbravo.apachejdbcconnectionpool.JdbcExternalConnectionPool (or none at
al),
but in those cases the query to check if the ad_context_info table exists will
still be performed.
src-core/src/org/openbravo/database/SessionInfo.java
RM packaging bot <[email protected]> null
Merge back from main
RM packaging bot <[email protected]> null
Merge temporary head for 3.0PR17Q3.3
RM packaging bot <[email protected]> null
Added signature for changeset 2e43174aba46
.hgsigs
RM packaging bot <[email protected]> null
Added tag 3.0PR17Q3.3 for changeset dd65065492e5
.hgtags
RM packaging bot <[email protected]> null
Update AD_MODULE version to 3.0PR17Q3.3
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.apachejdbcconnectionpool/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.base.weld/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.htmlwidget/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.kernel/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.myob/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.client.widgets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.financial.paymentreport/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.reports.ordersawaitingdelivery/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.integration.openid/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.service.json/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.selector/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.skin.250to300Comp/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.utility.cleanup.log/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.datasets/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3.framework/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE.xml
modules/org.openbravo.v3/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
src-db/database/sourcedata/AD_MODULE.xml
Nono Carballo <[email protected]> null
Fixes issue 37067: RTV shipment (Pick/Edit Lines) not properly working if
Returned UOM is changed from Unit to Pallet.
When changing Ship Qty and then returned Uom, just pending field is updated,
showing the pending quantity expressed in returned Uom.
Same behaviour in Return Material Receipt window.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/return-material/ob-return-material.js
David Miguelez <[email protected]> null
Related to Issue 37070. Change done to reload the qty in stock for a product
instead of 0 after the line has been saved
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
David Miguelez <[email protected]> null
Related to issue 37070: Code Review changes
* Added final modifier to product object again
* Removed unused methods
* When setting the AUM, set also the Quantity expresed in AUM
and for that, convert the original quantity to the AUM equivalent.
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
Nono Carballo <[email protected]> null
Fixes issue 37070: Movement Qty column info not updated once a product with
stock
is selected in Goods Shipment if Alt UOM Preference is enable.
Operative Quantity field isautomatically populated if the selected product
do not have a default Alternative UOM configured and the product has
quantity on hand.
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
Carlos Aristu <[email protected]> null
related to bug 37686: use title field as the display value for the menu
entries
As now the _identifier contains the title text but without accents, it can
not be used as the display field because in that case it would not be possible
to show menu entries with accents. For this reason we now use the title field
as the display field.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
Inigo Sanchez <[email protected]> null
Fixed issue 37686: Filter on quick launch menu is not accent sensitive
After the changes introduced in the "Improve scalability of the login process"
project on issue #35553, the quick launch menu no longer used the specific
datasource. The datasource has a fieldMatchesFilter method that allow searchs
not distinguish between accent or non-accent words. Since the changes were
introduced, the data is filter in the client instead of in the datasource and
for this reason the fieldMatchesFilter method is not executed.
To fix the problem two main actions have been done:
- Small clean code moving the functionality of fieldMatchesFilter method to
ob-utilities in order to avoid duplicated code.
- The getQuickMenuItems method must be save the identifiers without accents
using the method previosuly created in ob-utilities. It has been done the same
with the value returned in the getPickListFilterCriteria method.
Removing the accents in the items of the filter in ob-quick-launch.js the
problem has been resolved. The accents are now ignored in Quick launch Menu'
suggestion combobox.
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
David Miguelez <[email protected]> null
Related to Issue 37766. Code review changes.
Changed comparison to work as other outputs (PDF, HTML).
If the totalAmount is zero, then the margin is zero.
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesXLS.jrxml
Armaignac <[email protected]> null
Fixes issue 37766: Sales Invoice Dimensional Report in Excel - error 0/0
A division by zero was taking place when the total amount of the invoice is zero
A validation was added to avoid division by zero when total amount is zero.
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesXLS.jrxml
Javier Armendáriz <[email protected]> null
Related to bug 37700: Updated copyright years
src-test/src/org/openbravo/test/AllWebserviceTests.java
src-test/src/org/openbravo/test/datasource/LinkToParentTreeDataSourceTest.java
Javier Armendáriz <[email protected]> null
Fixed bug 37700: Link to parent trees does not show non active items.
OBQuery by default filters non active fields. Needed to override this behavior
on LinkToParentTreeDatasource to show all items in the tree view.
src-test/src/org/openbravo/test/datasource/LinkToParentTreeDataSourceTest.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/LinkToParentTreeDatasourceService.java
src-test/src/org/openbravo/test/AllWebserviceTests.java
Carlos Aristu <[email protected]> null
fixes issue 37734: High Availability in Import Entries
Carlos Aristu <[email protected]> null
[ha] Use the proper alternative for StringUtils
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Include leader name information in ClusterService
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/cluster/ClusterService_data.xsql
Carlos Aristu <[email protected]> null
[ha] Remove unneeded isDebugEnabled() check
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Restore methods that require to be at least protected due to CDI
injection
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] Improved log info
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Methods visibility is as restrictive as possible
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] Define getters used only in JMX as package private
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Implement methods used only in JMX in the JmxClusterServiceManager
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/cluster/JmxClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Class javadoc
src/org/openbravo/service/importprocess/ImportEntryClusterService.java
Carlos Aristu <[email protected]> null
[ha] Improve constants definition
- DEFAULT_TIMEOUT can be private
- Use _ as thousand separator in all constants
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] DB/AD adjustments
- Define timeout as a mandatory setting
- Increase node name colum size to 255
- Show the node ID field
- Updated node ID and node name field names
src-db/database/model/tables/AD_CLUSTER_SERVICE.xml
src-db/database/model/tables/AD_CLUSTER_SERVICE_SETTINGS.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
Asier Lostalé <[email protected]> null
[ha] typo
src/org/openbravo/cluster/JmxClusterServiceManager.java
Asier Lostalé <[email protected]> null
[ha] added @Override to ImportProcessContextListener methods
src/org/openbravo/service/importprocess/ImportProcessContextListener.java
Asier Lostalé <[email protected]> null
[ha] typo
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Avoid connection leak when ping thread does not even start
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Avoid connection leaks when threads should wait
src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
src/org/openbravo/service/importprocess/ImportEntryManager.java
Carlos Aristu <[email protected]> null
[ha] Log the error instead of ignoring it
src/org/openbravo/cluster/JmxClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Decouple the ClusterService JMX MBean from the ClusterServiceManager
src/org/openbravo/cluster/JmxClusterServiceManager.java
src/org/openbravo/cluster/JmxClusterServiceManagerMBean.java
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/cluster/ClusterServiceManagerMBean.java
Carlos Aristu <[email protected]> null
[ha] Minor change in javadoc
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] Use new ImportEntryClusterService in ImportEntryArchiveManager also
- Use new ImportEntryClusterService to check if we are in the cluster node
handling the import entries. In that case, it should also archive them.
- Added also the check before archiving each import entry
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
Carlos Aristu <[email protected]> null
[ha] Some minor improvements
- Include the leader name in the information provided through JMX
- Improved log message when registering the service for the first time
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Add additional checks in enable/disable ping methods
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Use a UUID to uniquely identify each cluster node
This avoids problems in case of of machine name missconfiguration
src-db/database/model/tables/AD_CLUSTER_SERVICE.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/cluster/ClusterServiceManagerMBean.java
src/org/openbravo/cluster/ClusterService_data.xsql
Carlos Aristu <[email protected]> null
[ha] Do not force changes in class hierarchy to declare services
src/org/openbravo/service/importprocess/ImportEntryClusterService.java
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/service/importprocess/ImportEntryManager.java
Carlos Aristu <[email protected]> null
[ha] Allow to enable/disable the ping service through JMX
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/cluster/ClusterServiceManagerMBean.java
Carlos Aristu <[email protected]> null
[ha] Fix typo
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] Update comment
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] On startup log if current node is leading a service (and if not who)
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Renamed the field showing the leader of a service as "Master Node"
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
Carlos Aristu <[email protected]> null
[ha] Add more missing AD information
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
Carlos Aristu <[email protected]> null
[ha] Use an anonymous class to create the ThreadFactory of the
ExecutorService
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Improve name of methods that return the node and service names
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/service/importprocess/ImportEntryManager.java
Carlos Aristu <[email protected]> null
[ha] AD changes/improvements
- Hide the active field in the cluster information/settings windows.
- Add missing window and tab descriptions.
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_MENU.xml
src-db/database/sourcedata/AD_TAB.xml
src-db/database/sourcedata/AD_WINDOW.xml
Carlos Aristu <[email protected]> null
[ha] Timeout must accept just positive values
src-db/database/model/tables/AD_CLUSTER_SERVICE_SETTINGS.xml
Carlos Aristu <[email protected]> null
[ha] Retrieve the settings from memory
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Improved the API exposed through JMX
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/cluster/ClusterServiceManagerMBean.java
Carlos Aristu <[email protected]> null
[ha] reduce vertical separation
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Do not check client/org when using registerCurrentNodeForService method
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] When shutting down a leader node, deregister it as leader
When shutting down a leader node, deregister it so next node doesn't need to
wait until timeout is expired to be promoted.
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Centralize code used to retrieve the machine (node) name
src-core/src/org/openbravo/base/ConfigParameters.java
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] No need to check if connection is not null
No need to check if connection is not null null because this is also handled
in dcp.releaseCommitConnection(connection);
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] getClusterServiceTimeout() returns the timeout in ms
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] Use Long.parseLong(String) instead of new Long(String)
new Long(String) is deprecated in JDK9, using Long.parseLong(String) instead
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] Start the ImportEntryManager on application startup
src/org/openbravo/service/importprocess/ImportEntryManager.java
src/org/openbravo/service/importprocess/ImportProcessContextListener.java
Carlos Aristu <[email protected]> null
[ha] Use own ThreadFactory to create the ClusterServiceThread
Use own DaemonThreadFactory to set the ClusterServiceThread as a daemon thread.
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] start/shutdown ClusterServiceManager in the
ImportProcessContextListener
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src/org/openbravo/service/importprocess/ImportProcessContextListener.java
src/org/openbravo/cluster/ClusterServiceContextListener.java
Carlos Aristu <[email protected]> null
[ha] Add missing help/description for the new AD elements
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
Carlos Aristu <[email protected]> null
[ha] use initialized variable
src/org/openbravo/cluster/ClusterService.java
Carlos Aristu <[email protected]> null
[ha] Some minor code improvements
- Allow to invoke the ClusterServiceManager.isCluster() method from
ClusterService to avoid code duplication
- Use better method name: renamed method 'isHandlingService' as
'isServiceHandledInCurrentNode'
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
Carlos Aristu <[email protected]> null
[ha] ClusterService instance should know if they're running in cluster
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Refactor to support the new definion of the ClusterService abstract
class
src/org/openbravo/cluster/ClusterService_data.xsql
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
src/org/openbravo/service/importprocess/ImportEntryManager.java
src/org/openbravo/cluster/ClusterServiceManager_data.xsql
Carlos Aristu <[email protected]> null
[ha] Now the ping service detects if cluster services are alive
src/org/openbravo/cluster/ClusterService.java
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/service/importprocess/ImportEntryManager.java
Carlos Aristu <[email protected]> null
[ha] Check if current node should handle the import entry before processing
it
src/org/openbravo/service/importprocess/ImportEntryManager.java
Carlos Aristu <[email protected]> null
[ha] Early return if there are not available cluster services
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Reduce vertical separation
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Define the threshold as a % of the timeout
The threshold will be the 10% of the timeout unless it is lower than 1 second
or higher than 5 seconds, in these cases the threshold will be 1 second and 5
seconds respectively. Taking into account that the ping round should be
completed in milliseconds, those values are more than enough
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Fix log message
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Specify the current node when updating the last ping
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Remove extra blank spaces
src/org/openbravo/cluster/ClusterServiceManager_data.xsql
Carlos Aristu <[email protected]> null
[ha] Add additional where clause when replacing the node in charge of a
service
Adding node = <formerNodeInCharge> into the where clause when replacing the
node in charge of a service. This is done in order to prevent two succesfull
leader registrations in case two nodes tries to promote themselves as leaders
at the same time.
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Use a different connection to get the node in charge of a service
src/org/openbravo/cluster/ClusterServiceManager_data.xsql
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
src/org/openbravo/service/importprocess/ImportEntryManager.java
Carlos Aristu <[email protected]> null
[ha] Merge with pi
Carlos Aristu <[email protected]> null
[ha] Revert undesired changeset
src-test/.project
Carlos Aristu <[email protected]> null
Refresh current time on each iteration
This is done to avoid missing to refresh the leadership in case the ping
round took so much time
src-test/.project
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] The Date of the last ping performed by a node can be consulted through
JMX
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/cluster/ClusterServiceManagerMBean.java
Carlos Aristu <[email protected]> null
[ha] Add the javadoc of the ClusterServiceManager API
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Allow to close the connection automatically when using
isHandlingService
If the isHandlingService is invoked from a request which is outside of the
DalRequestFilter, the connection used to retrieve cluster service information
must be closed manually. Otherwise, threads like ImportEntryManagerThread or
ImportEntryArchiveManager could retrieved outdated information (from the
Hibernate session cache) and also could be a risk of leaving connection leaks.
src/org/openbravo/cluster/ClusterServiceManager.java
src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
src/org/openbravo/service/importprocess/ImportEntryManager.java
Carlos Aristu <[email protected]> null
[ha] Improve log info when forcing a node to be in charge of a service
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Allow to override the getName() method
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Remove unneeded annotation
src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
src/org/openbravo/service/importprocess/ImportEntryManager.java
Carlos Aristu <[email protected]> null
[ha] Prevent connection leaks when there is not any registered cluster
service
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Merge with pi
Carlos Aristu <[email protected]> null
[ha] Define the minimum threshold needed if all nodes start at the same time
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Define the ClusterServiceManager as a JMX MBean
src/org/openbravo/cluster/ClusterServiceManagerMBean.java
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Improve some parameter names
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Ensure that ClusterServiceThread closes the DB transaction that it uses
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] merge with pi
Carlos Aristu <[email protected]> null
[ha] Add ClusterServiceManager into the Import Entry Framework
src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
src/org/openbravo/service/importprocess/ImportEntryManager.java
Carlos Aristu <[email protected]> null
[ha] When not in cluster, service should be executed
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Specify the timeout in the AD in seconds
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Added comment
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] For the moment, the threshold is not configurable
src-db/database/model/tables/AD_CLUSTER_SERVICE_SETTINGS.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Several improvements in ClusterServiceManager
- New private methods invoked by the register logic
- Renamed the register method to registerOrUpdateService
- Improved the way of discovering whether the node in charge of a service is
down
- Init the node name on ClusterServiceManager startup
- Added log info
src/org/openbravo/cluster/ClusterServiceManager.java
Carlos Aristu <[email protected]> null
[ha] Add the Cluster Service Manager
src/org/openbravo/cluster/ClusterServiceContextListener.java
src/org/openbravo/cluster/ClusterServiceManager.java
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
Carlos Aristu <[email protected]> null
[ha] Add missing AD_Element
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
Carlos Aristu <[email protected]> null
[ha] AD Infrastructure
src-db/database/model/tables/AD_CLUSTER_SERVICE.xml
src-db/database/model/tables/AD_CLUSTER_SERVICE_SETTINGS.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_ELEMENT.xml
src-db/database/sourcedata/AD_FIELD.xml
src-db/database/sourcedata/AD_MENU.xml
src-db/database/sourcedata/AD_REFERENCE.xml
src-db/database/sourcedata/AD_REF_LIST.xml
src-db/database/sourcedata/AD_TAB.xml
src-db/database/sourcedata/AD_TABLE.xml
src-db/database/sourcedata/AD_TREENODE.xml
src-db/database/sourcedata/AD_WINDOW.xml
David Miguelez <[email protected]> null
Related to Issue 37664. Product field of selector is flagged as No Centraly
Maintained to avoid the description and help fields to be overwritten.
src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
David Miguelez <[email protected]> null
Related to Issue 33231. Code Review changes
* Added another field to PopUp
* Changed order in grid of fields
* Added missing descriptions and help
src-db/database/sourcedata/AD_REFERENCE.xml
src-db/database/sourcedata/OBUISEL_SELECTOR.xml
src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
Armaignac <[email protected]> null
Fixes issue 37664:Perfomance issue in Invoice Line drop down of Landed Cost
Cost
On a environment with huge number of invoices the drop down to select a invoice
line in the Cost tab of Landed Cost window takes too much time to load.
The where clause of the selector was wrong. It should filter out also the
invoices that have been completely matched in the Matched Amount tab and are not
in the Landed Cost Cost tab.
Two new auxiliary input was added to compute the product and account ids defined
in the landed cost type selected also a callout was added to clear the invoice
line field when it's change.
The where clause of the selector was updated to properly take into account the
invoices
src/org/openbravo/erpCommon/ad_callouts/SL_LandedCost_Cost_Type.java
src-db/database/model/tables/C_INVOICELINE.xml
src-db/database/sourcedata/AD_AUXILIARINPUT.xml
src-db/database/sourcedata/AD_CALLOUT.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
src-db/database/sourcedata/OBUISEL_SELECTOR.xml
src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
David Miguelez <[email protected]> null
Fixes Issue 37742. Fixes performance in Return Material Receipt P&E
In view m_rm_receipt_pick_edit a new column has been added with the
Business Partner from the Order.
This new column is used in the filter of the Return Material P&E Tab.
By doing so, additional cross joins with OrderLine and Order Tables
are avoided.
Also, the planner in Postgres is able to properly use the Business
Partner index.
src-db/database/model/views/M_RM_RECEIPT_PICK_EDIT.xml
src-db/database/sourcedata/AD_COLUMN.xml
src-db/database/sourcedata/AD_TAB.xml
Stefan Hühner <[email protected]> null
related to issue 37501. Removed not used OBVersion.getVersionId method
Showing hg id output alone of core repo is not useful nowadays as there are
many modules present in any typical install.
Remove that output as preparation to fix 37500 issue.
src/org/openbravo/erpCommon/utility/OBVersion.java
Stefan Hühner <[email protected]> null
Fixed 37499. Remove unused feature to export code_revision to xml files.
EntityXmlConverter has a feature to add 3 attributes to root 'Openbravo'
element of files it is creating (ob-version, ob-revision, crated), by calling
addSystemAttributes method.
However rewrite of the xml export done in commit (102ba22a81ca, 2009-02-12)
stopped calling that method.
No other caller of that protected method can be found in pi or search in
getAllModules today.
Apart even before the only code requesting those attributes was the dataset
xml export. That has been later switched over to checksum for exported content.
As that is now dead code since 8 years remove that unused feature.
src-test/src/org/openbravo/test/xml/EntityXMLImportTestBusinessObject.java
src-test/src/org/openbravo/test/xml/EntityXMLImportTestSingle.java
src-test/src/org/openbravo/test/xml/UniqueConstraintImportTest.java
src-test/src/org/openbravo/test/xml/XMLBaseTest.java
src/org/openbravo/dal/xml/EntityXMLConverter.java
src/org/openbravo/dal/xml/ModelXMLConverter.java
src/org/openbravo/dal/xml/XMLConstants.java
src/org/openbravo/service/db/DataExportService.java
Stefan Hühner <[email protected]> null
Fixed 37497. Remove deprecated and unused DalUUIDHexGenerator class.
That class was made obsolete and unuse in 2011.
Also no user in getAllModules exists.
So remove it as dead code.
src/org/openbravo/dal/core/DalUUIDHexGenerator.java
Stefan Hühner <[email protected]> null
Fixed 37496. Remove unused CalculateCoreRevision
That class is unused since commit cd0c49fbd501 from 2012-03-02.
Search in getAllModules did not find any user.
src/org/openbravo/erpCommon/utility/CalculateCoreRevision.java
Stefan Hühner <[email protected]> null
Fixed 36433. Delete long time deprecated and unused
DataSourceJaaScriptCreator
This class has been deprecated long time ago and is also not used anywhere in
pi.
Checking getAllModules also does not show any user.
Same applies for the deprecated getter method in the BaseDataSourceService.
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceJavaScriptCreator.java
Asier Lostalé <[email protected]> null
fixed issue 37683: Axis services page is always available
- SOAP ws are disabled by default
- removed org.apache.axis.transport.http.AdminServlet entry in web.xml which
didn't have mapping anyway
src-db/database/sourcedata/AD_MODEL_OBJECT.xml
David Miguelez <[email protected]> null
Related to Issue 37661.
Removed call to addDataToResponse when not needed.
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
Armaignac <[email protected]> null
Fixes issue 37661:Wrong navigation from Journal Entries Report when using
Simple
GL Journal
In the Journal Entries Report the documents created using Simple GL Journal a
wrong
navigation was get by clicking on "entry number" you are carried to GL Journal
instead
of Simple GL Journal so no entry is loaded.
A new navegation rule is created to open Simple GL Journal window when
journalBatch
is null, also the query was modified to properly set the tab_id taking into
account
the journal batch value
src-db/database/sourcedata/AD_TABLE_NAVIGATION.xml
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal_data.xsql
src/org/openbravo/erpCommon/utility/ReferencedLink.java
Last 20 lines of the console output:
[...truncated 4405 lines...]
Connected to:
Oracle Database 11g Release 11.2.0.1.0 - 64bit Production
SQL>
Call completed.
SQL> Disconnected from Oracle Database 11g Release 11.2.0.1.0 - 64bit Production
+ run_ora_command 'column object_name format a32
SELECT object_id, object_name, object_type FROM user_objects WHERE
status<>'\''VALID'\'' AND object_type IN('\''VIEW'\'', '\''PACKAGE'\'',
'\''PACKAGE BODY'\'', '\''FUNCTION'\'', '\''PROCEDURE'\'', '\''TRIGGER'\'',
'\''JAVA CLASS'\'') ORDER BY object_type, object_name;'
+ ssh [email protected]
Pseudo-terminal will not be allocated because stdin is not a terminal.
+ grep -q OBJECT_ID /tmp/int-dbcons-oracle_objects
+ true
+ exit 0
Checking console output
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
