int-full-pgsql-compile-all - Build # 1513 - Fixed:

Check console output at 
https://ci.openbravo.com/job/int-full-pgsql-compile-all/1513/ to view the 
results.


Committers since last success:

Changes for Build #1512

    Asier Lostalé <[email protected]> null
    fixed bug 37437: useless session cache of window.isSOTrx

  Now isSOTrx propery is not cached in session for each window in the system,
  instead its value is obtained from application scoped ADCS when required:
   - In Utility.getConext
   - In OBBindings
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
        src/org/openbravo/base/secureApp/Attribute_data.xsql
        src/org/openbravo/base/secureApp/LoginUtils.java
        src/org/openbravo/erpCommon/utility/Utility.java

    Asier Lostalé <[email protected]> null
    related to bug 37437: useless session cache of window.isSOTrx

  Reapplied backed out changeset.

  Some code minor clean up:
    - Removed some duplicity
    - Fixed format in some comments
    - ...
        src/org/openbravo/erpCommon/utility/Utility.java

    Asier Lostalé <[email protected]> null
    related to bug 37437 related to bug 37544: added test case

  covering regression #37544
        src-test/src/org/openbravo/test/datasource/OtherDatasourceRequests.java
        src-test/src/org/openbravo/test/AllWebserviceTests.java

    Stefan Hühner <[email protected]> null
    Fixed 37825. Fix javadoc syntax to not show warnings with JDK 9.

Javadoc from Java9 is more strict by enabling a subset of -Xdoclint:html and
complains about any unescaped <,>,& in comments.

Apart from fixing all those in pi also undo the addition of -Xdoclint:none
to build.xml to let javadoc check those again.
        build.xml
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ExtraWindowSettingsInjector.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/ReorderCascadingChildDeletionsHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
        
src-test/src/org/openbravo/advpaymentmngt/test/DocumentNumberGeneration.java
        src-test/src/org/openbravo/test/base/BaseTest.java
        src-test/src/org/openbravo/test/base/OBBaseTest.java
        
src-test/src/org/openbravo/test/db/model/functions/Ad_isorgincludedTest.java
        src-test/src/org/openbravo/test/pricelist/data/PriceListTestData.java
        
src-test/src/org/openbravo/test/role/inheritance/RoleInheritanceTestUtils.java
        
src-test/src/org/openbravo/test/role/inheritance/VerticalInheritance.java
        src-test/src/org/openbravo/test/xml/ClientExportImportTest.java
        src/org/openbravo/base/util/Check.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateTax.java
        
src/org/openbravo/common/datasource/ReturnFromCustomerVendorPropertyFieldsTransformer.java
        src/org/openbravo/dal/core/DalRequestFilter.java
        src/org/openbravo/dal/xml/StaxXMLEntityConverter.java
        src/org/openbravo/erpCommon/ad_forms/Fact.java
        src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
        src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
        src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
        src/org/openbravo/erpCommon/modules/ImportModule.java
        src/org/openbravo/erpCommon/modules/VersionUtility.java
        src/org/openbravo/erpCommon/obps/ActivationKey.java
        src/org/openbravo/erpCommon/utility/BasicUtility.java
        src/org/openbravo/erpCommon/utility/HttpsUtils.java
        src/org/openbravo/erpCommon/utility/OBMessageUtils.java
        src/org/openbravo/erpCommon/utility/Utility.java
        src/org/openbravo/jmx/MBeanRegistry.java

    Víctor Martínez Romanos <[email protected]> null
    Fixed issue 37827: [ri] updated copyright year
        src/org/openbravo/erpCommon/ad_callouts/SE_RefInventory_RefInvType.java
        src/org/openbravo/event/ReferenceInventoryEventHandler.java
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Javier Armendáriz <[email protected]> null
    Fixed bug 37587: Opening tab with display logic using aux input appears 
empty.

ShowTabIf logic applied only if the view does not come from a direct link call. 
This fixed the issue with no wait until the contextInfo is fully loaded.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js

    Víctor Martínez Romanos <[email protected]> null
    Fixed issue 37827: [ri] Removed TODO as no need of hooks
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java

    Víctor Martínez Romanos <[email protected]> null
    Fixed issue 37827: [ri] Added Referenced Inventory support
      
    Víctor Martínez Romanos <[email protected]> null
    [ri] Fixes exception in Oracle,
Add reservation preference if necessary
        src-db/database/model/functions/M_MOVEMENT_POST.xml
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Shared flag is always readonly
        src-db/database/sourcedata/AD_FIELD.xml

    Víctor Martínez Romanos <[email protected]> null
    pi merge
      
    Víctor Martínez Romanos <[email protected]> null
    [ri] Avoid editing Attributes when linked to RI
        src-db/database/sourcedata/AD_MESSAGE.xml
        src/org/openbravo/erpCommon/info/AttributeSetInstance.java
        src/org/openbravo/erpCommon/utility/AttributeSetInstanceValue.java
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Improvements in Box/Unbox grid
        src-db/database/sourcedata/AD_FIELD.xml

    Víctor Martínez Romanos <[email protected]> null
    [ri] fixes issues found in CI
        src-db/database/model/tables/M_REFINVENTORY.xml
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <[email protected]> null
    pi merge
      
    Víctor Martínez Romanos <[email protected]> null
    [ri] Force Bin or Attribute at reservation header
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxForcedReservation.java
        src-db/database/sourcedata/AD_MESSAGE.xml
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestSuite.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        src/org/openbravo/materialmgmt/refinventory/ReservationManager.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Added storage details check after unboxing with reservations
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxReservationTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] extended allocated flag check
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] improved unbox reservation tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] simplified unbox reservation tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] removed useless throws
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] removed useless null checks
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] More improvements in JUnit tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Run more tests for all unboxing flows
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] properly test reservation qty in boxing
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] removed useless method in tests and simplified test condition
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] fixed getStorageDetails in tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryExceptionTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] minor fixes en tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Added missed class
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Support for reservations
JUnit tests in progress
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxFullReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxSeveralStorageDetailsTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryExceptionTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventorySequenceTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestSuite.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxReservationTest.java
        src/org/openbravo/materialmgmt/refinventory/ReservationManager.java
        src-db/database/model/functions/M_MOVEMENT_POST.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-test/src/org/openbravo/test/AllAntTaskTests.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Tests for Box and Unbox referenced inventory
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java
        src-test/src/org/openbravo/test/AllAntTaskTests.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Removed unused method
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Refactor in Processors to avoid code duplication
        
src/org/openbravo/common/actionhandler/ReferencedInventoryUnBoxHandler.java
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
        src/org/openbravo/materialmgmt/refinventory/UnboxProcessor.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] getReferencedInventory only makes sense in boxing
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
        src/org/openbravo/materialmgmt/refinventory/UnboxProcessor.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Fixed several issues
In Box the new storage bin parameter must be mandatory
Unbox did wrong verification on previously linked to a referenced inventory
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        
src/org/openbravo/common/actionhandler/ReferencedInventoryBoxHandler.java
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Referenced Inventory window is a Transactional window
        src-db/database/sourcedata/AD_WINDOW.xml

    Víctor Martínez Romanos <[email protected]> null
    [ri] Added validation to avoid child referenced inventories
        src-db/database/model/tables/M_STORAGE_DETAIL.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_TAB.xml
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Added validation RI in unique bin
        src-db/database/sourcedata/AD_MESSAGE.xml
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java

    Víctor Martínez Romanos <[email protected]> null
    pi merge
      
    Víctor Martínez Romanos <[email protected]> null
    pi merge
      
    Víctor Martínez Romanos <[email protected]> null
    [ri] Represent ReferencedInventoy inside [] in attribute desc
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] Added ReferencedInventory to attribute set instance description
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <[email protected]> null
    [ri] New selector in StorageDetail.Locator
        src-db/database/sourcedata/AD_COLUMN.xml

    Víctor Martínez Romanos <[email protected]> null
    [ri] Box and Unbox processes
        
src/org/openbravo/common/actionhandler/ReferencedInventoryBoxHandler.java
        
src/org/openbravo/common/actionhandler/ReferencedInventoryUnBoxHandler.java
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
        src/org/openbravo/materialmgmt/refinventory/UnboxProcessor.java
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
        src-db/database/model/functions/M_MOVEMENT_POST.xml
        src-db/database/model/functions/M_UPDATE_INVENTORY.xml
        src-db/database/model/tables/M_REFINVENTORY.xml
        src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_WINDOW.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_PROCESS.xml
        src-db/database/sourcedata/OBUIAPP_REF_WINDOW.xml
        src/org/openbravo/erpCommon/ad_callouts/SE_RefInventory_RefInvType.java
        src/org/openbravo/event/ReferenceInventoryEventHandler.java
        src/org/openbravo/erpCommon/utility/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <[email protected]> null
    pi merge
      
    Víctor Martínez Romanos <[email protected]> null
    [ri] Added data model, windows and sequence management code
        src-db/database/model/tables/M_REFINVENTORY.xml
        src-db/database/model/tables/M_REFINVENTORY_TYPE.xml
        src/org/openbravo/erpCommon/ad_callouts/SE_RefInventory_RefInvType.java
        src/org/openbravo/erpCommon/utility/ReferencedInventoryUtil.java
        src/org/openbravo/event/ReferenceInventoryEventHandler.java
        src-db/database/model/tables/M_ATTRIBUTESETINSTANCE.xml
        src-db/database/model/tables/M_MOVEMENTLINE.xml
        src-db/database/model/tables/M_STORAGE_DETAIL.xml
        src-db/database/sourcedata/AD_CALLOUT.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MENU.xml
        src-db/database/sourcedata/AD_MODEL_OBJECT.xml
        src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/AD_TREENODE.xml
        src-db/database/sourcedata/AD_WINDOW.xml

    Carlos Aristu <[email protected]> null
    related to issue 37734: Protection against ping disabling + minor 
improvements
      
    Carlos Aristu <[email protected]> null
    [ha] Show service name in log message
        src/org/openbravo/cluster/ClusterServiceManager.java

    Carlos Aristu <[email protected]> null
    [ha] Added missing javadoc
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/service/importprocess/ImportEntryManager.java

    Carlos Aristu <[email protected]> null
    [ha] Fix typo
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/cluster/ClusterService_data.xsql

    Carlos Aristu <[email protected]> null
    [ha] Move the start/end processing notification into the 
ImportEntryProcessor
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/service/importprocess/ImportEntryManager.java
        src/org/openbravo/service/importprocess/ImportEntryProcessor.java

    Asier Lostalé <[email protected]> null
    [ha] typo
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/cluster/JmxClusterServiceManager.java

    Carlos Aristu <[email protected]> null
    [ha] Added log info when disabling ping while processing
        src/org/openbravo/cluster/ClusterService.java

    Carlos Aristu <[email protected]> null
    [ha] Reset processing attributes when a new node can take the leadership
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/cluster/ClusterServiceManager.java

    Carlos Aristu <[email protected]> null
    [ha] Added protection against ping disabling while processing import entries
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/cluster/ClusterServiceManager.java
        src/org/openbravo/cluster/ClusterService_data.xsql
        src/org/openbravo/cluster/JmxClusterServiceManager.java
        src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
        src/org/openbravo/service/importprocess/ImportEntryManager.java

Changes for Build #1513

    Augusto Mauch <[email protected]> null
    Related with issue 37451: Adds tests

Tests have been added to check that the datasource returns properly the results 
using the updated criteria.

Selenium tests with the current infrastructure are not possible, since when 
they filter the grid, they do not
select the checkboxes of the foreign key combo boxes, they just enter the text 
in the filter input, and if done
that way the issue is not reproducible.
        src-test/src/org/openbravo/test/datasource/NonIdForeignKeyFilters.java
        src-test/src/org/openbravo/test/AllWebserviceTests.java

    Augusto Mauch <[email protected]> null
    Fixes issue 37451: Fixes filtering of fks that dont use ids as key

The problem was that the foreign keys that did not use and id column as key 
(i.e. ad_country.ad_language) were not being properly
filtered locally in smartclient, because the criteria used the id of the 
referenced record, that was not available in the browser (it
was available in the query done in the back end, that is why only the 
client-side filtering was not working).

For instance, if the ad_language foreign key reference uses as key 
ad_language.ad_language instead of ad_language.ad_language_id, the criteria
will no longer be:

{
  fieldName: 'language',
  operator: 'equals',
  value: '192'
}

Now it will be:

{
  fieldName: 'language',
  operator: 'equals',
  value: 'en_US'
}

The AdvancedQueryBuilder has been adapted to support the new type of criteria.

There are also changes on ob-grid.js and ob-formitem-fk-filter to ensure that 
the criteria is properly displayed in the filter input.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
        
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
        
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java

    Víctor Martínez Romanos <[email protected]> null
    Fixed issue 37827: [ri] clear session after each individual test execution
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxForcedReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxFullReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxSeveralStorageDetailsTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java

    Víctor Martínez Romanos <[email protected]> null
    Fixed issue 37827: [ri] clear session after each test execution
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java




Last 20 lines of the console output:

[...truncated 1854 lines...]
Executed 2974 SQL command(s) successfully in 2659 ms

database.postupdate.POSTGRE:
      [sql] Executing commands
      [sql] 5 of 5 SQL statements executed successfully
      [sql] Executing commands
      [sql] 2 of 2 SQL statements executed successfully

setApplied:
      [sql] Executing commands
      [sql] 2 of 2 SQL statements executed successfully

BUILD SUCCESSFUL
Total time: 2 minutes 33 seconds

Checking console output
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-builds

Reply via email to