up-2.50topi-oracle - Build # 229 - Fixed:

Check console output at https://ci.openbravo.com/job/up-2.50topi-oracle/229/ to 
view the results.


Committers since last success:

Changes for Build #226

    Augusto Mauch <augusto.ma...@openbravo.com> null
    Related with issue 37867: Commented out code meant for debug has been 
restored
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java

    David Miguelez <david.migue...@openbravo.com> null
    fixed bug 36829: can't display long process execution logs

  Even in database is defined as an arbitary lenght text, logs were truncated
  to 4K characters. This artificial restriction has been removed, so that logs
  can now be longer.
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src/org/openbravo/scheduling/ProcessMonitor.java

    Augusto Mauch <augusto.ma...@openbravo.com> null
    Fixes issue 37867: Adds missing admin mode
        
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed bug 37648: slow junit ViewTest test cases

  testViews (renamed to viewsCanBeQueried)
    * Queries all the visible records for all views in system loading those 
records
      in memory. Now, record is limited to just one and we stop querying views 
once
      one record is retrieved.

  test14914
    * All invoices in the instance were loaded in memory loading for those all 
their
      payments and making a copy. Now only one invoice is loaded.
        src-test/src/org/openbravo/test/dal/ViewTest.java

    Mark <markm...@gmail.com> null
    Fixes issue 37823: Sales tax selected in Return To Vendor if the returned 
goods
receipt does not have a purchase order related

A wrong sales tax was selected in Return To Vendor if the returned goods receipt
does not have a purchase order related.

The Tax field has the Tax Id value of the receipt line being copied, in case
that the good receipt line was created from an order then it will have the tax 
id
used on the order line. But in case the goods receipt line was created 
manually, as
it lines aren't related to any order lines, the tax received will be NULL, so 
it is
needed to get the default Tax to be used in the new generated returned line.

In the case of a Return to Vendor is needed to return the default Purchase Tax 
of the
product. In the case of Return from Customer is neede to use the default Sales 
tax
of the product. It was fixed passing this parameter taking into account the 
processed
order is sales transaction or not.
        src/org/openbravo/common/actionhandler/SRMOPickEditLines.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    related to bug 37857: minor optimizations

  * FIC uses multiple ids only for attachemnts, we can initialize it only in 
that case
  * In convertJSONArray use more generic variable name
  * In convertJSONArray we know which will be the array size, so it can be 
initialized
    using it
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    fixes bug 37857: Wrong FIC request after selecting hundreds of records

  The MULTIPLE_ROW_IDS parameter contains the ids of the selected records that 
are sent to the FIC. They are used to check if there exists attachments within 
the selection and in that case enable the attachment button of the toolbar or 
display the number of attachments of the current record in case we are in form 
view.

  This information was being sent as part of the request URL in the HTTP header 
which in case of having hundreds of records, the maximum size allowed for the 
request URL was being exceeded.

  To fix this problem, now the MULTIPLE_ROW_IDS parameter is sent within the 
body of the FIC request.
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed issue 37827: [ri] Added message to Application Dictionary
        src-db/database/sourcedata/AD_MESSAGE.xml
        src/org/openbravo/materialmgmt/refinventory/UnboxProcessor.java

    Armaignac <collazoan...@gmail.com> null
    Fixes issue 37763: Trial Balance Report sometimes returns null pointer 
exception
when include zero figures is checked.

When zero figures is checked the matches accounts are skipped from vector list
causing null entries when the vector values are copied with different sizes

Now the dataZeroFigures size is equal to the vector size to avoid null entries
        src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    realted to issue 37849: remove system key hash in log files

  Restored ActivationKey.getOpsLogId method as it is public and used
        src/org/openbravo/erpCommon/obps/ActivationKey.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed issue 37849: remove system key hash in log files

  This hash has been removed as it is not useful and complicates log parsing
        src/org/openbravo/erpCommon/obps/ActivationKey.java

    Mark <markm...@gmail.com> null
    Fixes issue 37724: Error when cancel and replace a sales order of zero 
amount

When an order with grand total of ZERO is created and booked, no Payment Plan is
created for it, so when she is cancelled and replaced the new created orders 
haven't
payment plans neither.

So, when the Cancell and Replace process is executed on orders of this kind, the
it was failing trying to get get the payment schedule detail of the oldOrder and
an exception was thrown.

To fix this issue, only will be created Payments to orders with grand total 
different
than ZERO to avoid the exception and keep the current behaviour for this kind 
of orders
        src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java

    Armaignac <collazoan...@gmail.com> null
    Fixes issue 37837:Tax selected is based on the invoicing address instead of 
the
partner address

Wrong tax is selected when selecting a business partner with different invoicing
and shipping address, the invoicing address was used as shipping

Now the correct business partner address is selected to properly get the product
tax
        src/org/openbravo/common/actionhandler/OrderCreatePOLines.java
        src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
        src/org/openbravo/erpCommon/ad_actionButton/RMInsertOrphanLine.java

    Mark <markm...@gmail.com> null
    Fixed issue 37798: Add Characteristic to Product does not update the
Characteristic Description

When adding a characteristic value to an existing product its Characteristic 
Description
field should update with the new value but wasn't doing as expected.

To fix, ii passed True as commitAndClose to commit and notify the import entry 
creation
on the event handler.
        src/org/openbravo/event/ProductCharacteristicValueEventHandler.java

    David Miguelez <david.migue...@openbravo.com> null
    Fixes Issue 37772. Adds several indexes that improve performance
in basic operations like deleting an Invoice or an Order
        src-db/database/model/tables/C_INVOICELINE.xml
        src-db/database/model/tables/C_ORDER.xml
        src-db/database/model/tables/M_COSTING.xml
        src-db/database/model/tables/M_INOUT.xml
        src-db/database/model/tables/M_MATCHPO.xml

    Carlos Aristu <carlos.ari...@openbravo.com> null
    related to issue 37734: use getClusterServices() method in 
ClusterServiceThread

 This allows us to make more extensible the ClusterServiceManager for testing 
purposes.
        src/org/openbravo/cluster/ClusterServiceManager.java

    Augusto Mauch <augusto.ma...@openbravo.com> null
    Related with issue 37451: Adds tests

Tests have been added to check that the datasource returns properly the results 
using the updated criteria.

Selenium tests with the current infrastructure are not possible, since when 
they filter the grid, they do not
select the checkboxes of the foreign key combo boxes, they just enter the text 
in the filter input, and if done
that way the issue is not reproducible.
        src-test/src/org/openbravo/test/datasource/NonIdForeignKeyFilters.java
        src-test/src/org/openbravo/test/AllWebserviceTests.java

    Augusto Mauch <augusto.ma...@openbravo.com> null
    Fixes issue 37451: Fixes filtering of fks that dont use ids as key

The problem was that the foreign keys that did not use and id column as key 
(i.e. ad_country.ad_language) were not being properly
filtered locally in smartclient, because the criteria used the id of the 
referenced record, that was not available in the browser (it
was available in the query done in the back end, that is why only the 
client-side filtering was not working).

For instance, if the ad_language foreign key reference uses as key 
ad_language.ad_language instead of ad_language.ad_language_id, the criteria
will no longer be:

{
  fieldName: 'language',
  operator: 'equals',
  value: '192'
}

Now it will be:

{
  fieldName: 'language',
  operator: 'equals',
  value: 'en_US'
}

The AdvancedQueryBuilder has been adapted to support the new type of criteria.

There are also changes on ob-grid.js and ob-formitem-fk-filter to ensure that 
the criteria is properly displayed in the filter input.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
        
modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/ForeignKeyUIDefinition.java
        
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed issue 37827: [ri] clear session after each individual test execution
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxForcedReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxFullReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxSeveralStorageDetailsTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed issue 37827: [ri] clear session after each test execution
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    fixed bug 37437: useless session cache of window.isSOTrx

  Now isSOTrx propery is not cached in session for each window in the system,
  instead its value is obtained from application scoped ADCS when required:
   - In Utility.getConext
   - In OBBindings
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/OBBindings.java
        src/org/openbravo/base/secureApp/Attribute_data.xsql
        src/org/openbravo/base/secureApp/LoginUtils.java
        src/org/openbravo/erpCommon/utility/Utility.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    related to bug 37437: useless session cache of window.isSOTrx

  Reapplied backed out changeset.

  Some code minor clean up:
    - Removed some duplicity
    - Fixed format in some comments
    - ...
        src/org/openbravo/erpCommon/utility/Utility.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    related to bug 37437 related to bug 37544: added test case

  covering regression #37544
        src-test/src/org/openbravo/test/datasource/OtherDatasourceRequests.java
        src-test/src/org/openbravo/test/AllWebserviceTests.java

    Stefan Hühner <stefan.hueh...@openbravo.com> null
    Fixed 37825. Fix javadoc syntax to not show warnings with JDK 9.

Javadoc from Java9 is more strict by enabling a subset of -Xdoclint:html and
complains about any unescaped <,>,& in comments.

Apart from fixing all those in pi also undo the addition of -Xdoclint:none
to build.xml to let javadoc check those again.
        build.xml
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ExtraWindowSettingsInjector.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/ParameterUtils.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/ReorderCascadingChildDeletionsHandler.java
        
modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
        
src-test/src/org/openbravo/advpaymentmngt/test/DocumentNumberGeneration.java
        src-test/src/org/openbravo/test/base/BaseTest.java
        src-test/src/org/openbravo/test/base/OBBaseTest.java
        
src-test/src/org/openbravo/test/db/model/functions/Ad_isorgincludedTest.java
        src-test/src/org/openbravo/test/pricelist/data/PriceListTestData.java
        
src-test/src/org/openbravo/test/role/inheritance/RoleInheritanceTestUtils.java
        
src-test/src/org/openbravo/test/role/inheritance/VerticalInheritance.java
        src-test/src/org/openbravo/test/xml/ClientExportImportTest.java
        src/org/openbravo/base/util/Check.java
        
src/org/openbravo/common/actionhandler/copyfromorderprocess/UpdateTax.java
        
src/org/openbravo/common/datasource/ReturnFromCustomerVendorPropertyFieldsTransformer.java
        src/org/openbravo/dal/core/DalRequestFilter.java
        src/org/openbravo/dal/xml/StaxXMLEntityConverter.java
        src/org/openbravo/erpCommon/ad_forms/Fact.java
        src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceUtils.java
        src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
        src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
        src/org/openbravo/erpCommon/modules/ImportModule.java
        src/org/openbravo/erpCommon/modules/VersionUtility.java
        src/org/openbravo/erpCommon/obps/ActivationKey.java
        src/org/openbravo/erpCommon/utility/BasicUtility.java
        src/org/openbravo/erpCommon/utility/HttpsUtils.java
        src/org/openbravo/erpCommon/utility/OBMessageUtils.java
        src/org/openbravo/erpCommon/utility/Utility.java
        src/org/openbravo/jmx/MBeanRegistry.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed issue 37827: [ri] updated copyright year
        src/org/openbravo/erpCommon/ad_callouts/SE_RefInventory_RefInvType.java
        src/org/openbravo/event/ReferenceInventoryEventHandler.java
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Javier Armendáriz <javier.armenda...@openbravo.com> null
    Fixed bug 37587: Opening tab with display logic using aux input appears 
empty.

ShowTabIf logic applied only if the view does not come from a direct link call. 
This fixed the issue with no wait until the contextInfo is fully loaded.
        
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed issue 37827: [ri] Removed TODO as no need of hooks
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    Fixed issue 37827: [ri] Added Referenced Inventory support
      
    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Fixes exception in Oracle,
Add reservation preference if necessary
        src-db/database/model/functions/M_MOVEMENT_POST.xml
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Shared flag is always readonly
        src-db/database/sourcedata/AD_FIELD.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    pi merge
      
    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Avoid editing Attributes when linked to RI
        src-db/database/sourcedata/AD_MESSAGE.xml
        src/org/openbravo/erpCommon/info/AttributeSetInstance.java
        src/org/openbravo/erpCommon/utility/AttributeSetInstanceValue.java
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Improvements in Box/Unbox grid
        src-db/database/sourcedata/AD_FIELD.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] fixes issues found in CI
        src-db/database/model/tables/M_REFINVENTORY.xml
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    pi merge
      
    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Force Bin or Attribute at reservation header
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxForcedReservation.java
        src-db/database/sourcedata/AD_MESSAGE.xml
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestSuite.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        src/org/openbravo/materialmgmt/refinventory/ReservationManager.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Added storage details check after unboxing with reservations
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxReservationTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] extended allocated flag check
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] improved unbox reservation tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] simplified unbox reservation tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] removed useless throws
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] removed useless null checks
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] More improvements in JUnit tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Run more tests for all unboxing flows
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] properly test reservation qty in boxing
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] removed useless method in tests and simplified test condition
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] fixed getStorageDetails in tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryExceptionTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] minor fixes en tests
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Added missed class
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Support for reservations
JUnit tests in progress
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxFullReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxOverReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxPartialReservationTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxSeveralStorageDetailsTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryExceptionTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryFullUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxFullReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxPartialReservation.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryPartialUnboxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventorySequenceTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestSuite.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxReservationTest.java
        src/org/openbravo/materialmgmt/refinventory/ReservationManager.java
        src-db/database/model/functions/M_MOVEMENT_POST.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-test/src/org/openbravo/test/AllAntTaskTests.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Tests for Box and Unbox referenced inventory
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryBoxTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTest.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryTestUtils.java
        
src-test/src/org/openbravo/test/referencedinventory/ReferencedInventoryUnboxTest.java
        src-test/src/org/openbravo/test/AllAntTaskTests.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Removed unused method
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Refactor in Processors to avoid code duplication
        
src/org/openbravo/common/actionhandler/ReferencedInventoryUnBoxHandler.java
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
        src/org/openbravo/materialmgmt/refinventory/UnboxProcessor.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] getReferencedInventory only makes sense in boxing
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
        src/org/openbravo/materialmgmt/refinventory/UnboxProcessor.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Fixed several issues
In Box the new storage bin parameter must be mandatory
Unbox did wrong verification on previously linked to a referenced inventory
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        
src/org/openbravo/common/actionhandler/ReferencedInventoryBoxHandler.java
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Referenced Inventory window is a Transactional window
        src-db/database/sourcedata/AD_WINDOW.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Added validation to avoid child referenced inventories
        src-db/database/model/tables/M_STORAGE_DETAIL.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_TAB.xml
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Added validation RI in unique bin
        src-db/database/sourcedata/AD_MESSAGE.xml
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    pi merge
      
    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    pi merge
      
    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Represent ReferencedInventoy inside [] in attribute desc
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Added ReferencedInventory to attribute set instance description
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] New selector in StorageDetail.Locator
        src-db/database/sourcedata/AD_COLUMN.xml

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Box and Unbox processes
        
src/org/openbravo/common/actionhandler/ReferencedInventoryBoxHandler.java
        
src/org/openbravo/common/actionhandler/ReferencedInventoryUnBoxHandler.java
        src/org/openbravo/materialmgmt/refinventory/BoxProcessor.java
        
src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryProcessor.java
        src/org/openbravo/materialmgmt/refinventory/ReferencedInventoryUtil.java
        src/org/openbravo/materialmgmt/refinventory/UnboxProcessor.java
        
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
        src-db/database/model/functions/M_MOVEMENT_POST.xml
        src-db/database/model/functions/M_UPDATE_INVENTORY.xml
        src-db/database/model/tables/M_REFINVENTORY.xml
        src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MESSAGE.xml
        src-db/database/sourcedata/AD_REFERENCE.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_WINDOW.xml
        src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
        src-db/database/sourcedata/OBUIAPP_PROCESS.xml
        src-db/database/sourcedata/OBUIAPP_REF_WINDOW.xml
        src/org/openbravo/erpCommon/ad_callouts/SE_RefInventory_RefInvType.java
        src/org/openbravo/event/ReferenceInventoryEventHandler.java
        src/org/openbravo/erpCommon/utility/ReferencedInventoryUtil.java

    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    pi merge
      
    Víctor Martínez Romanos <victor.marti...@openbravo.com> null
    [ri] Added data model, windows and sequence management code
        src-db/database/model/tables/M_REFINVENTORY.xml
        src-db/database/model/tables/M_REFINVENTORY_TYPE.xml
        src/org/openbravo/erpCommon/ad_callouts/SE_RefInventory_RefInvType.java
        src/org/openbravo/erpCommon/utility/ReferencedInventoryUtil.java
        src/org/openbravo/event/ReferenceInventoryEventHandler.java
        src-db/database/model/tables/M_ATTRIBUTESETINSTANCE.xml
        src-db/database/model/tables/M_MOVEMENTLINE.xml
        src-db/database/model/tables/M_STORAGE_DETAIL.xml
        src-db/database/sourcedata/AD_CALLOUT.xml
        src-db/database/sourcedata/AD_COLUMN.xml
        src-db/database/sourcedata/AD_ELEMENT.xml
        src-db/database/sourcedata/AD_FIELD.xml
        src-db/database/sourcedata/AD_MENU.xml
        src-db/database/sourcedata/AD_MODEL_OBJECT.xml
        src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
        src-db/database/sourcedata/AD_TAB.xml
        src-db/database/sourcedata/AD_TABLE.xml
        src-db/database/sourcedata/AD_TREENODE.xml
        src-db/database/sourcedata/AD_WINDOW.xml

    Carlos Aristu <carlos.ari...@openbravo.com> null
    related to issue 37734: Protection against ping disabling + minor 
improvements
      
    Carlos Aristu <carlos.ari...@openbravo.com> null
    [ha] Show service name in log message
        src/org/openbravo/cluster/ClusterServiceManager.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    [ha] Added missing javadoc
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/service/importprocess/ImportEntryManager.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    [ha] Fix typo
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/cluster/ClusterService_data.xsql

    Carlos Aristu <carlos.ari...@openbravo.com> null
    [ha] Move the start/end processing notification into the 
ImportEntryProcessor
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/service/importprocess/ImportEntryManager.java
        src/org/openbravo/service/importprocess/ImportEntryProcessor.java

    Asier Lostalé <asier.lost...@openbravo.com> null
    [ha] typo
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/cluster/JmxClusterServiceManager.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    [ha] Added log info when disabling ping while processing
        src/org/openbravo/cluster/ClusterService.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    [ha] Reset processing attributes when a new node can take the leadership
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/cluster/ClusterServiceManager.java

    Carlos Aristu <carlos.ari...@openbravo.com> null
    [ha] Added protection against ping disabling while processing import entries
        src/org/openbravo/cluster/ClusterService.java
        src/org/openbravo/cluster/ClusterServiceManager.java
        src/org/openbravo/cluster/ClusterService_data.xsql
        src/org/openbravo/cluster/JmxClusterServiceManager.java
        src/org/openbravo/service/importprocess/ImportEntryArchiveManager.java
        src/org/openbravo/service/importprocess/ImportEntryManager.java

Changes for Build #227
No changes

Changes for Build #228

    David Miguelez <david.migue...@openbravo.com> null
    Related to Issue 37843. Code Review changes.

Refactor code to improve redability:
* Encapsulated order parameters into a sub class that can be
  shared between methods
* Split code of methods to reduce cognitive complexity
* Removed comments since the code is self explanatory enough
        src/org/openbravo/event/OrderEventHandler.java

    Mark <markm...@gmail.com> null
    Fixes issue 37843: OrderEventHandler does useless and repeated queries when 
not
needed.

OrderEventHandler class has been refactorized:
- Removed unused vars.
- Renamed newWarehouseId to newWarehouse as it store a Warehouse object instead 
of an ID
- Renamed oldWarehouseId to oldWarehouse as it store a Warehouse object instead 
of an ID
- Only executed query to get preferences after verify that values have changed. 
This way
  it avoids to execute unneeded queries.
- Saved the orderLineCriteria.list() in a variable to avoid execute the same 
query more than once.
- Merged the three used loops updating fields in only one that updates fields 
if needed.
- Only loop is executed if at least one of the expected fields is changed and 
it is not
  activated the related preference.
- Created new methods to make code more cleaned and reuse in similar cases.
        src/org/openbravo/event/OrderEventHandler.java

    Armaignac <collazoan...@gmail.com> null
    Fixes issue 37775:Cannot create an outbound picking list for a partially 
shipped
sales order

When the shipment has removed all the stock a new reservation line is created
with 0 reservedqty and releasedqty to correct the product reservation values and
the the reservation line is removed.
        src-db/database/model/functions/M_CREATE_RESERVE_FROM_SOL.xml

Changes for Build #229
No changes




Last 20 lines of the console output:

[...truncated 4391 lines...]

Connected to:
Oracle Database 12c Release 12.1.0.1.0 - 64bit Production

SQL> 
Call completed.

SQL> Disconnected from Oracle Database 12c Release 12.1.0.1.0 - 64bit Production
+ run_ora_command 'column object_name format a32
SELECT object_id, object_name, object_type FROM user_objects WHERE 
status<>'\''VALID'\'' AND object_type IN('\''VIEW'\'', '\''PACKAGE'\'', 
'\''PACKAGE BODY'\'', '\''FUNCTION'\'', '\''PROCEDURE'\'', '\''TRIGGER'\'', 
'\''JAVA CLASS'\'') ORDER BY object_type, object_name;'
+ ssh oracle@10.0.3.12
Pseudo-terminal will not be allocated because stdin is not a terminal.
+ grep -q OBJECT_ID /tmp/int-dbcons-oracle_objects
+ true
+ exit 0
Checking console output
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openbravo-builds mailing list
Openbravo-builds@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-builds

Reply via email to