int-dummy-pgsql - Build # 2635 - Fixed:
Check console output at https://ci.openbravo.com/job/int-dummy-pgsql/2635/ to
view the results.
Committers since last success:
Changes for Build #2634
Carlos Aristu <carlos.ari...@openbravo.com> null
related to issue 40046: make observer be stateless
modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RemoveImagesEventHandler.java
Changes for Build #2635
Asier Lostalé <asier.lost...@openbravo.com> null
fixed issue 38258: removed obsolete code from ToolBar class
Asier Lostalé <asier.lost...@openbravo.com> null
issue 38258: minor cleanup
src/org/openbravo/erpCommon/utility/ToolBar.java
Asier Lostalé <asier.lost...@openbravo.com> null
issue 38258: applied new Java format
src/org/openbravo/erpCommon/utility/ToolBar.java
Asier Lostalé <asier.lost...@openbravo.com> null
issue 38258: pi merge
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove ToolBar_Link class as it is never used.
src/org/openbravo/erpCommon/utility/ToolBar_Link.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove unused AUDIT_SHOW_RELATION_DISABLED button.
As that is effectively remove in all prepare*Template method anyway.
Also do some follow up cleanup in getButtonScript removing the now
obsolete
- SAVE
- AUDIT_EDITION
- AUDIT_RELATION
cases.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Simplify prepareRelationTemplateNoSearch.
The only caller of this function (Transactions servlet) calls a the 2nd
prepareSimpleToolBarTemplate function directly after.
That allows to delete nearly all removeElement calls from the first as those
are done anyway by the 2nd prepareSimpleToolBarTemplate later.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove isReference parameter from transformElementsToString.
After last commit that function is never called with that parameter set to true
So remove it from the function simplifying the code.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove 'RELATED_INFO' button aka "Linked Items" as it is
obsolete.
That buttons is to show the old 2.50 style 'Linked Items' popup which is only
useful when run inside a (2.50 style) generated window.
However the only prepare*Template methods not already removing the button is
the prepareSimpleExcelToolBarTemplate which is only used in 3 reports (1 in pi
and 2 in modules.
Double checking in 2 of those reports shows that the Linked items button was
present in toolbar but in fact did not work and fails with a missing tabId error
as it is not run from inside a generated window.
So remove the button completely as being obsolete.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove unused FIRST_RELATION & LAST_RELATION buttons.
As again they are effectively removed anyway by all the prepare*Template
methods.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove unused GRIDEXCEL, GRIDCSV, GRIDPDF buttons.
As those are also effectively remove by all prepare*Template methods
anyway. Not implementation for those was deleted earlier already.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove NEW button as it is unused.
Same as previous commits that button is effectively removed by all
prepare*Template functions anyway.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove unused ATTACHMENT button.
Similar to last commits it is effectively removed in all prepare*Template
methods so can be completely removed.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove unused NEXT, PREVIOUS buttons.
Same as in last last two commits those are effectively unused and thus
here removed. Directly unused in all but 1 prepare* function. And caller
of that one prepareRelationTemplateNoSearch called 2nd prepare* function
making them fully unused.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove 'AUDIT_TRAIL' button as it is unused.
Similar to last commit all prepare* except one remove that button.
In the caller of that 1 prepareRelationTemplateNoSearch it also
calls prepateSimpleToolBarTemplate so in fact all remove that button.
So delete it completely as being unused.
That allows follow up cleanup of setTabId public function which is
never called in pi or any modules as well as the private helper
function changeAuditTrailVisibility.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove button DELETE_RELATION as it is unused.
All prepare* except 'prepareRelationTemplateNoSearch' remove the
DELETE_RELATION button.
The prepareRelationTemplateNoSearch only conditionally removes that button.
However as its only caller 'Transactions' calls prepareSimpleToolBarTemplate
also in the end -> all remove the button.
So remove it completely as unused.
That makes the member + setter setDeletable unused. As the function is never
called in pi or any module delete it as well.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove some more completely unused buttons.
The following buttons are removed in all prepare*Template method so are
completely unused:
- TREE, AUDIT_SHOW_EDITION_ENABLED, AUDIT_SHOW_EDITION_DISABLED,
AUDIT_SHOW_RELATION_ENABLED
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Fix compile issue in last commit (remove unused write into
forms).
Last commit remove forms member as it was never read from but did not remove a
write into that variable.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Simplify prepareRelationTemplateNoSearch for its only user.
That prepare function is never called in modules but only in pi by the
delete Transaction manual servlet. Start simplifying it by removing
all its parameters as they are all false in the only caller.
Also inline the prepareRelationTemplate function (which is also never called
in any modules) directly into the prepareRelationTemplateNoSearch.
That allows to remove as few private obsolete methods which are no never
used.
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/Transactions.java
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove completely some more buttons which are never used.
All prepare*Template methods remove the following buttons. Remove all of
them as completely unused:
- EDIT, RELATION, SAVE_RELATION, SAVE_NEW, SAVE_EDIT, SAVE_NEXT, DELETE, UNDO,
FIRST, LAST
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Remove SEARCH & SEARCH_FILTERED as no longer usable.
Every prepare*Template function removes both buttons. Making them completely
unused. -> Remove them completely.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Cleanup ToolBar remove SEPERATOR1,ORDERBY,ORDERBY_FILTERED
Those buttons are never created in createAllButons so any access to them
is not useful.
src/org/openbravo/erpCommon/utility/ToolBar.java
Stefan Hühner <stefan.hueh...@openbravo.com> null
Issue 38258. Delete all prepare*Template functions which are obsolete.
Checking in all publishes modules and pi many of the various prepare functions
are never called and are removed here.
src/org/openbravo/erpCommon/utility/ToolBar.java
Carlos Aristu <carlos.ari...@openbravo.com> null
Fixes bug 40047: include wstx-asl-3.0.2.jar in the classpath on database
export
- Execute ant export.database and export.sample.data as forked tasks in order
to define the classpath of those tasks with the required libraries. This way,
it will be no longer needed to manually copying wstx-asl-3.0.2.jar inside Ant
folder to get the xml headers of the database model files with single quotes.
- Besides, the runtime-classpath now includes the Tomcat pool libraries.
Therefore these tasks now use it to retrieve the DB connections. Otherwise, the
default Hibernate pool would be used, forcing to explicitly close it within the
tasks as we do here[1].
- Updated dbsourcemanager.jar with the changes in DBSourceManager.
[1]
https://code.openbravo.com/erp/devel/pi/rev/3ed849d672ae34b8bcec1d16aaea800ea68e5c61
src-db/database/build.xml
src-db/database/lib/dbsourcemanager.jar
Atul Gaware <atul.gaw...@openbravo.com> null
Fixes Issue 0039988: Last inventory counting no updating
M_Transaction records are not created for inventory count line
having qtyCount equals to book quantity or order quantity equals
order quantity book. Hence update inventory is not called which
actual updates the date inventory in M_Storage_Detail.
Update Date Inventory method is introduced and now used to update
date in such cases which calls update inventory.
src/org/openbravo/materialmgmt/InventoryCountProcess.java
Last 20 lines of the console output:
[...truncated 2709 lines...]
[ "$(jps | grep Bootstrap || true)" = "" ] && break
sleep 5
done
[ "$(jps | grep Bootstrap || true)" != "" ] && echo "Tomcat has fail to stop"
&& exit 1 || true
[ "$i" != "0" ] && secs=$(echo "$i * 5" | bc) && echo "Waiting for $secs secs
for tomcat to stop"
echo
fi
[int-dummy-pgsql] $ /bin/bash -xe /tmp/hudson3047881576201966106.sh
++ jps
++ grep Bootstrap
++ true
+ '[' '' '!=' '' ']'
POST BUILD TASK : SUCCESS
END OF POST BUILD TASK : 0
Email was triggered for: Fixed
Trigger Success was overridden by another trigger and will not send an email.
Sending email for trigger: Fixed
_______________________________________________
Openbravo-builds mailing list
Openbravo-builds@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-builds
