details:   /erp/devel/int/rev/12e73985217b
changeset: 7175:12e73985217b
user:      David Alsasua <david.alsasua <at> openbravo.com>
date:      Mon May 03 10:28:18 2010 +0200
summary:   Fixes issue 13175: In payment report
the payments generated in a manual settlement are not shown

details:   /erp/devel/int/rev/2a77ac2d4f9f
changeset: 7176:2a77ac2d4f9f
user:      Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
date:      Mon May 03 14:16:59 2010 +0530
summary:   Fixes issue 13061: In Project Line SE_ProjectLine_Value callout does 
not fill all fields

diffstat:

 src/org/openbravo/erpCommon/ad_callouts/SE_ProjectLine_Value.java  |   4 +-
 src/org/openbravo/erpCommon/ad_reports/ReportDebtPayment_data.xsql |  20 
++++-----
 2 files changed, 11 insertions(+), 13 deletions(-)

diffs (80 lines):

diff -r a106e43df4ad -r 2a77ac2d4f9f 
src/org/openbravo/erpCommon/ad_callouts/SE_ProjectLine_Value.java
--- a/src/org/openbravo/erpCommon/ad_callouts/SE_ProjectLine_Value.java Sat May 
01 17:10:36 2010 +0530
+++ b/src/org/openbravo/erpCommon/ad_callouts/SE_ProjectLine_Value.java Mon May 
03 14:16:59 2010 +0530
@@ -118,8 +118,8 @@
           String strCTaxID = Tax.get(this, strmProductId, strDate, strADOrgID, 
strMWarehouseID,
               strCBPartnerLocationID, strCBPartnerLocationID, strProjectId, 
strIsSOTrx.equals("Y"));
           if (strCTaxID != null && !strCTaxID.equals("")) {
-            resultado.append("new Array(\"inpcTaxId\", "
-                + (strCTaxID.equals("") ? "\"\"" : strCTaxID) + "),\n");
+            resultado.append("new Array(\"inpcTaxId\", \""
+                + (strCTaxID.equals("") ? "\"\"" : strCTaxID) + "\"),\n");
           } else
             strMessage = "TaxNotFound";
         }
diff -r a106e43df4ad -r 2a77ac2d4f9f 
src/org/openbravo/erpCommon/ad_reports/ReportDebtPayment_data.xsql
--- a/src/org/openbravo/erpCommon/ad_reports/ReportDebtPayment_data.xsql        
Sat May 01 17:10:36 2010 +0530
+++ b/src/org/openbravo/erpCommon/ad_reports/ReportDebtPayment_data.xsql        
Mon May 03 14:16:59 2010 +0530
@@ -35,9 +35,9 @@
       (CASE WHEN I.C_INVOICE_ID IS NULL THEN '0' ELSE I.C_INVOICE_ID END) AS 
C_INVOICE_ID, (CASE WHEN DP.C_DEBT_PAYMENT_ID IS NULL THEN '0' ELSE 
DP.C_DEBT_PAYMENT_ID END) AS C_DEBT_PAYMENT_ID, B.NAME AS BPARTNER, (CASE WHEN 
I.DOCUMENTNO IS NOT NULL THEN I.DOCUMENTNO||' ('||I.DATEINVOICED||')' END) AS 
INVOICE, DP.DATEPLANNED,
       DP.AMOUNT, DP.WRITEOFFAMT, C.ISO_CODE AS CURRENCY,
       (CASE WHEN S1.DOCUMENTNO IS NOT NULL THEN S1.DOCUMENTNO||' 
('||S1.DATETRX||')' END) AS DEBTCANCEL,
-      C_CURRENCY_CONVERT(DP.AMOUNT, DP.C_CURRENCY_ID, ?, 
TO_DATE(I.DATEINVOICED), NULL, C_INVOICELINE.AD_CLIENT_ID, 
C_INVOICELINE.AD_ORG_ID) AS CONVAMOUNT,
-      C_CURRENCY_SYMBOL(?, 0, 'Y') AS CONVSYM,          
-      C_CURRENCY_ISOSYM(?) AS CONVISOSYM, 
+      C_CURRENCY_CONVERT(DP.AMOUNT, DP.C_CURRENCY_ID, ?, 
TO_DATE(I.DATEINVOICED), NULL, I.AD_CLIENT_ID, I.AD_ORG_ID) AS CONVAMOUNT,
+      C_CURRENCY_SYMBOL(?, 0, 'Y') AS CONVSYM,
+      C_CURRENCY_ISOSYM(?) AS CONVISOSYM,
       (CASE WHEN S2.DOCUMENTNO IS NOT NULL THEN S2.DOCUMENTNO||' 
('||S2.DATETRX||')' END) AS DEBTGENERATE, COALESCE(RLT.NAME, RL.NAME) AS 
PAYMENTRULE,
       (CASE C_DEBT_PAYMENT_STATUS(DP.C_Settlement_Cancel_ID, 
DP.CANCEL_PROCESSED, DP.GENERATE_PROCESSED, DP.ISPAID, DP.ISVALID, 
       DP.C_CASHLINE_ID, DP.C_BANKSTATEMENTLINE_ID) WHEN 'I' THEN 
AD_MESSAGE_GET2('DPR_INVALID',?) WHEN 'C' THEN 
AD_MESSAGE_GET2('DPR_CONCILIATED',?) WHEN 'W' THEN 
AD_MESSAGE_GET2('DPR_CANCELLED',?) WHEN 'A' THEN 
AD_MESSAGE_GET2('DPR_SETTLE',?) WHEN 
@@ -55,9 +55,8 @@
                                                               AND 
RLT.AD_LANGUAGE = ?,
            AD_REF_LIST RL2    left join AD_REF_LIST_TRL RLT2 on 
RL2.AD_REF_LIST_ID = RLT2.AD_REF_LIST_ID
                                                               AND 
RLT2.AD_LANGUAGE = ?,
-           C_CURRENCY C, C_INVOICELINE
-      WHERE DP.C_CURRENCY_ID = C.C_CURRENCY_ID 
-      AND I.C_INVOICE_ID = C_INVOICELINE.C_INVOICE_ID
+           C_CURRENCY C
+      WHERE DP.C_CURRENCY_ID = C.C_CURRENCY_ID
       AND DP.PAYMENTRULE = RL.VALUE
       AND RL.AD_REFERENCE_ID = '195'
       AND DP.STATUS = RL2.VALUE
@@ -68,7 +67,7 @@
       AND DP.IsValid='Y'
       GROUP BY (BANK.NAME || '/' || BANK.CODEBRANCH || BANK.DIGITCONTROL || 
BA.CODEACCOUNT || '.' || BA.DIGITCONTROL),(CASE BA.showspanish WHEN 'Y' then 
BA.CODEACCOUNT ELSE CASE BA.SHOWGENERIC when 'Y' then GENERICACCOUNT ELSE CASE 
BA.SHOWIBAN WHEN 'Y' THEN BA.IBAN END END END),
       CASE WHEN I.C_INVOICE_ID IS NULL THEN '0' ELSE I.C_INVOICE_ID END, (CASE 
WHEN DP.C_DEBT_PAYMENT_ID IS NULL THEN '0' ELSE DP.C_DEBT_PAYMENT_ID END), 
B.NAME, (CASE WHEN I.DOCUMENTNO IS NOT NULL THEN I.DOCUMENTNO||' 
('||I.DATEINVOICED||')' END), DP.DATEPLANNED, 
-      DP.AMOUNT,DP.C_CURRENCY_ID, C_INVOICELINE.AD_CLIENT_ID, 
C_INVOICELINE.AD_ORG_ID, I.DATEINVOICED,
+      DP.AMOUNT,DP.C_CURRENCY_ID, I.AD_CLIENT_ID, I.AD_ORG_ID, I.DATEINVOICED,
       DP.WRITEOFFAMT, C.ISO_CODE, (CASE WHEN S1.DOCUMENTNO IS NOT NULL THEN 
S1.DOCUMENTNO||' ('||S1.DATETRX||')' END), (CASE WHEN S2.DOCUMENTNO IS NOT NULL 
THEN S2.DOCUMENTNO||' ('||S2.DATETRX||')' END), RLT.NAME, RL.NAME, RLT2.NAME, 
RL2.NAME, DP.C_Settlement_Cancel_ID,
       DP.CANCEL_PROCESSED, DP.GENERATE_PROCESSED, DP.ISPAID, DP.ISVALID, 
DP.C_CASHLINE_ID, DP.C_BANKSTATEMENTLINE_ID, DP.DESCRIPTION, (CASE DP.ISRECEIPT 
WHEN 'Y' THEN 'SalesInvoice' ELSE 'PurchaseInvoice' END),s2.SETTLEMENTTYPE, 
DP.STATUS, URS.NAME
       ORDER BY 1,STATUS, DP.DATEPLANNED
@@ -112,7 +111,7 @@
       (CASE WHEN I.C_INVOICE_ID IS NULL THEN '0' ELSE I.C_INVOICE_ID END) AS 
C_INVOICE_ID, (CASE WHEN DP.C_DEBT_PAYMENT_ID IS NULL THEN '0' ELSE 
DP.C_DEBT_PAYMENT_ID END) AS C_DEBT_PAYMENT_ID, B.NAME AS BPARTNER, (CASE WHEN 
I.DOCUMENTNO IS NOT NULL THEN I.DOCUMENTNO||' ('||I.DATEINVOICED||')' END) AS 
INVOICE, DP.DATEPLANNED,
       DP.AMOUNT, DP.WRITEOFFAMT, C.ISO_CODE AS CURRENCY,
       (CASE WHEN S1.DOCUMENTNO IS NOT NULL THEN S1.DOCUMENTNO||' 
('||S1.DATETRX||')' END) AS DEBTCANCEL, (CASE WHEN S2.DOCUMENTNO IS NOT NULL 
THEN S2.DOCUMENTNO||' ('||S2.DATETRX||')' END) AS DEBTGENERATE, 
COALESCE(RLT.NAME, RL.NAME) AS PAYMENTRULE,
-      C_CURRENCY_CONVERT(DP.AMOUNT, DP.C_CURRENCY_ID, ?, 
TO_DATE(I.DATEINVOICED), NULL, C_INVOICELINE.AD_CLIENT_ID, 
C_INVOICELINE.AD_ORG_ID) AS CONVAMOUNT,
+      C_CURRENCY_CONVERT(DP.AMOUNT, DP.C_CURRENCY_ID, ?, 
TO_DATE(I.DATEINVOICED), NULL, I.AD_CLIENT_ID, I.AD_ORG_ID) AS CONVAMOUNT,
       C_CURRENCY_SYMBOL(?, 0, 'Y') AS CONVSYM,          
       C_CURRENCY_ISOSYM(?) AS CONVISOSYM, 
       (CASE C_DEBT_PAYMENT_STATUS(DP.C_Settlement_Cancel_ID, 
DP.CANCEL_PROCESSED, DP.GENERATE_PROCESSED, DP.ISPAID, DP.ISVALID, 
@@ -131,9 +130,8 @@
                                                               AND 
RLT.AD_LANGUAGE = ?,
            AD_REF_LIST RL2    left join AD_REF_LIST_TRL RLT2 on 
RL2.AD_REF_LIST_ID = RLT2.AD_REF_LIST_ID
                                                               AND 
RLT2.AD_LANGUAGE = ?,
-           C_CURRENCY C, C_INVOICELINE
+           C_CURRENCY C
       WHERE DP.C_CURRENCY_ID = C.C_CURRENCY_ID 
-      AND I.C_INVOICE_ID = C_INVOICELINE.C_INVOICE_ID
       AND DP.PAYMENTRULE = RL.VALUE
       AND RL.AD_REFERENCE_ID = '195'
       AND DP.STATUS = RL2.VALUE
@@ -144,7 +142,7 @@
       AND DP.IsValid='Y'
       GROUP BY (BANK.NAME || '/' || BANK.CODEBRANCH || BANK.DIGITCONTROL || 
BA.CODEACCOUNT || '.' || BA.DIGITCONTROL), (CASE BA.showspanish WHEN 'Y' then 
BA.CODEACCOUNT ELSE CASE BA.SHOWGENERIC when 'Y' then GENERICACCOUNT ELSE CASE 
BA.SHOWIBAN WHEN 'Y' THEN BA.IBAN END END END),
       CASE WHEN I.C_INVOICE_ID IS NULL THEN '0' ELSE I.C_INVOICE_ID END, (CASE 
WHEN DP.C_DEBT_PAYMENT_ID IS NULL THEN '0' ELSE DP.C_DEBT_PAYMENT_ID END), 
B.NAME, (CASE WHEN I.DOCUMENTNO IS NOT NULL THEN I.DOCUMENTNO||' 
('||I.DATEINVOICED||')' END), DP.DATEPLANNED, DP.AMOUNT,
-      DP.C_CURRENCY_ID, C_INVOICELINE.AD_CLIENT_ID, C_INVOICELINE.AD_ORG_ID, 
I.DATEINVOICED,
+      DP.C_CURRENCY_ID, I.AD_CLIENT_ID, I.AD_ORG_ID, I.DATEINVOICED,
       DP.WRITEOFFAMT, C.ISO_CODE, (CASE WHEN S1.DOCUMENTNO IS NOT NULL THEN 
S1.DOCUMENTNO||' ('||S1.DATETRX||')' END), (CASE WHEN S2.DOCUMENTNO IS NOT NULL 
THEN S2.DOCUMENTNO||' ('||S2.DATETRX||')' END), RLT.NAME, RL.NAME, RLT2.NAME, 
RL2.NAME, DP.C_Settlement_Cancel_ID,
       DP.CANCEL_PROCESSED, DP.GENERATE_PROCESSED, DP.ISPAID, DP.ISVALID, 
DP.C_CASHLINE_ID, DP.C_BANKSTATEMENTLINE_ID, DP.DESCRIPTION, (CASE DP.ISRECEIPT 
WHEN 'Y' THEN 'SalesInvoice' ELSE 'PurchaseInvoice' END),s2.SETTLEMENTTYPE, 
DP.STATUS, URS.NAME
       ORDER BY 1,STATUS, DP.DATEPLANNED

------------------------------------------------------------------------------
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to