details: /erp/devel/pi/rev/87291b320c4c
changeset: 7426:87291b320c4c
user: Martin Taal <martin.taal <at> openbravo.com>
date: Tue May 25 20:57:43 2010 +0200
summary: Changed testcase to be more informative on failure and more robust
on date/time rounding
diffstat:
src-test/org/openbravo/test/system/SystemServiceTest.java | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diffs (33 lines):
diff -r 321844abf129 -r 87291b320c4c
src-test/org/openbravo/test/system/SystemServiceTest.java
--- a/src-test/org/openbravo/test/system/SystemServiceTest.java Tue May 25
17:41:43 2010 +0200
+++ b/src-test/org/openbravo/test/system/SystemServiceTest.java Tue May 25
20:57:43 2010 +0200
@@ -44,21 +44,25 @@
*/
public void testChangedDataSet() {
setSystemAdministratorContext();
+ final long oneDay = 1000 * 60 * 60 * 24;
+
final List<DataSet> dss =
OBDal.getInstance().createCriteria(DataSet.class).list();
- final Date now = new Date(System.currentTimeMillis());
+ // check one day in the future to prevent date/time rounding issues
+ final Date now = new Date(System.currentTimeMillis() + oneDay);
for (DataSet ds : dss) {
- assertFalse(DataSetService.getInstance().hasChanged(ds, now));
+ assertFalse("Fails on dataset " + ds.getName() + " checking date " +
now, DataSetService
+ .getInstance().hasChanged(ds, now));
}
// 600 days in the past
- final long oneDay = 1000 * 60 * 60 * 24;
final long manyDays = (long) 600 * oneDay;
final Date past = new Date(System.currentTimeMillis() - manyDays);
for (DataSet ds : dss) {
if (!DataSetService.getInstance().hasData(ds)) {
continue;
}
- assertTrue(DataSetService.getInstance().hasChanged(ds, past));
+ assertTrue("Fails on dataset " + ds.getName() + " checking date " +
past, DataSetService
+ .getInstance().hasChanged(ds, past));
}
}
------------------------------------------------------------------------------
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
