details:   /erp/devel/pi/rev/331c9ca70ae9
changeset: 8494:331c9ca70ae9
user:      Adrián Romero <adrianromero <at> openbravo.com>
date:      Fri Oct 01 11:19:40 2010 +0200
summary:   Fixes issue 0014730: CreateLines from is not working well: Lines 
with 0.00 can be selected
It has been added a filter to the SQL sentence that retrieves the lines to not 
get lines with remaining quantity to deliver equals to 0

diffstat:

 src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql |  8 
+++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diffs (32 lines):

diff -r 85e69faedcc4 -r 331c9ca70ae9 
src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
--- a/src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql 
Fri Oct 01 11:00:06 2010 +0200
+++ b/src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql 
Fri Oct 01 11:19:40 2010 +0200
@@ -34,7 +34,7 @@
         l.C_OrderLine_ID AS ID, '' AS C_Invoice_ID, l.DESCRIPTION AS 
DESCRIPTION,
         ((l.QtyOrdered-SUM(COALESCE(m.Qty,0)))/COALESCE(
         (SELECT DIVIDERATE FROM C_UOM_CONVERSION WHERE 
C_UOM_CONVERSION.C_UOM_ID = l.C_UOM_ID
-        AND C_UOM_CONVERSION.C_UOM_TO_ID = (SELECT C_UOM.C_UOM_ID FROM 
M_PRODUCT_UOM, C_UOM WHERE M_PRODUCT_UOM_ID = l.M_PRODUCT_UOM_ID AND 
M_PRODUCT_UOM.C_UOM_ID = C_UOM.C_UOM_ID)),1)) 
+        AND C_UOM_CONVERSION.C_UOM_TO_ID = (SELECT C_UOM.C_UOM_ID FROM 
M_PRODUCT_UOM, C_UOM WHERE M_PRODUCT_UOM_ID = l.M_PRODUCT_UOM_ID AND 
M_PRODUCT_UOM.C_UOM_ID = C_UOM.C_UOM_ID)),1))
         as SECQTY, l.M_PRODUCT_UOM_ID as SEC_PRODUCT_UOM_ID,
         (SELECT M_ATTRIBUTESETINSTANCE.DESCRIPTION FROM M_ATTRIBUTESETINSTANCE 
WHERE 
         l.M_ATTRIBUTESETINSTANCE_ID = 
M_ATTRIBUTESETINSTANCE.M_ATTRIBUTESETINSTANCE_ID) as ATTRIBUTESETINSTANCENAME, 
@@ -103,7 +103,8 @@
         AND ic.AD_Org_ID IN ('1') 
         AND l.C_UOM_ID = uom.C_UOM_ID
         AND l.M_Product_ID=p.M_Product_ID 
-        AND ic.C_Order_ID = ? 
+        AND ic.C_Order_ID = ?
+        AND l.QtyOrdered > COALESCE(l.qtydelivered,0)
         GROUP BY o.C_ORDER_ID, o.DocumentNo, o.DateOrdered, o.GrandTotal, 
l.QtyOrdered,l.qtydelivered, 
         
l.C_UOM_ID,uom.UOMSymbol,l.M_Product_ID,p.NAME,l.Line,l.C_OrderLine_ID, 
l.ad_org_id, l.DESCRIPTION
         ORDER BY NAME, l.Line
@@ -191,7 +192,8 @@
         AND ic.AD_Org_ID IN ('1') 
         AND l.C_UOM_ID = uom.C_UOM_ID 
         AND l.M_Product_ID=p.M_Product_ID 
-        AND ic.C_Order_ID = ? 
+        AND ic.C_Order_ID = ?
+        AND l.QtyOrdered > COALESCE(l.qtydelivered,0)
         GROUP BY o.C_ORDER_ID, o.DocumentNo, o.DateOrdered, o.GrandTotal, 
l.QtyOrdered,l.qtydelivered, 
         
l.C_UOM_ID,uom.UOMSymbol,uomt.UOMSymbol,l.M_Product_ID,p.NAME,l.Line,l.C_OrderLine_ID,
 l.DESCRIPTION
         ORDER BY NAME, l.Line

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to