details:   /erp/devel/pi/rev/5284d19837e1
changeset: 8761:5284d19837e1
user:      Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
date:      Wed Oct 27 17:47:51 2010 +0530
summary:   Fixes issue 14850: An error message in the Sales Invoice Dimensional 
Report is not clear

As It doesn't make sense to execute Dimensional report without selecting any 
dimension, Validation has been added in order to not allow empty dimension list.

diffstat:

 
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJRFilter.html
 |  5 +++++
 
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesFilterJR.html
   |  5 +++++
 
src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesFilterJR.html
        |  5 +++++
 
src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesFilterJR.html
        |  5 +++++
 
src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesFilter.html
       |  5 +++++
 
src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJRFilter.html
            |  5 +++++
 
src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJRFilter.html
         |  5 +++++
 7 files changed, 35 insertions(+), 0 deletions(-)

diffs (105 lines):

diff -r 4e251a8ddac6 -r 5284d19837e1 
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJRFilter.html
--- 
a/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJRFilter.html
      Wed Oct 27 17:22:50 2010 +0530
+++ 
b/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJRFilter.html
      Wed Oct 27 17:47:51 2010 +0530
@@ -77,6 +77,11 @@
                        return false;
                }
        }
+    if (frm.inpShown.length == 0) {
+        setWindowElementFocus(frm.inpShown);
+        showJSMessage(7);
+        return false;
+    }
        markCheckedAllElements(frm.inpmProductId_IN);
        markCheckedAllElements(frm.inpcBPartnerId_IN);
        markCheckedAllElements(frm.inpShown);
diff -r 4e251a8ddac6 -r 5284d19837e1 
src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesFilterJR.html
--- 
a/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesFilterJR.html
        Wed Oct 27 17:22:50 2010 +0530
+++ 
b/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesFilterJR.html
        Wed Oct 27 17:47:51 2010 +0530
@@ -76,6 +76,11 @@
                        return false;
                }
        }
+    if (frm.inpShown.length == 0) {
+        setWindowElementFocus(frm.inpShown);
+        showJSMessage(7);
+        return false;
+    }
        markCheckedAllElements(frm.inpmProductId_IN);
        markCheckedAllElements(frm.inpcBPartnerId_IN);
        markCheckedAllElements(frm.inpShown);
diff -r 4e251a8ddac6 -r 5284d19837e1 
src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesFilterJR.html
--- 
a/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesFilterJR.html
     Wed Oct 27 17:22:50 2010 +0530
+++ 
b/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesFilterJR.html
     Wed Oct 27 17:47:51 2010 +0530
@@ -76,6 +76,11 @@
                        return false;
                }
        }
+    if (frm.inpShown.length == 0) {
+        setWindowElementFocus(frm.inpShown);
+        showJSMessage(7);
+        return false;
+    }
        markCheckedAllElements(frm.inpmProductId_IN);
        markCheckedAllElements(frm.inpcBPartnerId_IN);
        markCheckedAllElements(frm.inpShown);
diff -r 4e251a8ddac6 -r 5284d19837e1 
src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesFilterJR.html
--- 
a/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesFilterJR.html
     Wed Oct 27 17:22:50 2010 +0530
+++ 
b/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesFilterJR.html
     Wed Oct 27 17:47:51 2010 +0530
@@ -76,6 +76,11 @@
                        return false;
                }
        }
+    if (frm.inpShown.length == 0) {
+        setWindowElementFocus(frm.inpShown);
+        showJSMessage(7);
+        return false;
+    }
        markCheckedAllElements(frm.inpmProductId_IN);
        markCheckedAllElements(frm.inpcBPartnerId_IN);
        markCheckedAllElements(frm.inpShown);
diff -r 4e251a8ddac6 -r 5284d19837e1 
src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesFilter.html
--- 
a/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesFilter.html
    Wed Oct 27 17:22:50 2010 +0530
+++ 
b/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesFilter.html
    Wed Oct 27 17:47:51 2010 +0530
@@ -86,6 +86,11 @@
                        return false;
                }
        }
+    if (frm.inpShown.length == 0) {
+        setWindowElementFocus(frm.inpShown);
+        showJSMessage(7);
+        return false;
+    }
        markCheckedAllElements(frm.inpmProductId_IN);
        markCheckedAllElements(frm.inpcBPartnerId_IN);
        markCheckedAllElements(frm.inpShown);
diff -r 4e251a8ddac6 -r 5284d19837e1 
src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJRFilter.html
--- 
a/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJRFilter.html
 Wed Oct 27 17:22:50 2010 +0530
+++ 
b/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJRFilter.html
 Wed Oct 27 17:47:51 2010 +0530
@@ -80,6 +80,11 @@
                        return false;
                }
        }
+    if (frm.inpShown.length == 0) {
+        setWindowElementFocus(frm.inpShown);
+        showJSMessage(7);
+        return false;
+    }
        markCheckedAllElements(frm.inpmProductId_IN);
        markCheckedAllElements(frm.inpcBPartnerId_IN);
        markCheckedAllElements(frm.inpShown);
diff -r 4e251a8ddac6 -r 5284d19837e1 
src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJRFilter.html
--- 
a/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJRFilter.html
      Wed Oct 27 17:22:50 2010 +0530
+++ 
b/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJRFilter.html
      Wed Oct 27 17:47:51 2010 +0530
@@ -87,6 +87,11 @@
                        return false;
                }
        }
+    if (frm.inpShown.length == 0) {
+        setWindowElementFocus(frm.inpShown);
+        showJSMessage(7);
+        return false;
+    }
        markCheckedAllElements(frm.inpmProductId_IN);
        markCheckedAllElements(frm.inpcBPartnerId_IN);
        markCheckedAllElements(frm.inpShown);

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to