details:   /erp/devel/pi/rev/32b809b3ad85
changeset: 9338:32b809b3ad85
user:      Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
date:      Thu Dec 23 16:16:17 2010 +0100
summary:   [OBCQL] Changed column size to number(10,0).Set min value.

details:   /erp/devel/pi/rev/0e7efa8fc09d
changeset: 9339:0e7efa8fc09d
user:      Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
date:      Thu Dec 23 16:16:56 2010 +0100
summary:   [OBSERDS] Manage Strings with " on csv generation.

diffstat:

 
modules/org.openbravo.client.querylist/src-db/database/model/tables/OBCQL_QUERY_COLUMN.xml
           |  4 ++--
 
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_COLUMN.xml 
                     |  1 +
 
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
 |  7 ++++++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diffs (56 lines):

diff -r acfad94d9cb9 -r 0e7efa8fc09d 
modules/org.openbravo.client.querylist/src-db/database/model/tables/OBCQL_QUERY_COLUMN.xml
--- 
a/modules/org.openbravo.client.querylist/src-db/database/model/tables/OBCQL_QUERY_COLUMN.xml
        Thu Dec 23 14:17:29 2010 +0100
+++ 
b/modules/org.openbravo.client.querylist/src-db/database/model/tables/OBCQL_QUERY_COLUMN.xml
        Thu Dec 23 16:16:56 2010 +0100
@@ -49,7 +49,7 @@
         <default/>
         <onCreateDefault/>
       </column>
-      <column name="WIDTH" primaryKey="false" required="true" type="DECIMAL" 
autoIncrement="false">
+      <column name="WIDTH" primaryKey="false" required="true" type="DECIMAL" 
size="10,0" autoIncrement="false">
         <default/>
         <onCreateDefault/>
       </column>
@@ -57,7 +57,7 @@
         <default/>
         <onCreateDefault/>
       </column>
-      <column name="SEQNO" primaryKey="false" required="true" type="DECIMAL" 
autoIncrement="false">
+      <column name="SEQNO" primaryKey="false" required="true" type="DECIMAL" 
size="10,0" autoIncrement="false">
         <default/>
         <onCreateDefault/>
       </column>
diff -r acfad94d9cb9 -r 0e7efa8fc09d 
modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_COLUMN.xml
--- 
a/modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_COLUMN.xml
   Thu Dec 23 14:17:29 2010 +0100
+++ 
b/modules/org.openbravo.client.querylist/src-db/database/sourcedata/AD_COLUMN.xml
   Thu Dec 23 16:16:56 2010 +0100
@@ -757,6 +757,7 @@
 <!--95CC63FD04C721F2E040007F010075C1-->  <SEQNO><![CDATA[130]]></SEQNO>
 <!--95CC63FD04C721F2E040007F010075C1-->  
<ISTRANSLATED><![CDATA[N]]></ISTRANSLATED>
 <!--95CC63FD04C721F2E040007F010075C1-->  
<ISENCRYPTED><![CDATA[N]]></ISENCRYPTED>
+<!--95CC63FD04C721F2E040007F010075C1-->  <VALUEMIN><![CDATA[0]]></VALUEMIN>
 <!--95CC63FD04C721F2E040007F010075C1-->  
<ISSELECTIONCOLUMN><![CDATA[N]]></ISSELECTIONCOLUMN>
 <!--95CC63FD04C721F2E040007F010075C1-->  
<AD_ELEMENT_ID><![CDATA[95CC5757ECBCE5B8E040007F010076A5]]></AD_ELEMENT_ID>
 <!--95CC63FD04C721F2E040007F010075C1-->  
<ISSESSIONATTR><![CDATA[N]]></ISSESSIONATTR>
diff -r acfad94d9cb9 -r 0e7efa8fc09d 
modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
--- 
a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
      Thu Dec 23 14:17:29 2010 +0100
+++ 
b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
      Thu Dec 23 16:16:56 2010 +0100
@@ -56,6 +56,7 @@
 import org.openbravo.service.web.InvalidRequestException;
 import org.openbravo.service.web.ResourceNotFoundException;
 import org.openbravo.service.web.WebServiceUtil;
+import org.openbravo.utils.Replace;
 
 /**
  * A web service which provides a JSON REST service using the {...@link 
DataSourceService}
@@ -457,7 +458,11 @@
           } else {
             csv.append(",");
           }
-          csv.append("'").append(row.get(key)).append("'");
+          Object keyValue = row.get(key);
+          if (keyValue instanceof String) {
+            Replace.replace((String) keyValue, "\"", "\"\"");
+          }
+          csv.append("\"").append(keyValue).append("\"");
         }
       }
     }

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to