details: /erp/devel/pi/rev/98279cd0b99f
changeset: 11193:98279cd0b99f
user: Iván Perdomo <ivan.perdomo <at> openbravo.com>
date: Thu Mar 10 14:08:47 2011 +0100
summary: Code style change, remove type coment from parameters
details: /erp/devel/pi/rev/4de94c7bffeb
changeset: 11194:4de94c7bffeb
user: Iván Perdomo <ivan.perdomo <at> openbravo.com>
date: Fri Mar 11 10:09:55 2011 +0100
summary: Small code fix - initWidget does not return a value
details: /erp/devel/pi/rev/e08f6a86e8e3
changeset: 11195:e08f6a86e8e3
user: Iván Perdomo <ivan.perdomo <at> openbravo.com>
date: Fri Mar 11 15:47:16 2011 +0100
summary: Disable tabbing to form icons
- Related to story:
https://www.pivotaltracker.com/projects/88818?story_id=10958899
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-classic-help.js
| 2 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-grid.js
| 6 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-help-about-widget.js
| 4 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-statusbar.js
| 2 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-manager.js
| 24 +++++-----
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
| 3 +
6 files changed, 22 insertions(+), 19 deletions(-)
diffs (193 lines):
diff -r aa2b3099cb9d -r e08f6a86e8e3
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-classic-help.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-classic-help.js
Fri Mar 11 15:11:58 2011 +0100
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-classic-help.js
Fri Mar 11 15:47:16 2011 +0100
@@ -56,7 +56,7 @@
if (this.windowName) {
this.contentsURL = this.contentsURL + '&inpwindowName=' +
this.windowName;
}
- return this.Super('initWidget', args);
+ this.Super('initWidget', args);
},
// The following methods are involved in making sure that a help tab for a
diff -r aa2b3099cb9d -r e08f6a86e8e3
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-grid.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-grid.js
Fri Mar 11 15:11:58 2011 +0100
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-grid.js
Fri Mar 11 15:47:16 2011 +0100
@@ -219,7 +219,7 @@
this.prompt =
OB.I18N.getLabel('OBUIAPP_GridFilterImplicitToolTip');
this.visibility = 'inherit';
}
- return this.Super('initWidget', arguments);
+ this.Super('initWidget', arguments);
},
click: function(){
// get rid of the initial filter clause
@@ -230,7 +230,7 @@
}
};
- return this.Super('initWidget', arguments);
+ this.Super('initWidget', arguments);
},
showSummaryRow: function(){
@@ -407,7 +407,7 @@
this.btn.setTitle(this.title);
this.btn.owner = this;
this.addMember(this.btn);
- return this.Super('initWidget', arguments);
+ this.Super('initWidget', arguments);
},
setTitle: function(title){
diff -r aa2b3099cb9d -r e08f6a86e8e3
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-help-about-widget.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-help-about-widget.js
Fri Mar 11 15:11:58 2011 +0100
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-help-about-widget.js
Fri Mar 11 15:47:16 2011 +0100
@@ -35,7 +35,7 @@
initWidget: function(){
OB.TestRegistry.register('org.openbravo.client.application.HelpAboutWidget',
this);
- return this.Super('initWidget', arguments);
+ this.Super('initWidget', arguments);
},
beforeShow: function(){
@@ -95,7 +95,7 @@
numCols: 1,
initWidget: function(){
OB.TestRegistry.register('org.openbravo.client.application.HelpAboutForm',
this);
- return this.Super('initWidget', arguments);
+ this.Super('initWidget', arguments);
}
})],
diff -r aa2b3099cb9d -r e08f6a86e8e3
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-statusbar.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-statusbar.js
Fri Mar 11 15:11:58 2011 +0100
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-statusbar.js
Fri Mar 11 15:47:16 2011 +0100
@@ -154,7 +154,7 @@
this.leftStatusBar.addMember(this.spacer, 0);
this.addMembers( [ this.leftStatusBar, buttonBar ]);
- return this.Super('initWidget', arguments);
+ this.Super('initWidget', arguments);
},
addIcon : function(icon) {
diff -r aa2b3099cb9d -r e08f6a86e8e3
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-manager.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-manager.js
Fri Mar 11 15:11:58 2011 +0100
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-manager.js
Fri Mar 11 15:47:16 2011 +0100
@@ -54,7 +54,7 @@
views: {
cache: [],
- getViewTabID: function(/* String */vName, /* Object */ params){
+ getViewTabID: function(vName, params){
var len = this.cache.length, i, item;
for (i = len; i > 0; i--) {
item = this.cache[i - 1];
@@ -65,7 +65,7 @@
return null;
},
- getTabNumberFromViewParam: function(/* String */param, value){
+ getTabNumberFromViewParam: function(param, value) {
var numberOfTabs = tabSet.tabs.length, viewParam = '', result = null;
for (var i = 0; i < numberOfTabs; i++) {
viewParam = tabSet.getTabPane(i)[param];
@@ -76,11 +76,11 @@
return result;
},
- push: function(/* Object */instanceDetails){
+ push: function(instanceDetails) {
this.cache.push(instanceDetails);
},
- removeTab: function(/* String */viewTabId){
+ removeTab: function(viewTabId) {
var len = this.cache.length, i, item, removed;
for (i = len; i > 0; i--) {
item = this.cache[i - 1];
@@ -105,7 +105,7 @@
return null;
},
- fetchView: function(/* String */viewId, /*function*/ callback, /*Object*/
clientContext, /*Object*/params, useLoadingTab){
+ fetchView: function(viewId, callback, clientContext, params,
useLoadingTab) {
if (useLoadingTab) {
// open a loading tab
params = params || {};
@@ -215,7 +215,7 @@
// information
// to initialize an instance.
//
- openView: function(/* String */viewName, /* Object */ params, /* Object */
state){
+ openView: function(viewName, params, state) {
params = params || {};
@@ -235,7 +235,7 @@
//
// Returns the function implementation of a View
//
- function getView(/* String */viewName, /* Object */ params, /* Object */
state){
+ function getView(viewName, params, state) {
if (!viewName) {
throw {
@@ -247,7 +247,7 @@
//
// Shows a view in a tab in the {{{ TabSet }}} or external
//
- function showTab(/* String */viewName, /* Object */ params, /* Object
*/ state){
+ function showTab(viewName, params, state) {
var viewTabId, tabTitle, loadingTab = vmgr.findLoadingTab(params);
@@ -330,7 +330,7 @@
// Function used by the {{ ISC.RPCManager }} after receiving the view
// implementation from the back-end
//
- function fetchViewCallback(/* Object */response){
+ function fetchViewCallback(response, data, request) {
// if the window is in development it's name is always unique
// and has changed
if (vmgr.loadedWindowClassName) {
@@ -348,7 +348,7 @@
if (isc[viewName]) {
showTab(viewName, params);
} else {
- vmgr.fetchView(viewName, fetchViewCallback, null, params, true);
+ vmgr.fetchView(viewName, fetchViewCallback, null, params, true);
}
}
getView(viewName, params, state);
@@ -362,7 +362,7 @@
// can not be bookmarked.
//
- restoreState: function(/* Object */newState, /* Object */ data){
+ restoreState: function(newState, data) {
var tabSet = M.TabSet, tabsLength, i, tabObject, hasChanged = false,
stateData;
@@ -532,4 +532,4 @@
// Initialize ViewManager object
vmgr = L.ViewManager = new ViewManager();
-})(OB, isc);
+})(OB, isc);
\ No newline at end of file
diff -r aa2b3099cb9d -r e08f6a86e8e3
modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
a/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
Fri Mar 11 15:11:58 2011 +0100
+++
b/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
Fri Mar 11 15:47:16 2011 +0100
@@ -52,6 +52,9 @@
isc.FormItem.addProperties({
// always take up space when an item is hidden in a form
alwaysTakeSpace: true,
+
+ // disable tab to icons
+ canTabToIcons: false,
_original_init: isc.FormItem.getPrototype().init,
init: function() {
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
