details:   /erp/devel/pi/rev/5f32bb22bf38
changeset: 11454:5f32bb22bf38
user:      Martin Taal <martin.taal <at> openbravo.com>
date:      Mon Apr 04 14:18:38 2011 +0200
summary:   Fixes issue 16285: Opening form (switching to form view) must have 
immediate response

diffstat:

 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
 |   2 +-
 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-form.js
     |  15 +---------
 2 files changed, 2 insertions(+), 15 deletions(-)

diffs (44 lines):

diff -r 9c7233da5638 -r 5f32bb22bf38 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
      Mon Apr 04 13:52:52 2011 +0200
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
      Mon Apr 04 14:18:38 2011 +0200
@@ -842,7 +842,7 @@
     this.messageBar.hide();
     
     if (!this.isShowingForm) {
-      this.viewForm.showFormOnFICReturn = true;
+      this.switchFormGridVisibility();
     }
     
     if (!record) { //  new case
diff -r 9c7233da5638 -r 5f32bb22bf38 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-form.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-form.js
  Mon Apr 04 13:52:52 2011 +0200
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-form.js
  Mon Apr 04 14:18:38 2011 +0200
@@ -428,14 +428,7 @@
     // TODO: an error occured, handles this much better...
     if (!data || !data.columnValues) {
       this.setDisabled(false);
-      // still open the form, as the user can then correct errors
-      if (this.showFormOnFICReturn) {
-        if (!this.isVisible()) {
-          this.view.switchFormGridVisibility();
-        }
-        this.validate();
-        delete this.showFormOnFICReturn;
-      }
+      this.validate();
       return;
     }
     
@@ -524,12 +517,6 @@
     }
 
     this.markForRedraw();
-    if (this.showFormOnFICReturn) {
-      if (!this.isVisible()) {
-        this.view.switchFormGridVisibility();
-      }
-      delete this.showFormOnFICReturn;
-    }
 
     this.view.toolBar.updateButtonState(true);
     

------------------------------------------------------------------------------
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and 
publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to