details: /erp/devel/pi/rev/9fcb89fe6508
changeset: 11908:9fcb89fe6508
user: Stefan Hühner <stefan.huehner <at> openbravo.com>
date: Tue May 03 20:46:01 2011 +0200
summary: [cleanup] remove some no longer needed SupressWarnings
details: /erp/devel/pi/rev/0a30bd9668fb
changeset: 11909:0a30bd9668fb
user: Stefan Hühner <stefan.huehner <at> openbravo.com>
date: Tue May 03 21:09:09 2011 +0200
summary: [cleanup] Fix a few javadoc syntax errors
diffstat:
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
| 1 -
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
| 2 --
src-test/org/openbravo/test/base/BaseTest.java
| 2 +-
src-test/org/openbravo/test/xml/EntityXMLImportTestReference.java
| 4 ++--
src/org/openbravo/base/model/Reference.java
| 3 ++-
src/org/openbravo/base/model/domaintype/BasePrimitiveDomainType.java
| 2 +-
src/org/openbravo/dal/service/OBDao.java
| 1 -
src/org/openbravo/erpCommon/ad_actionButton/InvoicePaymentMonitor.java
| 1 -
src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java
| 1 -
src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
| 2 +-
src/org/openbravo/erpCommon/utility/TableSQLData.java
| 2 --
11 files changed, 7 insertions(+), 14 deletions(-)
diffs (139 lines):
diff -r 9afb041e5d7f -r 0a30bd9668fb
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
Tue May 03 20:22:48 2011 +0200
+++
b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
Tue May 03 21:09:09 2011 +0200
@@ -384,7 +384,6 @@
OBDal.getInstance().flush();
}
- @SuppressWarnings("unused")
private void triggerAutomaticFinancialAccountTransaction(VariablesSecureApp
vars,
ConnectionProvider connectionProvider, FIN_Payment payment) {
FIN_FinaccTransaction transaction =
TransactionsDao.createFinAccTransaction(payment);
diff -r 9afb041e5d7f -r 0a30bd9668fb
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
Tue May 03 20:22:48 2011 +0200
+++
b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
Tue May 03 21:09:09 2011 +0200
@@ -504,8 +504,6 @@
*
* @param strCode
* String with the search key to search.
- * @param strLanguage
- * String with the translation language.
* @return String with the translated message.
*/
public static String messageBD(String strCode) {
diff -r 9afb041e5d7f -r 0a30bd9668fb
src-test/org/openbravo/test/base/BaseTest.java
--- a/src-test/org/openbravo/test/base/BaseTest.java Tue May 03 20:22:48
2011 +0200
+++ b/src-test/org/openbravo/test/base/BaseTest.java Tue May 03 21:09:09
2011 +0200
@@ -94,7 +94,7 @@
/**
* Record IDs of available users different than {@link #TEST_USER_ID} Note:
Initialized to null,
- * need to call {@link getRandomUserId} at least once
+ * need to call {@link #getRandomUser} at least once
*/
protected static List<User> userIds = null;
diff -r 9afb041e5d7f -r 0a30bd9668fb
src-test/org/openbravo/test/xml/EntityXMLImportTestReference.java
--- a/src-test/org/openbravo/test/xml/EntityXMLImportTestReference.java Tue May
03 20:22:48 2011 +0200
+++ b/src-test/org/openbravo/test/xml/EntityXMLImportTestReference.java Tue May
03 21:09:09 2011 +0200
@@ -131,9 +131,9 @@
}
/**
- * Repeat the action of importing the {@link Warehouse} objects from {@link
TEST_CLIENT_ID}. Now
+ * Repeat the action of importing the {@link Warehouse} objects from {@link
#TEST_CLIENT_ID}. Now
* the {@link Location} objects are also exported but not imported as they
already exist in
- * {@link QA_TEST_CLIENT_ID}.
+ * {@link #QA_TEST_CLIENT_ID}.
*/
public void test3Warehouse() {
setTestUserContext();
diff -r 9afb041e5d7f -r 0a30bd9668fb src/org/openbravo/base/model/Reference.java
--- a/src/org/openbravo/base/model/Reference.java Tue May 03 20:22:48
2011 +0200
+++ b/src/org/openbravo/base/model/Reference.java Tue May 03 21:09:09
2011 +0200
@@ -27,6 +27,7 @@
import org.apache.log4j.Logger;
import org.openbravo.base.exception.OBException;
+import org.openbravo.base.model.domaintype.BaseEnumerateDomainType;
import org.openbravo.base.model.domaintype.DateDomainType;
import org.openbravo.base.model.domaintype.DatetimeDomainType;
import org.openbravo.base.model.domaintype.DomainType;
@@ -206,7 +207,7 @@
}
/**
- * @deprecated use {@link
StringEnumerateDomainType#addEnumerateValue(String)}.
+ * @deprecated use {@link BaseEnumerateDomainType#addEnumerateValue(Object)}.
* @see #getDomainType()
*/
public void addAllowedValue(String value) {
diff -r 9afb041e5d7f -r 0a30bd9668fb
src/org/openbravo/base/model/domaintype/BasePrimitiveDomainType.java
--- a/src/org/openbravo/base/model/domaintype/BasePrimitiveDomainType.java
Tue May 03 20:22:48 2011 +0200
+++ b/src/org/openbravo/base/model/domaintype/BasePrimitiveDomainType.java
Tue May 03 21:09:09 2011 +0200
@@ -26,7 +26,7 @@
/**
* The base class for primitive property types. Subclasses only need to
implement
- * {@link DomainType#getPrimitiveType()}.
+ * {@link PrimitiveDomainType#getPrimitiveType()}.
*
* @author mtaal
*/
diff -r 9afb041e5d7f -r 0a30bd9668fb src/org/openbravo/dal/service/OBDao.java
--- a/src/org/openbravo/dal/service/OBDao.java Tue May 03 20:22:48 2011 +0200
+++ b/src/org/openbravo/dal/service/OBDao.java Tue May 03 21:09:09 2011 +0200
@@ -61,7 +61,6 @@
* BaseOBObject from which the values are requested
* @param property
* the name of the Property for which the value is requested
- * @return
*/
@SuppressWarnings("unchecked")
public static <T extends BaseOBObject> List<T>
getActiveOBObjectList(BaseOBObject obj,
diff -r 9afb041e5d7f -r 0a30bd9668fb
src/org/openbravo/erpCommon/ad_actionButton/InvoicePaymentMonitor.java
--- a/src/org/openbravo/erpCommon/ad_actionButton/InvoicePaymentMonitor.java
Tue May 03 20:22:48 2011 +0200
+++ b/src/org/openbravo/erpCommon/ad_actionButton/InvoicePaymentMonitor.java
Tue May 03 21:09:09 2011 +0200
@@ -83,7 +83,6 @@
pageErrorPopUp(response);
}
- @SuppressWarnings("deprecation")
private OBError process(VariablesSecureApp vars, String strKey) throws
ServletException {
OBError myError = null;
try {
diff -r 9afb041e5d7f -r 0a30bd9668fb
src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java
--- a/src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java Tue May
03 20:22:48 2011 +0200
+++ b/src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java Tue May
03 21:09:09 2011 +0200
@@ -33,7 +33,6 @@
* Users of this method should check for existence of the PaymentMonitor
property (disabling it)
* to be able to provide the user with a relevant message.
*/
- @SuppressWarnings("deprecation")
public static void updateInvoice(Invoice invoice) {
// Check for PaymentMonitor-disabling switch.
try {
diff -r 9afb041e5d7f -r 0a30bd9668fb
src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
--- a/src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
Tue May 03 20:22:48 2011 +0200
+++ b/src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
Tue May 03 21:09:09 2011 +0200
@@ -1605,7 +1605,7 @@
/**
*
* @param client
- * @param org
+ * @param orgProvided
* optional parameter. If not provided, "*" organization used
* @param module
* @return ADClientModule object with the created element
diff -r 9afb041e5d7f -r 0a30bd9668fb
src/org/openbravo/erpCommon/utility/TableSQLData.java
--- a/src/org/openbravo/erpCommon/utility/TableSQLData.java Tue May 03
20:22:48 2011 +0200
+++ b/src/org/openbravo/erpCommon/utility/TableSQLData.java Tue May 03
21:09:09 2011 +0200
@@ -970,8 +970,6 @@
/**
* Returns true in case the tab has internal filters. Internal filters are
added to tabs with
* filter clause and to transactional windows.
- *
- * @return
*/
public boolean hasInternalFilter() {
return internalFilter.size() > 0;
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits