details:   /erp/devel/pi/rev/36fe7542df64
changeset: 12036:36fe7542df64
user:      Martin Taal <martin.taal <at> openbravo.com>
date:      Fri May 06 15:16:32 2011 +0200
summary:   Fixes issue 16543: Window created with error on module

diffstat:

 
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
 |  10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diffs (27 lines):

diff -r 5529fa00a7de -r 36fe7542df64 
modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
--- 
a/modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
       Fri May 06 15:04:02 2011 +0200
+++ 
b/modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
       Fri May 06 15:16:32 2011 +0200
@@ -725,7 +725,7 @@
       orderByClause = "";
       return orderByClause;
     }
-    final StringBuilder sb = new StringBuilder(" order by ");
+    final StringBuilder sb = new StringBuilder();
     boolean firstElement = true;
     for (String localOrderBy : orderBy.split(",")) {
       if (!firstElement) {
@@ -734,7 +734,13 @@
       sb.append(getOrderByClausePart(localOrderBy.trim()));
       firstElement = false;
     }
-    orderByClause = sb.toString();
+
+    // no order by elements, just use empty string
+    if (sb.toString().trim().length() == 0) {
+      orderByClause = "";
+    } else {
+      orderByClause = " order by " + sb.toString();
+    }
     return orderByClause;
   }
 

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to