details: /erp/devel/pi/rev/fec3ab3b3c8c
changeset: 12179:fec3ab3b3c8c
user: Iván Perdomo <ivan.perdomo <at> openbravo.com>
date: Tue May 17 08:32:44 2011 +0200
summary: Updated jscheck adding smartclient to excluded path
details: /erp/devel/pi/rev/acc2c370946b
changeset: 12180:acc2c370946b
user: Iván Perdomo <ivan.perdomo <at> openbravo.com>
date: Tue May 17 08:33:17 2011 +0200
summary: Fixes JSLint warnings
details: /erp/devel/pi/rev/4c132892ba1b
changeset: 12181:4c132892ba1b
user: Iván Perdomo <ivan.perdomo <at> openbravo.com>
date: Tue May 17 08:33:35 2011 +0200
summary: Fixes JSLint warnings
details: /erp/devel/pi/rev/fb3513459f7a
changeset: 12182:fb3513459f7a
user: Iván Perdomo <ivan.perdomo <at> openbravo.com>
date: Tue May 17 08:33:52 2011 +0200
summary: Fixes JSLint warnings
details: /erp/devel/pi/rev/9f8a30621e41
changeset: 12183:9f8a30621e41
user: Iván Perdomo <ivan.perdomo <at> openbravo.com>
date: Tue May 17 08:34:13 2011 +0200
summary: Fixes JSLint warnings
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
| 6 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-action-button.js
| 2 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-alert-manager.js
| 5 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-application-menu.js
| 4 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-classic-compatibility.js
| 62 +++--
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-eventhandler.js
| 2 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-grid.js
| 17 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-history-manager.js
| 4 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-keyboard-manager.js
| 23 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-property-store.js
| 23 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-quick-launch.js
| 52 ++--
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-quickrun-widget.js
| 48 ++--
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-recent-utilities.js
| 6 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-remote-call-manager.js
| 4 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view-datasource.js
| 13 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
| 77 +++---
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-window.js
| 48 ++--
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-statusbar.js
| 6 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-tab.js
| 2 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-test-registry.js
| 14 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-toolbar.js
| 104 +++++----
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-user-profile-widget.js
| 2 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-utilities-number.js
| 20 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-utilities.js
| 46 ++--
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
| 91 ++++----
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-manager.js
| 9 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-ui-test.js
| 8 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/test/ob-utilities-date-test.js
| 24 +-
modules/org.openbravo.client.kernel/jslint/jscheck
| 3 +-
modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-community-branding-widget.js
| 18 +-
modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js
| 2 +-
modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-showparameter-widget.js
| 10 +-
modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-url-widget.js
| 4 +-
modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-widget.js
| 13 +-
modules/org.openbravo.client.querylist/web/org.openbravo.client.querylist/js/ob-querylist-widget.js
| 9 +-
modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js
| 8 +-
36 files changed, 400 insertions(+), 389 deletions(-)
diffs (truncated from 2344 to 300 lines):
diff -r a6315f2288a0 -r 9f8a30621e41
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
Mon May 16 15:54:43 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
Tue May 17 08:34:13 2011 +0200
@@ -267,13 +267,13 @@
this.filterEditor.getEditForm().setValue(this.getCheckboxField().name,
newValue);
}
},
-
+
// note when solving selection issues in the future also
// consider using the selectionChanged method, but that
// one has as disadvantage that it is called multiple times
// for one select/deselect action
selectionUpdated: function(record, recordList){
-
+
this.stopHover();
this.updateSelectedCountDisplay();
if (this.getSelectedRecords() && this.getSelectedRecords().length !== 1) {
@@ -503,4 +503,4 @@
return menuItems;
}
-});
\ No newline at end of file
+});
diff -r a6315f2288a0 -r 9f8a30621e41
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-action-button.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-action-button.js
Mon May 16 15:54:43 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-action-button.js
Tue May 17 08:34:13 2011 +0200
@@ -43,7 +43,7 @@
},
doAction: function(){
- var theView = this.contextView;
+ var theView = this.contextView, param;
var allProperties = theView.getContextInfo(false, true, false, true);
var sessionProperties = theView.getContextInfo(true, true, false, true);
diff -r a6315f2288a0 -r 9f8a30621e41
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-alert-manager.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-alert-manager.js
Mon May 16 15:54:43 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-alert-manager.js
Tue May 17 08:34:13 2011 +0200
@@ -70,11 +70,12 @@
},
_notify : function(rpcResponse, data, rpcRequest) {
+ var i;
// store info for new listeners
OB.AlertManager.lastResponse = rpcResponse;
OB.AlertManager.lastData = data;
OB.AlertManager.lastRequest = rpcRequest;
- for ( var i = 0; i < OB.AlertManager.listeners.length; i++) {
+ for (i = 0; i < OB.AlertManager.listeners.length; i++) {
OB.AlertManager.listeners[i](rpcResponse, data, rpcRequest);
}
isc.Timer.setTimeout(OB.AlertManager.call, OB.AlertManager.delay);
@@ -93,7 +94,7 @@
// call it ones to update the pings and start the timer
OB.AlertManager.call();
-})(OB, isc);
+}(OB, isc));
isc.ClassFactory.defineClass('OBAlertIcon', isc.ImgButton);
diff -r a6315f2288a0 -r 9f8a30621e41
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-application-menu.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-application-menu.js
Mon May 16 15:54:43 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-application-menu.js
Tue May 17 08:34:13 2011 +0200
@@ -244,9 +244,9 @@
setMenuItems: function () {
var recent = OB.RecentUtilities.getRecentValue('UINAVBA_MenuRecentList');
var recentEntries = [];
- var completeMenuTree;
+ var completeMenuTree, recentIndex;
if (recent && recent.length > 0) {
- for (var recentIndex = 0; recentIndex < recent.length; recentIndex++) {
+ for (recentIndex = 0; recentIndex < recent.length; recentIndex++) {
var recentEntry = recent[recentIndex];
if (recentEntry) {
recentEntries[recentIndex] = {title: recentEntry.tabTitle,
recentObject: recentEntry, type: recentEntry.type/*, _baseStyle:
'OBNavBarComponentMenuItemCell'*/};
diff -r a6315f2288a0 -r 9f8a30621e41
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-classic-compatibility.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-classic-compatibility.js
Mon May 16 15:54:43 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-classic-compatibility.js
Tue May 17 08:34:13 2011 +0200
@@ -109,8 +109,8 @@
if (field.selectedIndex === -1) {
return result;
} else {
- var length = field.options.length;
- for (var fieldsCount = 0; fieldsCount < length; fieldsCount++) {
+ var length = field.options.length, fieldsCount;
+ for (fieldsCount = 0; fieldsCount < length; fieldsCount++) {
if (field.options[fieldsCount].selected) {
result.name = name;
result.value = field.options[fieldsCount].value;
@@ -129,8 +129,8 @@
return result;
}
} else {
- var total = field.length;
- for (var i = 0; i < total; i++) {
+ var total = field.length, i;
+ for (i = 0; i < total; i++) {
if (field[i].checked) {
result.name = name;
result.value = field[i].value;
@@ -144,20 +144,21 @@
return result;
}
}
-
+
return result;
}
-
+
//
// Returns a JSON of all the form fields. Also adds Command and
IsAjaxCall
// parameters to communicate with the classic OB class
//
function getXHRParamsObj(/* String */action, /* Object */ formObject){
- var paramsObj = {};
+ var paramsObj = {}, i;
+
paramsObj.Command = action;
paramsObj.IsAjaxCall = '1';
- for (var i = 0; i < formObject.elements.length; i++) {
+ for (i = 0; i < formObject.elements.length; i++) {
if (formObject.elements[i].type) {
var param = inputValueForms(formObject.elements[i].name,
formObject.elements[i]);
@@ -221,21 +222,22 @@
if (tabNumber === null) {
return false;
}
-
+
tabPane = tabSet.getTabPane(tabNumber);
-
+
tabSet.setTabTitle(tabNumber, title);
tabPane.updateTabInformation(windowId, tabId, recordId, mode,
obManualURL, title);
},
-
+
Keyboard: {
getMDIKS: function(){
- var key, auxKey, action, funcParam, keyMap;
- var ClassicKeyJSON = [];
- var LKS = O.KeyboardManager.KS;
- for (var i = 0; i < LKS.list.length; i++) {
+ var key, auxKey, action, funcParam, keyMap,
+ ClassicKeyJSON = [],
+ LKS = O.KeyboardManager.KS, i;
+
+ for (i = 0; i < LKS.list.length; i++) {
auxKey = '';
-
+
if (LKS.list[i].keyComb.ctrl === true) {
auxKey = auxKey + 'ctrlKey';
}
@@ -248,13 +250,13 @@
if (LKS.list[i].keyComb.key !== null) {
key = LKS.list[i].keyComb.key;
}
-
+
action = LKS.list[i].action;
funcParam = LKS.list[i].funcParam;
-
+
// Special keys nomenclature adaptation from Smartclient way to
// classic utils.js way
-
+
keyMap = {
'Backspace': 'BACKSPACE',
'Tab': 'TAB',
@@ -286,9 +288,9 @@
'f11': 'F11',
'f12': 'F12'
};
-
+
key = keyMap[key] || key;
-
+
ClassicKeyJSON.push({
'key': key,
'auxKey': auxKey,
@@ -296,18 +298,18 @@
'funcParam': funcParam
});
}
-
+
return ClassicKeyJSON;
},
-
+
executeKSFunction: function(func, funcParam){
func(funcParam);
}
},
-
+
Popup: {
secString: 'dbXE8hjGuKyMefVf',
-
+
// ** {{{ Popup.open(name, width, height, url, title, theOpener) }}} **
//
// Shows a new popup with content
@@ -396,10 +398,10 @@
} else {
// Create a form and POST parameters as input hidden values
var doc =
cPopup.getIframeHtmlObj().contentWindow.frames[0].document,
- frm = doc.createElement('form');
+ frm = doc.createElement('form'), i;
frm.setAttribute('method','post');
frm.setAttribute('action', cPopup.popupURL);
- for (var i in postParams) {
+ for (i in postParams) {
if (postParams.hasOwnProperty(i)){
var inp = doc.createElement('input');
inp.setAttribute('type', 'hidden');
@@ -490,7 +492,7 @@
openHeartbeat: function(){
cobcomp.Popup.open('Heartbeat', 600, 500, OB.Application.contextUrl +
'ad_forms/Heartbeat.html', '', window, false, false, true);
},
-
+
// ** {{{ Popup.openRegistration() }}} **
//
// Opens directly the "Registration" window inside a popup
@@ -499,7 +501,7 @@
}
}
};
-
+
// Initialize ClassicOBCompatibility object
cobcomp = L.ClassicOBCompatibility = new ClassicOBCompatibility();
-})(OB, isc);
+}(OB, isc));
diff -r a6315f2288a0 -r 9f8a30621e41
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-eventhandler.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-eventhandler.js
Mon May 16 15:54:43 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-eventhandler.js
Tue May 17 08:34:13 2011 +0200
@@ -81,4 +81,4 @@
OB.EventHandler = new EventHandler();
isc.Page.setEvent(isc.EH.MOUSE_DOWN, OB.EventHandler, null, 'mouseDown');
-})(OB, isc);
+}(OB, isc));
diff -r a6315f2288a0 -r 9f8a30621e41
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-grid.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-grid.js
Mon May 16 15:54:43 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-grid.js
Tue May 17 08:34:13 2011 +0200
@@ -11,7 +11,7 @@
* under the License.
* The Original Code is Openbravo ERP.
* The Initial Developer of the Original Code is Openbravo SLU
- * All portions are Copyright (C) 2010 Openbravo SLU
+ * All portions are Copyright (C) 2010-2011 Openbravo SLU
* All Rights Reserved.
* Contributor(s): ______________________________________.
************************************************************************
@@ -183,8 +183,8 @@
var index = prop.lastIndexOf('.');
prop = prop.substring(0, index);
}
- var fnd = false;
- for (var j = 0; j < fields.length; j++) {
+ var fnd = false, j;
+ for (j = 0; j < fields.length; j++) {
if (fields[j].displayField === fullPropName) {
fnd = true;
break;
@@ -302,10 +302,11 @@
},
isGridFilteredWithCriteria: function(criteria) {
+ var i;
if (!criteria) {
return false;
}
- for (var i = 0; i < criteria.length; i++) {
+ for (i = 0; i < criteria.length; i++) {
var criterion = criteria[i];
var prop = criterion.fieldName;
var fullPropName = prop;
@@ -321,12 +322,12 @@
var index = prop.lastIndexOf('.');
prop = prop.substring(0, index);
}
-
+
var field = this.filterEditor.getField(prop);
if (this.isValidFilterField(field) && (value === false || value || value
=== 0)) {
return true;
}
------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
