[OpenbravoERP-commits] devel/pi: Fixes issue 18514: Widget in form do not work after up...

[hg]

details:   https://code.openbravo.com/erp/devel/pi/rev/4147af532ff5
changeset: 13793:4147af532ff5
user:      Martin Taal <martin.taal <at> openbravo.com>
date:      Mon Sep 19 14:52:27 2011 +0200
summary:   Fixes issue 18514: Widget in form do not work after upgrade to 
latest smartclient version
Reworked to handle empty string as input for jsonobject

diffstat:

 
modules/org.openbravo.client.myob/src/org/openbravo/client/myob/widgetinform/WidgetInFormUIDefinition.java
 |  8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diffs (36 lines):

diff -r af40fd7a85c8 -r 4147af532ff5 
modules/org.openbravo.client.myob/src/org/openbravo/client/myob/widgetinform/WidgetInFormUIDefinition.java
--- 
a/modules/org.openbravo.client.myob/src/org/openbravo/client/myob/widgetinform/WidgetInFormUIDefinition.java
        Mon Sep 19 14:17:06 2011 +0200
+++ 
b/modules/org.openbravo.client.myob/src/org/openbravo/client/myob/widgetinform/WidgetInFormUIDefinition.java
        Mon Sep 19 14:52:27 2011 +0200
@@ -18,6 +18,7 @@
  */
 package org.openbravo.client.myob.widgetinform;
 
+import org.apache.log4j.Logger;
 import org.codehaus.jettison.json.JSONException;
 import org.codehaus.jettison.json.JSONObject;
 import org.openbravo.client.kernel.reference.UIDefinition;
@@ -34,6 +35,8 @@
  */
 public class WidgetInFormUIDefinition extends UIDefinition {
 
+  private static Logger log = Logger.getLogger(WidgetInFormUIDefinition.class);
+
   @Override
   public String getFormEditorType() {
     return "OBWidgetInFormItem";
@@ -51,11 +54,14 @@
     WidgetClass widgetClass = wr.getWidgetClass();
 
     try {
-      JSONObject o = new JSONObject(fieldProperties);
+      JSONObject o = (fieldProperties == null || 
fieldProperties.trim().length() == 0) ? new JSONObject()
+          : new JSONObject(fieldProperties);
       o.put("widgetClassId", widgetClass.getId());
       o.put("showTitle", wr.isShowFieldTitle());
       return o.toString();
     } catch (JSONException e) {
+      // be robust
+      log.error(e.getMessage(), e);
       return fieldProperties;
     }
   }

------------------------------------------------------------------------------
BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
Learn about the latest advances in developing for the 
BlackBerry&reg; mobile platform with sessions, labs & more.
See new tools and technologies. Register for BlackBerry&reg; DevCon today!
http://p.sf.net/sfu/rim-devcon-copy1 
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits