details: https://code.openbravo.com/erp/devel/pi/rev/8bed3d97fec0
changeset: 13823:8bed3d97fec0
user: Martin Taal <martin.taal <at> openbravo.com>
date: Fri Sep 23 07:43:45 2011 +0200
summary: Fixes issue 18592: Yes/No filter combo shows double values after
filtering
Correctly translate string values to booleans
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list-filter.js
| 1 +
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-yesno.js
| 17 ++++++++-
2 files changed, 16 insertions(+), 2 deletions(-)
diffs (41 lines):
diff -r 4a26324524c5 -r 8bed3d97fec0
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list-filter.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list-filter.js
Fri Sep 23 07:19:08 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list-filter.js
Fri Sep 23 07:43:45 2011 +0200
@@ -28,6 +28,7 @@
validateOnExit: false,
validateOnChange: false,
filterOnKeypress: false,
+ addUnknownValues: false,
// note: can't override changed as it is used by the filter editor
// itself, see the RecordEditor source code and the changed event
diff -r 4a26324524c5 -r 8bed3d97fec0
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-yesno.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-yesno.js
Fri Sep 23 07:19:08 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-yesno.js
Fri Sep 23 07:43:45 2011 +0200
@@ -18,11 +18,24 @@
*/
// == OBYesNoItem ==
-// Extends SelectItem with preset yes and no values.
-isc.ClassFactory.defineClass('OBYesNoItem', SelectItem);
+// Extends ComboBoxItem with preset yes and no values.
+isc.ClassFactory.defineClass('OBYesNoItem', ComboBoxItem);
isc.OBYesNoItem.addProperties({
operator: 'equals',
+ addUnknownValues: false,
+
+ // solves:
+ // https://issues.openbravo.com/view.php?id=18592
+ setValue: function(value) {
+ if (value === 'true') {
+ this.Super('setValue', [true]);
+ } else if (value === 'false') {
+ this.Super('setValue', [false]);
+ } else {
+ this.Super('setValue', arguments);
+ }
+ },
mapValueToDisplay: function(value, a, b, c){
return OB.Utilities.getYesNoDisplayValue(value);
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2dcopy2
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
