details: https://code.openbravo.com/erp/devel/pi/rev/103c7719b601 changeset: 14077:103c7719b601 user: Iván Perdomo <ivan.perdomo <at> openbravo.com> date: Mon Oct 24 23:16:22 2011 +0200 summary: Issue 18781: Annotate source code with available globals
details: https://code.openbravo.com/erp/devel/pi/rev/fc3f17718283 changeset: 14078:fc3f17718283 user: Iván Perdomo <ivan.perdomo <at> openbravo.com> date: Mon Oct 24 23:17:12 2011 +0200 summary: Issue 18781: Annotate the source code with available globals details: https://code.openbravo.com/erp/devel/pi/rev/b249bed2371e changeset: 14079:b249bed2371e user: Iván Perdomo <ivan.perdomo <at> openbravo.com> date: Mon Oct 24 23:20:02 2011 +0200 summary: Issue 18781: Fixes use of undeclared variables details: https://code.openbravo.com/erp/devel/pi/rev/62ad106caee5 changeset: 14080:62ad106caee5 user: Iván Perdomo <ivan.perdomo <at> openbravo.com> date: Mon Oct 24 23:21:34 2011 +0200 summary: Issue 18781: Enabled the detection of undeclared variables diffstat: modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-search.js | 4 ++-- modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js | 2 +- modules/org.openbravo.client.kernel/jslint/jslint | 9 ++++++++- modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-community-branding-widget.js | 2 ++ modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-link-widget.js | 2 ++ modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js | 2 ++ 6 files changed, 17 insertions(+), 4 deletions(-) diffs (75 lines): diff -r 9ff50adb99e5 -r 62ad106caee5 modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-search.js --- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-search.js Mon Oct 24 17:36:40 2011 +0200 +++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-search.js Mon Oct 24 23:21:34 2011 +0200 @@ -217,7 +217,7 @@ setUnloadEventHandling: function(){ var me = this; if (document.layers) { - document.captureEvents(Event.UNLOAD); + document.captureEvents(isc.Event.UNLOAD); } window.onunload = function(){ if (isc.OBSearchItem.openedWindow) { @@ -230,7 +230,7 @@ clearUnloadEventHandling: function(){ if (document.layers) { - window.releaseEvents(Event.UNLOAD); + window.releaseEvents(isc.Event.UNLOAD); } window.onunload = function(){ }; diff -r 9ff50adb99e5 -r 62ad106caee5 modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js --- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js Mon Oct 24 17:36:40 2011 +0200 +++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js Mon Oct 24 23:21:34 2011 +0200 @@ -97,7 +97,7 @@ getStatusBarFields: function() { var statusBarFields = [[],[],[],[],[], []], i, item, title, refColumnName, targetEntity, value, displayedValue, - length = this.statusBarFields.length; + length = this.statusBarFields.length, sourceWindowId; for(i = 0; i < length; i++) { item = this.getItem(this.statusBarFields[i]); title = item.getTitle(); diff -r 9ff50adb99e5 -r 62ad106caee5 modules/org.openbravo.client.kernel/jslint/jslint --- a/modules/org.openbravo.client.kernel/jslint/jslint Mon Oct 24 17:36:40 2011 +0200 +++ b/modules/org.openbravo.client.kernel/jslint/jslint Mon Oct 24 23:21:34 2011 +0200 @@ -1,3 +1,10 @@ #!/bin/sh + +# --browser doesn't work properly in jslint4java 1.4.7 +# adding the global available functions manually: window, unscape, top, alert +# adding globals present in qunit: ok, test, module, expect, same, stop, start, equals, asyncTest + echo "Checking --> $@" -java -jar ./modules/org.openbravo.client.kernel/lib/runtime/jslint4java-1.4.7.jar --browser --evil --continue "$@" +java -jar ./modules/org.openbravo.client.kernel/lib/runtime/jslint4java-1.4.7.jar \ + --browser --evil --continue --undef \ + --predef window,unescape,top,alert,isc,OB,ok,test,module,expect,same,stop,start,asyncTest,equals "$@" diff -r 9ff50adb99e5 -r 62ad106caee5 modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-community-branding-widget.js --- a/modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-community-branding-widget.js Mon Oct 24 17:36:40 2011 +0200 +++ b/modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-community-branding-widget.js Mon Oct 24 23:21:34 2011 +0200 @@ -1,3 +1,5 @@ +/*global $LAB,internetConnection */ + /* ************************************************************************* * The contents of this file are subject to the Openbravo Public License diff -r 9ff50adb99e5 -r 62ad106caee5 modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-link-widget.js --- a/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-link-widget.js Mon Oct 24 17:36:40 2011 +0200 +++ b/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-link-widget.js Mon Oct 24 23:21:34 2011 +0200 @@ -1,3 +1,5 @@ +/*global setOBTabBehavior */ + /* ************************************************************************* * The contents of this file are subject to the Openbravo Public License diff -r 9ff50adb99e5 -r 62ad106caee5 modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js --- a/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js Mon Oct 24 17:36:40 2011 +0200 +++ b/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js Mon Oct 24 23:21:34 2011 +0200 @@ -1,3 +1,5 @@ +/*global setWindowEditing, readOnlyLogic, logChanges, setOBTabBehavior, setWindowElementFocus, disableDefaultAction, displayLogic */ + /* ************************************************************************* * The contents of this file are subject to the Openbravo Public License ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ Openbravo-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-commits
