details:   https://code.openbravo.com/erp/devel/pi/rev/bb262fd68c3f
changeset: 14883:bb262fd68c3f
user:      Javier Etxarri <javier.echarri <at> openbravo.com>
date:      Fri Dec 16 08:37:41 2011 +0100
summary:   Fixes issue 19258: c_validcombination_insert function has a variable 
incorrectly defined

details:   https://code.openbravo.com/erp/devel/pi/rev/64f59c381a6c
changeset: 14884:64f59c381a6c
user:      Javier Etxarri <javier.echarri <at> openbravo.com>
date:      Fri Dec 16 10:58:44 2011 +0100
summary:   Fixes issue 19125: Ending date is automatically updated when new 
period is saved

diffstat:

 src-db/database/model/functions/C_VALIDCOMBINATION_INSERT.xml |   2 +-
 src-db/database/model/triggers/C_PERIOD_TRG2.xml              |  10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diffs (41 lines):

diff -r b50bb1f894f9 -r 64f59c381a6c 
src-db/database/model/functions/C_VALIDCOMBINATION_INSERT.xml
--- a/src-db/database/model/functions/C_VALIDCOMBINATION_INSERT.xml     Fri Dec 
16 10:48:27 2011 +0100
+++ b/src-db/database/model/functions/C_VALIDCOMBINATION_INSERT.xml     Fri Dec 
16 10:58:44 2011 +0100
@@ -102,7 +102,7 @@
     -- Existance Loop - Get first fully qualified matching combination
     --
     FoundValue CHAR(1):='N';
-    RetValue NUMBER:=NULL;
+    RetValue VARCHAR2(32):=NULL;
     fullyQualified CHAR(1) ;
 
 
diff -r b50bb1f894f9 -r 64f59c381a6c 
src-db/database/model/triggers/C_PERIOD_TRG2.xml
--- a/src-db/database/model/triggers/C_PERIOD_TRG2.xml  Fri Dec 16 10:48:27 
2011 +0100
+++ b/src-db/database/model/triggers/C_PERIOD_TRG2.xml  Fri Dec 16 10:58:44 
2011 +0100
@@ -28,18 +28,22 @@
     V_COUNT NUMBER:= 0;
 
 BEGIN
-    
+
     IF AD_isTriggerEnabled()='N' THEN RETURN;
     END IF;
 
    IF(UPDATING) THEN
      IF COALESCE(:old.StartDate, v_DateNull) <> COALESCE(:NEW.StartDate, 
v_DateNull) THEN
-       :new.EndDate:= ADD_MONTHS(TRUNC(:new.StartDate, 'MM'), 1) -1;
+        IF (:new.EndDate IS NULL) THEN
+           :new.EndDate:= ADD_MONTHS(TRUNC(:new.StartDate, 'MM'), 1) -1;
+       END If;
      END IF;
    END IF;
 
    IF(INSERTING) THEN
-        :new.EndDate:= ADD_MONTHS(TRUNC(:new.StartDate, 'MM'), 1) -1;
+       IF (:new.EndDate IS NULL) THEN
+           :new.EndDate:= ADD_MONTHS(TRUNC(:new.StartDate, 'MM'), 1) -1;
+       END If;
    END IF;
 
    -- Validating dates period

------------------------------------------------------------------------------
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to