details: https://code.openbravo.com/erp/devel/pi/rev/8f6f2842e1f0
changeset: 16502:8f6f2842e1f0
user: Martin Taal <martin.taal <at> openbravo.com>
date: Sun May 13 22:53:02 2012 +0200
summary: Fixes issue 20482: Tab does not move focus in grid editing if a
field has a FIC call
The cell edit call to the smartclient code should be done before the blur,
because the
cell edit end call programmatically moves the focus to the next field in case
of a tab.
The blur will do a FIC call which forces the focus back into the original
field, if it
is not reset by the superclass.
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
| 28 ++-------
1 files changed, 6 insertions(+), 22 deletions(-)
diffs (43 lines):
diff -r 3e863f6c3a41 -r 8f6f2842e1f0
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
Sun May 13 22:46:18 2012 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
Sun May 13 22:53:02 2012 +0200
@@ -2054,33 +2054,17 @@
this.view.standardWindow.doActionAfterAutoSave(actionObject, true);
return;
}
- if (ficCallDone) {
- // get new value as the row can have changed
- this.Super('cellEditEnd', [editCompletionEvent,
this.getEditValue(rowNum, colNum)]);
- return;
- } else {
- // only needed for non picklist fields
- // as picklist fields will always have picked a value
- // note that focusItem updatevalue for picklist can result in extra
datasource requests
- if (focusItem && !focusItem.hasPickList) {
- focusItem.blur(focusItem.form, focusItem);
- if (editForm.inFicCall) {
- // use editValues object as the edit form will be re-used for a next
row
- var editValues = this.getEditValues(rowNum);
- editValues.actionAfterFicReturn = {
- target: this,
- method: this.cellEditEnd,
- parameters: [editCompletionEvent, newValue, true, autoSaveDone]
- };
- return;
- }
- }
- }
if (newValue) {
this.Super('cellEditEnd', [editCompletionEvent, newValue]);
} else {
this.Super('cellEditEnd', [editCompletionEvent]);
}
+ // only needed for non picklist fields
+ // as picklist fields will always have picked a value
+ // note that focusItem updatevalue for picklist can result in extra
datasource requests
+ if (focusItem && !focusItem.hasPickList) {
+ focusItem.blur(focusItem.form, focusItem);
+ }
},
// overridden to set the enterkeyaction to nextrowstart in cases the current
row
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits