details: https://code.openbravo.com/erp/devel/pi/rev/e260a84b287f
changeset: 16554:e260a84b287f
user: Augusto Mauch <augusto.mauch <at> openbravo.com>
date: Wed May 16 12:36:15 2012 +0200
summary: Fixes issue 20345: Code review changes applied
Now the field used to retrieve the language of the core module is ad_module_id
(0) instead of name ('Core', it may vary in the future). Instead of executing
the consult every time the language is needed, it is executed once and the
returned value is saved in a variable.
The year in the license has been updated.
diffstat:
src-db/database/model/functions/AD_LANGUAGE_CREATE.xml | 27 ++++++++++-------
1 files changed, 16 insertions(+), 11 deletions(-)
diffs (121 lines):
diff -r 7e1cede2db37 -r e260a84b287f
src-db/database/model/functions/AD_LANGUAGE_CREATE.xml
--- a/src-db/database/model/functions/AD_LANGUAGE_CREATE.xml Wed May 16
11:52:03 2012 +0200
+++ b/src-db/database/model/functions/AD_LANGUAGE_CREATE.xml Wed May 16
12:36:15 2012 +0200
@@ -19,7 +19,7 @@
* parts created by ComPiere are Copyright (C) ComPiere, Inc.;
* All Rights Reserved.
* Contributor(s): Openbravo SLU
- * Contributions are Copyright (C) 2001-2011 Openbravo, S.L.U.
+ * Contributions are Copyright (C) 2001-2012 Openbravo, S.L.U.
*
* Specifically, this derivative work is based upon the following Compiere
* file and version.
@@ -38,6 +38,7 @@
v_Result NUMBER:=1; -- 0=failure
v_Record_ID VARCHAR2(32);
v_AD_User_ID VARCHAR2(32);
+ v_Core_Language VARCHAR2(32);
-- Parameter
TYPE RECORD IS REF CURSOR;
Cur_Parameter RECORD;
@@ -371,6 +372,10 @@
v_Created:=v_Created + v_rowcount;
DBMS_OUTPUT.PUT_LINE('- AD_Window ' || v_rowcount) ;
+
+ SELECT ad_language INTO v_Core_Language
+ FROM ad_module
+ WHERE ad_module_id = '0';
--No module
INSERT
@@ -383,7 +388,7 @@
SELECT get_uuid(), AD_Month_ID, AD_Language.AD_Language, AD_Month.Name,
'N', '0', '0', AD_Month.AD_Client_ID, AD_Month.AD_Org_ID
FROM AD_Month, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM AD_Month_TRL
WHERE AD_Month_ID = AD_Month.AD_Month_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
@@ -403,7 +408,7 @@
SELECT get_uuid(), C_Country_ID, AD_Language.AD_Language, C_Country.Name,
C_Country.Description, C_Country.RegionName, C_Country.DisplaySequence, 'N',
'0', '0', C_Country.AD_Client_ID, C_Country.AD_Org_ID
FROM C_Country, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM C_Country_TRL
WHERE C_Country_ID = C_Country.C_Country_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
@@ -423,7 +428,7 @@
SELECT get_uuid(), C_Currency_ID, AD_Language.AD_Language,
C_Currency.CurSymbol, C_Currency.Description, 'N', '0', '0',
C_Currency.AD_Client_ID, C_Currency.AD_Org_ID
FROM C_Currency, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM C_Currency_TRL
WHERE C_Currency_ID = C_Currency.C_Currency_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
@@ -445,7 +450,7 @@
SELECT get_uuid(), C_DocType_ID, AD_Language.AD_Language, C_DocType.Name,
C_DocType.PrintName, C_DocType.DocumentNote, 'N', '0', '0',
C_DocType.AD_Client_ID, C_DocType.AD_Org_ID
FROM C_DocType, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM C_DocType_TRL
WHERE C_DocType_ID = C_DocType.C_DocType_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
@@ -464,7 +469,7 @@
SELECT get_uuid(), C_ElementValue_ID, AD_Language.AD_Language,
C_ElementValue.Name, C_ElementValue.Description, 'N', '0', '0',
C_ElementValue.AD_Client_ID, C_ElementValue.AD_Org_ID
FROM C_ElementValue, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM C_ElementValue_TRL
WHERE C_ElementValue_ID = C_ElementValue.C_ElementValue_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
@@ -482,7 +487,7 @@
SELECT get_uuid(), C_Greeting_ID, AD_Language.AD_Language,
C_Greeting.Name, C_Greeting.Greeting, 'N', '0', '0', C_Greeting.AD_Client_ID,
C_Greeting.AD_Org_ID
FROM C_Greeting, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM C_Greeting_TRL
WHERE C_Greeting_ID = C_Greeting.C_Greeting_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
@@ -500,7 +505,7 @@
SELECT get_uuid(), C_PaymentTerm_ID, AD_Language.AD_Language,
C_PaymentTerm.Name, C_PaymentTerm.Description, C_PaymentTerm.DocumentNote, 'N',
'0', '0', C_PaymentTerm.AD_Client_ID, C_PaymentTerm.AD_Org_ID
FROM C_PaymentTerm, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM C_PaymentTerm_TRL
WHERE C_PaymentTerm_ID = C_PaymentTerm.C_PaymentTerm_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
@@ -518,7 +523,7 @@
SELECT get_uuid(), C_TaxCategory_ID, AD_Language.AD_Language,
C_TaxCategory.Name, C_TaxCategory.Description, 'N', '0', '0',
C_TaxCategory.AD_Client_ID, C_TaxCategory.AD_Org_ID
FROM C_TaxCategory, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM C_TaxCategory_TRL
WHERE C_TaxCategory_ID = C_TaxCategory.C_TaxCategory_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
@@ -536,7 +541,7 @@
SELECT get_uuid(), C_UOM_ID, AD_Language.AD_Language, C_UOM.Name,
C_UOM.Description, C_UOM.UOMSymbol, 'N', '0', '0', C_UOM.AD_Client_ID,
C_UOM.AD_Org_ID
FROM C_UOM, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM C_UOM_TRL
WHERE C_UOM_ID = C_UOM.C_UOM_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
@@ -554,7 +559,7 @@
SELECT get_uuid(), C_Tax_ID, AD_Language.AD_Language, C_Tax.Name,
C_Tax.Description, C_Tax.TaxIndicator, 'N', '0', '0', C_Tax.AD_Client_ID,
C_Tax.AD_Org_ID
FROM C_Tax, AD_Language
WHERE AD_Language.IsActive='Y' AND AD_Language.IsSystemLanguage='Y'
- AND AD_Language.AD_Language != (SELECT ad_language FROM ad_module WHERE
name = 'Core')
+ AND AD_Language.AD_Language != v_Core_Language
AND NOT EXISTS (SELECT 1 FROM C_Tax_TRL
WHERE C_Tax_ID = C_Tax.C_Tax_ID
AND AD_LANGUAGE = AD_Language.AD_Language);
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
