details:   https://code.openbravo.com/erp/devel/pi/rev/6ab1c8f8f009
changeset: 17867:6ab1c8f8f009
user:      Augusto Mauch <augusto.mauch <at> openbravo.com>
date:      Thu Sep 06 13:27:51 2012 +0200
summary:   Fixes issue 21568: Using the Product selector do not cause log errors

The fix used to detect unknown properties was applied twice: to fields that 
properties that contained the field separator and to fields that did not. It 
should only have been applied to the fields that do not contain the field 
separator (if it contains a field separator, we can be confident the property 
is sent from the Openbravo client).

diffstat:

 
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
 |  6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diffs (16 lines):

diff -r ccb26bc958a4 -r 6ab1c8f8f009 
modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
--- 
a/modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
       Fri Jun 01 14:34:27 2012 +0200
+++ 
b/modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
       Thu Sep 06 13:27:51 2012 +0200
@@ -171,11 +171,7 @@
               }
             } else {
               for (int i = 0; i < fieldNameSplit.length; i++) {
-                if (cEntity.hasProperty(fieldName)) {
-                  fProp = cEntity.getProperty(fieldNameSplit[i]);
-                } else {
-                  continue;
-                }
+                fProp = cEntity.getProperty(fieldNameSplit[i]);
                 if (i != fieldNameSplit.length - 1) {
                   cEntity = fProp.getReferencedProperty().getEntity();
                 }

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to