details:   https://code.openbravo.com/erp/devel/pi/rev/2c39d6a6c546
changeset: 18554:2c39d6a6c546
user:      Shankar Balachandran <shankar.balachandran <at> openbravo.com>
date:      Fri Nov 16 09:36:31 2012 +0100
summary:   Fixes Issue 0021888: Issues in Payment Plan P&E Windows.

In Modify Payment plan P&E window, the payment method field's dropdown did not 
show any records.
Added logic to cache drop down values (rowEditorEnter method) if not a modify 
payment plan P&E window.

diffstat:

 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
 |  44 +++++----
 1 files changed, 25 insertions(+), 19 deletions(-)

diffs (63 lines):

diff -r f3a08810b2a9 -r 2c39d6a6c546 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
      Thu Nov 15 12:13:23 2012 +0100
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
      Fri Nov 16 09:36:31 2012 +0100
@@ -130,26 +130,28 @@
   // so that the combo shows the correct value without 
   // loading it from the backend
   rowEditorEnter: function (record, editValues, rowNum) {
-    var i = 0,
-        editRecord = this.getEditedRecord(rowNum),
-        gridFld, identifier, formFld, value, form = this.getEditForm();
+    if (this.view.actionHandler !== 
"org.openbravo.advpaymentmngt.actionHandler.ModifyPaymentPlanActionHandler") {
+      var i = 0,
+          editRecord = this.getEditedRecord(rowNum),
+          gridFld, identifier, formFld, value, form = this.getEditForm();
 
-    if (editRecord) {
-      // go through the fields and set the edit values
-      for (i = 0; i < this.getFields().length; i++) {
-        gridFld = this.getFields()[i];
-        formFld = form.getField(gridFld.name);
-        value = editRecord[gridFld.name];
-        identifier = editRecord[gridFld.name + OB.Constants.FIELDSEPARATOR + 
OB.Constants.IDENTIFIER];
-        if (formFld && value && identifier) {
-          if (formFld.setEntry) {
-            formFld.setEntry(value, identifier);
-          } else {
-            if (!formFld.valueMap) {
-              formFld.valueMap = {};
+      if (editRecord) {
+        // go through the fields and set the edit values
+        for (i = 0; i < this.getFields().length; i++) {
+          gridFld = this.getFields()[i];
+          formFld = form.getField(gridFld.name);
+          value = editRecord[gridFld.name];
+          identifier = editRecord[gridFld.name + OB.Constants.FIELDSEPARATOR + 
OB.Constants.IDENTIFIER];
+          if (formFld && value && identifier) {
+            if (formFld.setEntry) {
+              formFld.setEntry(value, identifier);
+            } else {
+              if (!formFld.valueMap) {
+                formFld.valueMap = {};
+              }
+              formFld.valueMap[value] = identifier;
+              form.setValue(formFld, value);
             }
-            formFld.valueMap[value] = identifier;
-            form.setValue(formFld, value);
           }
         }
       }
@@ -461,7 +463,11 @@
     // retrieve the initial values only if a new row has been selected
     // see issue https://issues.openbravo.com/view.php?id=20653
     if (newRow) {
-      this.retrieveInitialValues(rowNum, colNum, newCell, newRow, 
suppressFocus);
+      if (this.view.actionHandler === 
"org.openbravo.advpaymentmngt.actionHandler.ModifyPaymentPlanActionHandler") {
+        this.retrieveInitialValues(rowNum, colNum, false, false, 
suppressFocus);
+      } else {
+        this.retrieveInitialValues(rowNum, colNum, newCell, newRow, 
suppressFocus);
+      }
     }
     this.Super('showInlineEditor', arguments);
   },

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to