details: https://code.openbravo.com/erp/devel/pi/rev/ea1146b41c34
changeset: 18782:ea1146b41c34
user: Carlos Aristu <carlos.aristu <at> openbravo.com>
date: Fri Nov 30 11:02:08 2012 +0100
summary: fixes issue 22435: UpdateFactAcctDescription module script needs
to be improved
diffstat:
src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFactAcctDescription.class
| 0
src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFactAcctDescriptionData.class
| 0
src-util/modulescript/src/org/openbravo/modulescript/UpdateFactAcctDescription.java
| 9 ++-
src-util/modulescript/src/org/openbravo/modulescript/UpdateFactAcctDescription_data.xsql
| 34 +++++++++-
4 files changed, 38 insertions(+), 5 deletions(-)
diffs (73 lines):
diff -r 41dda3dfa14d -r ea1146b41c34
src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFactAcctDescription.class
Binary file
src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFactAcctDescription.class
has changed
diff -r 41dda3dfa14d -r ea1146b41c34
src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFactAcctDescriptionData.class
Binary file
src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFactAcctDescriptionData.class
has changed
diff -r 41dda3dfa14d -r ea1146b41c34
src-util/modulescript/src/org/openbravo/modulescript/UpdateFactAcctDescription.java
---
a/src-util/modulescript/src/org/openbravo/modulescript/UpdateFactAcctDescription.java
Fri Nov 30 10:35:39 2012 +0100
+++
b/src-util/modulescript/src/org/openbravo/modulescript/UpdateFactAcctDescription.java
Fri Nov 30 11:02:08 2012 +0100
@@ -28,8 +28,13 @@
public void execute() {
try {
ConnectionProvider cp = getConnectionProvider();
- if(UpdateFactAcctDescriptionData.needsUpdate(cp))
- UpdateFactAcctDescriptionData.updateFactAcctDescription(cp);
+ // If the preference does not exist in the database yet the modulescript
must be executed.
+ boolean isDescrUpdated =
UpdateFactAcctDescriptionData.isDescrUpdated(cp);
+ if (!isDescrUpdated){
+ if(UpdateFactAcctDescriptionData.needsUpdate(cp))
+ UpdateFactAcctDescriptionData.updateFactAcctDescription(cp);
+ UpdateFactAcctDescriptionData.createPreference(cp);
+ }
} catch(Exception e){
handleError(e);
}
diff -r 41dda3dfa14d -r ea1146b41c34
src-util/modulescript/src/org/openbravo/modulescript/UpdateFactAcctDescription_data.xsql
---
a/src-util/modulescript/src/org/openbravo/modulescript/UpdateFactAcctDescription_data.xsql
Fri Nov 30 10:35:39 2012 +0100
+++
b/src-util/modulescript/src/org/openbravo/modulescript/UpdateFactAcctDescription_data.xsql
Fri Nov 30 11:02:08 2012 +0100
@@ -24,9 +24,21 @@
<Sql>
<![CDATA[
SELECT count(1) as total
- FROM fact_acct fa LEFT JOIN c_elementvalue ev ON fa.account_id =
ev.c_elementvalue_id
- WHERE (fa.acctdescription is null
- OR (fa.acctdescription is not null and fa.acctdescription <>
ev.name))
+ FROM DUAL
+ WHERE EXISTS (SELECT 1 FROM fact_acct fa LEFT JOIN c_elementvalue ev
ON fa.account_id = ev.c_elementvalue_id
+ WHERE (fa.acctdescription is null
+ OR (fa.acctdescription is not null and
fa.acctdescription <> ev.name)))
+ ]]>
+ </Sql>
+ </SqlMethod>
+ <SqlMethod name="isDescrUpdated" type="preparedStatement" return="boolean">
+ <SqlMethodComment></SqlMethodComment>
+ <Sql>
+ <![CDATA[
+ SELECT count(*) as exist
+ FROM DUAL
+ WHERE EXISTS (SELECT 1 FROM ad_preference
+ WHERE attribute = 'Descr_Updated')
]]>
</Sql>
</SqlMethod>
@@ -44,4 +56,20 @@
]]>
</Sql>
</SqlMethod>
+ <SqlMethod name="createPreference" type="preparedStatement"
return="rowcount">
+ <SqlMethodComment></SqlMethodComment>
+ <Sql>
+ <![CDATA[
+ INSERT INTO ad_preference (
+ ad_preference_id, ad_client_id, ad_org_id, isactive,
+ createdby, created, updatedby, updated,
+ attribute
+ ) VALUES (
+ get_uuid(), '0', '0', 'Y',
+ '0', NOW(), '0', NOW(),
+ 'Descr_Updated'
+ )
+ ]]>
+ </Sql>
+ </SqlMethod>
</SqlClass>
\ No newline at end of file
------------------------------------------------------------------------------
Keep yourself connected to Go Parallel:
TUNE You got it built. Now make it sing. Tune shows you how.
http://goparallel.sourceforge.net
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
