details: https://code.openbravo.com/erp/devel/pi/rev/1d8be6fa0af9 changeset: 18995:1d8be6fa0af9 user: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> date: Mon Dec 10 17:45:21 2012 +0100 summary: Fixes bug 22474
details: https://code.openbravo.com/erp/devel/pi/rev/4827d77cafce changeset: 18996:4827d77cafce user: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com> date: Mon Dec 10 17:45:49 2012 +0100 summary: [managerial accounting] Applying code review diffstat: src/org/openbravo/erpCommon/businessUtility/COAUtility.java | 3 ++- src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java | 2 ++ src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diffs (38 lines): diff -r f1b0fc389b29 -r 4827d77cafce src/org/openbravo/erpCommon/businessUtility/COAUtility.java --- a/src/org/openbravo/erpCommon/businessUtility/COAUtility.java Mon Dec 10 17:18:50 2012 +0100 +++ b/src/org/openbravo/erpCommon/businessUtility/COAUtility.java Mon Dec 10 17:45:49 2012 +0100 @@ -216,8 +216,9 @@ try { obeResult = insertElementValuesInDB(coa); if (!obeResult.getType().equals(strMessageOk)) { + return obeResult; + } else { OBDal.getInstance().flush(); - return obeResult; } } catch (Exception e) { return logError( diff -r f1b0fc389b29 -r 4827d77cafce src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java --- a/src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java Mon Dec 10 17:18:50 2012 +0100 +++ b/src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java Mon Dec 10 17:45:49 2012 +0100 @@ -1483,6 +1483,8 @@ OBCriteria<AccountingCombination> obc = OBDal.getInstance().createCriteria( AccountingCombination.class); obc.add(Restrictions.eq(AccountingCombination.PROPERTY_ACCOUNT, elementValue)); + obc.setFilterOnReadableClients(false); + obc.setFilterOnReadableOrganization(false); List<AccountingCombination> combinations = obc.list(); if (combinations.size() == 0) { diff -r f1b0fc389b29 -r 4827d77cafce src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java --- a/src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java Mon Dec 10 17:18:50 2012 +0100 +++ b/src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java Mon Dec 10 17:45:49 2012 +0100 @@ -42,7 +42,7 @@ public class DimensionDisplayUtility { - public static final Logger log4j = Logger.getLogger(DimensionDisplayUtility.class); + private static final Logger log4j = Logger.getLogger(DimensionDisplayUtility.class); /** Accounting Dimensions **/ public static final String DIM_Header = "H"; ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Openbravo-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-commits
