details: https://code.openbravo.com/erp/devel/pi/rev/23ef6bb25464 changeset: 19179:23ef6bb25464 user: Shankar Balachandran <shankar.balachandran <at> openbravo.com> date: Wed Jan 09 14:55:32 2013 +0530 summary: Related to issue 0022684: Backout changeset a6b006e76cb2
Backout changeset because it fetches records with paging. details: https://code.openbravo.com/erp/devel/pi/rev/bedb82b9459e changeset: 19180:bedb82b9459e user: Shankar Balachandran <shankar.balachandran <at> openbravo.com> date: Wed Jan 09 14:56:52 2013 +0530 summary: Related to issue 22684 : Backout changeset 96927b00ddcc Backout changeset because it breaks another issue 16621. diffstat: modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java | 11 +-------- 1 files changed, 2 insertions(+), 9 deletions(-) diffs (29 lines): diff -r 005e47a80a31 -r bedb82b9459e modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java --- a/modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java Wed Jan 09 14:50:48 2013 +0530 +++ b/modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/CustomQuerySelectorDatasource.java Wed Jan 09 14:56:52 2013 +0530 @@ -74,6 +74,7 @@ final SimpleDateFormat xmlDateFormat = JsonUtils.createDateFormat(); final SimpleDateFormat xmlDateTimeFormat = JsonUtils.createDateTimeFormat(); final List<Map<String, Object>> result = new ArrayList<Map<String, Object>>(); + String selectorId = parameters.get(SelectorConstants.DS_REQUEST_SELECTOR_ID_PARAMETER); if (StringUtils.isEmpty(selectorId)) { @@ -99,16 +100,8 @@ if (startRow > 0) { selQuery.setFirstResult(startRow); } - - // ReadOnlyDataSourceService does not handle endRow setting based on the records. So setting - // the MaxResults based on the query list size. - int queryListSize = selQuery.list().size(); if (endRow > startRow) { - if (queryListSize > endRow) { - selQuery.setMaxResults(queryListSize); - } else { - selQuery.setMaxResults(endRow - startRow + 1); - } + selQuery.setMaxResults(endRow - startRow + 1); } for (Object objResult : selQuery.list()) { ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ Openbravo-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-commits
