details: https://code.openbravo.com/erp/devel/pi/rev/7902cbcdf8bd
changeset: 19630:7902cbcdf8bd
user: Javier Etxarri <javier.echarri <at> openbravo.com>
date: Fri Feb 08 01:39:11 2013 +0100
summary: Fixes issue 22628: It should not be possible to verify a BOM product
without lines on Bill of Materials tab
diffstat:
src-db/database/sourcedata/AD_MESSAGE.xml | 11 +++++++++++
src/org/openbravo/erpCommon/ad_process/VerifyBOM.java | 8 ++++++++
2 files changed, 19 insertions(+), 0 deletions(-)
diffs (53 lines):
diff -r 0fca6e755635 -r 7902cbcdf8bd src-db/database/sourcedata/AD_MESSAGE.xml
--- a/src-db/database/sourcedata/AD_MESSAGE.xml Thu Feb 07 22:47:50 2013 +0100
+++ b/src-db/database/sourcedata/AD_MESSAGE.xml Fri Feb 08 01:39:11 2013 +0100
@@ -17628,6 +17628,17 @@
<!--640A5393301E4EC6A473B781A7904E4B-->
<AD_MODULE_ID><![CDATA[0]]></AD_MODULE_ID>
<!--640A5393301E4EC6A473B781A7904E4B--></AD_MESSAGE>
+<!--6437716367E749CA9C8E8FADA041DF83--><AD_MESSAGE>
+<!--6437716367E749CA9C8E8FADA041DF83-->
<AD_MESSAGE_ID><![CDATA[6437716367E749CA9C8E8FADA041DF83]]></AD_MESSAGE_ID>
+<!--6437716367E749CA9C8E8FADA041DF83-->
<AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--6437716367E749CA9C8E8FADA041DF83--> <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--6437716367E749CA9C8E8FADA041DF83--> <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--6437716367E749CA9C8E8FADA041DF83-->
<VALUE><![CDATA[BOM_Without_Lines]]></VALUE>
+<!--6437716367E749CA9C8E8FADA041DF83--> <MSGTEXT><![CDATA[Verify that you
have included one or more products in tab Bill of Materials]]></MSGTEXT>
+<!--6437716367E749CA9C8E8FADA041DF83--> <MSGTYPE><![CDATA[E]]></MSGTYPE>
+<!--6437716367E749CA9C8E8FADA041DF83-->
<AD_MODULE_ID><![CDATA[0]]></AD_MODULE_ID>
+<!--6437716367E749CA9C8E8FADA041DF83--></AD_MESSAGE>
+
<!--643C242A10AE4A4495EA6D82B99C1F86--><AD_MESSAGE>
<!--643C242A10AE4A4495EA6D82B99C1F86-->
<AD_MESSAGE_ID><![CDATA[643C242A10AE4A4495EA6D82B99C1F86]]></AD_MESSAGE_ID>
<!--643C242A10AE4A4495EA6D82B99C1F86-->
<AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
diff -r 0fca6e755635 -r 7902cbcdf8bd
src/org/openbravo/erpCommon/ad_process/VerifyBOM.java
--- a/src/org/openbravo/erpCommon/ad_process/VerifyBOM.java Thu Feb 07
22:47:50 2013 +0100
+++ b/src/org/openbravo/erpCommon/ad_process/VerifyBOM.java Fri Feb 08
01:39:11 2013 +0100
@@ -23,13 +23,16 @@
import java.util.List;
import org.apache.log4j.Logger;
+import org.openbravo.dal.core.OBContext;
import org.openbravo.dal.service.OBDal;
import org.openbravo.erpCommon.utility.OBError;
import org.openbravo.erpCommon.utility.OBMessageUtils;
+import org.openbravo.erpCommon.utility.Utility;
import org.openbravo.model.common.plm.Product;
import org.openbravo.model.common.plm.ProductBOM;
import org.openbravo.scheduling.ProcessBundle;
import org.openbravo.service.db.DalBaseProcess;
+import org.openbravo.service.db.DalConnectionProvider;
public class VerifyBOM extends DalBaseProcess {
@@ -48,6 +51,11 @@
productList.add(product);
List<ProductBOM> productBOMList = product.getProductBOMList();
+ if (productBOMList.isEmpty()) {
+ throw new Exception(Utility.messageBD(new DalConnectionProvider(),
"BOM_Without_Lines",
+ OBContext.getOBContext().getLanguage().getLanguage()));
+ }
+
boolean cycle = checkForcycles(productList, productBOMList);
if (cycle) {
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
