details:   https://code.openbravo.com/erp/devel/pi/rev/c4ff9a91fe84
changeset: 20126:c4ff9a91fe84
user:      Augusto Mauch <augusto.mauch <at> openbravo.com>
date:      Wed Apr 17 11:23:28 2013 +0200
summary:   Fixes issue 23565: Checks if the session is null to prevent NPE

Before setting an attribute to the HTTP session, it must be checked that the 
session is not null to prevent a NullPointerException.

diffstat:

 src/org/openbravo/base/secureApp/HttpSecureAppServlet.java |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diffs (14 lines):

diff -r f3e2459475a6 -r c4ff9a91fe84 
src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
--- a/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java        Tue Apr 
16 19:17:41 2013 +0200
+++ b/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java        Wed Apr 
17 11:23:28 2013 +0200
@@ -1277,7 +1277,9 @@
         exportParameters.put(JRHtmlExporterParameter.OUTPUT_STREAM, os);
 
         HttpSession session = (HttpSession) 
designParameters.get("HTTP_SESSION");
-        
session.setAttribute(ImageServlet.DEFAULT_JASPER_PRINT_SESSION_ATTRIBUTE, 
jasperPrint);
+        if (session != null) {
+            
session.setAttribute(ImageServlet.DEFAULT_JASPER_PRINT_SESSION_ATTRIBUTE, 
jasperPrint);
+        }
 
         HttpServletRequest request = RequestContext.get().getRequest();
         String localAddress = HttpBaseUtils.getLocalAddress(request);

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to