details:   https://code.openbravo.com/erp/devel/pi/rev/bd25ca783eca
changeset: 20827:bd25ca783eca
user:      Ioritz Cia <ioritz.cia <at> openbravo.com>
date:      Wed Jul 31 12:11:59 2013 +0200
summary:   Related to issue 24038: Prepayment against invoice with different 
conversion rates.

diffstat:

 src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java |  17 ++++-------------
 1 files changed, 4 insertions(+), 13 deletions(-)

diffs (35 lines):

diff -r 95a0714b736d -r bd25ca783eca 
src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java   Wed Jul 31 
16:32:16 2013 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java   Wed Jul 31 
12:11:59 2013 +0200
@@ -27,7 +27,6 @@
 import javax.servlet.ServletException;
 
 import org.apache.log4j.Logger;
-import org.hibernate.Query;
 import org.hibernate.criterion.Restrictions;
 import org.openbravo.advpaymentmngt.utility.FIN_Utility;
 import org.openbravo.base.secureApp.VariablesSecureApp;
@@ -467,19 +466,11 @@
   }
 
   public boolean isOrderPrepayment(String paymentDetailID) {
-    StringBuilder hql = new StringBuilder();
-    hql.append("select pd ");
-    hql.append("from FIN_Payment_Detail pd ");
-    hql.append(" where pd.id = '" + paymentDetailID + "' ");
-
-    final Query obqPD = 
OBDal.getInstance().getSession().createQuery(hql.toString());
-
-    List<FIN_PaymentDetail> paymentDetailList = obqPD.list();
-    if (paymentDetailList.size() > 0) {
-      return paymentDetailList.get(0).isPrepayment();
-    } else {
-      return false;
+    FIN_PaymentDetail pd = OBDal.getInstance().get(FIN_PaymentDetail.class, 
paymentDetailID);
+    if (pd != null) {
+      return pd.isPrepayment();
     }
+    return false;
   }
 
   public String nextSeqNo(String oldSeqNo) {

------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to