details:   https://code.openbravo.com/erp/devel/pi/rev/d6cb6fc0a752
changeset: 21251:d6cb6fc0a752
user:      David Miguelez <david.miguelez <at> openbravo.com>
date:      Wed Oct 09 17:04:19 2013 +0200
summary:   Fixes Issue 24912. Prevents from not Balanced error.

diffstat:

 src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java |  13 
+++++----
 1 files changed, 7 insertions(+), 6 deletions(-)

diffs (23 lines):

diff -r 2302c22810c1 -r d6cb6fc0a752 
src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
--- a/src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java Wed Oct 
09 16:45:41 2013 +0200
+++ b/src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java Wed Oct 
09 17:04:19 2013 +0200
@@ -744,12 +744,13 @@
               ((DocLine_FINFinAccTransaction) p_lines[i]).PaymentAmount));
           retValue = retValue.subtract(lineBalance);
         } else {
-          BigDecimal lineBalance = BigDecimal.ZERO;
-          for (FIN_PaymentDetail pd : payment.getFINPaymentDetailList()) {
-            lineBalance = lineBalance.add(payment.isReceipt() ? 
pd.getAmount().add(
-                pd.getWriteoffAmount()) : 
pd.getAmount().add(pd.getWriteoffAmount()).negate());
-          }
-          retValue = retValue.subtract(lineBalance);
+          BigDecimal lineBalance = payment.isReceipt() ? new BigDecimal(
+              ((DocLine_FINFinAccTransaction) p_lines[i]).getAmount()) : new 
BigDecimal(
+              ((DocLine_FINFinAccTransaction) 
p_lines[i]).getAmount()).negate();
+          BigDecimal lineWriteoff = payment.isReceipt() ? new BigDecimal(
+              ((DocLine_FINFinAccTransaction) p_lines[i]).getWriteOffAmt()) : 
new BigDecimal(
+              ((DocLine_FINFinAccTransaction) 
p_lines[i]).getWriteOffAmt()).negate();
+          retValue = retValue.subtract(lineBalance).subtract(lineWriteoff);
         }
       }
     } finally {

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to