details: https://code.openbravo.com/erp/devel/pi/rev/df0dea56e2c8 changeset: 21272:df0dea56e2c8 user: Augusto Mauch <augusto.mauch <at> openbravo.com> date: Fri Oct 11 09:59:28 2013 +0200 summary: Related to issue 24924: Fixes integration test failure
Fixes this integration test failure [1]. A change from null to empty String, which should not have been detected as a change, caused the editColumnValues property of the selected record to be lost. This has been fixed by not considering the change from null to empty String as a change. [1] http://builds.openbravo.com/job/int-gui-oracle/1271/ diffstat: modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines): diff -r 2b5c09bed087 -r df0dea56e2c8 modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js Thu Oct 10 17:41:32 2013 +0200 +++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js Fri Oct 11 09:59:28 2013 +0200 @@ -2775,7 +2775,7 @@ oldFieldValue = oldValues[fieldName]; newFieldValue = newValues[fieldName]; // Use custom comparator to catch things like Dates where '==' check is not sufficient - if ((isNew || oldFieldValue !== undefined) && !this.fieldValuesAreEqual(this.getField(fieldName), oldFieldValue, newFieldValue)) { + if ((isNew || oldFieldValue !== undefined) && !this.fieldValuesAreEqual(this.getField(fieldName), oldFieldValue, newFieldValue) && !(newFieldValue === '' && oldFieldValue === null)) { changes = true; break; } ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ Openbravo-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-commits
