details:   https://code.openbravo.com/erp/devel/pi/rev/dc863e6e11e3
changeset: 21433:dc863e6e11e3
user:      David Baz Fayos <david.baz <at> openbravo.com>
date:      Tue Nov 12 02:41:00 2013 +0100
summary:   Fixed issue 25130: Proper message if there is no 'Record Identifier' 
defined
in the parent window of any window.
Before this fix, an exception was thrown in the console, and the UI rendered an 
incomplete
form impossible to be filled

diffstat:

 src/org/openbravo/erpCommon/utility/ComboTableData.java |  12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diffs (30 lines):

diff -r e783a7aa28d4 -r dc863e6e11e3 
src/org/openbravo/erpCommon/utility/ComboTableData.java
--- a/src/org/openbravo/erpCommon/utility/ComboTableData.java   Mon Nov 11 
15:01:36 2013 +0530
+++ b/src/org/openbravo/erpCommon/utility/ComboTableData.java   Tue Nov 12 
02:41:00 2013 +0100
@@ -11,7 +11,7 @@
  * under the License. 
  * The Original Code is Openbravo ERP. 
  * The Initial Developer of the Original Code is Openbravo SLU 
- * All portions are Copyright (C) 2001-2011 Openbravo SLU 
+ * All portions are Copyright (C) 2001-2013 Openbravo SLU 
  * All Rights Reserved. 
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -863,9 +863,15 @@
           }
         }
       }
-      if (!name.toString().equals(""))
+      text.append(id);
+      if (!name.toString().equals("")) {
         name.append(") AS NAME");
-      text.append(id).append(", ").append(name.toString());
+      } else {
+        name.append("'>>No Record Identifier<<' AS NAME");
+        log4j.error("Foreign table referenced by '" + idName
+            + "' does not have 'Record Identifier' defined");
+      }
+      text.append(", ").append(name.toString());
       if (description != null && !description.equals(""))
         text.append(", ").append(description);
       else

------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to