[OpenbravoERP-commits] devel/pi: Fixes issue 25730: Sometimes when reverting a payment ...

[hg]

details:   https://code.openbravo.com/erp/devel/pi/rev/c1997f6e4acf
changeset: 22990:c1997f6e4acf
user:      Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
date:      Wed May 07 17:57:16 2014 +0200
summary:   Fixes issue 25730: Sometimes when reverting a payment out with 
generated credit Used Credit Source tab is not filled

diffstat:

 
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
 |  10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diffs (20 lines):

diff -r 886a59579fd0 -r c1997f6e4acf 
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
--- 
a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
     Wed May 07 10:10:30 2014 +0200
+++ 
b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
     Wed May 07 17:57:16 2014 +0200
@@ -138,9 +138,13 @@
         boolean isRefund = false;
         OBContext.setAdminMode(false);
         try {
-          if (payment.getFINPaymentDetailList().size() > 0
-              && payment.getFINPaymentDetailList().get(0).isRefund()) {
-            isRefund = true;
+          if (payment.getFINPaymentDetailList().size() > 0) {
+            for (FIN_PaymentDetail det : payment.getFINPaymentDetailList()) {
+              if (det.isRefund()) {
+                isRefund = true;
+                break;
+              }
+            }
           }
         } finally {
           OBContext.restorePreviousMode();

------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
&#149; 3 signs your SCM is hindering your productivity
&#149; Requirements for releasing software faster
&#149; Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits