[OpenbravoERP-commits] devel/pi: Fixed bug 26502 Improve performance of modulescript In...

[hg]

details:   https://code.openbravo.com/erp/devel/pi/rev/5ef5b7acfcbd
changeset: 23005:5ef5b7acfcbd
user:      Sandra Huguet <sandra.huguet <at> openbravo.com>
date:      Fri May 09 13:41:51 2014 +0200
summary:   Fixed bug 26502 Improve performance of modulescript 
InitializeIsPaymentPaid

diffstat:

 src-db/database/model/tables/FIN_PAYMENT_SCHEDULEDETAIL.xml                    
                  |    2 +-
 
src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeIsPaymentPaidData.class
 |    0 
 
src-util/modulescript/src/org/openbravo/modulescript/InitializeIsPaymentPaid_data.xsql
           |   12 ++++-----
 3 files changed, 6 insertions(+), 8 deletions(-)

diffs (37 lines):

diff -r b6eadf200426 -r 5ef5b7acfcbd 
src-db/database/model/tables/FIN_PAYMENT_SCHEDULEDETAIL.xml
--- a/src-db/database/model/tables/FIN_PAYMENT_SCHEDULEDETAIL.xml       Fri May 
09 10:08:25 2014 +0200
+++ b/src-db/database/model/tables/FIN_PAYMENT_SCHEDULEDETAIL.xml       Fri May 
09 13:41:51 2014 +0200
@@ -99,7 +99,7 @@
       </column>
       <column name="ISINVOICEPAID" primaryKey="false" required="true" 
type="CHAR" size="1" autoIncrement="false">
         <default><![CDATA[N]]></default>
-        <onCreateDefault/>
+        <onCreateDefault><![CDATA['Y']]></onCreateDefault>
       </column>
       <foreign-key foreignTable="AD_CLIENT" 
name="FIN_AD_CLIENT_SCHEDULEDETAIL">
         <reference local="AD_CLIENT_ID" foreign="AD_CLIENT_ID"/>
diff -r b6eadf200426 -r 5ef5b7acfcbd 
src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeIsPaymentPaidData.class
Binary file 
src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeIsPaymentPaidData.class
 has changed
diff -r b6eadf200426 -r 5ef5b7acfcbd 
src-util/modulescript/src/org/openbravo/modulescript/InitializeIsPaymentPaid_data.xsql
--- 
a/src-util/modulescript/src/org/openbravo/modulescript/InitializeIsPaymentPaid_data.xsql
    Fri May 09 10:08:25 2014 +0200
+++ 
b/src-util/modulescript/src/org/openbravo/modulescript/InitializeIsPaymentPaid_data.xsql
    Fri May 09 13:41:51 2014 +0200
@@ -31,14 +31,12 @@
     <SqlMethodComment></SqlMethodComment>
     <Sql>
      <![CDATA[ 
-        update fin_payment_scheduledetail set isinvoicepaid=(select CASE WHEN 
fpsd.fin_payment_detail_id is null then 'N'
-        WHEN 
-       fp.status IN ('PPM', 'RPR', 'PWNC', 'RDNC', 'RPPC') THEN 'Y' ELSE 'N' 
END
-        from fin_payment_scheduledetail fpsd
-         left join fin_payment_detail fpd on 
fpsd.fin_payment_detail_id=fpd.fin_payment_detail_id
+         update fin_payment_scheduledetail set isinvoicepaid= 'N'
+         where fin_payment_schedule_invoice is not null
+         and not exists (select 1 from fin_payment_detail fpd
          left join fin_payment fp on fpd.fin_payment_id=fp.fin_payment_id
-         and fin_payment_schedule_invoice is not null
-         where 
fin_payment_scheduledetail.fin_payment_scheduledetail_id=fpsd.fin_payment_scheduledetail_id)
+         where fin_payment_scheduledetail.fin_payment_detail_id = 
fpd.fin_payment_detail_id
+         and fp.status IN ('PPM', 'RPR', 'PWNC', 'RDNC', 'RPPC'));
       ]]>
     </Sql>
     </SqlMethod>

------------------------------------------------------------------------------
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
&#149; 3 signs your SCM is hindering your productivity
&#149; Requirements for releasing software faster
&#149; Expert tips and advice for migrating your SCM now
http://p.sf.net/sfu/perforce
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits