details: https://code.openbravo.com/erp/devel/pi/rev/fee9a7256fe8
changeset: 23380:fee9a7256fe8
user: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
date: Mon May 26 13:27:53 2014 +0530
summary: Fixes Issue 26138: Small code clean up in HSAS
Removed unneeded private method.
Removed duplicate code.
diffstat:
src/org/openbravo/base/secureApp/HttpSecureAppServlet.java | 21 ++-----------
1 files changed, 4 insertions(+), 17 deletions(-)
diffs (44 lines):
diff -r 38b6f19194d0 -r fee9a7256fe8
src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
--- a/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java Mon May
26 10:42:33 2014 +0200
+++ b/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java Mon May
26 13:27:53 2014 +0530
@@ -1194,20 +1194,15 @@
String strReportName, String strOutputType, HashMap<String, Object>
designParameters,
FieldProvider[] data, Map<Object, Object> exportParameters) throws
ServletException {
renderJR(variables, response, strReportName, null, strOutputType,
designParameters, data,
- exportParameters);
+ exportParameters, false);
}
protected void renderJR(VariablesSecureApp variables, HttpServletResponse
response,
String strReportName, String strFileName, String strOutputType,
HashMap<String, Object> designParameters, FieldProvider[] data,
Map<Object, Object> exportParameters) throws ServletException {
- if (data != null) {
- renderJR(variables, response, strReportName, strFileName, strOutputType,
designParameters,
- new JRFieldProviderDataSource(data, variables.getJavaDateFormat()),
exportParameters);
- } else {
- renderJR(variables, response, strReportName, strFileName, strOutputType,
designParameters,
- (JRDataSource) null, exportParameters);
- }
+ renderJR(variables, response, strReportName, strFileName, strOutputType,
designParameters,
+ data, exportParameters, false);
}
protected void renderJR(VariablesSecureApp variables, HttpServletResponse
response,
@@ -1236,15 +1231,7 @@
Map<Object, Object> exportParameters) throws ServletException {
renderJR(variables, response, strReportName, strFileName, strOutputType,
designParameters,
new JRScrollableFieldProviderDataSource(sfp,
variables.getJavaDateFormat()),
- exportParameters);
- }
-
- private void renderJR(VariablesSecureApp variables, HttpServletResponse
response,
- String strReportName, String strFileName, String strOutputType,
- HashMap<String, Object> designParameters, JRDataSource data,
- Map<Object, Object> exportParameters) throws ServletException {
- renderJR(variables, response, strReportName, strFileName, strOutputType,
designParameters,
- data, exportParameters, false);
+ exportParameters, false);
}
private void renderJR(VariablesSecureApp variables, HttpServletResponse
response,
------------------------------------------------------------------------------
The best possible search technologies are now affordable for all companies.
Download your FREE open source Enterprise Search Engine today!
Our experts will assist you in its installation for $59/mo, no commitment.
Test it for FREE on our Cloud platform anytime!
http://pubads.g.doubleclick.net/gampad/clk?id=145328191&iu=/4140/ostg.clktrk
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
